2015-06-16 12:08:09 +02:00
|
|
|
/*
|
|
|
|
|
* Copyright © 2015 Intel Corporation
|
|
|
|
|
*
|
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
|
*
|
|
|
|
|
* The above copyright notice and this permission notice (including the next
|
|
|
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
|
|
|
* Software.
|
|
|
|
|
*
|
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
|
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
|
|
|
* IN THE SOFTWARE.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include "brw_nir.h"
|
|
|
|
|
#include "brw_vec4.h"
|
2015-09-10 12:00:04 +02:00
|
|
|
#include "brw_vec4_builder.h"
|
|
|
|
|
#include "brw_vec4_surface_builder.h"
|
2019-06-26 13:36:17 -07:00
|
|
|
#include "brw_eu.h"
|
2015-06-16 12:08:09 +02:00
|
|
|
|
2015-09-10 12:00:04 +02:00
|
|
|
using namespace brw;
|
|
|
|
|
using namespace brw::surface_access;
|
|
|
|
|
|
2015-06-16 12:08:09 +02:00
|
|
|
namespace brw {
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
vec4_visitor::emit_nir_code()
|
|
|
|
|
{
|
|
|
|
|
if (nir->num_uniforms > 0)
|
2015-10-01 12:23:53 -07:00
|
|
|
nir_setup_uniforms();
|
2015-06-16 12:08:09 +02:00
|
|
|
|
2018-10-29 12:08:29 -05:00
|
|
|
nir_emit_impl(nir_shader_get_entrypoint((nir_shader *)nir));
|
2015-06-16 12:08:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
2015-10-01 12:23:53 -07:00
|
|
|
vec4_visitor::nir_setup_uniforms()
|
2015-06-16 12:08:09 +02:00
|
|
|
{
|
2015-11-10 21:12:47 -08:00
|
|
|
uniforms = nir->num_uniforms / 16;
|
2015-06-16 12:08:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_impl(nir_function_impl *impl)
|
|
|
|
|
{
|
2015-07-22 09:34:35 +02:00
|
|
|
nir_locals = ralloc_array(mem_ctx, dst_reg, impl->reg_alloc);
|
2015-10-30 13:53:38 -07:00
|
|
|
for (unsigned i = 0; i < impl->reg_alloc; i++) {
|
|
|
|
|
nir_locals[i] = dst_reg();
|
|
|
|
|
}
|
2015-07-22 09:34:35 +02:00
|
|
|
|
|
|
|
|
foreach_list_typed(nir_register, reg, node, &impl->registers) {
|
|
|
|
|
unsigned array_elems =
|
|
|
|
|
reg->num_array_elems == 0 ? 1 : reg->num_array_elems;
|
2016-02-29 12:35:05 +01:00
|
|
|
const unsigned num_regs = array_elems * DIV_ROUND_UP(reg->bit_size, 32);
|
|
|
|
|
nir_locals[reg->index] = dst_reg(VGRF, alloc.allocate(num_regs));
|
2015-08-13 14:35:46 -07:00
|
|
|
|
|
|
|
|
if (reg->bit_size == 64)
|
|
|
|
|
nir_locals[reg->index].type = BRW_REGISTER_TYPE_DF;
|
2015-07-22 09:34:35 +02:00
|
|
|
}
|
|
|
|
|
|
2015-07-01 16:10:49 +02:00
|
|
|
nir_ssa_values = ralloc_array(mem_ctx, dst_reg, impl->ssa_alloc);
|
|
|
|
|
|
2015-07-22 09:34:35 +02:00
|
|
|
nir_emit_cf_list(&impl->body);
|
2015-06-16 12:08:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_cf_list(exec_list *list)
|
|
|
|
|
{
|
|
|
|
|
exec_list_validate(list);
|
|
|
|
|
foreach_list_typed(nir_cf_node, node, node, list) {
|
|
|
|
|
switch (node->type) {
|
|
|
|
|
case nir_cf_node_if:
|
|
|
|
|
nir_emit_if(nir_cf_node_as_if(node));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_cf_node_loop:
|
|
|
|
|
nir_emit_loop(nir_cf_node_as_loop(node));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_cf_node_block:
|
|
|
|
|
nir_emit_block(nir_cf_node_as_block(node));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
default:
|
|
|
|
|
unreachable("Invalid CFG node block");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_if(nir_if *if_stmt)
|
|
|
|
|
{
|
2015-06-16 20:16:15 +02:00
|
|
|
/* First, put the condition in f0 */
|
|
|
|
|
src_reg condition = get_nir_src(if_stmt->condition, BRW_REGISTER_TYPE_D, 1);
|
|
|
|
|
vec4_instruction *inst = emit(MOV(dst_null_d(), condition));
|
|
|
|
|
inst->conditional_mod = BRW_CONDITIONAL_NZ;
|
|
|
|
|
|
2015-10-09 16:59:20 +02:00
|
|
|
/* We can just predicate based on the X channel, as the condition only
|
|
|
|
|
* goes on its own line */
|
|
|
|
|
emit(IF(BRW_PREDICATE_ALIGN16_REPLICATE_X));
|
2015-06-16 20:16:15 +02:00
|
|
|
|
|
|
|
|
nir_emit_cf_list(&if_stmt->then_list);
|
|
|
|
|
|
|
|
|
|
/* note: if the else is empty, dead CF elimination will remove it */
|
|
|
|
|
emit(BRW_OPCODE_ELSE);
|
|
|
|
|
|
|
|
|
|
nir_emit_cf_list(&if_stmt->else_list);
|
|
|
|
|
|
|
|
|
|
emit(BRW_OPCODE_ENDIF);
|
2015-06-16 12:08:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_loop(nir_loop *loop)
|
|
|
|
|
{
|
2015-06-16 20:25:55 +02:00
|
|
|
emit(BRW_OPCODE_DO);
|
|
|
|
|
|
|
|
|
|
nir_emit_cf_list(&loop->body);
|
|
|
|
|
|
|
|
|
|
emit(BRW_OPCODE_WHILE);
|
2015-06-16 12:08:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_block(nir_block *block)
|
|
|
|
|
{
|
2016-04-26 18:34:19 -07:00
|
|
|
nir_foreach_instr(instr, block) {
|
2015-06-16 12:08:09 +02:00
|
|
|
nir_emit_instr(instr);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_instr(nir_instr *instr)
|
|
|
|
|
{
|
2015-09-18 10:30:12 +02:00
|
|
|
base_ir = instr;
|
2015-06-16 12:08:09 +02:00
|
|
|
|
|
|
|
|
switch (instr->type) {
|
|
|
|
|
case nir_instr_type_load_const:
|
|
|
|
|
nir_emit_load_const(nir_instr_as_load_const(instr));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_instr_type_intrinsic:
|
|
|
|
|
nir_emit_intrinsic(nir_instr_as_intrinsic(instr));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_instr_type_alu:
|
|
|
|
|
nir_emit_alu(nir_instr_as_alu(instr));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_instr_type_jump:
|
|
|
|
|
nir_emit_jump(nir_instr_as_jump(instr));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_instr_type_tex:
|
|
|
|
|
nir_emit_texture(nir_instr_as_tex(instr));
|
|
|
|
|
break;
|
|
|
|
|
|
2015-09-09 13:55:39 -07:00
|
|
|
case nir_instr_type_ssa_undef:
|
|
|
|
|
nir_emit_undef(nir_instr_as_ssa_undef(instr));
|
|
|
|
|
break;
|
|
|
|
|
|
2015-06-16 12:08:09 +02:00
|
|
|
default:
|
2018-07-02 20:29:27 -07:00
|
|
|
unreachable("VS instruction not yet implemented by NIR->vec4");
|
2015-06-16 12:08:09 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-16 17:43:02 +02:00
|
|
|
static dst_reg
|
|
|
|
|
dst_reg_for_nir_reg(vec4_visitor *v, nir_register *nir_reg,
|
|
|
|
|
unsigned base_offset, nir_src *indirect)
|
|
|
|
|
{
|
|
|
|
|
dst_reg reg;
|
|
|
|
|
|
|
|
|
|
reg = v->nir_locals[nir_reg->index];
|
2016-02-12 08:47:21 +01:00
|
|
|
if (nir_reg->bit_size == 64)
|
|
|
|
|
reg.type = BRW_REGISTER_TYPE_DF;
|
2016-10-03 13:33:12 +02:00
|
|
|
reg = offset(reg, 8, base_offset);
|
2015-06-16 17:43:02 +02:00
|
|
|
if (indirect) {
|
|
|
|
|
reg.reladdr =
|
|
|
|
|
new(v->mem_ctx) src_reg(v->get_nir_src(*indirect,
|
|
|
|
|
BRW_REGISTER_TYPE_D,
|
|
|
|
|
1));
|
|
|
|
|
}
|
|
|
|
|
return reg;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
dst_reg
|
2016-05-19 14:43:23 -07:00
|
|
|
vec4_visitor::get_nir_dest(const nir_dest &dest)
|
2015-06-16 17:43:02 +02:00
|
|
|
{
|
2015-09-09 13:55:39 -07:00
|
|
|
if (dest.is_ssa) {
|
2016-02-29 12:35:05 +01:00
|
|
|
dst_reg dst =
|
|
|
|
|
dst_reg(VGRF, alloc.allocate(DIV_ROUND_UP(dest.ssa.bit_size, 32)));
|
2016-02-12 08:47:21 +01:00
|
|
|
if (dest.ssa.bit_size == 64)
|
|
|
|
|
dst.type = BRW_REGISTER_TYPE_DF;
|
2015-09-09 13:55:39 -07:00
|
|
|
nir_ssa_values[dest.ssa.index] = dst;
|
|
|
|
|
return dst;
|
|
|
|
|
} else {
|
|
|
|
|
return dst_reg_for_nir_reg(this, dest.reg.reg, dest.reg.base_offset,
|
|
|
|
|
dest.reg.indirect);
|
|
|
|
|
}
|
2015-06-16 17:43:02 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
dst_reg
|
2016-05-19 14:43:23 -07:00
|
|
|
vec4_visitor::get_nir_dest(const nir_dest &dest, enum brw_reg_type type)
|
2015-06-16 17:43:02 +02:00
|
|
|
{
|
|
|
|
|
return retype(get_nir_dest(dest), type);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
dst_reg
|
2016-05-19 14:43:23 -07:00
|
|
|
vec4_visitor::get_nir_dest(const nir_dest &dest, nir_alu_type type)
|
2015-06-16 17:43:02 +02:00
|
|
|
{
|
2017-01-20 19:03:21 -08:00
|
|
|
return get_nir_dest(dest, brw_type_for_nir_type(devinfo, type));
|
2015-06-16 17:43:02 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
src_reg
|
2016-05-19 14:43:23 -07:00
|
|
|
vec4_visitor::get_nir_src(const nir_src &src, enum brw_reg_type type,
|
2015-06-16 17:43:02 +02:00
|
|
|
unsigned num_components)
|
|
|
|
|
{
|
|
|
|
|
dst_reg reg;
|
|
|
|
|
|
|
|
|
|
if (src.is_ssa) {
|
|
|
|
|
assert(src.ssa != NULL);
|
|
|
|
|
reg = nir_ssa_values[src.ssa->index];
|
|
|
|
|
}
|
|
|
|
|
else {
|
2016-10-05 10:54:35 +02:00
|
|
|
reg = dst_reg_for_nir_reg(this, src.reg.reg, src.reg.base_offset,
|
|
|
|
|
src.reg.indirect);
|
2015-06-16 17:43:02 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
reg = retype(reg, type);
|
|
|
|
|
|
|
|
|
|
src_reg reg_as_src = src_reg(reg);
|
|
|
|
|
reg_as_src.swizzle = brw_swizzle_for_size(num_components);
|
|
|
|
|
return reg_as_src;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
src_reg
|
2016-05-19 14:43:23 -07:00
|
|
|
vec4_visitor::get_nir_src(const nir_src &src, nir_alu_type type,
|
2015-06-16 17:43:02 +02:00
|
|
|
unsigned num_components)
|
|
|
|
|
{
|
2017-01-20 19:03:21 -08:00
|
|
|
return get_nir_src(src, brw_type_for_nir_type(devinfo, type),
|
|
|
|
|
num_components);
|
2015-06-16 17:43:02 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
src_reg
|
2016-05-19 14:43:23 -07:00
|
|
|
vec4_visitor::get_nir_src(const nir_src &src, unsigned num_components)
|
2015-06-16 17:43:02 +02:00
|
|
|
{
|
|
|
|
|
/* if type is not specified, default to signed int */
|
2015-11-02 00:07:27 -05:00
|
|
|
return get_nir_src(src, nir_type_int32, num_components);
|
2015-06-16 17:43:02 +02:00
|
|
|
}
|
|
|
|
|
|
2018-10-20 10:05:33 -05:00
|
|
|
src_reg
|
|
|
|
|
vec4_visitor::get_nir_src_imm(const nir_src &src)
|
|
|
|
|
{
|
|
|
|
|
assert(nir_src_num_components(src) == 1);
|
|
|
|
|
assert(nir_src_bit_size(src) == 32);
|
2018-10-20 10:28:51 -05:00
|
|
|
return nir_src_is_const(src) ? src_reg(brw_imm_d(nir_src_as_int(src))) :
|
|
|
|
|
get_nir_src(src, 1);
|
2018-10-20 10:05:33 -05:00
|
|
|
}
|
|
|
|
|
|
2015-11-17 01:07:39 -08:00
|
|
|
src_reg
|
|
|
|
|
vec4_visitor::get_indirect_offset(nir_intrinsic_instr *instr)
|
|
|
|
|
{
|
|
|
|
|
nir_src *offset_src = nir_get_io_offset_src(instr);
|
|
|
|
|
|
2018-10-20 10:28:51 -05:00
|
|
|
if (nir_src_is_const(*offset_src)) {
|
2015-11-17 01:07:39 -08:00
|
|
|
/* The only constant offset we should find is 0. brw_nir.c's
|
|
|
|
|
* add_const_offset_to_base() will fold other constant offsets
|
2022-08-13 01:11:58 -07:00
|
|
|
* into the base index.
|
2015-11-17 01:07:39 -08:00
|
|
|
*/
|
2018-10-20 10:28:51 -05:00
|
|
|
assert(nir_src_as_uint(*offset_src) == 0);
|
2015-11-17 01:07:39 -08:00
|
|
|
return src_reg();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return get_nir_src(*offset_src, BRW_REGISTER_TYPE_UD, 1);
|
|
|
|
|
}
|
|
|
|
|
|
2017-03-07 10:29:53 +01:00
|
|
|
static src_reg
|
|
|
|
|
setup_imm_df(const vec4_builder &bld, double v)
|
|
|
|
|
{
|
2021-04-05 13:19:39 -07:00
|
|
|
const intel_device_info *devinfo = bld.shader->devinfo;
|
2021-03-29 14:41:58 -07:00
|
|
|
assert(devinfo->ver == 7);
|
2017-03-07 10:29:53 +01:00
|
|
|
|
2022-06-22 18:31:08 +02:00
|
|
|
/* gfx7.5 does not support DF immediates straightforward but the DIM
|
2017-03-07 10:29:53 +01:00
|
|
|
* instruction allows to set the 64-bit immediate value.
|
|
|
|
|
*/
|
2021-09-22 15:06:58 +03:00
|
|
|
if (devinfo->verx10 == 75) {
|
2017-03-07 10:29:53 +01:00
|
|
|
const vec4_builder ubld = bld.exec_all();
|
|
|
|
|
const dst_reg dst = bld.vgrf(BRW_REGISTER_TYPE_DF);
|
|
|
|
|
ubld.DIM(dst, brw_imm_df(v));
|
|
|
|
|
return swizzle(src_reg(dst), BRW_SWIZZLE_XXXX);
|
|
|
|
|
}
|
|
|
|
|
|
2021-03-29 15:40:04 -07:00
|
|
|
/* gfx7 does not support DF immediates */
|
2017-03-07 10:29:53 +01:00
|
|
|
union {
|
|
|
|
|
double d;
|
|
|
|
|
struct {
|
|
|
|
|
uint32_t i1;
|
|
|
|
|
uint32_t i2;
|
|
|
|
|
};
|
|
|
|
|
} di;
|
|
|
|
|
|
|
|
|
|
di.d = v;
|
|
|
|
|
|
|
|
|
|
/* Write the low 32-bit of the constant to the X:UD channel and the
|
|
|
|
|
* high 32-bit to the Y:UD channel to build the constant in a VGRF.
|
|
|
|
|
* We have to do this twice (offset 0 and offset 1), since a DF VGRF takes
|
|
|
|
|
* two SIMD8 registers in SIMD4x2 execution. Finally, return a swizzle
|
|
|
|
|
* XXXX so any access to the VGRF only reads the constant data in these
|
|
|
|
|
* channels.
|
|
|
|
|
*/
|
|
|
|
|
const dst_reg tmp = bld.vgrf(BRW_REGISTER_TYPE_UD, 2);
|
|
|
|
|
for (unsigned n = 0; n < 2; n++) {
|
|
|
|
|
const vec4_builder ubld = bld.exec_all().group(4, n);
|
|
|
|
|
ubld.MOV(writemask(offset(tmp, 8, n), WRITEMASK_X), brw_imm_ud(di.i1));
|
|
|
|
|
ubld.MOV(writemask(offset(tmp, 8, n), WRITEMASK_Y), brw_imm_ud(di.i2));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return swizzle(src_reg(retype(tmp, BRW_REGISTER_TYPE_DF)), BRW_SWIZZLE_XXXX);
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-16 12:08:09 +02:00
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_load_const(nir_load_const_instr *instr)
|
|
|
|
|
{
|
2015-08-13 15:30:34 -07:00
|
|
|
dst_reg reg;
|
|
|
|
|
|
|
|
|
|
if (instr->def.bit_size == 64) {
|
|
|
|
|
reg = dst_reg(VGRF, alloc.allocate(2));
|
|
|
|
|
reg.type = BRW_REGISTER_TYPE_DF;
|
|
|
|
|
} else {
|
|
|
|
|
reg = dst_reg(VGRF, alloc.allocate(1));
|
|
|
|
|
reg.type = BRW_REGISTER_TYPE_D;
|
|
|
|
|
}
|
2015-07-01 16:10:49 +02:00
|
|
|
|
2017-03-07 10:29:53 +01:00
|
|
|
const vec4_builder ibld = vec4_builder(this).at_end();
|
2015-08-12 11:35:17 -07:00
|
|
|
unsigned remaining = brw_writemask_for_size(instr->def.num_components);
|
|
|
|
|
|
2015-07-01 16:10:49 +02:00
|
|
|
/* @FIXME: consider emitting vector operations to save some MOVs in
|
|
|
|
|
* cases where the components are representable in 8 bits.
|
2015-08-12 11:35:17 -07:00
|
|
|
* For now, we emit a MOV for each distinct value.
|
2015-07-01 16:10:49 +02:00
|
|
|
*/
|
2015-08-12 11:35:17 -07:00
|
|
|
for (unsigned i = 0; i < instr->def.num_components; i++) {
|
|
|
|
|
unsigned writemask = 1 << i;
|
|
|
|
|
|
|
|
|
|
if ((remaining & writemask) == 0)
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
for (unsigned j = i; j < instr->def.num_components; j++) {
|
2015-08-13 15:30:34 -07:00
|
|
|
if ((instr->def.bit_size == 32 &&
|
2019-03-27 00:59:03 +01:00
|
|
|
instr->value[i].u32 == instr->value[j].u32) ||
|
2015-08-13 15:30:34 -07:00
|
|
|
(instr->def.bit_size == 64 &&
|
2019-03-27 00:59:03 +01:00
|
|
|
instr->value[i].f64 == instr->value[j].f64)) {
|
2015-08-12 11:35:17 -07:00
|
|
|
writemask |= 1 << j;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
reg.writemask = writemask;
|
2015-08-13 15:30:34 -07:00
|
|
|
if (instr->def.bit_size == 64) {
|
2019-03-27 00:59:03 +01:00
|
|
|
emit(MOV(reg, setup_imm_df(ibld, instr->value[i].f64)));
|
2015-08-13 15:30:34 -07:00
|
|
|
} else {
|
2019-03-27 00:59:03 +01:00
|
|
|
emit(MOV(reg, brw_imm_d(instr->value[i].i32)));
|
2015-08-13 15:30:34 -07:00
|
|
|
}
|
2015-08-12 11:35:17 -07:00
|
|
|
|
|
|
|
|
remaining &= ~writemask;
|
2015-07-01 16:10:49 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Set final writemask */
|
|
|
|
|
reg.writemask = brw_writemask_for_size(instr->def.num_components);
|
|
|
|
|
|
|
|
|
|
nir_ssa_values[instr->def.index] = reg;
|
2015-06-16 12:08:09 +02:00
|
|
|
}
|
|
|
|
|
|
2018-10-20 10:05:33 -05:00
|
|
|
src_reg
|
|
|
|
|
vec4_visitor::get_nir_ssbo_intrinsic_index(nir_intrinsic_instr *instr)
|
|
|
|
|
{
|
|
|
|
|
/* SSBO stores are weird in that their index is in src[1] */
|
|
|
|
|
const unsigned src = instr->intrinsic == nir_intrinsic_store_ssbo ? 1 : 0;
|
|
|
|
|
|
2018-10-20 10:28:51 -05:00
|
|
|
if (nir_src_is_const(instr->src[src])) {
|
2021-12-03 22:20:30 -06:00
|
|
|
return brw_imm_ud(nir_src_as_uint(instr->src[src]));
|
2018-10-20 10:05:33 -05:00
|
|
|
} else {
|
2021-12-03 22:20:30 -06:00
|
|
|
return emit_uniformize(get_nir_src(instr->src[src]));
|
2018-10-20 10:05:33 -05:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-16 12:08:09 +02:00
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_intrinsic(nir_intrinsic_instr *instr)
|
|
|
|
|
{
|
2015-06-16 21:24:21 +02:00
|
|
|
dst_reg dest;
|
|
|
|
|
src_reg src;
|
|
|
|
|
|
2015-06-16 12:08:09 +02:00
|
|
|
switch (instr->intrinsic) {
|
|
|
|
|
|
2015-06-16 21:24:21 +02:00
|
|
|
case nir_intrinsic_load_input: {
|
2019-07-20 08:17:59 -05:00
|
|
|
assert(nir_dest_bit_size(instr->dest) == 32);
|
2015-11-25 14:14:05 -08:00
|
|
|
/* We set EmitNoIndirectInput for VS */
|
2018-10-20 10:28:51 -05:00
|
|
|
unsigned load_offset = nir_src_as_uint(instr->src[0]);
|
2015-11-25 14:14:05 -08:00
|
|
|
|
2016-07-06 12:40:49 +02:00
|
|
|
dest = get_nir_dest(instr->dest);
|
|
|
|
|
dest.writemask = brw_writemask_for_size(instr->num_components);
|
|
|
|
|
|
2022-08-13 01:11:58 -07:00
|
|
|
src = src_reg(ATTR, nir_intrinsic_base(instr) + load_offset,
|
2015-11-25 14:14:05 -08:00
|
|
|
glsl_type::uvec4_type);
|
2016-07-06 12:40:49 +02:00
|
|
|
src = retype(src, dest.type);
|
2015-06-16 21:24:21 +02:00
|
|
|
|
2019-07-20 08:17:59 -05:00
|
|
|
/* Swizzle source based on component layout qualifier */
|
|
|
|
|
src.swizzle = BRW_SWZ_COMP_INPUT(nir_intrinsic_component(instr));
|
|
|
|
|
emit(MOV(dest, src));
|
2015-06-16 12:08:09 +02:00
|
|
|
break;
|
2015-06-16 21:24:21 +02:00
|
|
|
}
|
2015-06-16 12:08:09 +02:00
|
|
|
|
2015-06-16 21:31:49 +02:00
|
|
|
case nir_intrinsic_store_output: {
|
2019-07-20 08:17:59 -05:00
|
|
|
assert(nir_src_bit_size(instr->src[0]) == 32);
|
2018-10-20 10:28:51 -05:00
|
|
|
unsigned store_offset = nir_src_as_uint(instr->src[1]);
|
2022-08-13 01:11:58 -07:00
|
|
|
int varying = nir_intrinsic_base(instr) + store_offset;
|
2019-07-20 08:17:59 -05:00
|
|
|
src = get_nir_src(instr->src[0], BRW_REGISTER_TYPE_F,
|
|
|
|
|
instr->num_components);
|
2015-06-16 21:31:49 +02:00
|
|
|
|
2016-10-17 11:14:10 -07:00
|
|
|
unsigned c = nir_intrinsic_component(instr);
|
|
|
|
|
output_reg[varying][c] = dst_reg(src);
|
|
|
|
|
output_num_components[varying][c] = instr->num_components;
|
2015-06-16 12:08:09 +02:00
|
|
|
break;
|
2015-06-16 21:31:49 +02:00
|
|
|
}
|
2015-06-16 12:08:09 +02:00
|
|
|
|
2020-09-22 03:24:45 -05:00
|
|
|
case nir_intrinsic_get_ssbo_size: {
|
2019-01-12 10:58:33 -06:00
|
|
|
assert(nir_src_num_components(instr->src[0]) == 1);
|
2018-10-20 10:28:51 -05:00
|
|
|
unsigned ssbo_index = nir_src_is_const(instr->src[0]) ?
|
|
|
|
|
nir_src_as_uint(instr->src[0]) : 0;
|
2015-08-26 12:21:54 +02:00
|
|
|
|
|
|
|
|
dst_reg result_dst = get_nir_dest(instr->dest);
|
|
|
|
|
vec4_instruction *inst = new(mem_ctx)
|
2017-12-10 17:03:32 -08:00
|
|
|
vec4_instruction(SHADER_OPCODE_GET_BUFFER_SIZE, result_dst);
|
2015-08-26 12:21:54 +02:00
|
|
|
|
|
|
|
|
inst->base_mrf = 2;
|
|
|
|
|
inst->mlen = 1; /* always at least one */
|
2021-12-03 22:20:30 -06:00
|
|
|
inst->src[1] = brw_imm_ud(ssbo_index);
|
2015-08-26 12:21:54 +02:00
|
|
|
|
|
|
|
|
/* MRF for the first parameter */
|
2015-11-02 12:12:44 -08:00
|
|
|
src_reg lod = brw_imm_d(0);
|
2015-08-26 12:21:54 +02:00
|
|
|
int param_base = inst->base_mrf;
|
|
|
|
|
int writemask = WRITEMASK_X;
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base, glsl_type::int_type, writemask), lod));
|
|
|
|
|
|
|
|
|
|
emit(inst);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2015-09-10 12:00:04 +02:00
|
|
|
case nir_intrinsic_store_ssbo: {
|
2021-03-29 14:41:58 -07:00
|
|
|
assert(devinfo->ver == 7);
|
2015-09-10 12:00:04 +02:00
|
|
|
|
2018-11-12 18:48:10 -06:00
|
|
|
/* brw_nir_lower_mem_access_bit_sizes takes care of this */
|
|
|
|
|
assert(nir_src_bit_size(instr->src[0]) == 32);
|
|
|
|
|
assert(nir_intrinsic_write_mask(instr) ==
|
2018-11-16 09:23:56 -06:00
|
|
|
(1u << instr->num_components) - 1);
|
2018-11-12 18:48:10 -06:00
|
|
|
|
2018-10-20 10:05:33 -05:00
|
|
|
src_reg surf_index = get_nir_ssbo_intrinsic_index(instr);
|
|
|
|
|
src_reg offset_reg = retype(get_nir_src_imm(instr->src[2]),
|
|
|
|
|
BRW_REGISTER_TYPE_UD);
|
2015-09-10 12:00:04 +02:00
|
|
|
|
|
|
|
|
/* Value */
|
2016-02-12 14:05:11 +01:00
|
|
|
src_reg val_reg = get_nir_src(instr->src[0], BRW_REGISTER_TYPE_F, 4);
|
2015-09-10 12:00:04 +02:00
|
|
|
|
|
|
|
|
/* IvyBridge does not have a native SIMD4x2 untyped write message so untyped
|
|
|
|
|
* writes will use SIMD8 mode. In order to hide this and keep symmetry across
|
|
|
|
|
* typed and untyped messages and across hardware platforms, the
|
|
|
|
|
* current implementation of the untyped messages will transparently convert
|
|
|
|
|
* the SIMD4x2 payload into an equivalent SIMD8 payload by transposing it
|
|
|
|
|
* and enabling only channel X on the SEND instruction.
|
|
|
|
|
*
|
|
|
|
|
* The above, works well for full vector writes, but not for partial writes
|
|
|
|
|
* where we want to write some channels and not others, like when we have
|
|
|
|
|
* code such as v.xyw = vec3(1,2,4). Because the untyped write messages are
|
|
|
|
|
* quite restrictive with regards to the channel enables we can configure in
|
|
|
|
|
* the message descriptor (not all combinations are allowed) we cannot simply
|
|
|
|
|
* implement these scenarios with a single message while keeping the
|
|
|
|
|
* aforementioned symmetry in the implementation. For now we de decided that
|
|
|
|
|
* it is better to keep the symmetry to reduce complexity, so in situations
|
|
|
|
|
* such as the one described we end up emitting two untyped write messages
|
|
|
|
|
* (one for xy and another for w).
|
|
|
|
|
*
|
|
|
|
|
* The code below packs consecutive channels into a single write message,
|
|
|
|
|
* detects gaps in the vector write and if needed, sends a second message
|
|
|
|
|
* with the remaining channels. If in the future we decide that we want to
|
|
|
|
|
* emit a single message at the expense of losing the symmetry in the
|
|
|
|
|
* implementation we can:
|
|
|
|
|
*
|
|
|
|
|
* 1) For IvyBridge: Only use the red channel of the untyped write SIMD8
|
|
|
|
|
* message payload. In this mode we can write up to 8 offsets and dwords
|
|
|
|
|
* to the red channel only (for the two vec4s in the SIMD4x2 execution)
|
|
|
|
|
* and select which of the 8 channels carry data to write by setting the
|
|
|
|
|
* appropriate writemask in the dst register of the SEND instruction.
|
|
|
|
|
* It would require to write a new generator opcode specifically for
|
|
|
|
|
* IvyBridge since we would need to prepare a SIMD8 payload that could
|
|
|
|
|
* use any channel, not just X.
|
|
|
|
|
*
|
|
|
|
|
* 2) For Haswell+: Simply send a single write message but set the writemask
|
|
|
|
|
* on the dst of the SEND instruction to select the channels we want to
|
|
|
|
|
* write. It would require to modify the current messages to receive
|
|
|
|
|
* and honor the writemask provided.
|
|
|
|
|
*/
|
|
|
|
|
const vec4_builder bld = vec4_builder(this).at_end()
|
|
|
|
|
.annotate(current_annotation, base_ir);
|
|
|
|
|
|
2018-11-12 18:48:10 -06:00
|
|
|
emit_untyped_write(bld, surf_index, offset_reg, val_reg,
|
|
|
|
|
1 /* dims */, instr->num_components /* size */,
|
|
|
|
|
BRW_PREDICATE_NONE);
|
2015-09-10 12:00:04 +02:00
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2015-09-10 12:01:02 +02:00
|
|
|
case nir_intrinsic_load_ssbo: {
|
2021-03-29 14:41:58 -07:00
|
|
|
assert(devinfo->ver == 7);
|
2015-09-10 12:01:02 +02:00
|
|
|
|
2018-11-12 18:48:10 -06:00
|
|
|
/* brw_nir_lower_mem_access_bit_sizes takes care of this */
|
|
|
|
|
assert(nir_dest_bit_size(instr->dest) == 32);
|
|
|
|
|
|
2018-10-20 10:05:33 -05:00
|
|
|
src_reg surf_index = get_nir_ssbo_intrinsic_index(instr);
|
|
|
|
|
src_reg offset_reg = retype(get_nir_src_imm(instr->src[1]),
|
|
|
|
|
BRW_REGISTER_TYPE_UD);
|
2015-09-10 12:01:02 +02:00
|
|
|
|
|
|
|
|
/* Read the vector */
|
|
|
|
|
const vec4_builder bld = vec4_builder(this).at_end()
|
|
|
|
|
.annotate(current_annotation, base_ir);
|
|
|
|
|
|
2018-11-12 18:48:10 -06:00
|
|
|
src_reg read_result = emit_untyped_read(bld, surf_index, offset_reg,
|
|
|
|
|
1 /* dims */, 4 /* size*/,
|
|
|
|
|
BRW_PREDICATE_NONE);
|
2015-09-10 12:01:02 +02:00
|
|
|
dst_reg dest = get_nir_dest(instr->dest);
|
|
|
|
|
read_result.type = dest.type;
|
|
|
|
|
read_result.swizzle = brw_swizzle_for_size(instr->num_components);
|
|
|
|
|
emit(MOV(dest, read_result));
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2019-08-20 23:10:50 -05:00
|
|
|
case nir_intrinsic_ssbo_atomic_add:
|
2015-09-28 10:47:22 +02:00
|
|
|
case nir_intrinsic_ssbo_atomic_imin:
|
|
|
|
|
case nir_intrinsic_ssbo_atomic_umin:
|
|
|
|
|
case nir_intrinsic_ssbo_atomic_imax:
|
|
|
|
|
case nir_intrinsic_ssbo_atomic_umax:
|
2015-08-07 11:31:13 +02:00
|
|
|
case nir_intrinsic_ssbo_atomic_and:
|
|
|
|
|
case nir_intrinsic_ssbo_atomic_or:
|
|
|
|
|
case nir_intrinsic_ssbo_atomic_xor:
|
|
|
|
|
case nir_intrinsic_ssbo_atomic_exchange:
|
|
|
|
|
case nir_intrinsic_ssbo_atomic_comp_swap:
|
2019-08-20 23:10:50 -05:00
|
|
|
nir_emit_ssbo_atomic(brw_aop_for_nir_intrinsic(instr), instr);
|
2015-08-07 11:31:13 +02:00
|
|
|
break;
|
|
|
|
|
|
2015-06-16 12:08:09 +02:00
|
|
|
case nir_intrinsic_load_vertex_id:
|
2022-08-30 12:14:01 -07:00
|
|
|
unreachable("should be lowered by vertex_id_zero_based");
|
2015-06-16 12:08:09 +02:00
|
|
|
|
2015-08-03 16:10:21 -07:00
|
|
|
case nir_intrinsic_load_vertex_id_zero_base:
|
|
|
|
|
case nir_intrinsic_load_base_vertex:
|
2015-11-17 01:07:39 -08:00
|
|
|
case nir_intrinsic_load_instance_id:
|
2015-12-10 12:24:50 -08:00
|
|
|
case nir_intrinsic_load_base_instance:
|
2015-12-10 12:27:38 -08:00
|
|
|
case nir_intrinsic_load_draw_id:
|
2017-05-03 17:40:54 -07:00
|
|
|
case nir_intrinsic_load_invocation_id:
|
|
|
|
|
unreachable("should be lowered by brw_nir_lower_vs_inputs()");
|
2015-06-16 12:08:09 +02:00
|
|
|
|
2015-06-16 21:55:14 +02:00
|
|
|
case nir_intrinsic_load_uniform: {
|
2016-04-05 15:55:35 -07:00
|
|
|
/* Offsets are in bytes but they should always be multiples of 4 */
|
|
|
|
|
assert(nir_intrinsic_base(instr) % 4 == 0);
|
2015-11-10 21:12:47 -08:00
|
|
|
|
2015-06-16 21:55:14 +02:00
|
|
|
dest = get_nir_dest(instr->dest);
|
|
|
|
|
|
2016-04-18 18:51:50 -07:00
|
|
|
src = src_reg(dst_reg(UNIFORM, nir_intrinsic_base(instr) / 16));
|
2015-11-25 14:14:05 -08:00
|
|
|
src.type = dest.type;
|
2015-06-16 21:55:14 +02:00
|
|
|
|
2016-04-05 15:55:35 -07:00
|
|
|
/* Uniforms don't actually have to be vec4 aligned. In the case that
|
|
|
|
|
* it isn't, we have to use a swizzle to shift things around. They
|
|
|
|
|
* do still have the std140 alignment requirement that vec2's have to
|
|
|
|
|
* be vec2-aligned and vec3's and vec4's have to be vec4-aligned.
|
|
|
|
|
*
|
|
|
|
|
* The swizzle also works in the indirect case as the generator adds
|
|
|
|
|
* the swizzle to the offset for us.
|
|
|
|
|
*/
|
2017-04-19 10:35:07 +02:00
|
|
|
const int type_size = type_sz(src.type);
|
|
|
|
|
unsigned shift = (nir_intrinsic_base(instr) % 16) / type_size;
|
2016-04-05 15:55:35 -07:00
|
|
|
assert(shift + instr->num_components <= 4);
|
|
|
|
|
|
2018-10-20 10:28:51 -05:00
|
|
|
if (nir_src_is_const(instr->src[0])) {
|
|
|
|
|
const unsigned load_offset = nir_src_as_uint(instr->src[0]);
|
2016-04-05 15:55:35 -07:00
|
|
|
/* Offsets are in bytes but they should always be multiples of 4 */
|
2018-10-20 10:28:51 -05:00
|
|
|
assert(load_offset % 4 == 0);
|
2016-04-05 15:55:35 -07:00
|
|
|
|
2017-04-19 10:35:07 +02:00
|
|
|
src.swizzle = brw_swizzle_for_size(instr->num_components);
|
|
|
|
|
dest.writemask = brw_writemask_for_size(instr->num_components);
|
2018-10-20 10:28:51 -05:00
|
|
|
unsigned offset = load_offset + shift * type_size;
|
2016-09-01 13:10:36 -07:00
|
|
|
src.offset = ROUND_DOWN_TO(offset, 16);
|
2017-04-19 10:35:07 +02:00
|
|
|
shift = (offset % 16) / type_size;
|
|
|
|
|
assert(shift + instr->num_components <= 4);
|
2016-04-05 15:55:35 -07:00
|
|
|
src.swizzle += BRW_SWIZZLE4(shift, shift, shift, shift);
|
2015-11-25 09:36:34 -08:00
|
|
|
|
|
|
|
|
emit(MOV(dest, src));
|
2015-11-25 14:14:05 -08:00
|
|
|
} else {
|
2017-04-19 10:35:07 +02:00
|
|
|
/* Uniform arrays are vec4 aligned, because of std140 alignment
|
|
|
|
|
* rules.
|
|
|
|
|
*/
|
|
|
|
|
assert(shift == 0);
|
2016-04-05 15:55:35 -07:00
|
|
|
|
2015-11-25 09:36:34 -08:00
|
|
|
src_reg indirect = get_nir_src(instr->src[0], BRW_REGISTER_TYPE_UD, 1);
|
2015-06-16 21:55:14 +02:00
|
|
|
|
2016-04-05 15:55:35 -07:00
|
|
|
/* MOV_INDIRECT is going to stomp the whole thing anyway */
|
|
|
|
|
dest.writemask = WRITEMASK_XYZW;
|
|
|
|
|
|
2015-11-25 09:36:34 -08:00
|
|
|
emit(SHADER_OPCODE_MOV_INDIRECT, dest, src,
|
2022-08-13 01:11:58 -07:00
|
|
|
indirect, brw_imm_ud(nir_intrinsic_range(instr)));
|
2015-11-25 09:36:34 -08:00
|
|
|
}
|
2015-06-16 12:08:09 +02:00
|
|
|
break;
|
2015-06-16 21:55:14 +02:00
|
|
|
}
|
2015-06-16 12:08:09 +02:00
|
|
|
|
2015-06-16 22:10:32 +02:00
|
|
|
case nir_intrinsic_load_ubo: {
|
|
|
|
|
src_reg surf_index;
|
|
|
|
|
|
|
|
|
|
dest = get_nir_dest(instr->dest);
|
|
|
|
|
|
2018-10-20 10:28:51 -05:00
|
|
|
if (nir_src_is_const(instr->src[0])) {
|
2015-06-16 22:10:32 +02:00
|
|
|
/* The block index is a constant, so just emit the binding table entry
|
|
|
|
|
* as an immediate.
|
|
|
|
|
*/
|
2021-12-03 22:20:30 -06:00
|
|
|
const unsigned index = nir_src_as_uint(instr->src[0]);
|
2015-11-02 12:12:44 -08:00
|
|
|
surf_index = brw_imm_ud(index);
|
2015-06-16 22:10:32 +02:00
|
|
|
} else {
|
|
|
|
|
/* The block index is not a constant. Evaluate the index expression
|
|
|
|
|
* per-channel and add the base UBO index; we have to select a value
|
|
|
|
|
* from any live channel.
|
|
|
|
|
*/
|
|
|
|
|
surf_index = src_reg(this, glsl_type::uint_type);
|
2021-12-03 22:20:30 -06:00
|
|
|
emit(MOV(dst_reg(surf_index), get_nir_src(instr->src[0], nir_type_int32,
|
|
|
|
|
instr->num_components)));
|
2015-06-16 22:10:32 +02:00
|
|
|
surf_index = emit_uniformize(surf_index);
|
|
|
|
|
}
|
|
|
|
|
|
2021-05-02 17:19:02 -05:00
|
|
|
src_reg push_reg;
|
2016-07-13 12:10:18 +02:00
|
|
|
src_reg offset_reg;
|
2018-10-20 10:28:51 -05:00
|
|
|
if (nir_src_is_const(instr->src[1])) {
|
|
|
|
|
unsigned load_offset = nir_src_as_uint(instr->src[1]);
|
2021-05-02 17:19:02 -05:00
|
|
|
unsigned aligned_offset = load_offset & ~15;
|
|
|
|
|
offset_reg = brw_imm_ud(aligned_offset);
|
|
|
|
|
|
|
|
|
|
/* See if we've selected this as a push constant candidate */
|
|
|
|
|
if (nir_src_is_const(instr->src[0])) {
|
|
|
|
|
const unsigned ubo_block = nir_src_as_uint(instr->src[0]);
|
|
|
|
|
const unsigned offset_256b = aligned_offset / 32;
|
|
|
|
|
|
|
|
|
|
for (int i = 0; i < 4; i++) {
|
|
|
|
|
const struct brw_ubo_range *range = &prog_data->base.ubo_ranges[i];
|
|
|
|
|
if (range->block == ubo_block &&
|
|
|
|
|
offset_256b >= range->start &&
|
|
|
|
|
offset_256b < range->start + range->length) {
|
|
|
|
|
|
|
|
|
|
push_reg = src_reg(dst_reg(UNIFORM, UBO_START + i));
|
|
|
|
|
push_reg.type = dest.type;
|
|
|
|
|
push_reg.offset = aligned_offset - 32 * range->start;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2015-06-16 22:10:32 +02:00
|
|
|
} else {
|
2017-11-29 10:50:42 +01:00
|
|
|
offset_reg = src_reg(this, glsl_type::uint_type);
|
|
|
|
|
emit(MOV(dst_reg(offset_reg),
|
|
|
|
|
get_nir_src(instr->src[1], nir_type_uint32, 1)));
|
2015-06-16 22:10:32 +02:00
|
|
|
}
|
|
|
|
|
|
2016-07-13 12:10:18 +02:00
|
|
|
src_reg packed_consts;
|
2021-05-02 17:19:02 -05:00
|
|
|
if (push_reg.file != BAD_FILE) {
|
|
|
|
|
packed_consts = push_reg;
|
|
|
|
|
} else if (nir_dest_bit_size(instr->dest) == 32) {
|
2016-07-13 12:10:18 +02:00
|
|
|
packed_consts = src_reg(this, glsl_type::vec4_type);
|
|
|
|
|
emit_pull_constant_load_reg(dst_reg(packed_consts),
|
|
|
|
|
surf_index,
|
|
|
|
|
offset_reg,
|
|
|
|
|
NULL, NULL /* before_block/inst */);
|
2021-05-02 17:19:02 -05:00
|
|
|
prog_data->base.has_ubo_pull = true;
|
2016-07-13 12:10:18 +02:00
|
|
|
} else {
|
|
|
|
|
src_reg temp = src_reg(this, glsl_type::dvec4_type);
|
|
|
|
|
src_reg temp_float = retype(temp, BRW_REGISTER_TYPE_F);
|
|
|
|
|
|
|
|
|
|
emit_pull_constant_load_reg(dst_reg(temp_float),
|
|
|
|
|
surf_index, offset_reg, NULL, NULL);
|
|
|
|
|
if (offset_reg.file == IMM)
|
|
|
|
|
offset_reg.ud += 16;
|
|
|
|
|
else
|
|
|
|
|
emit(ADD(dst_reg(offset_reg), offset_reg, brw_imm_ud(16u)));
|
|
|
|
|
emit_pull_constant_load_reg(dst_reg(byte_offset(temp_float, REG_SIZE)),
|
|
|
|
|
surf_index, offset_reg, NULL, NULL);
|
2021-05-02 17:19:02 -05:00
|
|
|
prog_data->base.has_ubo_pull = true;
|
2016-07-13 12:10:18 +02:00
|
|
|
|
|
|
|
|
packed_consts = src_reg(this, glsl_type::dvec4_type);
|
|
|
|
|
shuffle_64bit_data(dst_reg(packed_consts), temp, false);
|
|
|
|
|
}
|
2015-06-16 22:10:32 +02:00
|
|
|
|
|
|
|
|
packed_consts.swizzle = brw_swizzle_for_size(instr->num_components);
|
2018-10-20 10:28:51 -05:00
|
|
|
if (nir_src_is_const(instr->src[1])) {
|
|
|
|
|
unsigned load_offset = nir_src_as_uint(instr->src[1]);
|
2016-07-13 12:10:18 +02:00
|
|
|
unsigned type_size = type_sz(dest.type);
|
|
|
|
|
packed_consts.swizzle +=
|
2018-10-20 10:28:51 -05:00
|
|
|
BRW_SWIZZLE4(load_offset % 16 / type_size,
|
|
|
|
|
load_offset % 16 / type_size,
|
|
|
|
|
load_offset % 16 / type_size,
|
|
|
|
|
load_offset % 16 / type_size);
|
2015-11-25 14:14:05 -08:00
|
|
|
}
|
2015-06-16 22:10:32 +02:00
|
|
|
|
2016-07-13 12:10:18 +02:00
|
|
|
emit(MOV(dest, retype(packed_consts, dest.type)));
|
|
|
|
|
|
2015-06-16 12:08:09 +02:00
|
|
|
break;
|
2015-06-16 22:10:32 +02:00
|
|
|
}
|
2015-06-16 12:08:09 +02:00
|
|
|
|
2020-05-05 09:13:20 +02:00
|
|
|
case nir_intrinsic_scoped_barrier:
|
|
|
|
|
assert(nir_intrinsic_execution_scope(instr) == NIR_SCOPE_NONE);
|
2021-04-10 17:11:58 +02:00
|
|
|
FALLTHROUGH;
|
2020-05-05 09:13:20 +02:00
|
|
|
case nir_intrinsic_memory_barrier: {
|
2015-09-15 11:16:29 +02:00
|
|
|
const vec4_builder bld =
|
|
|
|
|
vec4_builder(this).at_end().annotate(current_annotation, base_ir);
|
intel/fs,vec4: Pull stall logic for memory fences up into the IR
Instead of emitting the stall MOV "inside" the
SHADER_OPCODE_MEMORY_FENCE generation, use the scheduling fences when
creating the IR.
For IvyBridge, every (data cache) fence is accompained by a render
cache fence, that now is explicit in the IR, two
SHADER_OPCODE_MEMORY_FENCEs are emitted (with different SFIDs).
Because Begin and End interlock intrinsics are effectively memory
barriers, move its handling alongside the other memory barrier
intrinsics. The SHADER_OPCODE_INTERLOCK is still used to distinguish
if we are going to use a SENDC (for Begin) or regular SEND (for End).
This change is a preparation to allow emitting both SENDs in Gen11+
before we can stall on them.
Shader-db results for IVB (i965):
total instructions in shared programs: 11971190 -> 11971200 (<.01%)
instructions in affected programs: 11482 -> 11492 (0.09%)
helped: 0
HURT: 8
HURT stats (abs) min: 1 max: 3 x̄: 1.25 x̃: 1
HURT stats (rel) min: 0.03% max: 0.50% x̄: 0.14% x̃: 0.10%
95% mean confidence interval for instructions value: 0.66 1.84
95% mean confidence interval for instructions %-change: 0.01% 0.27%
Instructions are HURT.
Unlike the previous code, that used the `mov g1 g2` trick to force
both `g1` and `g2` to stall, the scheduling fence will generate `mov
null g1` and `mov null g2`. During review it was decided it was not
worth keeping the special codepath for the small effect will have.
Shader-db results for HSW (i965), BDW and SKL don't have a change
on instruction count, but do report changes in cycles count, showing
SKL results below
total cycles in shared programs: 341738444 -> 341710570 (<.01%)
cycles in affected programs: 7240002 -> 7212128 (-0.38%)
helped: 46
HURT: 5
helped stats (abs) min: 14 max: 1940 x̄: 676.22 x̃: 154
helped stats (rel) min: <.01% max: 2.62% x̄: 1.28% x̃: 0.95%
HURT stats (abs) min: 2 max: 1768 x̄: 646.40 x̃: 362
HURT stats (rel) min: <.01% max: 0.83% x̄: 0.28% x̃: 0.08%
95% mean confidence interval for cycles value: -777.71 -315.38
95% mean confidence interval for cycles %-change: -1.42% -0.83%
Cycles are helped.
This seems to be the effect of allocating two registers separatedly
instead of a single one with size 2, which causes different register
allocation, affecting the cycle estimates.
while ICL also has not change on instruction count but report changes
negative changes in cycles
total cycles in shared programs: 352665369 -> 352707484 (0.01%)
cycles in affected programs: 9608288 -> 9650403 (0.44%)
helped: 4
HURT: 104
helped stats (abs) min: 24 max: 128 x̄: 88.50 x̃: 101
helped stats (rel) min: <.01% max: 0.85% x̄: 0.46% x̃: 0.49%
HURT stats (abs) min: 2 max: 2016 x̄: 408.36 x̃: 48
HURT stats (rel) min: <.01% max: 3.31% x̄: 0.88% x̃: 0.45%
95% mean confidence interval for cycles value: 256.67 523.24
95% mean confidence interval for cycles %-change: 0.63% 1.03%
Cycles are HURT.
AFAICT this is the result of the case above.
Shader-db results for TGL have similar cycles result as ICL, but also
affect instructions
total instructions in shared programs: 17690586 -> 17690597 (<.01%)
instructions in affected programs: 64617 -> 64628 (0.02%)
helped: 55
HURT: 32
helped stats (abs) min: 1 max: 16 x̄: 4.13 x̃: 3
helped stats (rel) min: 0.05% max: 2.78% x̄: 0.86% x̃: 0.74%
HURT stats (abs) min: 1 max: 65 x̄: 7.44 x̃: 2
HURT stats (rel) min: 0.05% max: 4.58% x̄: 1.13% x̃: 0.69%
95% mean confidence interval for instructions value: -2.03 2.28
95% mean confidence interval for instructions %-change: -0.41% 0.15%
Inconclusive result (value mean confidence interval includes 0).
Now that more is done in the IR, more dependencies are visible and
more SWSB annotations are emitted. Mixed with different register
allocation decisions like above, some shaders will see more `sync
nops` while others able to avoid them.
Most of the new `sync nops` are also redundant and could be dropped,
which will be fixed in a separate change.
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3278>
2020-01-17 15:07:44 -08:00
|
|
|
const dst_reg tmp = bld.vgrf(BRW_REGISTER_TYPE_UD);
|
|
|
|
|
vec4_instruction *fence =
|
|
|
|
|
bld.emit(SHADER_OPCODE_MEMORY_FENCE, tmp, brw_vec8_grf(0, 0));
|
2021-03-29 15:16:59 -07:00
|
|
|
fence->sfid = GFX7_SFID_DATAPORT_DATA_CACHE;
|
2015-09-15 11:16:29 +02:00
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2015-10-07 11:50:01 +01:00
|
|
|
case nir_intrinsic_shader_clock: {
|
|
|
|
|
/* We cannot do anything if there is an event, so ignore it for now */
|
|
|
|
|
const src_reg shader_clock = get_timestamp();
|
|
|
|
|
const enum brw_reg_type type = brw_type_for_base_type(glsl_type::uvec2_type);
|
|
|
|
|
|
|
|
|
|
dest = get_nir_dest(instr->dest, type);
|
|
|
|
|
emit(MOV(dest, shader_clock));
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-16 12:08:09 +02:00
|
|
|
default:
|
|
|
|
|
unreachable("Unknown intrinsic");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-08-07 11:31:13 +02:00
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_ssbo_atomic(int op, nir_intrinsic_instr *instr)
|
|
|
|
|
{
|
|
|
|
|
dst_reg dest;
|
|
|
|
|
if (nir_intrinsic_infos[instr->intrinsic].has_dest)
|
|
|
|
|
dest = get_nir_dest(instr->dest);
|
|
|
|
|
|
2018-10-20 10:05:33 -05:00
|
|
|
src_reg surface = get_nir_ssbo_intrinsic_index(instr);
|
2015-08-07 11:31:13 +02:00
|
|
|
src_reg offset = get_nir_src(instr->src[1], 1);
|
2018-08-24 17:24:36 -07:00
|
|
|
src_reg data1;
|
|
|
|
|
if (op != BRW_AOP_INC && op != BRW_AOP_DEC && op != BRW_AOP_PREDEC)
|
|
|
|
|
data1 = get_nir_src(instr->src[2], 1);
|
2015-08-07 11:31:13 +02:00
|
|
|
src_reg data2;
|
|
|
|
|
if (op == BRW_AOP_CMPWR)
|
|
|
|
|
data2 = get_nir_src(instr->src[3], 1);
|
|
|
|
|
|
|
|
|
|
/* Emit the actual atomic operation operation */
|
|
|
|
|
const vec4_builder bld =
|
|
|
|
|
vec4_builder(this).at_end().annotate(current_annotation, base_ir);
|
|
|
|
|
|
2016-03-04 18:20:09 +01:00
|
|
|
src_reg atomic_result = emit_untyped_atomic(bld, surface, offset,
|
|
|
|
|
data1, data2,
|
|
|
|
|
1 /* dims */, 1 /* rsize */,
|
|
|
|
|
op,
|
|
|
|
|
BRW_PREDICATE_NONE);
|
2015-08-07 11:31:13 +02:00
|
|
|
dest.type = atomic_result.type;
|
|
|
|
|
bld.MOV(dest, atomic_result);
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-16 22:30:16 +02:00
|
|
|
static unsigned
|
|
|
|
|
brw_swizzle_for_nir_swizzle(uint8_t swizzle[4])
|
|
|
|
|
{
|
|
|
|
|
return BRW_SWIZZLE4(swizzle[0], swizzle[1], swizzle[2], swizzle[3]);
|
|
|
|
|
}
|
|
|
|
|
|
i965/vec4: Optimize predicate handling for any/all.
For a select whose condition is any(v), instead of emitting
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
mov(8) g7<1>.xUD 0x00000000UD
(+f0.any4h) mov(8) g7<1>.xUD 0xffffffffUD
cmp.nz.f0(8) null<1>D g7<4,4,1>.xD 0D
(+f0) sel(8) g8<1>UD g4<4,4,1>UD g3<4,4,1>UD
we now emit
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
(+f0.any4h) sel(8) g9<1>UD g4<4,4,1>UD g3<4,4,1>UD
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2015-11-25 21:54:30 -08:00
|
|
|
bool
|
|
|
|
|
vec4_visitor::optimize_predicate(nir_alu_instr *instr,
|
|
|
|
|
enum brw_predicate *predicate)
|
|
|
|
|
{
|
|
|
|
|
if (!instr->src[0].src.is_ssa ||
|
|
|
|
|
instr->src[0].src.ssa->parent_instr->type != nir_instr_type_alu)
|
|
|
|
|
return false;
|
|
|
|
|
|
|
|
|
|
nir_alu_instr *cmp_instr =
|
|
|
|
|
nir_instr_as_alu(instr->src[0].src.ssa->parent_instr);
|
|
|
|
|
|
|
|
|
|
switch (cmp_instr->op) {
|
2018-10-18 11:44:38 -05:00
|
|
|
case nir_op_b32any_fnequal2:
|
|
|
|
|
case nir_op_b32any_inequal2:
|
|
|
|
|
case nir_op_b32any_fnequal3:
|
|
|
|
|
case nir_op_b32any_inequal3:
|
|
|
|
|
case nir_op_b32any_fnequal4:
|
|
|
|
|
case nir_op_b32any_inequal4:
|
i965/vec4: Optimize predicate handling for any/all.
For a select whose condition is any(v), instead of emitting
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
mov(8) g7<1>.xUD 0x00000000UD
(+f0.any4h) mov(8) g7<1>.xUD 0xffffffffUD
cmp.nz.f0(8) null<1>D g7<4,4,1>.xD 0D
(+f0) sel(8) g8<1>UD g4<4,4,1>UD g3<4,4,1>UD
we now emit
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
(+f0.any4h) sel(8) g9<1>UD g4<4,4,1>UD g3<4,4,1>UD
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2015-11-25 21:54:30 -08:00
|
|
|
*predicate = BRW_PREDICATE_ALIGN16_ANY4H;
|
|
|
|
|
break;
|
2018-10-18 11:44:38 -05:00
|
|
|
case nir_op_b32all_fequal2:
|
|
|
|
|
case nir_op_b32all_iequal2:
|
|
|
|
|
case nir_op_b32all_fequal3:
|
|
|
|
|
case nir_op_b32all_iequal3:
|
|
|
|
|
case nir_op_b32all_fequal4:
|
|
|
|
|
case nir_op_b32all_iequal4:
|
i965/vec4: Optimize predicate handling for any/all.
For a select whose condition is any(v), instead of emitting
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
mov(8) g7<1>.xUD 0x00000000UD
(+f0.any4h) mov(8) g7<1>.xUD 0xffffffffUD
cmp.nz.f0(8) null<1>D g7<4,4,1>.xD 0D
(+f0) sel(8) g8<1>UD g4<4,4,1>UD g3<4,4,1>UD
we now emit
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
(+f0.any4h) sel(8) g9<1>UD g4<4,4,1>UD g3<4,4,1>UD
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2015-11-25 21:54:30 -08:00
|
|
|
*predicate = BRW_PREDICATE_ALIGN16_ALL4H;
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
unsigned size_swizzle =
|
|
|
|
|
brw_swizzle_for_size(nir_op_infos[cmp_instr->op].input_sizes[0]);
|
|
|
|
|
|
|
|
|
|
src_reg op[2];
|
|
|
|
|
assert(nir_op_infos[cmp_instr->op].num_inputs == 2);
|
|
|
|
|
for (unsigned i = 0; i < 2; i++) {
|
2016-02-18 09:24:16 +01:00
|
|
|
nir_alu_type type = nir_op_infos[cmp_instr->op].input_types[i];
|
|
|
|
|
unsigned bit_size = nir_src_bit_size(cmp_instr->src[i].src);
|
|
|
|
|
type = (nir_alu_type) (((unsigned) type) | bit_size);
|
|
|
|
|
op[i] = get_nir_src(cmp_instr->src[i].src, type, 4);
|
i965/vec4: Optimize predicate handling for any/all.
For a select whose condition is any(v), instead of emitting
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
mov(8) g7<1>.xUD 0x00000000UD
(+f0.any4h) mov(8) g7<1>.xUD 0xffffffffUD
cmp.nz.f0(8) null<1>D g7<4,4,1>.xD 0D
(+f0) sel(8) g8<1>UD g4<4,4,1>UD g3<4,4,1>UD
we now emit
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
(+f0.any4h) sel(8) g9<1>UD g4<4,4,1>UD g3<4,4,1>UD
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2015-11-25 21:54:30 -08:00
|
|
|
unsigned base_swizzle =
|
|
|
|
|
brw_swizzle_for_nir_swizzle(cmp_instr->src[i].swizzle);
|
|
|
|
|
op[i].swizzle = brw_compose_swizzle(size_swizzle, base_swizzle);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
emit(CMP(dst_null_d(), op[0], op[1],
|
2019-08-02 15:19:16 -05:00
|
|
|
brw_cmod_for_nir_comparison(cmp_instr->op)));
|
i965/vec4: Optimize predicate handling for any/all.
For a select whose condition is any(v), instead of emitting
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
mov(8) g7<1>.xUD 0x00000000UD
(+f0.any4h) mov(8) g7<1>.xUD 0xffffffffUD
cmp.nz.f0(8) null<1>D g7<4,4,1>.xD 0D
(+f0) sel(8) g8<1>UD g4<4,4,1>UD g3<4,4,1>UD
we now emit
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
(+f0.any4h) sel(8) g9<1>UD g4<4,4,1>UD g3<4,4,1>UD
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2015-11-25 21:54:30 -08:00
|
|
|
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
2016-06-21 15:14:03 -07:00
|
|
|
static void
|
|
|
|
|
emit_find_msb_using_lzd(const vec4_builder &bld,
|
|
|
|
|
const dst_reg &dst,
|
|
|
|
|
const src_reg &src,
|
|
|
|
|
bool is_signed)
|
|
|
|
|
{
|
|
|
|
|
vec4_instruction *inst;
|
2016-06-21 17:18:04 -07:00
|
|
|
src_reg temp = src;
|
2016-06-21 15:14:03 -07:00
|
|
|
|
2016-06-21 17:18:04 -07:00
|
|
|
if (is_signed) {
|
|
|
|
|
/* LZD of an absolute value source almost always does the right
|
|
|
|
|
* thing. There are two problem values:
|
|
|
|
|
*
|
|
|
|
|
* * 0x80000000. Since abs(0x80000000) == 0x80000000, LZD returns
|
|
|
|
|
* 0. However, findMSB(int(0x80000000)) == 30.
|
|
|
|
|
*
|
|
|
|
|
* * 0xffffffff. Since abs(0xffffffff) == 1, LZD returns
|
|
|
|
|
* 31. Section 8.8 (Integer Functions) of the GLSL 4.50 spec says:
|
|
|
|
|
*
|
|
|
|
|
* For a value of zero or negative one, -1 will be returned.
|
|
|
|
|
*
|
|
|
|
|
* * Negative powers of two. LZD(abs(-(1<<x))) returns x, but
|
|
|
|
|
* findMSB(-(1<<x)) should return x-1.
|
|
|
|
|
*
|
|
|
|
|
* For all negative number cases, including 0x80000000 and
|
|
|
|
|
* 0xffffffff, the correct value is obtained from LZD if instead of
|
|
|
|
|
* negating the (already negative) value the logical-not is used. A
|
2022-06-22 18:31:08 +02:00
|
|
|
* conditional logical-not can be achieved in two instructions.
|
2016-06-21 17:18:04 -07:00
|
|
|
*/
|
|
|
|
|
temp = src_reg(bld.vgrf(BRW_REGISTER_TYPE_D));
|
|
|
|
|
|
|
|
|
|
bld.ASR(dst_reg(temp), src, brw_imm_d(31));
|
|
|
|
|
bld.XOR(dst_reg(temp), temp, src);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bld.LZD(retype(dst, BRW_REGISTER_TYPE_UD),
|
|
|
|
|
retype(temp, BRW_REGISTER_TYPE_UD));
|
2016-06-21 15:14:03 -07:00
|
|
|
|
|
|
|
|
/* LZD counts from the MSB side, while GLSL's findMSB() wants the count
|
|
|
|
|
* from the LSB side. Subtract the result from 31 to convert the MSB count
|
|
|
|
|
* into an LSB count. If no bits are set, LZD will return 32. 31-32 = -1,
|
|
|
|
|
* which is exactly what findMSB() is supposed to return.
|
|
|
|
|
*/
|
|
|
|
|
inst = bld.ADD(dst, retype(src_reg(dst), BRW_REGISTER_TYPE_D),
|
|
|
|
|
brw_imm_d(31));
|
|
|
|
|
inst->src[0].negate = true;
|
|
|
|
|
}
|
|
|
|
|
|
2016-06-29 13:07:35 +02:00
|
|
|
void
|
intel/compiler: Drop nir_lower_to_source_mods() and related handling.
I think we're unanimous in wanting to drop nir_lower_to_source_mods.
It's a bit of complexity to handle in the backend, but perhaps more
importantly, would be even more complexity to handle in nir_search.
And, it turns out that since we made other compiler improvements in the
last few years, they no longer appear to buy us anything of value.
Summarizing the results from shader-db from this patch:
- Icelake (scalar mode)
Instruction counts:
- 411 helped, 598 hurt (out of 139,470 shaders)
- 99.2% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.78 instructions.
- total instructions in shared programs: 17214951 -> 17215206 (<.01%)
- instructions in affected programs: 1143879 -> 1144134 (0.02%)
Cycles:
- 1042 helped, 1357 hurt
- total cycles in shared programs: 365613294 -> 365882263 (0.07%)
- cycles in affected programs: 138155497 -> 138424466 (0.19%)
- Haswell (both scalar and vector modes)
Instruction counts:
- 73 helped, 1680 hurt (out of 139,470 shaders)
- 98.7% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.9 instructions.
- total instructions in shared programs: 14199527 -> 14202262 (0.02%)
- instructions in affected programs: 446499 -> 449234 (0.61%)
Cycles:
- 5253 helped, 5559 hurt
- total cycles in shared programs: 359996545 -> 360038731 (0.01%)
- cycles in affected programs: 155897127 -> 155939313 (0.03%)
Given that ~99% of shader-db remains unaffected, and the affected
programs are hurt by about 1-2 instructions - which are all cheap
ALU instructions - this is unlikely to be measurable in terms of
any real performance impact that would affect users.
So, drop them and simplify the backend, and hopefully enable other
future simplifications in NIR.
Reviewed-by: Eric Anholt <eric@anholt.net> [v1]
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4616>
2020-04-18 01:20:42 -07:00
|
|
|
vec4_visitor::emit_conversion_from_double(dst_reg dst, src_reg src)
|
2016-06-29 13:07:35 +02:00
|
|
|
{
|
2017-03-24 08:46:13 +01:00
|
|
|
enum opcode op;
|
|
|
|
|
switch (dst.type) {
|
|
|
|
|
case BRW_REGISTER_TYPE_D:
|
|
|
|
|
op = VEC4_OPCODE_DOUBLE_TO_D32;
|
|
|
|
|
break;
|
|
|
|
|
case BRW_REGISTER_TYPE_UD:
|
|
|
|
|
op = VEC4_OPCODE_DOUBLE_TO_U32;
|
|
|
|
|
break;
|
|
|
|
|
case BRW_REGISTER_TYPE_F:
|
|
|
|
|
op = VEC4_OPCODE_DOUBLE_TO_F32;
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
unreachable("Unknown conversion");
|
|
|
|
|
}
|
|
|
|
|
|
2016-06-29 13:07:35 +02:00
|
|
|
dst_reg temp = dst_reg(this, glsl_type::dvec4_type);
|
|
|
|
|
emit(MOV(temp, src));
|
|
|
|
|
dst_reg temp2 = dst_reg(this, glsl_type::dvec4_type);
|
2017-03-24 08:46:13 +01:00
|
|
|
emit(op, temp2, src_reg(temp));
|
2016-06-29 13:07:35 +02:00
|
|
|
|
2017-03-24 08:46:13 +01:00
|
|
|
emit(VEC4_OPCODE_PICK_LOW_32BIT, retype(temp2, dst.type), src_reg(temp2));
|
intel/compiler: Drop nir_lower_to_source_mods() and related handling.
I think we're unanimous in wanting to drop nir_lower_to_source_mods.
It's a bit of complexity to handle in the backend, but perhaps more
importantly, would be even more complexity to handle in nir_search.
And, it turns out that since we made other compiler improvements in the
last few years, they no longer appear to buy us anything of value.
Summarizing the results from shader-db from this patch:
- Icelake (scalar mode)
Instruction counts:
- 411 helped, 598 hurt (out of 139,470 shaders)
- 99.2% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.78 instructions.
- total instructions in shared programs: 17214951 -> 17215206 (<.01%)
- instructions in affected programs: 1143879 -> 1144134 (0.02%)
Cycles:
- 1042 helped, 1357 hurt
- total cycles in shared programs: 365613294 -> 365882263 (0.07%)
- cycles in affected programs: 138155497 -> 138424466 (0.19%)
- Haswell (both scalar and vector modes)
Instruction counts:
- 73 helped, 1680 hurt (out of 139,470 shaders)
- 98.7% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.9 instructions.
- total instructions in shared programs: 14199527 -> 14202262 (0.02%)
- instructions in affected programs: 446499 -> 449234 (0.61%)
Cycles:
- 5253 helped, 5559 hurt
- total cycles in shared programs: 359996545 -> 360038731 (0.01%)
- cycles in affected programs: 155897127 -> 155939313 (0.03%)
Given that ~99% of shader-db remains unaffected, and the affected
programs are hurt by about 1-2 instructions - which are all cheap
ALU instructions - this is unlikely to be measurable in terms of
any real performance impact that would affect users.
So, drop them and simplify the backend, and hopefully enable other
future simplifications in NIR.
Reviewed-by: Eric Anholt <eric@anholt.net> [v1]
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4616>
2020-04-18 01:20:42 -07:00
|
|
|
emit(MOV(dst, src_reg(retype(temp2, dst.type))));
|
2016-06-29 13:07:35 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
intel/compiler: Drop nir_lower_to_source_mods() and related handling.
I think we're unanimous in wanting to drop nir_lower_to_source_mods.
It's a bit of complexity to handle in the backend, but perhaps more
importantly, would be even more complexity to handle in nir_search.
And, it turns out that since we made other compiler improvements in the
last few years, they no longer appear to buy us anything of value.
Summarizing the results from shader-db from this patch:
- Icelake (scalar mode)
Instruction counts:
- 411 helped, 598 hurt (out of 139,470 shaders)
- 99.2% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.78 instructions.
- total instructions in shared programs: 17214951 -> 17215206 (<.01%)
- instructions in affected programs: 1143879 -> 1144134 (0.02%)
Cycles:
- 1042 helped, 1357 hurt
- total cycles in shared programs: 365613294 -> 365882263 (0.07%)
- cycles in affected programs: 138155497 -> 138424466 (0.19%)
- Haswell (both scalar and vector modes)
Instruction counts:
- 73 helped, 1680 hurt (out of 139,470 shaders)
- 98.7% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.9 instructions.
- total instructions in shared programs: 14199527 -> 14202262 (0.02%)
- instructions in affected programs: 446499 -> 449234 (0.61%)
Cycles:
- 5253 helped, 5559 hurt
- total cycles in shared programs: 359996545 -> 360038731 (0.01%)
- cycles in affected programs: 155897127 -> 155939313 (0.03%)
Given that ~99% of shader-db remains unaffected, and the affected
programs are hurt by about 1-2 instructions - which are all cheap
ALU instructions - this is unlikely to be measurable in terms of
any real performance impact that would affect users.
So, drop them and simplify the backend, and hopefully enable other
future simplifications in NIR.
Reviewed-by: Eric Anholt <eric@anholt.net> [v1]
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4616>
2020-04-18 01:20:42 -07:00
|
|
|
vec4_visitor::emit_conversion_to_double(dst_reg dst, src_reg src)
|
2016-06-29 13:07:35 +02:00
|
|
|
{
|
|
|
|
|
dst_reg tmp_dst = dst_reg(src_reg(this, glsl_type::dvec4_type));
|
2017-03-07 18:32:17 -08:00
|
|
|
src_reg tmp_src = retype(src_reg(this, glsl_type::vec4_type), src.type);
|
|
|
|
|
emit(MOV(dst_reg(tmp_src), src));
|
2016-06-29 13:07:35 +02:00
|
|
|
emit(VEC4_OPCODE_TO_DOUBLE, tmp_dst, tmp_src);
|
intel/compiler: Drop nir_lower_to_source_mods() and related handling.
I think we're unanimous in wanting to drop nir_lower_to_source_mods.
It's a bit of complexity to handle in the backend, but perhaps more
importantly, would be even more complexity to handle in nir_search.
And, it turns out that since we made other compiler improvements in the
last few years, they no longer appear to buy us anything of value.
Summarizing the results from shader-db from this patch:
- Icelake (scalar mode)
Instruction counts:
- 411 helped, 598 hurt (out of 139,470 shaders)
- 99.2% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.78 instructions.
- total instructions in shared programs: 17214951 -> 17215206 (<.01%)
- instructions in affected programs: 1143879 -> 1144134 (0.02%)
Cycles:
- 1042 helped, 1357 hurt
- total cycles in shared programs: 365613294 -> 365882263 (0.07%)
- cycles in affected programs: 138155497 -> 138424466 (0.19%)
- Haswell (both scalar and vector modes)
Instruction counts:
- 73 helped, 1680 hurt (out of 139,470 shaders)
- 98.7% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.9 instructions.
- total instructions in shared programs: 14199527 -> 14202262 (0.02%)
- instructions in affected programs: 446499 -> 449234 (0.61%)
Cycles:
- 5253 helped, 5559 hurt
- total cycles in shared programs: 359996545 -> 360038731 (0.01%)
- cycles in affected programs: 155897127 -> 155939313 (0.03%)
Given that ~99% of shader-db remains unaffected, and the affected
programs are hurt by about 1-2 instructions - which are all cheap
ALU instructions - this is unlikely to be measurable in terms of
any real performance impact that would affect users.
So, drop them and simplify the backend, and hopefully enable other
future simplifications in NIR.
Reviewed-by: Eric Anholt <eric@anholt.net> [v1]
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4616>
2020-04-18 01:20:42 -07:00
|
|
|
emit(MOV(dst, src_reg(tmp_dst)));
|
2016-06-29 13:07:35 +02:00
|
|
|
}
|
|
|
|
|
|
2018-12-13 15:39:49 -08:00
|
|
|
/**
|
2019-06-26 13:36:17 -07:00
|
|
|
* Try to use an immediate value for a source
|
2018-12-13 15:39:49 -08:00
|
|
|
*
|
|
|
|
|
* In cases of flow control, constant propagation is sometimes unable to
|
|
|
|
|
* determine that a register contains a constant value. To work around this,
|
2019-06-26 13:36:17 -07:00
|
|
|
* try to emit a literal as one of the sources. If \c try_src0_also is set,
|
|
|
|
|
* \c op[0] will also be tried for an immediate value.
|
|
|
|
|
*
|
|
|
|
|
* If \c op[0] is modified, the operands will be exchanged so that \c op[1]
|
|
|
|
|
* will always be the immediate value.
|
|
|
|
|
*
|
|
|
|
|
* \return The index of the source that was modified, 0 or 1, if successful.
|
|
|
|
|
* Otherwise, -1.
|
|
|
|
|
*
|
|
|
|
|
* \param op - Operands to the instruction
|
|
|
|
|
* \param try_src0_also - True if \c op[0] should also be a candidate for
|
|
|
|
|
* getting an immediate value. This should only be set
|
|
|
|
|
* for commutative operations.
|
2018-12-13 15:39:49 -08:00
|
|
|
*/
|
2019-06-26 13:36:17 -07:00
|
|
|
static int
|
2018-12-13 15:39:49 -08:00
|
|
|
try_immediate_source(const nir_alu_instr *instr, src_reg *op,
|
2020-09-22 13:09:56 -07:00
|
|
|
bool try_src0_also)
|
2018-12-13 15:39:49 -08:00
|
|
|
{
|
2019-06-26 13:36:17 -07:00
|
|
|
unsigned idx;
|
|
|
|
|
|
2019-06-11 12:06:52 -07:00
|
|
|
/* MOV should be the only single-source instruction passed to this
|
|
|
|
|
* function. Any other unary instruction with a constant source should
|
|
|
|
|
* have been constant-folded away!
|
|
|
|
|
*/
|
|
|
|
|
assert(nir_op_infos[instr->op].num_inputs > 1 ||
|
|
|
|
|
instr->op == nir_op_mov);
|
|
|
|
|
|
|
|
|
|
if (instr->op != nir_op_mov &&
|
|
|
|
|
nir_src_bit_size(instr->src[1].src) == 32 &&
|
2019-06-26 13:36:17 -07:00
|
|
|
nir_src_is_const(instr->src[1].src)) {
|
|
|
|
|
idx = 1;
|
|
|
|
|
} else if (try_src0_also &&
|
|
|
|
|
nir_src_bit_size(instr->src[0].src) == 32 &&
|
|
|
|
|
nir_src_is_const(instr->src[0].src)) {
|
|
|
|
|
idx = 0;
|
|
|
|
|
} else {
|
|
|
|
|
return -1;
|
|
|
|
|
}
|
2018-12-13 15:39:49 -08:00
|
|
|
|
2019-06-26 13:36:17 -07:00
|
|
|
const enum brw_reg_type old_type = op[idx].type;
|
2018-12-13 15:39:49 -08:00
|
|
|
|
|
|
|
|
switch (old_type) {
|
|
|
|
|
case BRW_REGISTER_TYPE_D:
|
|
|
|
|
case BRW_REGISTER_TYPE_UD: {
|
2019-06-25 18:39:59 -07:00
|
|
|
int first_comp = -1;
|
2019-08-23 07:41:18 -07:00
|
|
|
int d = 0;
|
2019-06-25 18:39:59 -07:00
|
|
|
|
|
|
|
|
for (unsigned i = 0; i < NIR_MAX_VEC_COMPONENTS; i++) {
|
2019-06-26 13:36:17 -07:00
|
|
|
if (nir_alu_instr_channel_used(instr, idx, i)) {
|
2019-06-25 18:39:59 -07:00
|
|
|
if (first_comp < 0) {
|
|
|
|
|
first_comp = i;
|
2019-06-26 13:36:17 -07:00
|
|
|
d = nir_src_comp_as_int(instr->src[idx].src,
|
|
|
|
|
instr->src[idx].swizzle[i]);
|
|
|
|
|
} else if (d != nir_src_comp_as_int(instr->src[idx].src,
|
|
|
|
|
instr->src[idx].swizzle[i])) {
|
|
|
|
|
return -1;
|
2019-06-25 18:39:59 -07:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2018-12-13 15:39:49 -08:00
|
|
|
|
2019-08-23 07:41:18 -07:00
|
|
|
assert(first_comp >= 0);
|
|
|
|
|
|
2019-06-26 13:36:17 -07:00
|
|
|
if (op[idx].abs)
|
2018-12-13 15:39:49 -08:00
|
|
|
d = MAX2(-d, d);
|
|
|
|
|
|
2020-09-22 13:09:56 -07:00
|
|
|
if (op[idx].negate)
|
2018-12-13 15:39:49 -08:00
|
|
|
d = -d;
|
|
|
|
|
|
2019-06-26 13:36:17 -07:00
|
|
|
op[idx] = retype(src_reg(brw_imm_d(d)), old_type);
|
2018-12-13 15:39:49 -08:00
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
case BRW_REGISTER_TYPE_F: {
|
2019-06-25 18:39:59 -07:00
|
|
|
int first_comp = -1;
|
2020-07-24 20:13:00 +02:00
|
|
|
float f[NIR_MAX_VEC_COMPONENTS] = { 0.0f };
|
2019-06-11 11:08:49 -07:00
|
|
|
bool is_scalar = true;
|
2019-06-25 18:39:59 -07:00
|
|
|
|
|
|
|
|
for (unsigned i = 0; i < NIR_MAX_VEC_COMPONENTS; i++) {
|
2019-06-26 13:36:17 -07:00
|
|
|
if (nir_alu_instr_channel_used(instr, idx, i)) {
|
2019-06-11 11:08:49 -07:00
|
|
|
f[i] = nir_src_comp_as_float(instr->src[idx].src,
|
|
|
|
|
instr->src[idx].swizzle[i]);
|
2019-06-25 18:39:59 -07:00
|
|
|
if (first_comp < 0) {
|
|
|
|
|
first_comp = i;
|
2019-06-11 11:08:49 -07:00
|
|
|
} else if (f[first_comp] != f[i]) {
|
|
|
|
|
is_scalar = false;
|
2019-06-25 18:39:59 -07:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2018-12-13 15:39:49 -08:00
|
|
|
|
2019-06-11 11:08:49 -07:00
|
|
|
if (is_scalar) {
|
|
|
|
|
if (op[idx].abs)
|
|
|
|
|
f[first_comp] = fabs(f[first_comp]);
|
|
|
|
|
|
|
|
|
|
if (op[idx].negate)
|
|
|
|
|
f[first_comp] = -f[first_comp];
|
|
|
|
|
|
|
|
|
|
op[idx] = src_reg(brw_imm_f(f[first_comp]));
|
|
|
|
|
assert(op[idx].type == old_type);
|
|
|
|
|
} else {
|
|
|
|
|
uint8_t vf_values[4] = { 0, 0, 0, 0 };
|
2018-12-13 15:39:49 -08:00
|
|
|
|
2020-02-04 14:58:17 +02:00
|
|
|
for (unsigned i = 0; i < ARRAY_SIZE(vf_values); i++) {
|
|
|
|
|
|
2019-06-11 11:08:49 -07:00
|
|
|
if (op[idx].abs)
|
|
|
|
|
f[i] = fabs(f[i]);
|
2018-12-13 15:39:49 -08:00
|
|
|
|
2019-06-11 11:08:49 -07:00
|
|
|
if (op[idx].negate)
|
|
|
|
|
f[i] = -f[i];
|
|
|
|
|
|
|
|
|
|
const int vf = brw_float_to_vf(f[i]);
|
|
|
|
|
if (vf == -1)
|
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
|
|
vf_values[i] = vf;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
op[idx] = src_reg(brw_imm_vf4(vf_values[0], vf_values[1],
|
|
|
|
|
vf_values[2], vf_values[3]));
|
|
|
|
|
}
|
2018-12-13 15:39:49 -08:00
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
default:
|
|
|
|
|
unreachable("Non-32bit type.");
|
|
|
|
|
}
|
2019-06-26 13:36:17 -07:00
|
|
|
|
2019-06-11 12:06:52 -07:00
|
|
|
/* If the instruction has more than one source, the instruction format only
|
|
|
|
|
* allows source 1 to be an immediate value. If the immediate value was
|
|
|
|
|
* source 0, then the sources must be exchanged.
|
2019-06-26 13:36:17 -07:00
|
|
|
*/
|
2019-06-11 12:06:52 -07:00
|
|
|
if (idx == 0 && instr->op != nir_op_mov) {
|
2019-06-26 13:36:17 -07:00
|
|
|
src_reg tmp = op[0];
|
|
|
|
|
op[0] = op[1];
|
|
|
|
|
op[1] = tmp;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return idx;
|
2018-12-13 15:39:49 -08:00
|
|
|
}
|
|
|
|
|
|
2019-06-06 11:12:14 -07:00
|
|
|
void
|
2019-06-06 11:21:15 -07:00
|
|
|
vec4_visitor::fix_float_operands(src_reg op[3], nir_alu_instr *instr)
|
2019-06-06 11:12:14 -07:00
|
|
|
{
|
|
|
|
|
bool fixed[3] = { false, false, false };
|
|
|
|
|
|
2019-06-06 11:21:15 -07:00
|
|
|
for (unsigned i = 0; i < 2; i++) {
|
|
|
|
|
if (!nir_src_is_const(instr->src[i].src))
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
for (unsigned j = i + 1; j < 3; j++) {
|
|
|
|
|
if (fixed[j])
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
if (!nir_src_is_const(instr->src[j].src))
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
if (nir_alu_srcs_equal(instr, instr, i, j)) {
|
|
|
|
|
if (!fixed[i])
|
|
|
|
|
op[i] = fix_3src_operand(op[i]);
|
|
|
|
|
|
|
|
|
|
op[j] = op[i];
|
|
|
|
|
|
|
|
|
|
fixed[i] = true;
|
|
|
|
|
fixed[j] = true;
|
|
|
|
|
} else if (nir_alu_srcs_negative_equal(instr, instr, i, j)) {
|
|
|
|
|
if (!fixed[i])
|
|
|
|
|
op[i] = fix_3src_operand(op[i]);
|
|
|
|
|
|
|
|
|
|
op[j] = op[i];
|
|
|
|
|
op[j].negate = !op[j].negate;
|
|
|
|
|
|
|
|
|
|
fixed[i] = true;
|
|
|
|
|
fixed[j] = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-06-06 11:12:14 -07:00
|
|
|
for (unsigned i = 0; i < 3; i++) {
|
|
|
|
|
if (!fixed[i])
|
|
|
|
|
op[i] = fix_3src_operand(op[i]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-12-16 14:43:53 -08:00
|
|
|
static bool
|
|
|
|
|
const_src_fits_in_16_bits(const nir_src &src, brw_reg_type type)
|
|
|
|
|
{
|
|
|
|
|
assert(nir_src_is_const(src));
|
2021-08-18 14:04:45 -07:00
|
|
|
if (brw_reg_type_is_unsigned_integer(type)) {
|
2019-12-16 14:43:53 -08:00
|
|
|
return nir_src_comp_as_uint(src, 0) <= UINT16_MAX;
|
|
|
|
|
} else {
|
|
|
|
|
const int64_t c = nir_src_comp_as_int(src, 0);
|
|
|
|
|
return c <= INT16_MAX && c >= INT16_MIN;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-16 12:08:09 +02:00
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_alu(nir_alu_instr *instr)
|
|
|
|
|
{
|
2015-06-16 22:52:29 +02:00
|
|
|
vec4_instruction *inst;
|
|
|
|
|
|
2016-05-25 09:27:49 +02:00
|
|
|
nir_alu_type dst_type = (nir_alu_type) (nir_op_infos[instr->op].output_type |
|
|
|
|
|
nir_dest_bit_size(instr->dest.dest));
|
|
|
|
|
dst_reg dst = get_nir_dest(instr->dest.dest, dst_type);
|
2015-06-16 22:30:16 +02:00
|
|
|
dst.writemask = instr->dest.write_mask;
|
|
|
|
|
|
intel/compiler: Drop nir_lower_to_source_mods() and related handling.
I think we're unanimous in wanting to drop nir_lower_to_source_mods.
It's a bit of complexity to handle in the backend, but perhaps more
importantly, would be even more complexity to handle in nir_search.
And, it turns out that since we made other compiler improvements in the
last few years, they no longer appear to buy us anything of value.
Summarizing the results from shader-db from this patch:
- Icelake (scalar mode)
Instruction counts:
- 411 helped, 598 hurt (out of 139,470 shaders)
- 99.2% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.78 instructions.
- total instructions in shared programs: 17214951 -> 17215206 (<.01%)
- instructions in affected programs: 1143879 -> 1144134 (0.02%)
Cycles:
- 1042 helped, 1357 hurt
- total cycles in shared programs: 365613294 -> 365882263 (0.07%)
- cycles in affected programs: 138155497 -> 138424466 (0.19%)
- Haswell (both scalar and vector modes)
Instruction counts:
- 73 helped, 1680 hurt (out of 139,470 shaders)
- 98.7% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.9 instructions.
- total instructions in shared programs: 14199527 -> 14202262 (0.02%)
- instructions in affected programs: 446499 -> 449234 (0.61%)
Cycles:
- 5253 helped, 5559 hurt
- total cycles in shared programs: 359996545 -> 360038731 (0.01%)
- cycles in affected programs: 155897127 -> 155939313 (0.03%)
Given that ~99% of shader-db remains unaffected, and the affected
programs are hurt by about 1-2 instructions - which are all cheap
ALU instructions - this is unlikely to be measurable in terms of
any real performance impact that would affect users.
So, drop them and simplify the backend, and hopefully enable other
future simplifications in NIR.
Reviewed-by: Eric Anholt <eric@anholt.net> [v1]
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4616>
2020-04-18 01:20:42 -07:00
|
|
|
assert(!instr->dest.saturate);
|
|
|
|
|
|
2015-06-16 22:30:16 +02:00
|
|
|
src_reg op[4];
|
|
|
|
|
for (unsigned i = 0; i < nir_op_infos[instr->op].num_inputs; i++) {
|
intel/compiler: Drop nir_lower_to_source_mods() and related handling.
I think we're unanimous in wanting to drop nir_lower_to_source_mods.
It's a bit of complexity to handle in the backend, but perhaps more
importantly, would be even more complexity to handle in nir_search.
And, it turns out that since we made other compiler improvements in the
last few years, they no longer appear to buy us anything of value.
Summarizing the results from shader-db from this patch:
- Icelake (scalar mode)
Instruction counts:
- 411 helped, 598 hurt (out of 139,470 shaders)
- 99.2% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.78 instructions.
- total instructions in shared programs: 17214951 -> 17215206 (<.01%)
- instructions in affected programs: 1143879 -> 1144134 (0.02%)
Cycles:
- 1042 helped, 1357 hurt
- total cycles in shared programs: 365613294 -> 365882263 (0.07%)
- cycles in affected programs: 138155497 -> 138424466 (0.19%)
- Haswell (both scalar and vector modes)
Instruction counts:
- 73 helped, 1680 hurt (out of 139,470 shaders)
- 98.7% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.9 instructions.
- total instructions in shared programs: 14199527 -> 14202262 (0.02%)
- instructions in affected programs: 446499 -> 449234 (0.61%)
Cycles:
- 5253 helped, 5559 hurt
- total cycles in shared programs: 359996545 -> 360038731 (0.01%)
- cycles in affected programs: 155897127 -> 155939313 (0.03%)
Given that ~99% of shader-db remains unaffected, and the affected
programs are hurt by about 1-2 instructions - which are all cheap
ALU instructions - this is unlikely to be measurable in terms of
any real performance impact that would affect users.
So, drop them and simplify the backend, and hopefully enable other
future simplifications in NIR.
Reviewed-by: Eric Anholt <eric@anholt.net> [v1]
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4616>
2020-04-18 01:20:42 -07:00
|
|
|
/* We don't lower to source modifiers, so they shouldn't exist. */
|
|
|
|
|
assert(!instr->src[i].abs);
|
|
|
|
|
assert(!instr->src[i].negate);
|
|
|
|
|
|
2016-05-25 09:27:49 +02:00
|
|
|
nir_alu_type src_type = (nir_alu_type)
|
|
|
|
|
(nir_op_infos[instr->op].input_types[i] |
|
|
|
|
|
nir_src_bit_size(instr->src[i].src));
|
|
|
|
|
op[i] = get_nir_src(instr->src[i].src, src_type, 4);
|
2015-06-16 22:30:16 +02:00
|
|
|
op[i].swizzle = brw_swizzle_for_nir_swizzle(instr->src[i].swizzle);
|
|
|
|
|
}
|
2015-06-16 22:52:29 +02:00
|
|
|
|
2021-01-22 14:54:02 -08:00
|
|
|
#ifndef NDEBUG
|
|
|
|
|
/* On Gen7 and earlier, no functionality is exposed that should allow 8-bit
|
|
|
|
|
* integer types to ever exist.
|
|
|
|
|
*/
|
|
|
|
|
for (unsigned i = 0; i < nir_op_infos[instr->op].num_inputs; i++)
|
|
|
|
|
assert(type_sz(op[i].type) > 1);
|
|
|
|
|
#endif
|
|
|
|
|
|
2015-06-16 22:52:29 +02:00
|
|
|
switch (instr->op) {
|
2019-05-06 11:45:46 -05:00
|
|
|
case nir_op_mov:
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, &op[0], true);
|
2015-06-16 22:52:29 +02:00
|
|
|
inst = emit(MOV(dst, op[0]));
|
|
|
|
|
break;
|
|
|
|
|
|
2015-06-16 22:58:15 +02:00
|
|
|
case nir_op_vec2:
|
|
|
|
|
case nir_op_vec3:
|
|
|
|
|
case nir_op_vec4:
|
|
|
|
|
unreachable("not reached: should be handled by lower_vec_to_movs()");
|
|
|
|
|
|
2017-03-07 19:54:37 -08:00
|
|
|
case nir_op_i2f32:
|
|
|
|
|
case nir_op_u2f32:
|
2015-06-16 23:04:32 +02:00
|
|
|
inst = emit(MOV(dst, op[0]));
|
|
|
|
|
break;
|
|
|
|
|
|
2017-03-07 19:54:37 -08:00
|
|
|
case nir_op_f2f32:
|
|
|
|
|
case nir_op_f2i32:
|
|
|
|
|
case nir_op_f2u32:
|
|
|
|
|
if (nir_src_bit_size(instr->src[0].src) == 64)
|
intel/compiler: Drop nir_lower_to_source_mods() and related handling.
I think we're unanimous in wanting to drop nir_lower_to_source_mods.
It's a bit of complexity to handle in the backend, but perhaps more
importantly, would be even more complexity to handle in nir_search.
And, it turns out that since we made other compiler improvements in the
last few years, they no longer appear to buy us anything of value.
Summarizing the results from shader-db from this patch:
- Icelake (scalar mode)
Instruction counts:
- 411 helped, 598 hurt (out of 139,470 shaders)
- 99.2% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.78 instructions.
- total instructions in shared programs: 17214951 -> 17215206 (<.01%)
- instructions in affected programs: 1143879 -> 1144134 (0.02%)
Cycles:
- 1042 helped, 1357 hurt
- total cycles in shared programs: 365613294 -> 365882263 (0.07%)
- cycles in affected programs: 138155497 -> 138424466 (0.19%)
- Haswell (both scalar and vector modes)
Instruction counts:
- 73 helped, 1680 hurt (out of 139,470 shaders)
- 98.7% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.9 instructions.
- total instructions in shared programs: 14199527 -> 14202262 (0.02%)
- instructions in affected programs: 446499 -> 449234 (0.61%)
Cycles:
- 5253 helped, 5559 hurt
- total cycles in shared programs: 359996545 -> 360038731 (0.01%)
- cycles in affected programs: 155897127 -> 155939313 (0.03%)
Given that ~99% of shader-db remains unaffected, and the affected
programs are hurt by about 1-2 instructions - which are all cheap
ALU instructions - this is unlikely to be measurable in terms of
any real performance impact that would affect users.
So, drop them and simplify the backend, and hopefully enable other
future simplifications in NIR.
Reviewed-by: Eric Anholt <eric@anholt.net> [v1]
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4616>
2020-04-18 01:20:42 -07:00
|
|
|
emit_conversion_from_double(dst, op[0]);
|
2017-03-07 19:54:37 -08:00
|
|
|
else
|
|
|
|
|
inst = emit(MOV(dst, op[0]));
|
2016-02-17 11:12:19 +01:00
|
|
|
break;
|
|
|
|
|
|
2017-03-07 19:54:37 -08:00
|
|
|
case nir_op_f2f64:
|
|
|
|
|
case nir_op_i2f64:
|
|
|
|
|
case nir_op_u2f64:
|
intel/compiler: Drop nir_lower_to_source_mods() and related handling.
I think we're unanimous in wanting to drop nir_lower_to_source_mods.
It's a bit of complexity to handle in the backend, but perhaps more
importantly, would be even more complexity to handle in nir_search.
And, it turns out that since we made other compiler improvements in the
last few years, they no longer appear to buy us anything of value.
Summarizing the results from shader-db from this patch:
- Icelake (scalar mode)
Instruction counts:
- 411 helped, 598 hurt (out of 139,470 shaders)
- 99.2% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.78 instructions.
- total instructions in shared programs: 17214951 -> 17215206 (<.01%)
- instructions in affected programs: 1143879 -> 1144134 (0.02%)
Cycles:
- 1042 helped, 1357 hurt
- total cycles in shared programs: 365613294 -> 365882263 (0.07%)
- cycles in affected programs: 138155497 -> 138424466 (0.19%)
- Haswell (both scalar and vector modes)
Instruction counts:
- 73 helped, 1680 hurt (out of 139,470 shaders)
- 98.7% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.9 instructions.
- total instructions in shared programs: 14199527 -> 14202262 (0.02%)
- instructions in affected programs: 446499 -> 449234 (0.61%)
Cycles:
- 5253 helped, 5559 hurt
- total cycles in shared programs: 359996545 -> 360038731 (0.01%)
- cycles in affected programs: 155897127 -> 155939313 (0.03%)
Given that ~99% of shader-db remains unaffected, and the affected
programs are hurt by about 1-2 instructions - which are all cheap
ALU instructions - this is unlikely to be measurable in terms of
any real performance impact that would affect users.
So, drop them and simplify the backend, and hopefully enable other
future simplifications in NIR.
Reviewed-by: Eric Anholt <eric@anholt.net> [v1]
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4616>
2020-04-18 01:20:42 -07:00
|
|
|
emit_conversion_to_double(dst, op[0]);
|
2016-02-17 11:12:19 +01:00
|
|
|
break;
|
|
|
|
|
|
2019-05-06 11:16:25 -05:00
|
|
|
case nir_op_fsat:
|
|
|
|
|
inst = emit(MOV(dst, op[0]));
|
|
|
|
|
inst->saturate = true;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_fneg:
|
|
|
|
|
case nir_op_ineg:
|
|
|
|
|
op[0].negate = true;
|
|
|
|
|
inst = emit(MOV(dst, op[0]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_fabs:
|
|
|
|
|
case nir_op_iabs:
|
|
|
|
|
op[0].negate = false;
|
|
|
|
|
op[0].abs = true;
|
|
|
|
|
inst = emit(MOV(dst, op[0]));
|
|
|
|
|
break;
|
|
|
|
|
|
2015-06-16 23:48:46 +02:00
|
|
|
case nir_op_iadd:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2021-04-10 17:11:58 +02:00
|
|
|
FALLTHROUGH;
|
2015-11-10 10:20:25 +01:00
|
|
|
case nir_op_fadd:
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, true);
|
2015-06-16 23:48:46 +02:00
|
|
|
inst = emit(ADD(dst, op[0], op[1]));
|
|
|
|
|
break;
|
2018-10-08 17:33:10 -05:00
|
|
|
|
|
|
|
|
case nir_op_uadd_sat:
|
|
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
|
|
|
|
inst = emit(ADD(dst, op[0], op[1]));
|
|
|
|
|
inst->saturate = true;
|
|
|
|
|
break;
|
2015-06-16 23:48:46 +02:00
|
|
|
|
2015-06-16 23:50:46 +02:00
|
|
|
case nir_op_fmul:
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, true);
|
2015-06-16 23:50:46 +02:00
|
|
|
inst = emit(MUL(dst, op[0], op[1]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_imul: {
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2020-09-22 13:09:56 -07:00
|
|
|
|
|
|
|
|
/* For integer multiplication, the MUL uses the low 16 bits of one of
|
|
|
|
|
* the operands (src0 through SNB, src1 on IVB and later). The MACH
|
|
|
|
|
* accumulates in the contribution of the upper 16 bits of that
|
|
|
|
|
* operand. If we can determine that one of the args is in the low
|
|
|
|
|
* 16 bits, though, we can just emit a single MUL.
|
|
|
|
|
*/
|
|
|
|
|
if (nir_src_is_const(instr->src[0].src) &&
|
|
|
|
|
nir_alu_instr_src_read_mask(instr, 0) == 1 &&
|
|
|
|
|
const_src_fits_in_16_bits(instr->src[0].src, op[0].type)) {
|
2021-03-29 14:41:58 -07:00
|
|
|
if (devinfo->ver < 7)
|
2020-09-22 13:09:56 -07:00
|
|
|
emit(MUL(dst, op[0], op[1]));
|
|
|
|
|
else
|
|
|
|
|
emit(MUL(dst, op[1], op[0]));
|
|
|
|
|
} else if (nir_src_is_const(instr->src[1].src) &&
|
|
|
|
|
nir_alu_instr_src_read_mask(instr, 1) == 1 &&
|
|
|
|
|
const_src_fits_in_16_bits(instr->src[1].src, op[1].type)) {
|
2021-03-29 14:41:58 -07:00
|
|
|
if (devinfo->ver < 7)
|
2020-09-22 13:09:56 -07:00
|
|
|
emit(MUL(dst, op[1], op[0]));
|
|
|
|
|
else
|
|
|
|
|
emit(MUL(dst, op[0], op[1]));
|
2015-06-16 23:50:46 +02:00
|
|
|
} else {
|
2020-09-22 13:09:56 -07:00
|
|
|
struct brw_reg acc = retype(brw_acc_reg(8), dst.type);
|
|
|
|
|
|
|
|
|
|
emit(MUL(acc, op[0], op[1]));
|
|
|
|
|
emit(MACH(dst_null_d(), op[0], op[1]));
|
|
|
|
|
emit(MOV(dst, src_reg(acc)));
|
2015-06-16 23:50:46 +02:00
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
case nir_op_imul_high:
|
|
|
|
|
case nir_op_umul_high: {
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-16 23:50:46 +02:00
|
|
|
struct brw_reg acc = retype(brw_acc_reg(8), dst.type);
|
|
|
|
|
|
2020-09-22 13:09:56 -07:00
|
|
|
emit(MUL(acc, op[0], op[1]));
|
2015-06-16 23:50:46 +02:00
|
|
|
emit(MACH(dst, op[0], op[1]));
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-17 00:10:18 +02:00
|
|
|
case nir_op_frcp:
|
|
|
|
|
inst = emit_math(SHADER_OPCODE_RCP, dst, op[0]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_fexp2:
|
|
|
|
|
inst = emit_math(SHADER_OPCODE_EXP2, dst, op[0]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_flog2:
|
|
|
|
|
inst = emit_math(SHADER_OPCODE_LOG2, dst, op[0]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_fsin:
|
2016-04-07 15:04:35 -07:00
|
|
|
inst = emit_math(SHADER_OPCODE_SIN, dst, op[0]);
|
2015-06-17 00:10:18 +02:00
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_fcos:
|
2016-04-07 15:04:35 -07:00
|
|
|
inst = emit_math(SHADER_OPCODE_COS, dst, op[0]);
|
2015-06-17 00:10:18 +02:00
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_idiv:
|
|
|
|
|
case nir_op_udiv:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 00:10:18 +02:00
|
|
|
emit_math(SHADER_OPCODE_INT_QUOTIENT, dst, op[0], op[1]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_umod:
|
2016-03-25 11:17:53 -07:00
|
|
|
case nir_op_irem:
|
|
|
|
|
/* According to the sign table for INT DIV in the Ivy Bridge PRM, it
|
|
|
|
|
* appears that our hardware just does the right thing for signed
|
|
|
|
|
* remainder.
|
|
|
|
|
*/
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 00:10:18 +02:00
|
|
|
emit_math(SHADER_OPCODE_INT_REMAINDER, dst, op[0], op[1]);
|
|
|
|
|
break;
|
|
|
|
|
|
2016-03-25 11:17:53 -07:00
|
|
|
case nir_op_imod: {
|
|
|
|
|
/* Get a regular C-style remainder. If a % b == 0, set the predicate. */
|
|
|
|
|
inst = emit_math(SHADER_OPCODE_INT_REMAINDER, dst, op[0], op[1]);
|
|
|
|
|
|
|
|
|
|
/* Math instructions don't support conditional mod */
|
|
|
|
|
inst = emit(MOV(dst_null_d(), src_reg(dst)));
|
|
|
|
|
inst->conditional_mod = BRW_CONDITIONAL_NZ;
|
|
|
|
|
|
|
|
|
|
/* Now, we need to determine if signs of the sources are different.
|
|
|
|
|
* When we XOR the sources, the top bit is 0 if they are the same and 1
|
|
|
|
|
* if they are different. We can then use a conditional modifier to
|
|
|
|
|
* turn that into a predicate. This leads us to an XOR.l instruction.
|
|
|
|
|
*
|
|
|
|
|
* Technically, according to the PRM, you're not allowed to use .l on a
|
2022-06-22 18:31:08 +02:00
|
|
|
* XOR instruction. However, empirical experiments and Curro's reading
|
2016-03-25 11:17:53 -07:00
|
|
|
* of the simulator source both indicate that it's safe.
|
|
|
|
|
*/
|
|
|
|
|
src_reg tmp = src_reg(this, glsl_type::ivec4_type);
|
|
|
|
|
inst = emit(XOR(dst_reg(tmp), op[0], op[1]));
|
|
|
|
|
inst->predicate = BRW_PREDICATE_NORMAL;
|
|
|
|
|
inst->conditional_mod = BRW_CONDITIONAL_L;
|
|
|
|
|
|
|
|
|
|
/* If the result of the initial remainder operation is non-zero and the
|
|
|
|
|
* two sources have different signs, add in a copy of op[1] to get the
|
|
|
|
|
* final integer modulus value.
|
|
|
|
|
*/
|
|
|
|
|
inst = emit(ADD(dst, src_reg(dst), op[1]));
|
|
|
|
|
inst->predicate = BRW_PREDICATE_NORMAL;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-17 00:10:18 +02:00
|
|
|
case nir_op_ldexp:
|
|
|
|
|
unreachable("not reached: should be handled by ldexp_to_arith()");
|
|
|
|
|
|
|
|
|
|
case nir_op_fsqrt:
|
|
|
|
|
inst = emit_math(SHADER_OPCODE_SQRT, dst, op[0]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_frsq:
|
|
|
|
|
inst = emit_math(SHADER_OPCODE_RSQ, dst, op[0]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_fpow:
|
|
|
|
|
inst = emit_math(SHADER_OPCODE_POW, dst, op[0], op[1]);
|
|
|
|
|
break;
|
|
|
|
|
|
2015-06-17 00:22:14 +02:00
|
|
|
case nir_op_uadd_carry: {
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 00:22:14 +02:00
|
|
|
struct brw_reg acc = retype(brw_acc_reg(8), BRW_REGISTER_TYPE_UD);
|
|
|
|
|
|
|
|
|
|
emit(ADDC(dst_null_ud(), op[0], op[1]));
|
|
|
|
|
emit(MOV(dst, src_reg(acc)));
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
case nir_op_usub_borrow: {
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 00:22:14 +02:00
|
|
|
struct brw_reg acc = retype(brw_acc_reg(8), BRW_REGISTER_TYPE_UD);
|
|
|
|
|
|
|
|
|
|
emit(SUBB(dst_null_ud(), op[0], op[1]));
|
|
|
|
|
emit(MOV(dst, src_reg(acc)));
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-17 00:25:02 +02:00
|
|
|
case nir_op_ftrunc:
|
|
|
|
|
inst = emit(RNDZ(dst, op[0]));
|
2021-03-29 14:41:58 -07:00
|
|
|
if (devinfo->ver < 6) {
|
2020-01-16 11:17:14 -08:00
|
|
|
inst->conditional_mod = BRW_CONDITIONAL_R;
|
|
|
|
|
inst = emit(ADD(dst, src_reg(dst), brw_imm_f(1.0f)));
|
|
|
|
|
inst->predicate = BRW_PREDICATE_NORMAL;
|
|
|
|
|
inst = emit(MOV(dst, src_reg(dst))); /* for potential saturation */
|
|
|
|
|
}
|
2015-06-17 00:25:02 +02:00
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_fceil: {
|
|
|
|
|
src_reg tmp = src_reg(this, glsl_type::float_type);
|
|
|
|
|
tmp.swizzle =
|
|
|
|
|
brw_swizzle_for_size(instr->src[0].src.is_ssa ?
|
|
|
|
|
instr->src[0].src.ssa->num_components :
|
|
|
|
|
instr->src[0].src.reg.reg->num_components);
|
|
|
|
|
|
|
|
|
|
op[0].negate = !op[0].negate;
|
|
|
|
|
emit(RNDD(dst_reg(tmp), op[0]));
|
|
|
|
|
tmp.negate = true;
|
|
|
|
|
inst = emit(MOV(dst, tmp));
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
case nir_op_ffloor:
|
|
|
|
|
inst = emit(RNDD(dst, op[0]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_ffract:
|
|
|
|
|
inst = emit(FRC(dst, op[0]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_fround_even:
|
|
|
|
|
inst = emit(RNDE(dst, op[0]));
|
2021-03-29 14:41:58 -07:00
|
|
|
if (devinfo->ver < 6) {
|
2020-01-16 11:17:14 -08:00
|
|
|
inst->conditional_mod = BRW_CONDITIONAL_R;
|
|
|
|
|
inst = emit(ADD(dst, src_reg(dst), brw_imm_f(1.0f)));
|
|
|
|
|
inst->predicate = BRW_PREDICATE_NORMAL;
|
|
|
|
|
inst = emit(MOV(dst, src_reg(dst))); /* for potential saturation */
|
|
|
|
|
}
|
2015-06-17 00:25:02 +02:00
|
|
|
break;
|
|
|
|
|
|
2016-03-25 13:57:15 -07:00
|
|
|
case nir_op_fquantize2f16: {
|
|
|
|
|
/* See also vec4_visitor::emit_pack_half_2x16() */
|
|
|
|
|
src_reg tmp16 = src_reg(this, glsl_type::uvec4_type);
|
|
|
|
|
src_reg tmp32 = src_reg(this, glsl_type::vec4_type);
|
|
|
|
|
src_reg zero = src_reg(this, glsl_type::vec4_type);
|
|
|
|
|
|
|
|
|
|
/* Check for denormal */
|
|
|
|
|
src_reg abs_src0 = op[0];
|
|
|
|
|
abs_src0.abs = true;
|
|
|
|
|
emit(CMP(dst_null_f(), abs_src0, brw_imm_f(ldexpf(1.0, -14)),
|
|
|
|
|
BRW_CONDITIONAL_L));
|
|
|
|
|
/* Get the appropriately signed zero */
|
|
|
|
|
emit(AND(retype(dst_reg(zero), BRW_REGISTER_TYPE_UD),
|
|
|
|
|
retype(op[0], BRW_REGISTER_TYPE_UD),
|
|
|
|
|
brw_imm_ud(0x80000000)));
|
|
|
|
|
/* Do the actual F32 -> F16 -> F32 conversion */
|
|
|
|
|
emit(F32TO16(dst_reg(tmp16), op[0]));
|
|
|
|
|
emit(F16TO32(dst_reg(tmp32), tmp16));
|
|
|
|
|
/* Select that or zero based on normal status */
|
|
|
|
|
inst = emit(BRW_OPCODE_SEL, dst, zero, tmp32);
|
|
|
|
|
inst->predicate = BRW_PREDICATE_NORMAL;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-17 00:34:57 +02:00
|
|
|
case nir_op_imin:
|
|
|
|
|
case nir_op_umin:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2021-04-10 17:11:58 +02:00
|
|
|
FALLTHROUGH;
|
2015-11-10 10:20:25 +01:00
|
|
|
case nir_op_fmin:
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, true);
|
2015-06-17 00:34:57 +02:00
|
|
|
inst = emit_minmax(BRW_CONDITIONAL_L, dst, op[0], op[1]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_imax:
|
|
|
|
|
case nir_op_umax:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2021-04-10 17:11:58 +02:00
|
|
|
FALLTHROUGH;
|
2015-11-10 10:20:25 +01:00
|
|
|
case nir_op_fmax:
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, true);
|
2015-06-17 00:34:57 +02:00
|
|
|
inst = emit_minmax(BRW_CONDITIONAL_GE, dst, op[0], op[1]);
|
|
|
|
|
break;
|
|
|
|
|
|
2015-04-14 12:04:24 +02:00
|
|
|
case nir_op_fddx:
|
|
|
|
|
case nir_op_fddx_coarse:
|
|
|
|
|
case nir_op_fddx_fine:
|
|
|
|
|
case nir_op_fddy:
|
|
|
|
|
case nir_op_fddy_coarse:
|
|
|
|
|
case nir_op_fddy_fine:
|
|
|
|
|
unreachable("derivatives are not valid in vertex shaders");
|
|
|
|
|
|
2018-10-18 11:44:38 -05:00
|
|
|
case nir_op_ilt32:
|
|
|
|
|
case nir_op_ult32:
|
|
|
|
|
case nir_op_ige32:
|
|
|
|
|
case nir_op_uge32:
|
|
|
|
|
case nir_op_ieq32:
|
|
|
|
|
case nir_op_ine32:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2021-04-10 17:11:58 +02:00
|
|
|
FALLTHROUGH;
|
2018-10-18 11:44:38 -05:00
|
|
|
case nir_op_flt32:
|
|
|
|
|
case nir_op_fge32:
|
|
|
|
|
case nir_op_feq32:
|
2020-08-18 19:51:57 +02:00
|
|
|
case nir_op_fneu32: {
|
2015-08-13 15:34:24 -07:00
|
|
|
enum brw_conditional_mod conditional_mod =
|
2019-08-02 15:19:16 -05:00
|
|
|
brw_cmod_for_nir_comparison(instr->op);
|
2015-08-13 15:34:24 -07:00
|
|
|
|
|
|
|
|
if (nir_src_bit_size(instr->src[0].src) < 64) {
|
2019-06-26 13:36:17 -07:00
|
|
|
/* If the order of the sources is changed due to an immediate value,
|
|
|
|
|
* then the condition must also be changed.
|
|
|
|
|
*/
|
2020-09-22 13:09:56 -07:00
|
|
|
if (try_immediate_source(instr, op, true) == 0)
|
2019-06-26 13:36:17 -07:00
|
|
|
conditional_mod = brw_swap_cmod(conditional_mod);
|
|
|
|
|
|
2015-08-13 15:34:24 -07:00
|
|
|
emit(CMP(dst, op[0], op[1], conditional_mod));
|
|
|
|
|
} else {
|
|
|
|
|
/* Produce a 32-bit boolean result from the DF comparison by selecting
|
|
|
|
|
* only the low 32-bit in each DF produced. Do this in a temporary
|
|
|
|
|
* so we can then move from there to the result using align16 again
|
|
|
|
|
* to honor the original writemask.
|
|
|
|
|
*/
|
|
|
|
|
dst_reg temp = dst_reg(this, glsl_type::dvec4_type);
|
|
|
|
|
emit(CMP(temp, op[0], op[1], conditional_mod));
|
|
|
|
|
dst_reg result = dst_reg(this, glsl_type::bvec4_type);
|
|
|
|
|
emit(VEC4_OPCODE_PICK_LOW_32BIT, result, src_reg(temp));
|
|
|
|
|
emit(MOV(dst, src_reg(result)));
|
|
|
|
|
}
|
2015-06-17 00:49:42 +02:00
|
|
|
break;
|
2015-08-13 15:34:24 -07:00
|
|
|
}
|
2015-06-17 00:49:42 +02:00
|
|
|
|
2018-10-18 11:44:38 -05:00
|
|
|
case nir_op_b32all_iequal2:
|
|
|
|
|
case nir_op_b32all_iequal3:
|
|
|
|
|
case nir_op_b32all_iequal4:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2021-04-10 17:11:58 +02:00
|
|
|
FALLTHROUGH;
|
2018-10-18 11:44:38 -05:00
|
|
|
case nir_op_b32all_fequal2:
|
|
|
|
|
case nir_op_b32all_fequal3:
|
|
|
|
|
case nir_op_b32all_fequal4: {
|
2015-10-25 20:49:08 -07:00
|
|
|
unsigned swiz =
|
|
|
|
|
brw_swizzle_for_size(nir_op_infos[instr->op].input_sizes[0]);
|
2015-06-17 00:55:24 +02:00
|
|
|
|
2015-10-25 20:49:08 -07:00
|
|
|
emit(CMP(dst_null_d(), swizzle(op[0], swiz), swizzle(op[1], swiz),
|
2019-08-02 15:19:16 -05:00
|
|
|
brw_cmod_for_nir_comparison(instr->op)));
|
2015-11-02 12:12:44 -08:00
|
|
|
emit(MOV(dst, brw_imm_d(0)));
|
|
|
|
|
inst = emit(MOV(dst, brw_imm_d(~0)));
|
2015-06-17 00:55:24 +02:00
|
|
|
inst->predicate = BRW_PREDICATE_ALIGN16_ALL4H;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2018-10-18 11:44:38 -05:00
|
|
|
case nir_op_b32any_inequal2:
|
|
|
|
|
case nir_op_b32any_inequal3:
|
|
|
|
|
case nir_op_b32any_inequal4:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2021-04-10 17:11:58 +02:00
|
|
|
FALLTHROUGH;
|
2018-10-18 11:44:38 -05:00
|
|
|
case nir_op_b32any_fnequal2:
|
|
|
|
|
case nir_op_b32any_fnequal3:
|
|
|
|
|
case nir_op_b32any_fnequal4: {
|
2015-10-25 20:49:08 -07:00
|
|
|
unsigned swiz =
|
|
|
|
|
brw_swizzle_for_size(nir_op_infos[instr->op].input_sizes[0]);
|
2015-06-17 09:01:28 +02:00
|
|
|
|
2015-10-25 20:49:08 -07:00
|
|
|
emit(CMP(dst_null_d(), swizzle(op[0], swiz), swizzle(op[1], swiz),
|
2019-08-02 15:19:16 -05:00
|
|
|
brw_cmod_for_nir_comparison(instr->op)));
|
2015-06-17 09:01:28 +02:00
|
|
|
|
2015-11-02 12:12:44 -08:00
|
|
|
emit(MOV(dst, brw_imm_d(0)));
|
|
|
|
|
inst = emit(MOV(dst, brw_imm_d(~0)));
|
2015-06-17 09:01:28 +02:00
|
|
|
inst->predicate = BRW_PREDICATE_ALIGN16_ANY4H;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-17 09:07:20 +02:00
|
|
|
case nir_op_inot:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 09:07:20 +02:00
|
|
|
emit(NOT(dst, op[0]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_ixor:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, true);
|
2015-06-17 09:07:20 +02:00
|
|
|
emit(XOR(dst, op[0], op[1]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_ior:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, true);
|
2015-06-17 09:07:20 +02:00
|
|
|
emit(OR(dst, op[0], op[1]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_iand:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, true);
|
2015-06-17 09:07:20 +02:00
|
|
|
emit(AND(dst, op[0], op[1]));
|
|
|
|
|
break;
|
|
|
|
|
|
2018-11-07 13:43:40 -06:00
|
|
|
case nir_op_b2i32:
|
|
|
|
|
case nir_op_b2f32:
|
|
|
|
|
case nir_op_b2f64:
|
2018-10-10 22:04:17 -05:00
|
|
|
if (nir_dest_bit_size(instr->dest.dest) > 32) {
|
|
|
|
|
assert(dst.type == BRW_REGISTER_TYPE_DF);
|
intel/compiler: Drop nir_lower_to_source_mods() and related handling.
I think we're unanimous in wanting to drop nir_lower_to_source_mods.
It's a bit of complexity to handle in the backend, but perhaps more
importantly, would be even more complexity to handle in nir_search.
And, it turns out that since we made other compiler improvements in the
last few years, they no longer appear to buy us anything of value.
Summarizing the results from shader-db from this patch:
- Icelake (scalar mode)
Instruction counts:
- 411 helped, 598 hurt (out of 139,470 shaders)
- 99.2% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.78 instructions.
- total instructions in shared programs: 17214951 -> 17215206 (<.01%)
- instructions in affected programs: 1143879 -> 1144134 (0.02%)
Cycles:
- 1042 helped, 1357 hurt
- total cycles in shared programs: 365613294 -> 365882263 (0.07%)
- cycles in affected programs: 138155497 -> 138424466 (0.19%)
- Haswell (both scalar and vector modes)
Instruction counts:
- 73 helped, 1680 hurt (out of 139,470 shaders)
- 98.7% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.9 instructions.
- total instructions in shared programs: 14199527 -> 14202262 (0.02%)
- instructions in affected programs: 446499 -> 449234 (0.61%)
Cycles:
- 5253 helped, 5559 hurt
- total cycles in shared programs: 359996545 -> 360038731 (0.01%)
- cycles in affected programs: 155897127 -> 155939313 (0.03%)
Given that ~99% of shader-db remains unaffected, and the affected
programs are hurt by about 1-2 instructions - which are all cheap
ALU instructions - this is unlikely to be measurable in terms of
any real performance impact that would affect users.
So, drop them and simplify the backend, and hopefully enable other
future simplifications in NIR.
Reviewed-by: Eric Anholt <eric@anholt.net> [v1]
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4616>
2020-04-18 01:20:42 -07:00
|
|
|
emit_conversion_to_double(dst, negate(op[0]));
|
2018-10-10 22:04:17 -05:00
|
|
|
} else {
|
|
|
|
|
emit(MOV(dst, negate(op[0])));
|
|
|
|
|
}
|
2015-06-17 09:21:30 +02:00
|
|
|
break;
|
|
|
|
|
|
2018-11-07 13:43:40 -06:00
|
|
|
case nir_op_f2b32:
|
2017-03-07 19:54:37 -08:00
|
|
|
if (nir_src_bit_size(instr->src[0].src) == 64) {
|
|
|
|
|
/* We use a MOV with conditional_mod to check if the provided value is
|
|
|
|
|
* 0.0. We want this to flush denormalized numbers to zero, so we set a
|
|
|
|
|
* source modifier on the source operand to trigger this, as source
|
|
|
|
|
* modifiers don't affect the result of the testing against 0.0.
|
|
|
|
|
*/
|
|
|
|
|
src_reg value = op[0];
|
|
|
|
|
value.abs = true;
|
|
|
|
|
vec4_instruction *inst = emit(MOV(dst_null_df(), value));
|
|
|
|
|
inst->conditional_mod = BRW_CONDITIONAL_NZ;
|
|
|
|
|
|
|
|
|
|
src_reg one = src_reg(this, glsl_type::ivec4_type);
|
|
|
|
|
emit(MOV(dst_reg(one), brw_imm_d(~0)));
|
|
|
|
|
inst = emit(BRW_OPCODE_SEL, dst, one, brw_imm_d(0));
|
|
|
|
|
inst->predicate = BRW_PREDICATE_NORMAL;
|
|
|
|
|
} else {
|
|
|
|
|
emit(CMP(dst, op[0], brw_imm_f(0.0f), BRW_CONDITIONAL_NZ));
|
|
|
|
|
}
|
2016-02-17 13:08:47 +01:00
|
|
|
break;
|
|
|
|
|
|
2015-06-17 09:29:04 +02:00
|
|
|
case nir_op_unpack_half_2x16_split_x:
|
|
|
|
|
case nir_op_unpack_half_2x16_split_y:
|
|
|
|
|
case nir_op_pack_half_2x16_split:
|
|
|
|
|
unreachable("not reached: should not occur in vertex shader");
|
|
|
|
|
|
|
|
|
|
case nir_op_unpack_snorm_2x16:
|
|
|
|
|
case nir_op_unpack_unorm_2x16:
|
|
|
|
|
case nir_op_pack_snorm_2x16:
|
|
|
|
|
case nir_op_pack_unorm_2x16:
|
|
|
|
|
unreachable("not reached: should be handled by lower_packing_builtins");
|
|
|
|
|
|
2016-01-25 10:49:15 -08:00
|
|
|
case nir_op_pack_uvec4_to_uint:
|
|
|
|
|
unreachable("not reached");
|
|
|
|
|
|
|
|
|
|
case nir_op_pack_uvec2_to_uint: {
|
|
|
|
|
dst_reg tmp1 = dst_reg(this, glsl_type::uint_type);
|
|
|
|
|
tmp1.writemask = WRITEMASK_X;
|
|
|
|
|
op[0].swizzle = BRW_SWIZZLE_YYYY;
|
|
|
|
|
emit(SHL(tmp1, op[0], src_reg(brw_imm_ud(16u))));
|
|
|
|
|
|
|
|
|
|
dst_reg tmp2 = dst_reg(this, glsl_type::uint_type);
|
|
|
|
|
tmp2.writemask = WRITEMASK_X;
|
|
|
|
|
op[0].swizzle = BRW_SWIZZLE_XXXX;
|
|
|
|
|
emit(AND(tmp2, op[0], src_reg(brw_imm_ud(0xffffu))));
|
|
|
|
|
|
|
|
|
|
emit(OR(dst, src_reg(tmp1), src_reg(tmp2)));
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2017-02-14 22:15:16 -08:00
|
|
|
case nir_op_pack_64_2x32_split: {
|
2016-06-01 09:57:06 +02:00
|
|
|
dst_reg result = dst_reg(this, glsl_type::dvec4_type);
|
|
|
|
|
dst_reg tmp = dst_reg(this, glsl_type::uvec4_type);
|
|
|
|
|
emit(MOV(tmp, retype(op[0], BRW_REGISTER_TYPE_UD)));
|
|
|
|
|
emit(VEC4_OPCODE_SET_LOW_32BIT, result, src_reg(tmp));
|
|
|
|
|
emit(MOV(tmp, retype(op[1], BRW_REGISTER_TYPE_UD)));
|
|
|
|
|
emit(VEC4_OPCODE_SET_HIGH_32BIT, result, src_reg(tmp));
|
|
|
|
|
emit(MOV(dst, src_reg(result)));
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2017-02-14 22:15:16 -08:00
|
|
|
case nir_op_unpack_64_2x32_split_x:
|
|
|
|
|
case nir_op_unpack_64_2x32_split_y: {
|
|
|
|
|
enum opcode oper = (instr->op == nir_op_unpack_64_2x32_split_x) ?
|
2016-06-01 09:58:00 +02:00
|
|
|
VEC4_OPCODE_PICK_LOW_32BIT : VEC4_OPCODE_PICK_HIGH_32BIT;
|
|
|
|
|
dst_reg tmp = dst_reg(this, glsl_type::dvec4_type);
|
|
|
|
|
emit(MOV(tmp, op[0]));
|
|
|
|
|
dst_reg tmp2 = dst_reg(this, glsl_type::uvec4_type);
|
|
|
|
|
emit(oper, tmp2, src_reg(tmp));
|
|
|
|
|
emit(MOV(dst, src_reg(tmp2)));
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-17 09:29:04 +02:00
|
|
|
case nir_op_unpack_half_2x16:
|
|
|
|
|
/* As NIR does not guarantee that we have a correct swizzle outside the
|
|
|
|
|
* boundaries of a vector, and the implementation of emit_unpack_half_2x16
|
|
|
|
|
* uses the source operand in an operation with WRITEMASK_Y while our
|
|
|
|
|
* source operand has only size 1, it accessed incorrect data producing
|
|
|
|
|
* regressions in Piglit. We repeat the swizzle of the first component on the
|
|
|
|
|
* rest of components to avoid regressions. In the vec4_visitor IR code path
|
|
|
|
|
* this is not needed because the operand has already the correct swizzle.
|
|
|
|
|
*/
|
|
|
|
|
op[0].swizzle = brw_compose_swizzle(BRW_SWIZZLE_XXXX, op[0].swizzle);
|
|
|
|
|
emit_unpack_half_2x16(dst, op[0]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_pack_half_2x16:
|
|
|
|
|
emit_pack_half_2x16(dst, op[0]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_unpack_unorm_4x8:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 09:29:04 +02:00
|
|
|
emit_unpack_unorm_4x8(dst, op[0]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_pack_unorm_4x8:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 09:29:04 +02:00
|
|
|
emit_pack_unorm_4x8(dst, op[0]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_unpack_snorm_4x8:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 09:29:04 +02:00
|
|
|
emit_unpack_snorm_4x8(dst, op[0]);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_pack_snorm_4x8:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 09:29:04 +02:00
|
|
|
emit_pack_snorm_4x8(dst, op[0]);
|
|
|
|
|
break;
|
|
|
|
|
|
2015-06-17 09:44:25 +02:00
|
|
|
case nir_op_bitfield_reverse:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 09:44:25 +02:00
|
|
|
emit(BFREV(dst, op[0]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_bit_count:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 09:44:25 +02:00
|
|
|
emit(CBIT(dst, op[0]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_ufind_msb:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2016-06-21 15:14:03 -07:00
|
|
|
emit_find_msb_using_lzd(vec4_builder(this).at_end(), dst, op[0], false);
|
|
|
|
|
break;
|
|
|
|
|
|
2015-06-17 09:44:25 +02:00
|
|
|
case nir_op_ifind_msb: {
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2016-06-21 17:18:04 -07:00
|
|
|
vec4_builder bld = vec4_builder(this).at_end();
|
2015-10-26 11:35:57 -07:00
|
|
|
src_reg src(dst);
|
2015-06-17 09:44:25 +02:00
|
|
|
|
2021-03-29 14:41:58 -07:00
|
|
|
if (devinfo->ver < 7) {
|
2016-06-21 17:18:04 -07:00
|
|
|
emit_find_msb_using_lzd(bld, dst, op[0], true);
|
|
|
|
|
} else {
|
|
|
|
|
emit(FBH(retype(dst, BRW_REGISTER_TYPE_UD), op[0]));
|
|
|
|
|
|
|
|
|
|
/* FBH counts from the MSB side, while GLSL's findMSB() wants the
|
|
|
|
|
* count from the LSB side. If FBH didn't return an error
|
|
|
|
|
* (0xFFFFFFFF), then subtract the result from 31 to convert the MSB
|
|
|
|
|
* count into an LSB count.
|
|
|
|
|
*/
|
|
|
|
|
bld.CMP(dst_null_d(), src, brw_imm_d(-1), BRW_CONDITIONAL_NZ);
|
|
|
|
|
|
|
|
|
|
inst = bld.ADD(dst, src, brw_imm_d(31));
|
|
|
|
|
inst->predicate = BRW_PREDICATE_NORMAL;
|
|
|
|
|
inst->src[0].negate = true;
|
|
|
|
|
}
|
2015-06-17 09:44:25 +02:00
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2016-06-22 13:12:26 -07:00
|
|
|
case nir_op_find_lsb: {
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2016-06-22 13:12:26 -07:00
|
|
|
vec4_builder bld = vec4_builder(this).at_end();
|
|
|
|
|
|
2021-03-29 14:41:58 -07:00
|
|
|
if (devinfo->ver < 7) {
|
2016-06-22 13:12:26 -07:00
|
|
|
dst_reg temp = bld.vgrf(BRW_REGISTER_TYPE_D);
|
|
|
|
|
|
|
|
|
|
/* (x & -x) generates a value that consists of only the LSB of x.
|
|
|
|
|
* For all powers of 2, findMSB(y) == findLSB(y).
|
|
|
|
|
*/
|
|
|
|
|
src_reg src = src_reg(retype(op[0], BRW_REGISTER_TYPE_D));
|
|
|
|
|
src_reg negated_src = src;
|
|
|
|
|
|
|
|
|
|
/* One must be negated, and the other must be non-negated. It
|
|
|
|
|
* doesn't matter which is which.
|
|
|
|
|
*/
|
|
|
|
|
negated_src.negate = true;
|
|
|
|
|
src.negate = false;
|
|
|
|
|
|
|
|
|
|
bld.AND(temp, src, negated_src);
|
|
|
|
|
emit_find_msb_using_lzd(bld, dst, src_reg(temp), false);
|
|
|
|
|
} else {
|
|
|
|
|
bld.FBL(dst, op[0]);
|
|
|
|
|
}
|
2015-06-17 09:44:25 +02:00
|
|
|
break;
|
2016-06-22 13:12:26 -07:00
|
|
|
}
|
2015-06-17 09:44:25 +02:00
|
|
|
|
|
|
|
|
case nir_op_ubitfield_extract:
|
|
|
|
|
case nir_op_ibitfield_extract:
|
2016-01-13 11:09:11 -08:00
|
|
|
unreachable("should have been lowered");
|
|
|
|
|
case nir_op_ubfe:
|
|
|
|
|
case nir_op_ibfe:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 09:44:25 +02:00
|
|
|
op[0] = fix_3src_operand(op[0]);
|
|
|
|
|
op[1] = fix_3src_operand(op[1]);
|
|
|
|
|
op[2] = fix_3src_operand(op[2]);
|
|
|
|
|
|
|
|
|
|
emit(BFE(dst, op[2], op[1], op[0]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_bfm:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 09:44:25 +02:00
|
|
|
emit(BFI1(dst, op[0], op[1]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_bfi:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2015-06-17 09:44:25 +02:00
|
|
|
op[0] = fix_3src_operand(op[0]);
|
|
|
|
|
op[1] = fix_3src_operand(op[1]);
|
|
|
|
|
op[2] = fix_3src_operand(op[2]);
|
|
|
|
|
|
|
|
|
|
emit(BFI2(dst, op[0], op[1], op[2]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_bitfield_insert:
|
2016-01-07 15:54:16 -08:00
|
|
|
unreachable("not reached: should have been lowered");
|
2015-06-17 09:44:25 +02:00
|
|
|
|
2015-06-17 09:47:41 +02:00
|
|
|
case nir_op_fsign:
|
2020-04-21 23:50:46 -07:00
|
|
|
if (type_sz(op[0].type) < 8) {
|
2016-02-05 10:12:57 +01:00
|
|
|
/* AND(val, 0x80000000) gives the sign bit.
|
|
|
|
|
*
|
|
|
|
|
* Predicated OR ORs 1.0 (0x3f800000) with the sign bit if val is not
|
|
|
|
|
* zero.
|
|
|
|
|
*/
|
|
|
|
|
emit(CMP(dst_null_f(), op[0], brw_imm_f(0.0f), BRW_CONDITIONAL_NZ));
|
2015-06-17 09:47:41 +02:00
|
|
|
|
2016-02-05 10:12:57 +01:00
|
|
|
op[0].type = BRW_REGISTER_TYPE_UD;
|
|
|
|
|
dst.type = BRW_REGISTER_TYPE_UD;
|
|
|
|
|
emit(AND(dst, op[0], brw_imm_ud(0x80000000u)));
|
2015-06-17 09:47:41 +02:00
|
|
|
|
2016-02-05 10:12:57 +01:00
|
|
|
inst = emit(OR(dst, src_reg(dst), brw_imm_ud(0x3f800000u)));
|
|
|
|
|
inst->predicate = BRW_PREDICATE_NORMAL;
|
|
|
|
|
dst.type = BRW_REGISTER_TYPE_F;
|
|
|
|
|
} else {
|
|
|
|
|
/* For doubles we do the same but we need to consider:
|
|
|
|
|
*
|
|
|
|
|
* - We use a MOV with conditional_mod instead of a CMP so that we can
|
|
|
|
|
* skip loading a 0.0 immediate. We use a source modifier on the
|
|
|
|
|
* source of the MOV so that we flush denormalized values to 0.
|
|
|
|
|
* Since we want to compare against 0, this won't alter the result.
|
|
|
|
|
* - We need to extract the high 32-bit of each DF where the sign
|
|
|
|
|
* is stored.
|
|
|
|
|
* - We need to produce a DF result.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
/* Check for zero */
|
|
|
|
|
src_reg value = op[0];
|
|
|
|
|
value.abs = true;
|
|
|
|
|
inst = emit(MOV(dst_null_df(), value));
|
|
|
|
|
inst->conditional_mod = BRW_CONDITIONAL_NZ;
|
|
|
|
|
|
|
|
|
|
/* AND each high 32-bit channel with 0x80000000u */
|
|
|
|
|
dst_reg tmp = dst_reg(this, glsl_type::uvec4_type);
|
|
|
|
|
emit(VEC4_OPCODE_PICK_HIGH_32BIT, tmp, op[0]);
|
|
|
|
|
emit(AND(tmp, src_reg(tmp), brw_imm_ud(0x80000000u)));
|
|
|
|
|
|
|
|
|
|
/* Add 1.0 to each channel, predicated to skip the cases where the
|
|
|
|
|
* channel's value was 0
|
|
|
|
|
*/
|
|
|
|
|
inst = emit(OR(tmp, src_reg(tmp), brw_imm_ud(0x3f800000u)));
|
|
|
|
|
inst->predicate = BRW_PREDICATE_NORMAL;
|
2015-06-17 09:47:41 +02:00
|
|
|
|
2016-02-05 10:12:57 +01:00
|
|
|
/* Now convert the result from float to double */
|
2017-03-07 18:32:17 -08:00
|
|
|
emit_conversion_to_double(dst, retype(src_reg(tmp),
|
intel/compiler: Drop nir_lower_to_source_mods() and related handling.
I think we're unanimous in wanting to drop nir_lower_to_source_mods.
It's a bit of complexity to handle in the backend, but perhaps more
importantly, would be even more complexity to handle in nir_search.
And, it turns out that since we made other compiler improvements in the
last few years, they no longer appear to buy us anything of value.
Summarizing the results from shader-db from this patch:
- Icelake (scalar mode)
Instruction counts:
- 411 helped, 598 hurt (out of 139,470 shaders)
- 99.2% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.78 instructions.
- total instructions in shared programs: 17214951 -> 17215206 (<.01%)
- instructions in affected programs: 1143879 -> 1144134 (0.02%)
Cycles:
- 1042 helped, 1357 hurt
- total cycles in shared programs: 365613294 -> 365882263 (0.07%)
- cycles in affected programs: 138155497 -> 138424466 (0.19%)
- Haswell (both scalar and vector modes)
Instruction counts:
- 73 helped, 1680 hurt (out of 139,470 shaders)
- 98.7% of shaders remain unaffected. The average increase in
instruction count in hurt programs is 1.9 instructions.
- total instructions in shared programs: 14199527 -> 14202262 (0.02%)
- instructions in affected programs: 446499 -> 449234 (0.61%)
Cycles:
- 5253 helped, 5559 hurt
- total cycles in shared programs: 359996545 -> 360038731 (0.01%)
- cycles in affected programs: 155897127 -> 155939313 (0.03%)
Given that ~99% of shader-db remains unaffected, and the affected
programs are hurt by about 1-2 instructions - which are all cheap
ALU instructions - this is unlikely to be measurable in terms of
any real performance impact that would affect users.
So, drop them and simplify the backend, and hopefully enable other
future simplifications in NIR.
Reviewed-by: Eric Anholt <eric@anholt.net> [v1]
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4616>
2020-04-18 01:20:42 -07:00
|
|
|
BRW_REGISTER_TYPE_F));
|
2015-06-17 09:47:41 +02:00
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
|
2015-06-17 09:49:31 +02:00
|
|
|
case nir_op_ishl:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, false);
|
2015-06-17 09:49:31 +02:00
|
|
|
emit(SHL(dst, op[0], op[1]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_ishr:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, false);
|
2015-06-17 09:49:31 +02:00
|
|
|
emit(ASR(dst, op[0], op[1]));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_op_ushr:
|
2015-11-10 10:20:25 +01:00
|
|
|
assert(nir_dest_bit_size(instr->dest.dest) < 64);
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, false);
|
2015-06-17 09:49:31 +02:00
|
|
|
emit(SHR(dst, op[0], op[1]));
|
|
|
|
|
break;
|
|
|
|
|
|
2015-06-17 09:51:10 +02:00
|
|
|
case nir_op_ffma:
|
i965/vec4/nir: do not emit 64-bit MAD
RepCtrl=1 does not work with 64-bit operands so we need to use RepCtrl=0.
In that situation, the regioning generated for the sources seems to be
equivalent to <4,4,1>:DF, so it will only work for components XY, which
means that we have to move any other swizzle to a temporary so that we can
source from channel X (or Y) in MAD and we also need to split the instruction
(we are already scalarizing DF instructions but there is room for
improvement and with MAD would be more restricted in that area)
Also, it seems that MAD operations like this only write proper output for
channels X and Y, so writes to Z and W also need to be done to a temporary
using channels X/Y and then move that to channels Z or W of the actual dst.
As a result the code we produce for native 64-bit MAD instructions is rather
bad, and much worse than just emitting MUL+ADD. For reference, a simple case
of a fully scalarized dvec4 MAD operation requires 15 instructions if we use
native MAD and 8 instructions if we emit ADD+MUL instead. There are some
improvements that we can do to the emission of MAD that might bring the
instruction count down in some cases, but it comes at the expense of a more
complex implementation so it does not seem worth it, at least initially.
This patch makes translation of NIR's 64-bit FMMA instructions produce MUL+ADD
instead of MAD. Currently, there is nothing else in the vec4 backend that emits
MAD instructions, so this is sufficient and it helps optimization passes see
MUL+ADD from the get go.
Reviewed-by: Matt Turner <mattst88@gmail.com>
2016-06-08 11:05:51 +02:00
|
|
|
if (type_sz(dst.type) == 8) {
|
|
|
|
|
dst_reg mul_dst = dst_reg(this, glsl_type::dvec4_type);
|
|
|
|
|
emit(MUL(mul_dst, op[1], op[0]));
|
|
|
|
|
inst = emit(ADD(dst, src_reg(mul_dst), op[2]));
|
|
|
|
|
} else {
|
2019-06-06 11:21:15 -07:00
|
|
|
fix_float_operands(op, instr);
|
i965/vec4/nir: do not emit 64-bit MAD
RepCtrl=1 does not work with 64-bit operands so we need to use RepCtrl=0.
In that situation, the regioning generated for the sources seems to be
equivalent to <4,4,1>:DF, so it will only work for components XY, which
means that we have to move any other swizzle to a temporary so that we can
source from channel X (or Y) in MAD and we also need to split the instruction
(we are already scalarizing DF instructions but there is room for
improvement and with MAD would be more restricted in that area)
Also, it seems that MAD operations like this only write proper output for
channels X and Y, so writes to Z and W also need to be done to a temporary
using channels X/Y and then move that to channels Z or W of the actual dst.
As a result the code we produce for native 64-bit MAD instructions is rather
bad, and much worse than just emitting MUL+ADD. For reference, a simple case
of a fully scalarized dvec4 MAD operation requires 15 instructions if we use
native MAD and 8 instructions if we emit ADD+MUL instead. There are some
improvements that we can do to the emission of MAD that might bring the
instruction count down in some cases, but it comes at the expense of a more
complex implementation so it does not seem worth it, at least initially.
This patch makes translation of NIR's 64-bit FMMA instructions produce MUL+ADD
instead of MAD. Currently, there is nothing else in the vec4 backend that emits
MAD instructions, so this is sufficient and it helps optimization passes see
MUL+ADD from the get go.
Reviewed-by: Matt Turner <mattst88@gmail.com>
2016-06-08 11:05:51 +02:00
|
|
|
inst = emit(MAD(dst, op[2], op[1], op[0]));
|
|
|
|
|
}
|
2015-06-17 09:51:10 +02:00
|
|
|
break;
|
|
|
|
|
|
2015-06-17 09:52:43 +02:00
|
|
|
case nir_op_flrp:
|
2019-06-06 11:21:15 -07:00
|
|
|
fix_float_operands(op, instr);
|
2019-06-06 11:00:40 -07:00
|
|
|
inst = emit(LRP(dst, op[2], op[1], op[0]));
|
2015-06-17 09:52:43 +02:00
|
|
|
break;
|
|
|
|
|
|
2018-10-18 11:44:38 -05:00
|
|
|
case nir_op_b32csel:
|
i965/vec4: Optimize predicate handling for any/all.
For a select whose condition is any(v), instead of emitting
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
mov(8) g7<1>.xUD 0x00000000UD
(+f0.any4h) mov(8) g7<1>.xUD 0xffffffffUD
cmp.nz.f0(8) null<1>D g7<4,4,1>.xD 0D
(+f0) sel(8) g8<1>UD g4<4,4,1>UD g3<4,4,1>UD
we now emit
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
(+f0.any4h) sel(8) g9<1>UD g4<4,4,1>UD g3<4,4,1>UD
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2015-11-25 21:54:30 -08:00
|
|
|
enum brw_predicate predicate;
|
|
|
|
|
if (!optimize_predicate(instr, &predicate)) {
|
|
|
|
|
emit(CMP(dst_null_d(), op[0], brw_imm_d(0), BRW_CONDITIONAL_NZ));
|
|
|
|
|
switch (dst.writemask) {
|
|
|
|
|
case WRITEMASK_X:
|
|
|
|
|
predicate = BRW_PREDICATE_ALIGN16_REPLICATE_X;
|
|
|
|
|
break;
|
|
|
|
|
case WRITEMASK_Y:
|
|
|
|
|
predicate = BRW_PREDICATE_ALIGN16_REPLICATE_Y;
|
|
|
|
|
break;
|
|
|
|
|
case WRITEMASK_Z:
|
|
|
|
|
predicate = BRW_PREDICATE_ALIGN16_REPLICATE_Z;
|
|
|
|
|
break;
|
|
|
|
|
case WRITEMASK_W:
|
|
|
|
|
predicate = BRW_PREDICATE_ALIGN16_REPLICATE_W;
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
predicate = BRW_PREDICATE_NORMAL;
|
|
|
|
|
break;
|
|
|
|
|
}
|
i965/vec4: select predicate based on writemask for sel emissions
Equivalent to commit 8ac3b525c but with sel operations. In this case
we select the PredCtrl based on the writemask.
This patch helps on cases like this:
1: cmp.l.f0.0 vgrf40.0.x:F, vgrf0.zzzz:F, vgrf7.xxxx:F
2: cmp.nz.f0.0 null:D, vgrf40.xxxx:D, 0D
3: (+f0.0) sel vgrf41.0.x:UD, vgrf6.xxxx:UD, vgrf5.xxxx:UD
In this case, cmod propagation can't optimize instruction #2, because
instructions #1 and #2 have different writemasks, and we can't update
directly instruction #2 writemask because our code thinks that sel at
instruction #3 reads all four channels of the flag, when it actually
only reads .x.
So, with this patch, the previous case becames this:
1: cmp.l.f0.0 vgrf40.0.x:F, vgrf0.zzzz:F, vgrf7.xxxx:F
2: cmp.nz.f0.0 null:D, vgrf40.xxxx:D, 0D
3: (+f0.0.x) sel vgrf41.0.x:UD, vgrf6.xxxx:UD, vgrf5.xxxx:UD
Now only the x channel of the flag is used, allowing dead code
eliminate to update the writemask at the second instruction:
1: cmp.l.f0.0 vgrf40.0.x:F, vgrf0.zzzz:F, vgrf7.xxxx:F
2: cmp.nz.f0.0 null.x:D, vgrf40.xxxx:D, 0D
3: (+f0.0.x) sel vgrf41.0.x:UD, vgrf6.xxxx:UD, vgrf5.xxxx:UD
So now cmod propagation can simplify out #2:
1: cmp.l.f0.0 vgrf40.0.x:F, attr18.wwww:F, vgrf7.xxxx:F
2: (+f0.0.x) sel vgrf41.0.x:UD, vgrf6.xxxx:UD, vgrf5.xxxx:UD
Shader-db numbers:
total instructions in shared programs: 6235835 -> 6228008 (-0.13%)
instructions in affected programs: 219850 -> 212023 (-3.56%)
total loops in shared programs: 1979 -> 1979 (0.00%)
helped: 1192
HURT: 0
2015-10-20 13:08:09 +02:00
|
|
|
}
|
i965/vec4: Optimize predicate handling for any/all.
For a select whose condition is any(v), instead of emitting
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
mov(8) g7<1>.xUD 0x00000000UD
(+f0.any4h) mov(8) g7<1>.xUD 0xffffffffUD
cmp.nz.f0(8) null<1>D g7<4,4,1>.xD 0D
(+f0) sel(8) g8<1>UD g4<4,4,1>UD g3<4,4,1>UD
we now emit
cmp.nz.f0(8) null<1>D g1<0,4,1>D 0D
(+f0.any4h) sel(8) g9<1>UD g4<4,4,1>UD g3<4,4,1>UD
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2015-11-25 21:54:30 -08:00
|
|
|
inst = emit(BRW_OPCODE_SEL, dst, op[1], op[2]);
|
|
|
|
|
inst->predicate = predicate;
|
2015-06-17 10:05:29 +02:00
|
|
|
break;
|
|
|
|
|
|
2020-06-20 14:33:57 -07:00
|
|
|
case nir_op_fdot2_replicated:
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, true);
|
2015-06-17 10:06:44 +02:00
|
|
|
inst = emit(BRW_OPCODE_DP2, dst, op[0], op[1]);
|
|
|
|
|
break;
|
|
|
|
|
|
2020-06-20 14:33:57 -07:00
|
|
|
case nir_op_fdot3_replicated:
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, true);
|
2015-06-17 10:06:44 +02:00
|
|
|
inst = emit(BRW_OPCODE_DP3, dst, op[0], op[1]);
|
|
|
|
|
break;
|
|
|
|
|
|
2020-06-20 14:33:57 -07:00
|
|
|
case nir_op_fdot4_replicated:
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, true);
|
2015-06-17 10:06:44 +02:00
|
|
|
inst = emit(BRW_OPCODE_DP4, dst, op[0], op[1]);
|
|
|
|
|
break;
|
|
|
|
|
|
2015-09-22 16:55:42 -07:00
|
|
|
case nir_op_fdph_replicated:
|
2020-09-22 13:09:56 -07:00
|
|
|
try_immediate_source(instr, op, false);
|
2015-09-22 16:55:42 -07:00
|
|
|
inst = emit(BRW_OPCODE_DPH, dst, op[0], op[1]);
|
|
|
|
|
break;
|
|
|
|
|
|
2015-06-17 10:10:44 +02:00
|
|
|
case nir_op_fdiv:
|
2022-05-31 13:48:17 -07:00
|
|
|
unreachable("not reached: should be lowered by lower_fdiv in the compiler");
|
2015-06-17 10:10:44 +02:00
|
|
|
|
|
|
|
|
case nir_op_fmod:
|
2022-03-28 15:54:31 -07:00
|
|
|
unreachable("not reached: should be lowered by lower_fmod in the compiler");
|
2015-06-17 10:10:44 +02:00
|
|
|
|
|
|
|
|
case nir_op_fsub:
|
|
|
|
|
case nir_op_isub:
|
|
|
|
|
unreachable("not reached: should be handled by ir_sub_to_add_neg");
|
|
|
|
|
|
2015-06-16 22:52:29 +02:00
|
|
|
default:
|
|
|
|
|
unreachable("Unimplemented ALU operation");
|
|
|
|
|
}
|
2015-08-03 10:00:38 -07:00
|
|
|
|
|
|
|
|
/* If we need to do a boolean resolve, replace the result with -(x & 1)
|
|
|
|
|
* to sign extend the low bit to 0/~0
|
|
|
|
|
*/
|
2021-03-29 14:41:58 -07:00
|
|
|
if (devinfo->ver <= 5 &&
|
2015-08-03 10:00:38 -07:00
|
|
|
(instr->instr.pass_flags & BRW_NIR_BOOLEAN_MASK) ==
|
|
|
|
|
BRW_NIR_BOOLEAN_NEEDS_RESOLVE) {
|
|
|
|
|
dst_reg masked = dst_reg(this, glsl_type::int_type);
|
|
|
|
|
masked.writemask = dst.writemask;
|
2015-11-02 12:12:44 -08:00
|
|
|
emit(AND(masked, src_reg(dst), brw_imm_d(1)));
|
2015-08-03 10:00:38 -07:00
|
|
|
src_reg masked_neg = src_reg(masked);
|
|
|
|
|
masked_neg.negate = true;
|
|
|
|
|
emit(MOV(retype(dst, BRW_REGISTER_TYPE_D), masked_neg));
|
|
|
|
|
}
|
2015-06-16 12:08:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_jump(nir_jump_instr *instr)
|
|
|
|
|
{
|
2015-06-17 10:20:19 +02:00
|
|
|
switch (instr->type) {
|
|
|
|
|
case nir_jump_break:
|
|
|
|
|
emit(BRW_OPCODE_BREAK);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_jump_continue:
|
|
|
|
|
emit(BRW_OPCODE_CONTINUE);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_jump_return:
|
2021-04-10 17:11:58 +02:00
|
|
|
FALLTHROUGH;
|
2015-06-17 10:20:19 +02:00
|
|
|
default:
|
|
|
|
|
unreachable("unknown jump");
|
|
|
|
|
}
|
2015-06-16 12:08:09 +02:00
|
|
|
}
|
|
|
|
|
|
2021-12-13 16:52:57 -08:00
|
|
|
static bool
|
|
|
|
|
is_high_sampler(const struct intel_device_info *devinfo, src_reg sampler)
|
|
|
|
|
{
|
|
|
|
|
if (devinfo->verx10 != 75)
|
|
|
|
|
return false;
|
|
|
|
|
|
|
|
|
|
return sampler.file != IMM || sampler.ud >= 16;
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-16 12:08:09 +02:00
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_texture(nir_tex_instr *instr)
|
|
|
|
|
{
|
2016-02-06 09:05:10 -08:00
|
|
|
unsigned texture = instr->texture_index;
|
2015-11-02 18:39:17 -08:00
|
|
|
unsigned sampler = instr->sampler_index;
|
2016-02-06 09:05:10 -08:00
|
|
|
src_reg texture_reg = brw_imm_ud(texture);
|
2015-11-02 18:39:17 -08:00
|
|
|
src_reg sampler_reg = brw_imm_ud(sampler);
|
2015-07-06 15:08:15 +02:00
|
|
|
src_reg coordinate;
|
|
|
|
|
const glsl_type *coord_type = NULL;
|
2016-12-12 08:32:38 -05:00
|
|
|
src_reg shadow_comparator;
|
2015-07-06 15:08:15 +02:00
|
|
|
src_reg offset_value;
|
|
|
|
|
src_reg lod, lod2;
|
|
|
|
|
src_reg sample_index;
|
|
|
|
|
src_reg mcs;
|
|
|
|
|
|
|
|
|
|
dst_reg dest = get_nir_dest(instr->dest, instr->dest_type);
|
|
|
|
|
|
2016-03-25 14:02:50 -07:00
|
|
|
/* The hardware requires a LOD for buffer textures */
|
|
|
|
|
if (instr->sampler_dim == GLSL_SAMPLER_DIM_BUF)
|
|
|
|
|
lod = brw_imm_d(0);
|
|
|
|
|
|
2015-07-06 15:08:15 +02:00
|
|
|
/* Load the texture operation sources */
|
2016-02-09 14:51:28 -08:00
|
|
|
uint32_t constant_offset = 0;
|
2015-07-06 15:08:15 +02:00
|
|
|
for (unsigned i = 0; i < instr->num_srcs; i++) {
|
|
|
|
|
switch (instr->src[i].src_type) {
|
2016-12-12 08:32:38 -05:00
|
|
|
case nir_tex_src_comparator:
|
|
|
|
|
shadow_comparator = get_nir_src(instr->src[i].src,
|
2015-07-06 15:08:15 +02:00
|
|
|
BRW_REGISTER_TYPE_F, 1);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_tex_src_coord: {
|
|
|
|
|
unsigned src_size = nir_tex_instr_src_size(instr, i);
|
|
|
|
|
|
|
|
|
|
switch (instr->op) {
|
|
|
|
|
case nir_texop_txf:
|
|
|
|
|
case nir_texop_txf_ms:
|
2015-11-17 17:57:08 -08:00
|
|
|
case nir_texop_samples_identical:
|
2015-07-06 15:08:15 +02:00
|
|
|
coordinate = get_nir_src(instr->src[i].src, BRW_REGISTER_TYPE_D,
|
|
|
|
|
src_size);
|
|
|
|
|
coord_type = glsl_type::ivec(src_size);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
default:
|
|
|
|
|
coordinate = get_nir_src(instr->src[i].src, BRW_REGISTER_TYPE_F,
|
|
|
|
|
src_size);
|
|
|
|
|
coord_type = glsl_type::vec(src_size);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
case nir_tex_src_ddx:
|
|
|
|
|
lod = get_nir_src(instr->src[i].src, BRW_REGISTER_TYPE_F,
|
|
|
|
|
nir_tex_instr_src_size(instr, i));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_tex_src_ddy:
|
|
|
|
|
lod2 = get_nir_src(instr->src[i].src, BRW_REGISTER_TYPE_F,
|
|
|
|
|
nir_tex_instr_src_size(instr, i));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_tex_src_lod:
|
|
|
|
|
switch (instr->op) {
|
|
|
|
|
case nir_texop_txs:
|
|
|
|
|
case nir_texop_txf:
|
|
|
|
|
lod = get_nir_src(instr->src[i].src, BRW_REGISTER_TYPE_D, 1);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
default:
|
|
|
|
|
lod = get_nir_src(instr->src[i].src, BRW_REGISTER_TYPE_F, 1);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case nir_tex_src_ms_index: {
|
|
|
|
|
sample_index = get_nir_src(instr->src[i].src, BRW_REGISTER_TYPE_D, 1);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2019-03-27 17:34:10 -05:00
|
|
|
case nir_tex_src_offset:
|
|
|
|
|
if (!brw_texture_offset(instr, i, &constant_offset)) {
|
2016-02-09 14:51:28 -08:00
|
|
|
offset_value =
|
|
|
|
|
get_nir_src(instr->src[i].src, BRW_REGISTER_TYPE_D, 2);
|
|
|
|
|
}
|
2015-07-06 15:08:15 +02:00
|
|
|
break;
|
|
|
|
|
|
2016-02-06 09:05:10 -08:00
|
|
|
case nir_tex_src_texture_offset: {
|
2015-07-06 15:08:15 +02:00
|
|
|
/* Emit code to evaluate the actual indexing expression */
|
|
|
|
|
src_reg src = get_nir_src(instr->src[i].src, 1);
|
|
|
|
|
src_reg temp(this, glsl_type::uint_type);
|
2016-02-06 09:05:10 -08:00
|
|
|
emit(ADD(dst_reg(temp), src, brw_imm_ud(texture)));
|
|
|
|
|
texture_reg = emit_uniformize(temp);
|
2015-07-06 15:08:15 +02:00
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2015-11-02 18:39:17 -08:00
|
|
|
case nir_tex_src_sampler_offset: {
|
|
|
|
|
/* Emit code to evaluate the actual indexing expression */
|
|
|
|
|
src_reg src = get_nir_src(instr->src[i].src, 1);
|
|
|
|
|
src_reg temp(this, glsl_type::uint_type);
|
|
|
|
|
emit(ADD(dst_reg(temp), src, brw_imm_ud(sampler)));
|
|
|
|
|
sampler_reg = emit_uniformize(temp);
|
|
|
|
|
break;
|
|
|
|
|
}
|
2015-11-02 17:58:29 -08:00
|
|
|
|
2015-07-06 15:08:15 +02:00
|
|
|
case nir_tex_src_projector:
|
2021-07-12 11:50:04 -05:00
|
|
|
unreachable("Should be lowered by nir_lower_tex");
|
2015-07-06 15:08:15 +02:00
|
|
|
|
|
|
|
|
case nir_tex_src_bias:
|
|
|
|
|
unreachable("LOD bias is not valid for vertex shaders.\n");
|
|
|
|
|
|
|
|
|
|
default:
|
|
|
|
|
unreachable("unknown texture source");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-11-17 17:57:08 -08:00
|
|
|
if (instr->op == nir_texop_txf_ms ||
|
|
|
|
|
instr->op == nir_texop_samples_identical) {
|
2015-11-17 19:31:39 -08:00
|
|
|
assert(coord_type != NULL);
|
intel: Drop compressed_multisample_layout_mask from the compiler keys
The compiler looks at this key field to determine whether to perform
an MCS fetch for a txf_ms or samples_identical texture message, if a
nir_tex_src_ms_mcs_intel source wasn't provided. If it isn't set,
it instead uses constant 0 (nothing is compressed).
All of the drivers (iris, crocus, anv, hasvk) unconditionally set this
to ~0 because we don't want to pay for costly shader recompiles (which
can cause nasty stuttering). Most textures are compressed anyway, and
the hardware ignores the l2dms MCS parameter if MCS is disabled.
The only user was BLORP, which sets the key field based on whether the
texture's aux usage has MCS. But if it has MCS, it also does the MCS
fetch itself and supplies it directly. Otherwise, it relies on the
compiler to fill in the 0 value. But it could easily just provide the
0 value itself in that case and not rely on the compiler at all.
With that fixed, we can just drop the key fields entirely. We leave
them as padding for now to avoid repacking structures; we won't need
to after the next commits anyway.
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20223>
2022-12-07 20:20:12 -08:00
|
|
|
if (devinfo->ver >= 7) {
|
2016-02-06 09:05:10 -08:00
|
|
|
mcs = emit_mcs_fetch(coord_type, coordinate, texture_reg);
|
2015-11-17 19:31:39 -08:00
|
|
|
} else {
|
|
|
|
|
mcs = brw_imm_ud(0u);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-07-06 15:08:15 +02:00
|
|
|
/* Stuff the channel select bits in the top of the texture offset */
|
2015-11-11 18:41:37 -08:00
|
|
|
if (instr->op == nir_texop_tg4) {
|
|
|
|
|
if (instr->component == 1 &&
|
2016-02-06 09:05:10 -08:00
|
|
|
(key_tex->gather_channel_quirk_mask & (1 << texture))) {
|
2015-11-11 18:41:37 -08:00
|
|
|
/* gather4 sampler is broken for green channel on RG32F --
|
|
|
|
|
* we must ask for blue instead.
|
|
|
|
|
*/
|
|
|
|
|
constant_offset |= 2 << 16;
|
|
|
|
|
} else {
|
|
|
|
|
constant_offset |= instr->component << 16;
|
|
|
|
|
}
|
|
|
|
|
}
|
2015-07-06 15:08:15 +02:00
|
|
|
|
2021-12-13 16:52:57 -08:00
|
|
|
enum opcode opcode;
|
|
|
|
|
switch (instr->op) {
|
|
|
|
|
case nir_texop_tex: opcode = SHADER_OPCODE_TXL; break;
|
|
|
|
|
case nir_texop_txl: opcode = SHADER_OPCODE_TXL; break;
|
|
|
|
|
case nir_texop_txd: opcode = SHADER_OPCODE_TXD; break;
|
|
|
|
|
case nir_texop_txf: opcode = SHADER_OPCODE_TXF; break;
|
|
|
|
|
case nir_texop_txf_ms: opcode = SHADER_OPCODE_TXF_CMS; break;
|
|
|
|
|
case nir_texop_txs: opcode = SHADER_OPCODE_TXS; break;
|
|
|
|
|
case nir_texop_query_levels: opcode = SHADER_OPCODE_TXS; break;
|
|
|
|
|
case nir_texop_texture_samples: opcode = SHADER_OPCODE_SAMPLEINFO; break;
|
|
|
|
|
case nir_texop_tg4:
|
|
|
|
|
opcode = offset_value.file != BAD_FILE ? SHADER_OPCODE_TG4_OFFSET
|
|
|
|
|
: SHADER_OPCODE_TG4;
|
|
|
|
|
break;
|
|
|
|
|
case nir_texop_samples_identical: {
|
|
|
|
|
/* There are some challenges implementing this for vec4, and it seems
|
|
|
|
|
* unlikely to be used anyway. For now, just return false ways.
|
|
|
|
|
*/
|
|
|
|
|
emit(MOV(dest, brw_imm_ud(0u)));
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
case nir_texop_txb:
|
|
|
|
|
case nir_texop_lod:
|
|
|
|
|
unreachable("Implicit LOD is only valid inside fragment shaders.");
|
|
|
|
|
default:
|
|
|
|
|
unreachable("Unrecognized tex op");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
vec4_instruction *inst = new(mem_ctx) vec4_instruction(opcode, dest);
|
|
|
|
|
|
|
|
|
|
inst->offset = constant_offset;
|
|
|
|
|
|
|
|
|
|
/* The message header is necessary for:
|
|
|
|
|
* - Gfx4 (always)
|
|
|
|
|
* - Texel offsets
|
|
|
|
|
* - Gather channel selection
|
|
|
|
|
* - Sampler indices too large to fit in a 4-bit value.
|
|
|
|
|
* - Sampleinfo message - takes no parameters, but mlen = 0 is illegal
|
|
|
|
|
*/
|
|
|
|
|
inst->header_size =
|
|
|
|
|
(devinfo->ver < 5 ||
|
|
|
|
|
inst->offset != 0 ||
|
|
|
|
|
opcode == SHADER_OPCODE_TG4 ||
|
|
|
|
|
opcode == SHADER_OPCODE_TG4_OFFSET ||
|
|
|
|
|
opcode == SHADER_OPCODE_SAMPLEINFO ||
|
|
|
|
|
is_high_sampler(devinfo, sampler_reg)) ? 1 : 0;
|
|
|
|
|
inst->base_mrf = 2;
|
|
|
|
|
inst->mlen = inst->header_size;
|
|
|
|
|
inst->dst.writemask = WRITEMASK_XYZW;
|
|
|
|
|
inst->shadow_compare = shadow_comparator.file != BAD_FILE;
|
|
|
|
|
|
|
|
|
|
inst->src[1] = texture_reg;
|
|
|
|
|
inst->src[2] = sampler_reg;
|
|
|
|
|
|
|
|
|
|
/* MRF for the first parameter */
|
|
|
|
|
int param_base = inst->base_mrf + inst->header_size;
|
|
|
|
|
|
|
|
|
|
if (opcode == SHADER_OPCODE_TXS) {
|
|
|
|
|
int writemask = devinfo->ver == 4 ? WRITEMASK_W : WRITEMASK_X;
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base, lod.type, writemask), lod));
|
|
|
|
|
inst->mlen++;
|
|
|
|
|
} else if (opcode == SHADER_OPCODE_SAMPLEINFO) {
|
|
|
|
|
inst->dst.writemask = WRITEMASK_X;
|
|
|
|
|
} else {
|
|
|
|
|
/* Load the coordinate */
|
|
|
|
|
/* FINISHME: gl_clamp_mask and saturate */
|
|
|
|
|
int coord_mask = (1 << instr->coord_components) - 1;
|
|
|
|
|
int zero_mask = 0xf & ~coord_mask;
|
|
|
|
|
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base, coordinate.type, coord_mask),
|
|
|
|
|
coordinate));
|
|
|
|
|
inst->mlen++;
|
|
|
|
|
|
|
|
|
|
if (zero_mask != 0) {
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base, coordinate.type, zero_mask),
|
|
|
|
|
brw_imm_d(0)));
|
|
|
|
|
}
|
|
|
|
|
/* Load the shadow comparator */
|
|
|
|
|
if (shadow_comparator.file != BAD_FILE &&
|
|
|
|
|
opcode != SHADER_OPCODE_TXD &&
|
|
|
|
|
opcode != SHADER_OPCODE_TG4_OFFSET) {
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base + 1, shadow_comparator.type,
|
|
|
|
|
WRITEMASK_X),
|
|
|
|
|
shadow_comparator));
|
|
|
|
|
inst->mlen++;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Load the LOD info */
|
|
|
|
|
switch (opcode) {
|
|
|
|
|
case SHADER_OPCODE_TXL: {
|
|
|
|
|
int mrf, writemask;
|
|
|
|
|
if (devinfo->ver >= 5) {
|
|
|
|
|
mrf = param_base + 1;
|
|
|
|
|
if (shadow_comparator.file != BAD_FILE) {
|
|
|
|
|
writemask = WRITEMASK_Y;
|
|
|
|
|
/* mlen already incremented */
|
|
|
|
|
} else {
|
|
|
|
|
writemask = WRITEMASK_X;
|
|
|
|
|
inst->mlen++;
|
|
|
|
|
}
|
|
|
|
|
} else /* devinfo->ver == 4 */ {
|
|
|
|
|
mrf = param_base;
|
|
|
|
|
writemask = WRITEMASK_W;
|
|
|
|
|
}
|
|
|
|
|
emit(MOV(dst_reg(MRF, mrf, lod.type, writemask), lod));
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
case SHADER_OPCODE_TXF:
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base, lod.type, WRITEMASK_W), lod));
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case SHADER_OPCODE_TXF_CMS:
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base + 1, sample_index.type, WRITEMASK_X),
|
|
|
|
|
sample_index));
|
|
|
|
|
if (devinfo->ver >= 7) {
|
|
|
|
|
/* MCS data is in the first channel of `mcs`, but we need to get it into
|
|
|
|
|
* the .y channel of the second vec4 of params, so replicate .x across
|
|
|
|
|
* the whole vec4 and then mask off everything except .y
|
|
|
|
|
*/
|
|
|
|
|
mcs.swizzle = BRW_SWIZZLE_XXXX;
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base + 1, glsl_type::uint_type, WRITEMASK_Y),
|
|
|
|
|
mcs));
|
|
|
|
|
}
|
|
|
|
|
inst->mlen++;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case SHADER_OPCODE_TXD: {
|
|
|
|
|
const brw_reg_type type = lod.type;
|
|
|
|
|
|
|
|
|
|
if (devinfo->ver >= 5) {
|
|
|
|
|
lod.swizzle = BRW_SWIZZLE4(SWIZZLE_X,SWIZZLE_X,SWIZZLE_Y,SWIZZLE_Y);
|
|
|
|
|
lod2.swizzle = BRW_SWIZZLE4(SWIZZLE_X,SWIZZLE_X,SWIZZLE_Y,SWIZZLE_Y);
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base + 1, type, WRITEMASK_XZ), lod));
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base + 1, type, WRITEMASK_YW), lod2));
|
|
|
|
|
inst->mlen++;
|
|
|
|
|
|
|
|
|
|
if (nir_tex_instr_dest_size(instr) == 3 ||
|
|
|
|
|
shadow_comparator.file != BAD_FILE) {
|
|
|
|
|
lod.swizzle = BRW_SWIZZLE_ZZZZ;
|
|
|
|
|
lod2.swizzle = BRW_SWIZZLE_ZZZZ;
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base + 2, type, WRITEMASK_X), lod));
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base + 2, type, WRITEMASK_Y), lod2));
|
|
|
|
|
inst->mlen++;
|
|
|
|
|
|
|
|
|
|
if (shadow_comparator.file != BAD_FILE) {
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base + 2,
|
|
|
|
|
shadow_comparator.type, WRITEMASK_Z),
|
|
|
|
|
shadow_comparator));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
} else /* devinfo->ver == 4 */ {
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base + 1, type, WRITEMASK_XYZ), lod));
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base + 2, type, WRITEMASK_XYZ), lod2));
|
|
|
|
|
inst->mlen += 2;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
case SHADER_OPCODE_TG4_OFFSET:
|
|
|
|
|
if (shadow_comparator.file != BAD_FILE) {
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base, shadow_comparator.type, WRITEMASK_W),
|
|
|
|
|
shadow_comparator));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base + 1, glsl_type::ivec2_type, WRITEMASK_XY),
|
|
|
|
|
offset_value));
|
|
|
|
|
inst->mlen++;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
default:
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
emit(inst);
|
|
|
|
|
|
|
|
|
|
/* fixup num layers (z) for cube arrays: hardware returns faces * layers;
|
|
|
|
|
* spec requires layers.
|
|
|
|
|
*/
|
|
|
|
|
if (instr->op == nir_texop_txs && devinfo->ver < 7) {
|
|
|
|
|
/* Gfx4-6 return 0 instead of 1 for single layer surfaces. */
|
|
|
|
|
emit_minmax(BRW_CONDITIONAL_GE, writemask(inst->dst, WRITEMASK_Z),
|
|
|
|
|
src_reg(inst->dst), brw_imm_d(1));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (instr->op == nir_texop_query_levels) {
|
|
|
|
|
/* # levels is in .w */
|
|
|
|
|
src_reg swizzled(dest);
|
|
|
|
|
swizzled.swizzle = BRW_SWIZZLE4(SWIZZLE_W, SWIZZLE_W,
|
|
|
|
|
SWIZZLE_W, SWIZZLE_W);
|
|
|
|
|
emit(MOV(dest, swizzled));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
src_reg
|
|
|
|
|
vec4_visitor::emit_mcs_fetch(const glsl_type *coordinate_type,
|
|
|
|
|
src_reg coordinate, src_reg surface)
|
|
|
|
|
{
|
|
|
|
|
vec4_instruction *inst =
|
|
|
|
|
new(mem_ctx) vec4_instruction(SHADER_OPCODE_TXF_MCS,
|
|
|
|
|
dst_reg(this, glsl_type::uvec4_type));
|
|
|
|
|
inst->base_mrf = 2;
|
|
|
|
|
inst->src[1] = surface;
|
|
|
|
|
inst->src[2] = brw_imm_ud(0); /* sampler */
|
|
|
|
|
inst->mlen = 1;
|
|
|
|
|
|
|
|
|
|
const int param_base = inst->base_mrf;
|
|
|
|
|
|
|
|
|
|
/* parameters are: u, v, r, lod; lod will always be zero due to api restrictions */
|
|
|
|
|
int coord_mask = (1 << coordinate_type->vector_elements) - 1;
|
|
|
|
|
int zero_mask = 0xf & ~coord_mask;
|
|
|
|
|
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base, coordinate_type, coord_mask),
|
|
|
|
|
coordinate));
|
|
|
|
|
|
|
|
|
|
emit(MOV(dst_reg(MRF, param_base, coordinate_type, zero_mask),
|
|
|
|
|
brw_imm_d(0)));
|
|
|
|
|
|
|
|
|
|
emit(inst);
|
|
|
|
|
return src_reg(inst->dst);
|
|
|
|
|
}
|
|
|
|
|
|
2015-09-09 13:55:39 -07:00
|
|
|
void
|
|
|
|
|
vec4_visitor::nir_emit_undef(nir_ssa_undef_instr *instr)
|
|
|
|
|
{
|
2016-02-15 10:07:42 +01:00
|
|
|
nir_ssa_values[instr->def.index] =
|
|
|
|
|
dst_reg(VGRF, alloc.allocate(DIV_ROUND_UP(instr->def.bit_size, 32)));
|
2015-09-09 13:55:39 -07:00
|
|
|
}
|
|
|
|
|
|
2016-06-22 11:44:15 +02:00
|
|
|
/* SIMD4x2 64bit data is stored in register space like this:
|
|
|
|
|
*
|
|
|
|
|
* r0.0:DF x0 y0 z0 w0
|
|
|
|
|
* r1.0:DF x1 y1 z1 w1
|
|
|
|
|
*
|
|
|
|
|
* When we need to write data such as this to memory using 32-bit write
|
|
|
|
|
* messages we need to shuffle it in this fashion:
|
|
|
|
|
*
|
|
|
|
|
* r0.0:DF x0 y0 x1 y1 (to be written at base offset)
|
|
|
|
|
* r0.0:DF z0 w0 z1 w1 (to be written at base offset + 16)
|
|
|
|
|
*
|
|
|
|
|
* We need to do the inverse operation when we read using 32-bit messages,
|
|
|
|
|
* which we can do by applying the same exact shuffling on the 64-bit data
|
|
|
|
|
* read, only that because the data for each vertex is positioned differently
|
|
|
|
|
* we need to apply different channel enables.
|
|
|
|
|
*
|
|
|
|
|
* This function takes 64bit data and shuffles it as explained above.
|
|
|
|
|
*
|
|
|
|
|
* The @for_write parameter is used to specify if the shuffling is being done
|
|
|
|
|
* for proper SIMD4x2 64-bit data that needs to be shuffled prior to a 32-bit
|
|
|
|
|
* write message (for_write = true), or instead we are doing the inverse
|
|
|
|
|
* operation and we have just read 64-bit data using a 32-bit messages that we
|
|
|
|
|
* need to shuffle to create valid SIMD4x2 64-bit data (for_write = false).
|
|
|
|
|
*
|
|
|
|
|
* If @block and @ref are non-NULL, then the shuffling is done after @ref,
|
|
|
|
|
* otherwise the instructions are emitted normally at the end. The function
|
|
|
|
|
* returns the last instruction inserted.
|
|
|
|
|
*
|
|
|
|
|
* Notice that @src and @dst cannot be the same register.
|
|
|
|
|
*/
|
|
|
|
|
vec4_instruction *
|
|
|
|
|
vec4_visitor::shuffle_64bit_data(dst_reg dst, src_reg src, bool for_write,
|
2021-05-04 15:30:27 -05:00
|
|
|
bool for_scratch,
|
2016-06-22 11:44:15 +02:00
|
|
|
bblock_t *block, vec4_instruction *ref)
|
|
|
|
|
{
|
|
|
|
|
assert(type_sz(src.type) == 8);
|
|
|
|
|
assert(type_sz(dst.type) == 8);
|
|
|
|
|
assert(!regions_overlap(dst, 2 * REG_SIZE, src, 2 * REG_SIZE));
|
|
|
|
|
assert(!ref == !block);
|
|
|
|
|
|
2021-05-04 15:30:27 -05:00
|
|
|
opcode mov_op = for_scratch ? VEC4_OPCODE_MOV_FOR_SCRATCH : BRW_OPCODE_MOV;
|
|
|
|
|
|
2016-06-22 11:44:15 +02:00
|
|
|
const vec4_builder bld = !ref ? vec4_builder(this).at_end() :
|
|
|
|
|
vec4_builder(this).at(block, ref->next);
|
|
|
|
|
|
|
|
|
|
/* Resolve swizzle in src */
|
|
|
|
|
if (src.swizzle != BRW_SWIZZLE_XYZW) {
|
|
|
|
|
dst_reg data = dst_reg(this, glsl_type::dvec4_type);
|
2021-06-02 23:08:13 -05:00
|
|
|
bld.emit(mov_op, data, src);
|
2016-06-22 11:44:15 +02:00
|
|
|
src = src_reg(data);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* dst+0.XY = src+0.XY */
|
2021-05-04 15:30:27 -05:00
|
|
|
bld.group(4, 0).emit(mov_op, writemask(dst, WRITEMASK_XY), src);
|
2016-06-22 11:44:15 +02:00
|
|
|
|
|
|
|
|
/* dst+0.ZW = src+1.XY */
|
2020-07-30 16:32:16 +02:00
|
|
|
bld.group(4, for_write ? 1 : 0)
|
2021-05-04 15:30:27 -05:00
|
|
|
.emit(mov_op, writemask(dst, WRITEMASK_ZW),
|
2016-06-22 11:44:15 +02:00
|
|
|
swizzle(byte_offset(src, REG_SIZE), BRW_SWIZZLE_XYXY));
|
|
|
|
|
|
|
|
|
|
/* dst+1.XY = src+0.ZW */
|
2020-07-30 16:32:16 +02:00
|
|
|
bld.group(4, for_write ? 0 : 1)
|
2021-05-04 15:30:27 -05:00
|
|
|
.emit(mov_op, writemask(byte_offset(dst, REG_SIZE), WRITEMASK_XY),
|
|
|
|
|
swizzle(src, BRW_SWIZZLE_ZWZW));
|
2016-06-22 11:44:15 +02:00
|
|
|
|
|
|
|
|
/* dst+1.ZW = src+1.ZW */
|
2020-07-30 16:32:16 +02:00
|
|
|
return bld.group(4, 1)
|
2021-05-04 15:30:27 -05:00
|
|
|
.emit(mov_op, writemask(byte_offset(dst, REG_SIZE), WRITEMASK_ZW),
|
|
|
|
|
byte_offset(src, REG_SIZE));
|
2016-06-22 11:44:15 +02:00
|
|
|
}
|
|
|
|
|
|
2015-06-16 12:08:09 +02:00
|
|
|
}
|