2011-01-18 17:16:49 -08:00
|
|
|
/*
|
|
|
|
|
* Copyright © 2010 Intel Corporation
|
|
|
|
|
*
|
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
|
*
|
|
|
|
|
* The above copyright notice and this permission notice (including the next
|
|
|
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
|
|
|
* Software.
|
|
|
|
|
*
|
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
|
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
|
|
|
* IN THE SOFTWARE.
|
|
|
|
|
*
|
|
|
|
|
* Authors:
|
|
|
|
|
* Eric Anholt <eric@anholt.net>
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include "brw_fs.h"
|
2015-06-09 10:26:53 -07:00
|
|
|
#include "brw_fs_live_variables.h"
|
2012-11-30 16:13:34 -08:00
|
|
|
#include "brw_vec4.h"
|
2014-08-31 21:19:47 -07:00
|
|
|
#include "brw_cfg.h"
|
|
|
|
|
#include "brw_shader.h"
|
2011-01-18 17:16:49 -08:00
|
|
|
|
2012-11-30 16:13:34 -08:00
|
|
|
using namespace brw;
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
/** @file brw_fs_schedule_instructions.cpp
|
|
|
|
|
*
|
|
|
|
|
* List scheduling of FS instructions.
|
|
|
|
|
*
|
|
|
|
|
* The basic model of the list scheduler is to take a basic block,
|
|
|
|
|
* compute a DAG of the dependencies (RAW ordering with latency, WAW
|
2013-03-28 10:46:17 -07:00
|
|
|
* ordering with latency, WAR ordering), and make a list of the DAG heads.
|
2011-01-18 17:16:49 -08:00
|
|
|
* Heuristically pick a DAG head, then put all the children that are
|
|
|
|
|
* now DAG heads into the list of things to schedule.
|
|
|
|
|
*
|
|
|
|
|
* The heuristic is the important part. We're trying to be cheap,
|
|
|
|
|
* since actually computing the optimal scheduling is NP complete.
|
|
|
|
|
* What we do is track a "current clock". When we schedule a node, we
|
|
|
|
|
* update the earliest-unblocked clock time of its children, and
|
|
|
|
|
* increment the clock. Then, when trying to schedule, we just pick
|
|
|
|
|
* the earliest-unblocked instruction to schedule.
|
|
|
|
|
*
|
|
|
|
|
* Note that often there will be many things which could execute
|
|
|
|
|
* immediately, and there are a range of heuristic options to choose
|
|
|
|
|
* from in picking among those.
|
|
|
|
|
*/
|
|
|
|
|
|
2012-12-04 13:52:19 -08:00
|
|
|
static bool debug = false;
|
|
|
|
|
|
2013-11-05 23:30:33 -08:00
|
|
|
class instruction_scheduler;
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
class schedule_node : public exec_node
|
|
|
|
|
{
|
|
|
|
|
public:
|
2013-11-05 23:30:33 -08:00
|
|
|
schedule_node(backend_instruction *inst, instruction_scheduler *sched);
|
2012-12-05 15:24:07 -08:00
|
|
|
void set_latency_gen4();
|
2013-02-28 16:42:51 -08:00
|
|
|
void set_latency_gen7(bool is_haswell);
|
2012-12-05 15:24:07 -08:00
|
|
|
|
2013-04-29 14:05:33 -07:00
|
|
|
backend_instruction *inst;
|
2011-01-18 17:16:49 -08:00
|
|
|
schedule_node **children;
|
|
|
|
|
int *child_latency;
|
|
|
|
|
int child_count;
|
|
|
|
|
int parent_count;
|
|
|
|
|
int child_array_size;
|
|
|
|
|
int unblocked_time;
|
|
|
|
|
int latency;
|
2013-10-28 00:11:45 -07:00
|
|
|
|
2013-10-28 15:17:07 -07:00
|
|
|
/**
|
|
|
|
|
* Which iteration of pushing groups of children onto the candidates list
|
|
|
|
|
* this node was a part of.
|
|
|
|
|
*/
|
|
|
|
|
unsigned cand_generation;
|
|
|
|
|
|
2013-10-28 00:11:45 -07:00
|
|
|
/**
|
|
|
|
|
* This is the sum of the instruction's latency plus the maximum delay of
|
|
|
|
|
* its children, or just the issue_time if it's a leaf node.
|
|
|
|
|
*/
|
|
|
|
|
int delay;
|
2016-08-16 00:56:04 -07:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Preferred exit node among the (direct or indirect) successors of this
|
|
|
|
|
* node. Among the scheduler nodes blocked by this node, this will be the
|
|
|
|
|
* one that may cause earliest program termination, or NULL if none of the
|
|
|
|
|
* successors is an exit node.
|
|
|
|
|
*/
|
|
|
|
|
schedule_node *exit;
|
2011-01-18 17:16:49 -08:00
|
|
|
};
|
|
|
|
|
|
2016-08-16 00:56:04 -07:00
|
|
|
/**
|
|
|
|
|
* Lower bound of the scheduling time after which one of the instructions
|
|
|
|
|
* blocked by this node may lead to program termination.
|
|
|
|
|
*
|
|
|
|
|
* exit_unblocked_time() determines a strict partial ordering relation '«' on
|
|
|
|
|
* the set of scheduler nodes as follows:
|
|
|
|
|
*
|
|
|
|
|
* n « m <-> exit_unblocked_time(n) < exit_unblocked_time(m)
|
|
|
|
|
*
|
|
|
|
|
* which can be used to heuristically order nodes according to how early they
|
|
|
|
|
* can unblock an exit node and lead to program termination.
|
|
|
|
|
*/
|
|
|
|
|
static inline int
|
|
|
|
|
exit_unblocked_time(const schedule_node *n)
|
|
|
|
|
{
|
|
|
|
|
return n->exit ? n->exit->unblocked_time : INT_MAX;
|
|
|
|
|
}
|
|
|
|
|
|
2012-12-05 15:24:07 -08:00
|
|
|
void
|
|
|
|
|
schedule_node::set_latency_gen4()
|
|
|
|
|
{
|
|
|
|
|
int chans = 8;
|
|
|
|
|
int math_latency = 22;
|
|
|
|
|
|
|
|
|
|
switch (inst->opcode) {
|
|
|
|
|
case SHADER_OPCODE_RCP:
|
|
|
|
|
this->latency = 1 * chans * math_latency;
|
|
|
|
|
break;
|
|
|
|
|
case SHADER_OPCODE_RSQ:
|
|
|
|
|
this->latency = 2 * chans * math_latency;
|
|
|
|
|
break;
|
|
|
|
|
case SHADER_OPCODE_INT_QUOTIENT:
|
|
|
|
|
case SHADER_OPCODE_SQRT:
|
|
|
|
|
case SHADER_OPCODE_LOG2:
|
|
|
|
|
/* full precision log. partial is 2. */
|
|
|
|
|
this->latency = 3 * chans * math_latency;
|
|
|
|
|
break;
|
|
|
|
|
case SHADER_OPCODE_INT_REMAINDER:
|
|
|
|
|
case SHADER_OPCODE_EXP2:
|
|
|
|
|
/* full precision. partial is 3, same throughput. */
|
|
|
|
|
this->latency = 4 * chans * math_latency;
|
|
|
|
|
break;
|
|
|
|
|
case SHADER_OPCODE_POW:
|
|
|
|
|
this->latency = 8 * chans * math_latency;
|
|
|
|
|
break;
|
|
|
|
|
case SHADER_OPCODE_SIN:
|
|
|
|
|
case SHADER_OPCODE_COS:
|
|
|
|
|
/* minimum latency, max is 12 rounds. */
|
|
|
|
|
this->latency = 5 * chans * math_latency;
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
this->latency = 2;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2012-12-05 16:19:43 -08:00
|
|
|
void
|
2013-02-28 16:42:51 -08:00
|
|
|
schedule_node::set_latency_gen7(bool is_haswell)
|
2012-12-05 16:19:43 -08:00
|
|
|
{
|
|
|
|
|
switch (inst->opcode) {
|
|
|
|
|
case BRW_OPCODE_MAD:
|
2013-03-28 11:15:20 -07:00
|
|
|
/* 2 cycles
|
|
|
|
|
* (since the last two src operands are in different register banks):
|
2014-03-08 11:07:10 -08:00
|
|
|
* mad(8) g4<1>F g2.2<4,4,1>F.x g2<4,4,1>F.x g3.1<4,4,1>F.x { align16 WE_normal 1Q };
|
2013-03-28 11:15:20 -07:00
|
|
|
*
|
|
|
|
|
* 3 cycles on IVB, 4 on HSW
|
|
|
|
|
* (since the last two src operands are in the same register bank):
|
2014-03-08 11:07:10 -08:00
|
|
|
* mad(8) g4<1>F g2.2<4,4,1>F.x g2<4,4,1>F.x g2.1<4,4,1>F.x { align16 WE_normal 1Q };
|
2012-12-05 16:19:43 -08:00
|
|
|
*
|
2013-03-28 11:15:20 -07:00
|
|
|
* 18 cycles on IVB, 16 on HSW
|
|
|
|
|
* (since the last two src operands are in different register banks):
|
2014-03-08 11:07:10 -08:00
|
|
|
* mad(8) g4<1>F g2.2<4,4,1>F.x g2<4,4,1>F.x g3.1<4,4,1>F.x { align16 WE_normal 1Q };
|
2013-03-28 11:15:20 -07:00
|
|
|
* mov(8) null g4<4,5,1>F { align16 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* 20 cycles on IVB, 18 on HSW
|
|
|
|
|
* (since the last two src operands are in the same register bank):
|
2014-03-08 11:07:10 -08:00
|
|
|
* mad(8) g4<1>F g2.2<4,4,1>F.x g2<4,4,1>F.x g2.1<4,4,1>F.x { align16 WE_normal 1Q };
|
2012-12-05 16:19:43 -08:00
|
|
|
* mov(8) null g4<4,4,1>F { align16 WE_normal 1Q };
|
|
|
|
|
*/
|
2013-03-28 11:15:20 -07:00
|
|
|
|
|
|
|
|
/* Our register allocator doesn't know about register banks, so use the
|
|
|
|
|
* higher latency.
|
|
|
|
|
*/
|
|
|
|
|
latency = is_haswell ? 16 : 18;
|
2012-12-05 16:19:43 -08:00
|
|
|
break;
|
|
|
|
|
|
2013-03-28 10:57:34 -07:00
|
|
|
case BRW_OPCODE_LRP:
|
|
|
|
|
/* 2 cycles
|
|
|
|
|
* (since the last two src operands are in different register banks):
|
2014-03-08 11:07:10 -08:00
|
|
|
* lrp(8) g4<1>F g2.2<4,4,1>F.x g2<4,4,1>F.x g3.1<4,4,1>F.x { align16 WE_normal 1Q };
|
2013-03-28 10:57:34 -07:00
|
|
|
*
|
|
|
|
|
* 3 cycles on IVB, 4 on HSW
|
|
|
|
|
* (since the last two src operands are in the same register bank):
|
2014-03-08 11:07:10 -08:00
|
|
|
* lrp(8) g4<1>F g2.2<4,4,1>F.x g2<4,4,1>F.x g2.1<4,4,1>F.x { align16 WE_normal 1Q };
|
2013-03-28 10:57:34 -07:00
|
|
|
*
|
|
|
|
|
* 16 cycles on IVB, 14 on HSW
|
|
|
|
|
* (since the last two src operands are in different register banks):
|
2014-03-08 11:07:10 -08:00
|
|
|
* lrp(8) g4<1>F g2.2<4,4,1>F.x g2<4,4,1>F.x g3.1<4,4,1>F.x { align16 WE_normal 1Q };
|
2013-03-28 10:57:34 -07:00
|
|
|
* mov(8) null g4<4,4,1>F { align16 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* 16 cycles
|
|
|
|
|
* (since the last two src operands are in the same register bank):
|
2014-03-08 11:07:10 -08:00
|
|
|
* lrp(8) g4<1>F g2.2<4,4,1>F.x g2<4,4,1>F.x g2.1<4,4,1>F.x { align16 WE_normal 1Q };
|
2013-03-28 10:57:34 -07:00
|
|
|
* mov(8) null g4<4,4,1>F { align16 WE_normal 1Q };
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
/* Our register allocator doesn't know about register banks, so use the
|
|
|
|
|
* higher latency.
|
|
|
|
|
*/
|
|
|
|
|
latency = 14;
|
|
|
|
|
break;
|
|
|
|
|
|
2012-12-05 16:19:43 -08:00
|
|
|
case SHADER_OPCODE_RCP:
|
|
|
|
|
case SHADER_OPCODE_RSQ:
|
|
|
|
|
case SHADER_OPCODE_SQRT:
|
|
|
|
|
case SHADER_OPCODE_LOG2:
|
|
|
|
|
case SHADER_OPCODE_EXP2:
|
|
|
|
|
case SHADER_OPCODE_SIN:
|
|
|
|
|
case SHADER_OPCODE_COS:
|
|
|
|
|
/* 2 cycles:
|
|
|
|
|
* math inv(8) g4<1>F g2<0,1,0>F null { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* 18 cycles:
|
|
|
|
|
* math inv(8) g4<1>F g2<0,1,0>F null { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) null g4<8,8,1>F { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* Same for exp2, log2, rsq, sqrt, sin, cos.
|
|
|
|
|
*/
|
2013-02-28 16:42:51 -08:00
|
|
|
latency = is_haswell ? 14 : 16;
|
2012-12-05 16:19:43 -08:00
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case SHADER_OPCODE_POW:
|
|
|
|
|
/* 2 cycles:
|
|
|
|
|
* math pow(8) g4<1>F g2<0,1,0>F g2.1<0,1,0>F { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* 26 cycles:
|
|
|
|
|
* math pow(8) g4<1>F g2<0,1,0>F g2.1<0,1,0>F { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) null g4<8,8,1>F { align1 WE_normal 1Q };
|
|
|
|
|
*/
|
2013-02-28 16:42:51 -08:00
|
|
|
latency = is_haswell ? 22 : 24;
|
2012-12-05 16:19:43 -08:00
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case SHADER_OPCODE_TEX:
|
|
|
|
|
case SHADER_OPCODE_TXD:
|
|
|
|
|
case SHADER_OPCODE_TXF:
|
2016-05-04 15:46:45 -07:00
|
|
|
case SHADER_OPCODE_TXF_LZ:
|
2012-12-05 16:19:43 -08:00
|
|
|
case SHADER_OPCODE_TXL:
|
2016-05-04 15:46:45 -07:00
|
|
|
case SHADER_OPCODE_TXL_LZ:
|
2012-12-05 16:19:43 -08:00
|
|
|
/* 18 cycles:
|
|
|
|
|
* mov(8) g115<1>F 0F { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) g114<1>F 0F { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>UW g114<8,8,1>F
|
|
|
|
|
* sampler (10, 0, 0, 1) mlen 2 rlen 4 { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* 697 +/-49 cycles (min 610, n=26):
|
|
|
|
|
* mov(8) g115<1>F 0F { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) g114<1>F 0F { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>UW g114<8,8,1>F
|
|
|
|
|
* sampler (10, 0, 0, 1) mlen 2 rlen 4 { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) null g4<8,8,1>F { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* So the latency on our first texture load of the batchbuffer takes
|
|
|
|
|
* ~700 cycles, since the caches are cold at that point.
|
|
|
|
|
*
|
|
|
|
|
* 840 +/- 92 cycles (min 720, n=25):
|
|
|
|
|
* mov(8) g115<1>F 0F { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) g114<1>F 0F { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>UW g114<8,8,1>F
|
|
|
|
|
* sampler (10, 0, 0, 1) mlen 2 rlen 4 { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) null g4<8,8,1>F { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>UW g114<8,8,1>F
|
|
|
|
|
* sampler (10, 0, 0, 1) mlen 2 rlen 4 { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) null g4<8,8,1>F { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* On the second load, it takes just an extra ~140 cycles, and after
|
|
|
|
|
* accounting for the 14 cycles of the MOV's latency, that makes ~130.
|
|
|
|
|
*
|
|
|
|
|
* 683 +/- 49 cycles (min = 602, n=47):
|
|
|
|
|
* mov(8) g115<1>F 0F { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) g114<1>F 0F { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>UW g114<8,8,1>F
|
|
|
|
|
* sampler (10, 0, 0, 1) mlen 2 rlen 4 { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g50<1>UW g114<8,8,1>F
|
|
|
|
|
* sampler (10, 0, 0, 1) mlen 2 rlen 4 { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) null g4<8,8,1>F { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* The unit appears to be pipelined, since this matches up with the
|
|
|
|
|
* cache-cold case, despite there being two loads here. If you replace
|
|
|
|
|
* the g4 in the MOV to null with g50, it's still 693 +/- 52 (n=39).
|
|
|
|
|
*
|
|
|
|
|
* So, take some number between the cache-hot 140 cycles and the
|
|
|
|
|
* cache-cold 700 cycles. No particular tuning was done on this.
|
|
|
|
|
*
|
|
|
|
|
* I haven't done significant testing of the non-TEX opcodes. TXL at
|
|
|
|
|
* least looked about the same as TEX.
|
|
|
|
|
*/
|
|
|
|
|
latency = 200;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case SHADER_OPCODE_TXS:
|
|
|
|
|
/* Testing textureSize(sampler2D, 0), one load was 420 +/- 41
|
|
|
|
|
* cycles (n=15):
|
|
|
|
|
* mov(8) g114<1>UD 0D { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g6<1>UW g114<8,8,1>F
|
|
|
|
|
* sampler (10, 0, 10, 1) mlen 1 rlen 4 { align1 WE_normal 1Q };
|
|
|
|
|
* mov(16) g6<1>F g6<8,8,1>D { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
*
|
|
|
|
|
* Two loads was 535 +/- 30 cycles (n=19):
|
|
|
|
|
* mov(16) g114<1>UD 0D { align1 WE_normal 1H };
|
|
|
|
|
* send(16) g6<1>UW g114<8,8,1>F
|
|
|
|
|
* sampler (10, 0, 10, 2) mlen 2 rlen 8 { align1 WE_normal 1H };
|
|
|
|
|
* mov(16) g114<1>UD 0D { align1 WE_normal 1H };
|
|
|
|
|
* mov(16) g6<1>F g6<8,8,1>D { align1 WE_normal 1H };
|
|
|
|
|
* send(16) g8<1>UW g114<8,8,1>F
|
|
|
|
|
* sampler (10, 0, 10, 2) mlen 2 rlen 8 { align1 WE_normal 1H };
|
|
|
|
|
* mov(16) g8<1>F g8<8,8,1>D { align1 WE_normal 1H };
|
|
|
|
|
* add(16) g6<1>F g6<8,8,1>F g8<8,8,1>F { align1 WE_normal 1H };
|
|
|
|
|
*
|
|
|
|
|
* Since the only caches that should matter are just the
|
|
|
|
|
* instruction/state cache containing the surface state, assume that we
|
|
|
|
|
* always have hot caches.
|
|
|
|
|
*/
|
|
|
|
|
latency = 100;
|
|
|
|
|
break;
|
|
|
|
|
|
2016-05-20 13:03:31 -07:00
|
|
|
case FS_OPCODE_VARYING_PULL_CONSTANT_LOAD_GEN4:
|
2016-05-17 23:52:15 -07:00
|
|
|
case FS_OPCODE_VARYING_PULL_CONSTANT_LOAD_GEN7:
|
2012-12-05 16:19:43 -08:00
|
|
|
case FS_OPCODE_UNIFORM_PULL_CONSTANT_LOAD:
|
2016-05-17 23:52:15 -07:00
|
|
|
case FS_OPCODE_UNIFORM_PULL_CONSTANT_LOAD_GEN7:
|
2012-11-30 16:13:34 -08:00
|
|
|
case VS_OPCODE_PULL_CONSTANT_LOAD:
|
2012-12-05 16:19:43 -08:00
|
|
|
/* testing using varying-index pull constants:
|
|
|
|
|
*
|
|
|
|
|
* 16 cycles:
|
|
|
|
|
* mov(8) g4<1>D g2.1<0,1,0>F { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>F g4<8,8,1>D
|
|
|
|
|
* data (9, 2, 3) mlen 1 rlen 1 { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* ~480 cycles:
|
|
|
|
|
* mov(8) g4<1>D g2.1<0,1,0>F { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>F g4<8,8,1>D
|
|
|
|
|
* data (9, 2, 3) mlen 1 rlen 1 { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) null g4<8,8,1>F { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* ~620 cycles:
|
|
|
|
|
* mov(8) g4<1>D g2.1<0,1,0>F { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>F g4<8,8,1>D
|
|
|
|
|
* data (9, 2, 3) mlen 1 rlen 1 { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) null g4<8,8,1>F { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>F g4<8,8,1>D
|
|
|
|
|
* data (9, 2, 3) mlen 1 rlen 1 { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) null g4<8,8,1>F { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* So, if it's cache-hot, it's about 140. If it's cache cold, it's
|
|
|
|
|
* about 460. We expect to mostly be cache hot, so pick something more
|
|
|
|
|
* in that direction.
|
|
|
|
|
*/
|
|
|
|
|
latency = 200;
|
|
|
|
|
break;
|
|
|
|
|
|
2013-10-16 11:51:22 -07:00
|
|
|
case SHADER_OPCODE_GEN7_SCRATCH_READ:
|
|
|
|
|
/* Testing a load from offset 0, that had been previously written:
|
|
|
|
|
*
|
|
|
|
|
* send(8) g114<1>UW g0<8,8,1>F data (0, 0, 0) mlen 1 rlen 1 { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) null g114<8,8,1>F { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* The cycles spent seemed to be grouped around 40-50 (as low as 38),
|
|
|
|
|
* then around 140. Presumably this is cache hit vs miss.
|
|
|
|
|
*/
|
|
|
|
|
latency = 50;
|
2013-11-14 22:47:33 -08:00
|
|
|
break;
|
|
|
|
|
|
2013-11-01 11:29:13 -07:00
|
|
|
case SHADER_OPCODE_UNTYPED_ATOMIC:
|
2018-04-18 14:02:33 -07:00
|
|
|
case SHADER_OPCODE_UNTYPED_ATOMIC_FLOAT:
|
2015-04-23 14:28:25 +03:00
|
|
|
case SHADER_OPCODE_TYPED_ATOMIC:
|
2013-11-01 11:29:13 -07:00
|
|
|
/* Test code:
|
|
|
|
|
* mov(8) g112<1>ud 0x00000000ud { align1 WE_all 1Q };
|
|
|
|
|
* mov(1) g112.7<1>ud g1.7<0,1,0>ud { align1 WE_all };
|
|
|
|
|
* mov(8) g113<1>ud 0x00000000ud { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>ud g112<8,8,1>ud
|
|
|
|
|
* data (38, 5, 6) mlen 2 rlen 1 { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* Running it 100 times as fragment shader on a 128x128 quad
|
|
|
|
|
* gives an average latency of 13867 cycles per atomic op,
|
|
|
|
|
* standard deviation 3%. Note that this is a rather
|
|
|
|
|
* pessimistic estimate, the actual latency in cases with few
|
|
|
|
|
* collisions between threads and favorable pipelining has been
|
|
|
|
|
* seen to be reduced by a factor of 100.
|
|
|
|
|
*/
|
|
|
|
|
latency = 14000;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case SHADER_OPCODE_UNTYPED_SURFACE_READ:
|
2015-04-23 14:24:14 +03:00
|
|
|
case SHADER_OPCODE_UNTYPED_SURFACE_WRITE:
|
2015-04-23 14:28:25 +03:00
|
|
|
case SHADER_OPCODE_TYPED_SURFACE_READ:
|
|
|
|
|
case SHADER_OPCODE_TYPED_SURFACE_WRITE:
|
2013-11-01 11:29:13 -07:00
|
|
|
/* Test code:
|
|
|
|
|
* mov(8) g112<1>UD 0x00000000UD { align1 WE_all 1Q };
|
|
|
|
|
* mov(1) g112.7<1>UD g1.7<0,1,0>UD { align1 WE_all };
|
|
|
|
|
* mov(8) g113<1>UD 0x00000000UD { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>UD g112<8,8,1>UD
|
|
|
|
|
* data (38, 6, 5) mlen 2 rlen 1 { align1 WE_normal 1Q };
|
|
|
|
|
* .
|
|
|
|
|
* . [repeats 8 times]
|
|
|
|
|
* .
|
|
|
|
|
* mov(8) g112<1>UD 0x00000000UD { align1 WE_all 1Q };
|
|
|
|
|
* mov(1) g112.7<1>UD g1.7<0,1,0>UD { align1 WE_all };
|
|
|
|
|
* mov(8) g113<1>UD 0x00000000UD { align1 WE_normal 1Q };
|
|
|
|
|
* send(8) g4<1>UD g112<8,8,1>UD
|
|
|
|
|
* data (38, 6, 5) mlen 2 rlen 1 { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* Running it 100 times as fragment shader on a 128x128 quad
|
|
|
|
|
* gives an average latency of 583 cycles per surface read,
|
|
|
|
|
* standard deviation 0.9%.
|
|
|
|
|
*/
|
|
|
|
|
latency = is_haswell ? 300 : 600;
|
2013-10-16 11:51:22 -07:00
|
|
|
break;
|
|
|
|
|
|
2018-10-29 15:06:14 -05:00
|
|
|
case SHADER_OPCODE_SEND:
|
|
|
|
|
switch (inst->sfid) {
|
2018-10-30 12:23:44 -05:00
|
|
|
case GEN6_SFID_DATAPORT_RENDER_CACHE:
|
|
|
|
|
switch ((inst->desc >> 14) & 0x1f) {
|
|
|
|
|
case GEN7_DATAPORT_RC_TYPED_SURFACE_WRITE:
|
|
|
|
|
case GEN7_DATAPORT_RC_TYPED_SURFACE_READ:
|
|
|
|
|
/* See also SHADER_OPCODE_TYPED_SURFACE_READ */
|
|
|
|
|
assert(!is_haswell);
|
|
|
|
|
latency = 600;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case GEN7_DATAPORT_RC_TYPED_ATOMIC_OP:
|
|
|
|
|
/* See also SHADER_OPCODE_TYPED_ATOMIC */
|
|
|
|
|
assert(!is_haswell);
|
|
|
|
|
latency = 14000;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
default:
|
|
|
|
|
unreachable("Unknown render cache message");
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case GEN7_SFID_DATAPORT_DATA_CACHE:
|
|
|
|
|
switch ((inst->desc >> 14) & 0x1f) {
|
|
|
|
|
case HSW_DATAPORT_DC_PORT0_BYTE_SCATTERED_READ:
|
|
|
|
|
case HSW_DATAPORT_DC_PORT0_BYTE_SCATTERED_WRITE:
|
|
|
|
|
/* We have no data for this but assume it's roughly the same as
|
|
|
|
|
* untyped surface read/write.
|
|
|
|
|
*/
|
|
|
|
|
latency = 300;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case GEN7_DATAPORT_DC_UNTYPED_SURFACE_READ:
|
|
|
|
|
case GEN7_DATAPORT_DC_UNTYPED_SURFACE_WRITE:
|
|
|
|
|
/* See also SHADER_OPCODE_UNTYPED_SURFACE_READ */
|
|
|
|
|
assert(!is_haswell);
|
|
|
|
|
latency = 600;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case GEN7_DATAPORT_DC_UNTYPED_ATOMIC_OP:
|
|
|
|
|
/* See also SHADER_OPCODE_UNTYPED_ATOMIC */
|
|
|
|
|
assert(!is_haswell);
|
|
|
|
|
latency = 14000;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
default:
|
|
|
|
|
unreachable("Unknown data cache message");
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case HSW_SFID_DATAPORT_DATA_CACHE_1:
|
|
|
|
|
switch ((inst->desc >> 14) & 0x1f) {
|
|
|
|
|
case HSW_DATAPORT_DC_PORT1_UNTYPED_SURFACE_READ:
|
|
|
|
|
case HSW_DATAPORT_DC_PORT1_UNTYPED_SURFACE_WRITE:
|
|
|
|
|
case HSW_DATAPORT_DC_PORT1_TYPED_SURFACE_READ:
|
|
|
|
|
case HSW_DATAPORT_DC_PORT1_TYPED_SURFACE_WRITE:
|
|
|
|
|
/* See also SHADER_OPCODE_UNTYPED_SURFACE_READ */
|
|
|
|
|
latency = 300;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case HSW_DATAPORT_DC_PORT1_UNTYPED_ATOMIC_OP:
|
|
|
|
|
case HSW_DATAPORT_DC_PORT1_UNTYPED_ATOMIC_OP_SIMD4X2:
|
|
|
|
|
case HSW_DATAPORT_DC_PORT1_TYPED_ATOMIC_OP_SIMD4X2:
|
|
|
|
|
case HSW_DATAPORT_DC_PORT1_TYPED_ATOMIC_OP:
|
|
|
|
|
case GEN9_DATAPORT_DC_PORT1_UNTYPED_ATOMIC_FLOAT_OP:
|
|
|
|
|
/* See also SHADER_OPCODE_UNTYPED_ATOMIC */
|
|
|
|
|
latency = 14000;
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
default:
|
|
|
|
|
unreachable("Unknown data cache message");
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
|
2018-10-29 15:06:14 -05:00
|
|
|
default:
|
|
|
|
|
unreachable("Unknown SFID");
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
|
2012-12-05 16:19:43 -08:00
|
|
|
default:
|
|
|
|
|
/* 2 cycles:
|
|
|
|
|
* mul(8) g4<1>F g2<0,1,0>F 0.5F { align1 WE_normal 1Q };
|
|
|
|
|
*
|
|
|
|
|
* 16 cycles:
|
|
|
|
|
* mul(8) g4<1>F g2<0,1,0>F 0.5F { align1 WE_normal 1Q };
|
|
|
|
|
* mov(8) null g4<8,8,1>F { align1 WE_normal 1Q };
|
|
|
|
|
*/
|
|
|
|
|
latency = 14;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
class instruction_scheduler {
|
|
|
|
|
public:
|
2015-05-20 09:44:01 -07:00
|
|
|
instruction_scheduler(backend_shader *s, int grf_count,
|
2018-12-10 14:49:49 -08:00
|
|
|
unsigned hw_reg_count, int block_count,
|
2013-11-06 17:38:23 -08:00
|
|
|
instruction_scheduler_mode mode)
|
2011-01-18 17:16:49 -08:00
|
|
|
{
|
2015-05-20 09:44:01 -07:00
|
|
|
this->bs = s;
|
2013-10-23 11:16:26 -07:00
|
|
|
this->mem_ctx = ralloc_context(NULL);
|
2012-12-03 17:58:03 -08:00
|
|
|
this->grf_count = grf_count;
|
2015-06-09 10:26:53 -07:00
|
|
|
this->hw_reg_count = hw_reg_count;
|
2011-01-18 17:16:49 -08:00
|
|
|
this->instructions.make_empty();
|
|
|
|
|
this->instructions_to_schedule = 0;
|
2013-11-06 17:38:23 -08:00
|
|
|
this->post_reg_alloc = (mode == SCHEDULE_POST);
|
|
|
|
|
this->mode = mode;
|
2013-10-14 11:38:09 -07:00
|
|
|
if (!post_reg_alloc) {
|
2015-06-09 10:26:53 -07:00
|
|
|
this->reg_pressure_in = rzalloc_array(mem_ctx, int, block_count);
|
|
|
|
|
|
|
|
|
|
this->livein = ralloc_array(mem_ctx, BITSET_WORD *, block_count);
|
|
|
|
|
for (int i = 0; i < block_count; i++)
|
|
|
|
|
this->livein[i] = rzalloc_array(mem_ctx, BITSET_WORD,
|
|
|
|
|
BITSET_WORDS(grf_count));
|
|
|
|
|
|
|
|
|
|
this->liveout = ralloc_array(mem_ctx, BITSET_WORD *, block_count);
|
|
|
|
|
for (int i = 0; i < block_count; i++)
|
|
|
|
|
this->liveout[i] = rzalloc_array(mem_ctx, BITSET_WORD,
|
|
|
|
|
BITSET_WORDS(grf_count));
|
|
|
|
|
|
|
|
|
|
this->hw_liveout = ralloc_array(mem_ctx, BITSET_WORD *, block_count);
|
|
|
|
|
for (int i = 0; i < block_count; i++)
|
|
|
|
|
this->hw_liveout[i] = rzalloc_array(mem_ctx, BITSET_WORD,
|
|
|
|
|
BITSET_WORDS(hw_reg_count));
|
|
|
|
|
|
|
|
|
|
this->written = rzalloc_array(mem_ctx, bool, grf_count);
|
|
|
|
|
|
|
|
|
|
this->reads_remaining = rzalloc_array(mem_ctx, int, grf_count);
|
|
|
|
|
|
|
|
|
|
this->hw_reads_remaining = rzalloc_array(mem_ctx, int, hw_reg_count);
|
2013-10-14 11:38:09 -07:00
|
|
|
} else {
|
2015-06-09 10:26:53 -07:00
|
|
|
this->reg_pressure_in = NULL;
|
|
|
|
|
this->livein = NULL;
|
|
|
|
|
this->liveout = NULL;
|
|
|
|
|
this->hw_liveout = NULL;
|
|
|
|
|
this->written = NULL;
|
|
|
|
|
this->reads_remaining = NULL;
|
|
|
|
|
this->hw_reads_remaining = NULL;
|
2013-10-14 11:38:09 -07:00
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
~instruction_scheduler()
|
|
|
|
|
{
|
2011-01-21 14:32:31 -08:00
|
|
|
ralloc_free(this->mem_ctx);
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
void add_barrier_deps(schedule_node *n);
|
|
|
|
|
void add_dep(schedule_node *before, schedule_node *after, int latency);
|
2011-05-20 14:13:59 -07:00
|
|
|
void add_dep(schedule_node *before, schedule_node *after);
|
2011-01-18 17:16:49 -08:00
|
|
|
|
2014-08-31 21:19:47 -07:00
|
|
|
void run(cfg_t *cfg);
|
|
|
|
|
void add_insts_from_block(bblock_t *block);
|
2016-08-16 00:01:31 -07:00
|
|
|
void compute_delays();
|
2016-08-16 00:56:04 -07:00
|
|
|
void compute_exits();
|
2013-04-29 14:05:33 -07:00
|
|
|
virtual void calculate_deps() = 0;
|
|
|
|
|
virtual schedule_node *choose_instruction_to_schedule() = 0;
|
2013-04-29 16:45:10 -07:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Returns how many cycles it takes the instruction to issue.
|
|
|
|
|
*
|
|
|
|
|
* Instructions in gen hardware are handled one simd4 vector at a time,
|
2013-11-12 15:33:27 -08:00
|
|
|
* with 1 cycle per vector dispatched. Thus SIMD8 pixel shaders take 2
|
|
|
|
|
* cycles to dispatch and SIMD16 (compressed) instructions take 4.
|
2013-04-29 16:45:10 -07:00
|
|
|
*/
|
2013-04-29 14:05:33 -07:00
|
|
|
virtual int issue_time(backend_instruction *inst) = 0;
|
2013-04-29 16:45:10 -07:00
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
virtual void count_reads_remaining(backend_instruction *inst) = 0;
|
|
|
|
|
virtual void setup_liveness(cfg_t *cfg) = 0;
|
2013-10-14 11:38:09 -07:00
|
|
|
virtual void update_register_pressure(backend_instruction *inst) = 0;
|
|
|
|
|
virtual int get_register_pressure_benefit(backend_instruction *inst) = 0;
|
|
|
|
|
|
2014-08-31 21:19:47 -07:00
|
|
|
void schedule_instructions(bblock_t *block);
|
2011-03-23 13:53:26 -07:00
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
void *mem_ctx;
|
|
|
|
|
|
2012-12-03 17:58:03 -08:00
|
|
|
bool post_reg_alloc;
|
2011-01-18 17:16:49 -08:00
|
|
|
int instructions_to_schedule;
|
2012-12-03 17:58:03 -08:00
|
|
|
int grf_count;
|
2018-12-10 14:49:49 -08:00
|
|
|
unsigned hw_reg_count;
|
2015-06-09 10:26:53 -07:00
|
|
|
int reg_pressure;
|
|
|
|
|
int block_idx;
|
2011-01-18 17:16:49 -08:00
|
|
|
exec_list instructions;
|
2015-05-20 09:44:01 -07:00
|
|
|
backend_shader *bs;
|
2013-10-14 11:38:09 -07:00
|
|
|
|
2013-11-06 17:38:23 -08:00
|
|
|
instruction_scheduler_mode mode;
|
|
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
/*
|
|
|
|
|
* The register pressure at the beginning of each basic block.
|
2013-10-14 11:38:09 -07:00
|
|
|
*/
|
|
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
int *reg_pressure_in;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* The virtual GRF's whose range overlaps the beginning of each basic block.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
BITSET_WORD **livein;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* The virtual GRF's whose range overlaps the end of each basic block.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
BITSET_WORD **liveout;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* The hardware GRF's whose range overlaps the end of each basic block.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
BITSET_WORD **hw_liveout;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Whether we've scheduled a write for this virtual GRF yet.
|
2013-10-14 11:38:09 -07:00
|
|
|
*/
|
2015-06-09 10:26:53 -07:00
|
|
|
|
|
|
|
|
bool *written;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* How many reads we haven't scheduled for this virtual GRF yet.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
int *reads_remaining;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* How many reads we haven't scheduled for this hardware GRF yet.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
int *hw_reads_remaining;
|
2013-04-29 14:05:33 -07:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
class fs_instruction_scheduler : public instruction_scheduler
|
|
|
|
|
{
|
|
|
|
|
public:
|
2015-06-09 10:26:53 -07:00
|
|
|
fs_instruction_scheduler(fs_visitor *v, int grf_count, int hw_reg_count,
|
|
|
|
|
int block_count,
|
2013-11-06 17:38:23 -08:00
|
|
|
instruction_scheduler_mode mode);
|
2013-04-29 14:05:33 -07:00
|
|
|
void calculate_deps();
|
|
|
|
|
bool is_compressed(fs_inst *inst);
|
|
|
|
|
schedule_node *choose_instruction_to_schedule();
|
|
|
|
|
int issue_time(backend_instruction *inst);
|
2011-01-18 17:16:49 -08:00
|
|
|
fs_visitor *v;
|
2013-10-14 11:38:09 -07:00
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
void count_reads_remaining(backend_instruction *inst);
|
|
|
|
|
void setup_liveness(cfg_t *cfg);
|
2013-10-14 11:38:09 -07:00
|
|
|
void update_register_pressure(backend_instruction *inst);
|
|
|
|
|
int get_register_pressure_benefit(backend_instruction *inst);
|
2011-01-18 17:16:49 -08:00
|
|
|
};
|
|
|
|
|
|
2013-04-29 14:05:33 -07:00
|
|
|
fs_instruction_scheduler::fs_instruction_scheduler(fs_visitor *v,
|
2015-06-09 10:26:53 -07:00
|
|
|
int grf_count, int hw_reg_count,
|
|
|
|
|
int block_count,
|
2013-11-06 17:38:23 -08:00
|
|
|
instruction_scheduler_mode mode)
|
2015-06-09 10:26:53 -07:00
|
|
|
: instruction_scheduler(v, grf_count, hw_reg_count, block_count, mode),
|
2013-04-29 14:05:33 -07:00
|
|
|
v(v)
|
|
|
|
|
{
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
static bool
|
|
|
|
|
is_src_duplicate(fs_inst *inst, int src)
|
|
|
|
|
{
|
|
|
|
|
for (int i = 0; i < src; i++)
|
|
|
|
|
if (inst->src[i].equals(inst->src[src]))
|
|
|
|
|
return true;
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
2013-10-14 11:38:09 -07:00
|
|
|
void
|
2015-06-09 10:26:53 -07:00
|
|
|
fs_instruction_scheduler::count_reads_remaining(backend_instruction *be)
|
2013-10-14 11:38:09 -07:00
|
|
|
{
|
|
|
|
|
fs_inst *inst = (fs_inst *)be;
|
|
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
if (!reads_remaining)
|
2013-10-14 11:38:09 -07:00
|
|
|
return;
|
|
|
|
|
|
2014-03-17 10:39:43 -07:00
|
|
|
for (int i = 0; i < inst->sources; i++) {
|
2015-06-09 10:26:53 -07:00
|
|
|
if (is_src_duplicate(inst, i))
|
|
|
|
|
continue;
|
|
|
|
|
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->src[i].file == VGRF) {
|
2015-10-26 04:35:14 -07:00
|
|
|
reads_remaining[inst->src[i].nr]++;
|
2015-10-26 17:52:57 -07:00
|
|
|
} else if (inst->src[i].file == FIXED_GRF) {
|
2015-10-24 15:29:03 -07:00
|
|
|
if (inst->src[i].nr >= hw_reg_count)
|
2015-06-09 10:26:53 -07:00
|
|
|
continue;
|
|
|
|
|
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned j = 0; j < regs_read(inst, i); j++)
|
2015-10-24 15:29:03 -07:00
|
|
|
hw_reads_remaining[inst->src[i].nr + j]++;
|
2015-06-09 10:26:53 -07:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
fs_instruction_scheduler::setup_liveness(cfg_t *cfg)
|
|
|
|
|
{
|
|
|
|
|
/* First, compute liveness on a per-GRF level using the in/out sets from
|
|
|
|
|
* liveness calculation.
|
|
|
|
|
*/
|
|
|
|
|
for (int block = 0; block < cfg->num_blocks; block++) {
|
|
|
|
|
for (int i = 0; i < v->live_intervals->num_vars; i++) {
|
|
|
|
|
if (BITSET_TEST(v->live_intervals->block_data[block].livein, i)) {
|
|
|
|
|
int vgrf = v->live_intervals->vgrf_from_var[i];
|
|
|
|
|
if (!BITSET_TEST(livein[block], vgrf)) {
|
|
|
|
|
reg_pressure_in[block] += v->alloc.sizes[vgrf];
|
|
|
|
|
BITSET_SET(livein[block], vgrf);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (BITSET_TEST(v->live_intervals->block_data[block].liveout, i))
|
|
|
|
|
BITSET_SET(liveout[block], v->live_intervals->vgrf_from_var[i]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Now, extend the live in/live out sets for when a range crosses a block
|
|
|
|
|
* boundary, which matches what our register allocator/interference code
|
|
|
|
|
* does to account for force_writemask_all and incompatible exec_mask's.
|
|
|
|
|
*/
|
|
|
|
|
for (int block = 0; block < cfg->num_blocks - 1; block++) {
|
|
|
|
|
for (int i = 0; i < grf_count; i++) {
|
|
|
|
|
if (v->virtual_grf_start[i] <= cfg->blocks[block]->end_ip &&
|
|
|
|
|
v->virtual_grf_end[i] >= cfg->blocks[block + 1]->start_ip) {
|
|
|
|
|
if (!BITSET_TEST(livein[block + 1], i)) {
|
|
|
|
|
reg_pressure_in[block + 1] += v->alloc.sizes[i];
|
|
|
|
|
BITSET_SET(livein[block + 1], i);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
BITSET_SET(liveout[block], i);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
int payload_last_use_ip[hw_reg_count];
|
|
|
|
|
v->calculate_payload_ranges(hw_reg_count, payload_last_use_ip);
|
|
|
|
|
|
2018-12-10 14:49:49 -08:00
|
|
|
for (unsigned i = 0; i < hw_reg_count; i++) {
|
2015-06-09 10:26:53 -07:00
|
|
|
if (payload_last_use_ip[i] == -1)
|
2013-10-14 11:38:09 -07:00
|
|
|
continue;
|
|
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
for (int block = 0; block < cfg->num_blocks; block++) {
|
|
|
|
|
if (cfg->blocks[block]->start_ip <= payload_last_use_ip[i])
|
|
|
|
|
reg_pressure_in[block]++;
|
|
|
|
|
|
|
|
|
|
if (cfg->blocks[block]->end_ip <= payload_last_use_ip[i])
|
|
|
|
|
BITSET_SET(hw_liveout[block], i);
|
|
|
|
|
}
|
2013-10-14 11:38:09 -07:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
fs_instruction_scheduler::update_register_pressure(backend_instruction *be)
|
|
|
|
|
{
|
|
|
|
|
fs_inst *inst = (fs_inst *)be;
|
|
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
if (!reads_remaining)
|
2013-10-14 11:38:09 -07:00
|
|
|
return;
|
|
|
|
|
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->dst.file == VGRF) {
|
2015-10-26 04:35:14 -07:00
|
|
|
written[inst->dst.nr] = true;
|
2013-10-14 11:38:09 -07:00
|
|
|
}
|
|
|
|
|
|
2014-03-17 10:39:43 -07:00
|
|
|
for (int i = 0; i < inst->sources; i++) {
|
2015-06-09 10:26:53 -07:00
|
|
|
if (is_src_duplicate(inst, i))
|
|
|
|
|
continue;
|
|
|
|
|
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->src[i].file == VGRF) {
|
2015-10-26 04:35:14 -07:00
|
|
|
reads_remaining[inst->src[i].nr]--;
|
2015-10-26 17:52:57 -07:00
|
|
|
} else if (inst->src[i].file == FIXED_GRF &&
|
2015-10-24 15:29:03 -07:00
|
|
|
inst->src[i].nr < hw_reg_count) {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned off = 0; off < regs_read(inst, i); off++)
|
2015-10-24 15:29:03 -07:00
|
|
|
hw_reads_remaining[inst->src[i].nr + off]--;
|
2013-10-14 11:38:09 -07:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
int
|
|
|
|
|
fs_instruction_scheduler::get_register_pressure_benefit(backend_instruction *be)
|
|
|
|
|
{
|
|
|
|
|
fs_inst *inst = (fs_inst *)be;
|
|
|
|
|
int benefit = 0;
|
|
|
|
|
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->dst.file == VGRF) {
|
2015-10-26 04:35:14 -07:00
|
|
|
if (!BITSET_TEST(livein[block_idx], inst->dst.nr) &&
|
|
|
|
|
!written[inst->dst.nr])
|
|
|
|
|
benefit -= v->alloc.sizes[inst->dst.nr];
|
2013-10-14 11:38:09 -07:00
|
|
|
}
|
|
|
|
|
|
2014-03-17 10:39:43 -07:00
|
|
|
for (int i = 0; i < inst->sources; i++) {
|
2015-06-09 10:26:53 -07:00
|
|
|
if (is_src_duplicate(inst, i))
|
2013-10-14 11:38:09 -07:00
|
|
|
continue;
|
|
|
|
|
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->src[i].file == VGRF &&
|
2015-10-26 04:35:14 -07:00
|
|
|
!BITSET_TEST(liveout[block_idx], inst->src[i].nr) &&
|
|
|
|
|
reads_remaining[inst->src[i].nr] == 1)
|
|
|
|
|
benefit += v->alloc.sizes[inst->src[i].nr];
|
2015-06-09 10:26:53 -07:00
|
|
|
|
2015-10-26 17:52:57 -07:00
|
|
|
if (inst->src[i].file == FIXED_GRF &&
|
2015-10-24 15:29:03 -07:00
|
|
|
inst->src[i].nr < hw_reg_count) {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned off = 0; off < regs_read(inst, i); off++) {
|
2015-10-24 15:29:03 -07:00
|
|
|
int reg = inst->src[i].nr + off;
|
2015-06-09 10:26:53 -07:00
|
|
|
if (!BITSET_TEST(hw_liveout[block_idx], reg) &&
|
|
|
|
|
hw_reads_remaining[reg] == 1) {
|
|
|
|
|
benefit++;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2013-10-14 11:38:09 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return benefit;
|
|
|
|
|
}
|
|
|
|
|
|
2012-11-30 16:13:34 -08:00
|
|
|
class vec4_instruction_scheduler : public instruction_scheduler
|
|
|
|
|
{
|
|
|
|
|
public:
|
|
|
|
|
vec4_instruction_scheduler(vec4_visitor *v, int grf_count);
|
|
|
|
|
void calculate_deps();
|
|
|
|
|
schedule_node *choose_instruction_to_schedule();
|
|
|
|
|
int issue_time(backend_instruction *inst);
|
|
|
|
|
vec4_visitor *v;
|
2013-10-14 11:38:09 -07:00
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
void count_reads_remaining(backend_instruction *inst);
|
|
|
|
|
void setup_liveness(cfg_t *cfg);
|
2013-10-14 11:38:09 -07:00
|
|
|
void update_register_pressure(backend_instruction *inst);
|
|
|
|
|
int get_register_pressure_benefit(backend_instruction *inst);
|
2012-11-30 16:13:34 -08:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
vec4_instruction_scheduler::vec4_instruction_scheduler(vec4_visitor *v,
|
|
|
|
|
int grf_count)
|
2015-06-09 10:26:53 -07:00
|
|
|
: instruction_scheduler(v, grf_count, 0, 0, SCHEDULE_POST),
|
2012-11-30 16:13:34 -08:00
|
|
|
v(v)
|
|
|
|
|
{
|
|
|
|
|
}
|
|
|
|
|
|
2013-10-14 11:38:09 -07:00
|
|
|
void
|
2018-03-28 16:45:01 -07:00
|
|
|
vec4_instruction_scheduler::count_reads_remaining(backend_instruction *)
|
2015-06-09 10:26:53 -07:00
|
|
|
{
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
2018-03-28 16:45:01 -07:00
|
|
|
vec4_instruction_scheduler::setup_liveness(cfg_t *)
|
2013-10-14 11:38:09 -07:00
|
|
|
{
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
2018-03-28 16:45:01 -07:00
|
|
|
vec4_instruction_scheduler::update_register_pressure(backend_instruction *)
|
2013-10-14 11:38:09 -07:00
|
|
|
{
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
int
|
2018-03-28 16:45:01 -07:00
|
|
|
vec4_instruction_scheduler::get_register_pressure_benefit(backend_instruction *)
|
2013-10-14 11:38:09 -07:00
|
|
|
{
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2013-11-05 23:30:33 -08:00
|
|
|
schedule_node::schedule_node(backend_instruction *inst,
|
|
|
|
|
instruction_scheduler *sched)
|
|
|
|
|
{
|
2016-08-22 15:01:08 -07:00
|
|
|
const struct gen_device_info *devinfo = sched->bs->devinfo;
|
2013-11-05 23:30:33 -08:00
|
|
|
|
|
|
|
|
this->inst = inst;
|
|
|
|
|
this->child_array_size = 0;
|
|
|
|
|
this->children = NULL;
|
|
|
|
|
this->child_latency = NULL;
|
|
|
|
|
this->child_count = 0;
|
|
|
|
|
this->parent_count = 0;
|
|
|
|
|
this->unblocked_time = 0;
|
|
|
|
|
this->cand_generation = 0;
|
2013-11-14 22:33:56 -08:00
|
|
|
this->delay = 0;
|
2016-08-16 00:56:04 -07:00
|
|
|
this->exit = NULL;
|
2013-11-05 23:30:33 -08:00
|
|
|
|
|
|
|
|
/* We can't measure Gen6 timings directly but expect them to be much
|
|
|
|
|
* closer to Gen7 than Gen4.
|
|
|
|
|
*/
|
|
|
|
|
if (!sched->post_reg_alloc)
|
|
|
|
|
this->latency = 1;
|
2015-04-17 12:15:58 -07:00
|
|
|
else if (devinfo->gen >= 6)
|
|
|
|
|
set_latency_gen7(devinfo->is_haswell);
|
2013-11-05 23:30:33 -08:00
|
|
|
else
|
|
|
|
|
set_latency_gen4();
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
void
|
2014-08-31 21:19:47 -07:00
|
|
|
instruction_scheduler::add_insts_from_block(bblock_t *block)
|
2011-01-18 17:16:49 -08:00
|
|
|
{
|
2016-02-15 10:43:39 -08:00
|
|
|
foreach_inst_in_block(backend_instruction, inst, block) {
|
2014-08-31 21:19:47 -07:00
|
|
|
schedule_node *n = new(mem_ctx) schedule_node(inst, this);
|
2011-01-18 17:16:49 -08:00
|
|
|
|
2014-08-31 21:19:47 -07:00
|
|
|
instructions.push_tail(n);
|
|
|
|
|
}
|
2016-02-15 10:43:39 -08:00
|
|
|
|
|
|
|
|
this->instructions_to_schedule = block->end_ip - block->start_ip + 1;
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
2016-08-16 00:01:31 -07:00
|
|
|
/** Computation of the delay member of each node. */
|
2013-10-28 00:11:45 -07:00
|
|
|
void
|
2016-08-16 00:01:31 -07:00
|
|
|
instruction_scheduler::compute_delays()
|
2013-10-28 00:11:45 -07:00
|
|
|
{
|
2016-08-16 00:01:31 -07:00
|
|
|
foreach_in_list_reverse(schedule_node, n, &instructions) {
|
|
|
|
|
if (!n->child_count) {
|
|
|
|
|
n->delay = issue_time(n->inst);
|
|
|
|
|
} else {
|
|
|
|
|
for (int i = 0; i < n->child_count; i++) {
|
|
|
|
|
assert(n->children[i]->delay);
|
|
|
|
|
n->delay = MAX2(n->delay, n->latency + n->children[i]->delay);
|
|
|
|
|
}
|
2013-10-28 00:11:45 -07:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-08-16 00:56:04 -07:00
|
|
|
void
|
|
|
|
|
instruction_scheduler::compute_exits()
|
|
|
|
|
{
|
|
|
|
|
/* Calculate a lower bound of the scheduling time of each node in the
|
|
|
|
|
* graph. This is analogous to the node's critical path but calculated
|
|
|
|
|
* from the top instead of from the bottom of the block.
|
|
|
|
|
*/
|
|
|
|
|
foreach_in_list(schedule_node, n, &instructions) {
|
|
|
|
|
for (int i = 0; i < n->child_count; i++) {
|
|
|
|
|
n->children[i]->unblocked_time =
|
|
|
|
|
MAX2(n->children[i]->unblocked_time,
|
|
|
|
|
n->unblocked_time + issue_time(n->inst) + n->child_latency[i]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Calculate the exit of each node by induction based on the exit nodes of
|
|
|
|
|
* its children. The preferred exit of a node is the one among the exit
|
|
|
|
|
* nodes of its children which can be unblocked first according to the
|
|
|
|
|
* optimistic unblocked time estimate calculated above.
|
|
|
|
|
*/
|
|
|
|
|
foreach_in_list_reverse(schedule_node, n, &instructions) {
|
|
|
|
|
n->exit = (n->inst->opcode == FS_OPCODE_DISCARD_JUMP ? n : NULL);
|
|
|
|
|
|
|
|
|
|
for (int i = 0; i < n->child_count; i++) {
|
|
|
|
|
if (exit_unblocked_time(n->children[i]) < exit_unblocked_time(n))
|
|
|
|
|
n->exit = n->children[i]->exit;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
/**
|
|
|
|
|
* Add a dependency between two instruction nodes.
|
|
|
|
|
*
|
|
|
|
|
* The @after node will be scheduled after @before. We will try to
|
|
|
|
|
* schedule it @latency cycles after @before, but no guarantees there.
|
|
|
|
|
*/
|
|
|
|
|
void
|
|
|
|
|
instruction_scheduler::add_dep(schedule_node *before, schedule_node *after,
|
2014-11-12 10:17:36 -08:00
|
|
|
int latency)
|
2011-01-18 17:16:49 -08:00
|
|
|
{
|
|
|
|
|
if (!before || !after)
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
assert(before != after);
|
|
|
|
|
|
|
|
|
|
for (int i = 0; i < before->child_count; i++) {
|
|
|
|
|
if (before->children[i] == after) {
|
2014-11-12 10:17:36 -08:00
|
|
|
before->child_latency[i] = MAX2(before->child_latency[i], latency);
|
|
|
|
|
return;
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (before->child_array_size <= before->child_count) {
|
|
|
|
|
if (before->child_array_size < 16)
|
2014-11-12 10:17:36 -08:00
|
|
|
before->child_array_size = 16;
|
2011-01-18 17:16:49 -08:00
|
|
|
else
|
2014-11-12 10:17:36 -08:00
|
|
|
before->child_array_size *= 2;
|
2011-01-18 17:16:49 -08:00
|
|
|
|
2011-01-21 14:32:31 -08:00
|
|
|
before->children = reralloc(mem_ctx, before->children,
|
2014-11-12 10:17:36 -08:00
|
|
|
schedule_node *,
|
|
|
|
|
before->child_array_size);
|
2011-01-21 14:32:31 -08:00
|
|
|
before->child_latency = reralloc(mem_ctx, before->child_latency,
|
2014-11-12 10:17:36 -08:00
|
|
|
int, before->child_array_size);
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
before->children[before->child_count] = after;
|
|
|
|
|
before->child_latency[before->child_count] = latency;
|
|
|
|
|
before->child_count++;
|
|
|
|
|
after->parent_count++;
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-20 14:13:59 -07:00
|
|
|
void
|
|
|
|
|
instruction_scheduler::add_dep(schedule_node *before, schedule_node *after)
|
|
|
|
|
{
|
|
|
|
|
if (!before)
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
add_dep(before, after, before->latency);
|
|
|
|
|
}
|
|
|
|
|
|
2017-10-17 23:19:20 -07:00
|
|
|
static bool
|
|
|
|
|
is_scheduling_barrier(const backend_instruction *inst)
|
|
|
|
|
{
|
|
|
|
|
return inst->opcode == FS_OPCODE_PLACEHOLDER_HALT ||
|
|
|
|
|
inst->is_control_flow() ||
|
|
|
|
|
inst->has_side_effects();
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
/**
|
|
|
|
|
* Sometimes we really want this node to execute after everything that
|
|
|
|
|
* was before it and before everything that followed it. This adds
|
|
|
|
|
* the deps to do so.
|
|
|
|
|
*/
|
|
|
|
|
void
|
|
|
|
|
instruction_scheduler::add_barrier_deps(schedule_node *n)
|
|
|
|
|
{
|
|
|
|
|
schedule_node *prev = (schedule_node *)n->prev;
|
|
|
|
|
schedule_node *next = (schedule_node *)n->next;
|
|
|
|
|
|
|
|
|
|
if (prev) {
|
|
|
|
|
while (!prev->is_head_sentinel()) {
|
2014-11-12 10:17:36 -08:00
|
|
|
add_dep(prev, n, 0);
|
2017-10-17 23:19:20 -07:00
|
|
|
if (is_scheduling_barrier(prev->inst))
|
2016-08-18 16:47:05 -07:00
|
|
|
break;
|
2014-11-12 10:17:36 -08:00
|
|
|
prev = (schedule_node *)prev->prev;
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (next) {
|
|
|
|
|
while (!next->is_tail_sentinel()) {
|
2014-11-12 10:17:36 -08:00
|
|
|
add_dep(n, next, 0);
|
2017-10-17 23:19:20 -07:00
|
|
|
if (is_scheduling_barrier(next->inst))
|
2016-08-18 16:47:05 -07:00
|
|
|
break;
|
2014-11-12 10:17:36 -08:00
|
|
|
next = (schedule_node *)next->next;
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-03-23 13:53:26 -07:00
|
|
|
/* instruction scheduling needs to be aware of when an MRF write
|
|
|
|
|
* actually writes 2 MRFs.
|
|
|
|
|
*/
|
|
|
|
|
bool
|
2013-04-29 14:05:33 -07:00
|
|
|
fs_instruction_scheduler::is_compressed(fs_inst *inst)
|
2011-03-23 13:53:26 -07:00
|
|
|
{
|
2014-08-16 11:34:56 -07:00
|
|
|
return inst->exec_size == 16;
|
2011-03-23 13:53:26 -07:00
|
|
|
}
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
void
|
2013-04-29 14:05:33 -07:00
|
|
|
fs_instruction_scheduler::calculate_deps()
|
2011-01-18 17:16:49 -08:00
|
|
|
{
|
2013-10-08 22:54:46 -07:00
|
|
|
/* Pre-register-allocation, this tracks the last write per VGRF offset.
|
2012-12-03 17:58:03 -08:00
|
|
|
* After register allocation, reg_offsets are gone and we track individual
|
|
|
|
|
* GRF registers.
|
|
|
|
|
*/
|
2018-12-10 11:50:55 -08:00
|
|
|
schedule_node **last_grf_write;
|
i965: Turn BRW_MAX_MRF into a macro that accepts a hardware generation
There are some bug reports about shaders failing to compile in gen6
because MRF 14 is used when we need to spill. For example:
https://bugs.freedesktop.org/show_bug.cgi?id=86469
https://bugs.freedesktop.org/show_bug.cgi?id=90631
Discussion in bugzilla pointed to the fact that gen6 might actually have
24 MRF registers available instead of 16, so we could use other MRF
registers and avoid these conflicts (we still need to investigate why
some shaders need up to MRF 14 anyway, since this is not expected).
Notice that the hardware docs are not clear about this fact:
SNB PRM Vol4 Part2's "Table 5-4. MRF Registers Available in Device
Hardware" says "Number per Thread" - "24 registers"
However, SNB PRM Vol4 Part1, 1.6.1 Message Register File (MRF) says:
"Normal threads should construct their messages in m1..m15. (...)
Regardless of actual hardware implementation, the thread should
not assume th at MRF addresses above m15 wrap to legal MRF registers."
Therefore experimentation was necessary to evaluate if we had these extra
MRF registers available or not. This was tested in gen6 using MRF
registers 21..23 for spilling and doing a full piglit run (all.py) forcing
spilling of everything on the FS backend. It was also tested by doing
spilling of everything on both the FS and the VS backends with a piglit run
of shader.py. In both cases no regressions were observed. In fact, many of
these tests where helped in the cases where we forced spilling, since that
triggered the same underlying problem described in the bug reports. Here are
some results using INTEL_DEBUG=spill_fs,spill_vec4 for a shader.py run on
gen6 hardware:
Using MRFs 13..15 for spilling:
crash: 2, fail: 113, pass: 6621, skip: 5461
Using MRFs 21..23 for spilling:
crash: 2, fail: 12, pass: 6722, skip: 5461
This patch sets the ground for later patches to implement spilling
using MRF registers 21..23 in gen6.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2015-09-15 16:00:26 +02:00
|
|
|
schedule_node *last_mrf_write[BRW_MAX_MRF(v->devinfo->gen)];
|
2017-12-12 12:05:02 -08:00
|
|
|
schedule_node *last_conditional_mod[8] = {};
|
2014-04-04 16:51:59 +03:00
|
|
|
schedule_node *last_accumulator_write = NULL;
|
2011-05-23 09:12:07 -07:00
|
|
|
/* Fixed HW registers are assumed to be separate from the virtual
|
|
|
|
|
* GRFs, so they can be tracked separately. We don't really write
|
|
|
|
|
* to fixed GRFs much, so don't bother tracking them on a more
|
|
|
|
|
* granular level.
|
|
|
|
|
*/
|
|
|
|
|
schedule_node *last_fixed_grf_write = NULL;
|
2011-01-18 17:16:49 -08:00
|
|
|
|
2018-12-10 11:50:55 -08:00
|
|
|
last_grf_write = (schedule_node **)calloc(sizeof(schedule_node *), grf_count * 16);
|
2011-01-18 17:16:49 -08:00
|
|
|
memset(last_mrf_write, 0, sizeof(last_mrf_write));
|
|
|
|
|
|
|
|
|
|
/* top-to-bottom dependencies: RAW and WAW. */
|
2014-06-24 15:53:19 -07:00
|
|
|
foreach_in_list(schedule_node, n, &instructions) {
|
2013-04-29 14:05:33 -07:00
|
|
|
fs_inst *inst = (fs_inst *)n->inst;
|
2011-01-18 17:16:49 -08:00
|
|
|
|
2016-03-12 21:15:19 -08:00
|
|
|
if (is_scheduling_barrier(inst))
|
2013-03-27 23:19:39 -07:00
|
|
|
add_barrier_deps(n);
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
/* read-after-write deps. */
|
2014-03-17 10:39:43 -07:00
|
|
|
for (int i = 0; i < inst->sources; i++) {
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->src[i].file == VGRF) {
|
2012-12-03 17:58:03 -08:00
|
|
|
if (post_reg_alloc) {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_read(inst, i); r++)
|
2015-10-26 04:35:14 -07:00
|
|
|
add_dep(last_grf_write[inst->src[i].nr + r], n);
|
2012-12-03 17:58:03 -08:00
|
|
|
} else {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_read(inst, i); r++) {
|
2016-09-01 12:42:20 -07:00
|
|
|
add_dep(last_grf_write[inst->src[i].nr * 16 +
|
|
|
|
|
inst->src[i].offset / REG_SIZE + r], n);
|
2013-10-08 22:54:46 -07:00
|
|
|
}
|
2012-12-03 17:58:03 -08:00
|
|
|
}
|
2015-10-26 17:52:57 -07:00
|
|
|
} else if (inst->src[i].file == FIXED_GRF) {
|
2014-11-12 10:17:36 -08:00
|
|
|
if (post_reg_alloc) {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_read(inst, i); r++)
|
2015-10-24 15:29:03 -07:00
|
|
|
add_dep(last_grf_write[inst->src[i].nr + r], n);
|
2012-12-03 17:58:03 -08:00
|
|
|
} else {
|
|
|
|
|
add_dep(last_fixed_grf_write, n);
|
|
|
|
|
}
|
2014-05-07 09:58:43 +02:00
|
|
|
} else if (inst->src[i].is_accumulator()) {
|
2014-04-04 16:51:59 +03:00
|
|
|
add_dep(last_accumulator_write, n);
|
2016-02-14 23:21:03 -08:00
|
|
|
} else if (inst->src[i].file == ARF) {
|
2014-11-12 10:17:36 -08:00
|
|
|
add_barrier_deps(n);
|
|
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
i965/fs: Convert gen7 to using GRFs for texture messages.
Looking at Lightsmark's shaders, the way we used MRFs (or in gen7's
case, GRFs) was bad in a couple of ways. One was that it prevented
compute-to-MRF for the common case of a texcoord that gets used
exactly once, but where the texcoord setup all gets emitted before the
texture calls (such as when it's a bare fragment shader input, which
gets interpolated before processing main()). Another was that it
introduced a bunch of dependencies that constrained scheduling, and
forced waits for texture operations to be done before they are
required. For example, we can now move the compute-to-MRF
interpolation for the second texture send down after the first send.
The downside is that this generally prevents
remove_duplicate_mrf_writes() from doing anything, whereas previously
it avoided work for the case of sampling from the same texcoord twice.
However, I suspect that most of the win that originally justified that
code was in avoiding the WAR stall on the first send, which this patch
also avoids, rather than the small cost of the extra instruction. We
see instruction count regressions in shaders in unigine, yofrankie,
savage2, hon, and gstreamer.
Improves GLB2.7 performance by 0.633628% +/- 0.491809% (n=121/125, avg of
~66fps, outliers below 61 dropped).
Improves openarena performance by 1.01092% +/- 0.66897% (n=425).
No significant difference on Lightsmark (n=44).
v2: Squash in the fix for register unspilling for send-from-GRF, fixing a
segfault in lightsmark.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Acked-by: Matt Turner <mattst88@gmail.com>
2013-10-09 17:17:59 -07:00
|
|
|
if (inst->base_mrf != -1) {
|
2014-11-12 10:17:36 -08:00
|
|
|
for (int i = 0; i < inst->mlen; i++) {
|
|
|
|
|
/* It looks like the MRF regs are released in the send
|
|
|
|
|
* instruction once it's sent, not when the result comes
|
|
|
|
|
* back.
|
|
|
|
|
*/
|
|
|
|
|
add_dep(last_mrf_write[inst->base_mrf + i], n);
|
|
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
2016-05-18 22:13:52 -07:00
|
|
|
if (const unsigned mask = inst->flags_read(v->devinfo)) {
|
|
|
|
|
assert(mask < (1 << ARRAY_SIZE(last_conditional_mod)));
|
|
|
|
|
|
|
|
|
|
for (unsigned i = 0; i < ARRAY_SIZE(last_conditional_mod); i++) {
|
|
|
|
|
if (mask & (1 << i))
|
|
|
|
|
add_dep(last_conditional_mod[i], n);
|
|
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
2014-04-04 16:51:59 +03:00
|
|
|
if (inst->reads_accumulator_implicitly()) {
|
2014-05-07 09:58:43 +02:00
|
|
|
add_dep(last_accumulator_write, n);
|
2014-04-04 16:51:59 +03:00
|
|
|
}
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
/* write-after-write deps. */
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->dst.file == VGRF) {
|
2012-12-03 17:58:03 -08:00
|
|
|
if (post_reg_alloc) {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_written(inst); r++) {
|
2015-10-26 04:35:14 -07:00
|
|
|
add_dep(last_grf_write[inst->dst.nr + r], n);
|
|
|
|
|
last_grf_write[inst->dst.nr + r] = n;
|
2012-12-03 17:58:03 -08:00
|
|
|
}
|
|
|
|
|
} else {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_written(inst); r++) {
|
2016-09-01 12:42:20 -07:00
|
|
|
add_dep(last_grf_write[inst->dst.nr * 16 +
|
|
|
|
|
inst->dst.offset / REG_SIZE + r], n);
|
|
|
|
|
last_grf_write[inst->dst.nr * 16 +
|
|
|
|
|
inst->dst.offset / REG_SIZE + r] = n;
|
2013-10-08 22:54:46 -07:00
|
|
|
}
|
2012-12-03 17:58:03 -08:00
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
} else if (inst->dst.file == MRF) {
|
2015-10-26 04:35:14 -07:00
|
|
|
int reg = inst->dst.nr & ~BRW_MRF_COMPR4;
|
2014-11-12 10:17:36 -08:00
|
|
|
|
|
|
|
|
add_dep(last_mrf_write[reg], n);
|
|
|
|
|
last_mrf_write[reg] = n;
|
|
|
|
|
if (is_compressed(inst)) {
|
2015-10-26 04:35:14 -07:00
|
|
|
if (inst->dst.nr & BRW_MRF_COMPR4)
|
2014-11-12 10:17:36 -08:00
|
|
|
reg += 4;
|
|
|
|
|
else
|
|
|
|
|
reg++;
|
|
|
|
|
add_dep(last_mrf_write[reg], n);
|
|
|
|
|
last_mrf_write[reg] = n;
|
|
|
|
|
}
|
2015-10-26 17:52:57 -07:00
|
|
|
} else if (inst->dst.file == FIXED_GRF) {
|
2012-12-03 17:58:03 -08:00
|
|
|
if (post_reg_alloc) {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_written(inst); r++)
|
2015-10-24 15:29:03 -07:00
|
|
|
last_grf_write[inst->dst.nr + r] = n;
|
2012-12-03 17:58:03 -08:00
|
|
|
} else {
|
|
|
|
|
last_fixed_grf_write = n;
|
|
|
|
|
}
|
2014-05-07 09:58:43 +02:00
|
|
|
} else if (inst->dst.is_accumulator()) {
|
2014-04-04 16:51:59 +03:00
|
|
|
add_dep(last_accumulator_write, n);
|
|
|
|
|
last_accumulator_write = n;
|
2016-02-14 23:21:03 -08:00
|
|
|
} else if (inst->dst.file == ARF && !inst->dst.is_null()) {
|
2014-11-12 10:17:36 -08:00
|
|
|
add_barrier_deps(n);
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
i965/fs: Convert gen7 to using GRFs for texture messages.
Looking at Lightsmark's shaders, the way we used MRFs (or in gen7's
case, GRFs) was bad in a couple of ways. One was that it prevented
compute-to-MRF for the common case of a texcoord that gets used
exactly once, but where the texcoord setup all gets emitted before the
texture calls (such as when it's a bare fragment shader input, which
gets interpolated before processing main()). Another was that it
introduced a bunch of dependencies that constrained scheduling, and
forced waits for texture operations to be done before they are
required. For example, we can now move the compute-to-MRF
interpolation for the second texture send down after the first send.
The downside is that this generally prevents
remove_duplicate_mrf_writes() from doing anything, whereas previously
it avoided work for the case of sampling from the same texcoord twice.
However, I suspect that most of the win that originally justified that
code was in avoiding the WAR stall on the first send, which this patch
also avoids, rather than the small cost of the extra instruction. We
see instruction count regressions in shaders in unigine, yofrankie,
savage2, hon, and gstreamer.
Improves GLB2.7 performance by 0.633628% +/- 0.491809% (n=121/125, avg of
~66fps, outliers below 61 dropped).
Improves openarena performance by 1.01092% +/- 0.66897% (n=425).
No significant difference on Lightsmark (n=44).
v2: Squash in the fix for register unspilling for send-from-GRF, fixing a
segfault in lightsmark.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Acked-by: Matt Turner <mattst88@gmail.com>
2013-10-09 17:17:59 -07:00
|
|
|
if (inst->mlen > 0 && inst->base_mrf != -1) {
|
2014-11-12 10:17:36 -08:00
|
|
|
for (int i = 0; i < v->implied_mrf_writes(inst); i++) {
|
|
|
|
|
add_dep(last_mrf_write[inst->base_mrf + i], n);
|
|
|
|
|
last_mrf_write[inst->base_mrf + i] = n;
|
|
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
2016-05-18 22:13:52 -07:00
|
|
|
if (const unsigned mask = inst->flags_written()) {
|
|
|
|
|
assert(mask < (1 << ARRAY_SIZE(last_conditional_mod)));
|
|
|
|
|
|
|
|
|
|
for (unsigned i = 0; i < ARRAY_SIZE(last_conditional_mod); i++) {
|
|
|
|
|
if (mask & (1 << i)) {
|
|
|
|
|
add_dep(last_conditional_mod[i], n, 0);
|
|
|
|
|
last_conditional_mod[i] = n;
|
|
|
|
|
}
|
|
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
2014-04-04 16:51:59 +03:00
|
|
|
|
2015-04-17 12:15:58 -07:00
|
|
|
if (inst->writes_accumulator_implicitly(v->devinfo) &&
|
2014-05-07 09:58:43 +02:00
|
|
|
!inst->dst.is_accumulator()) {
|
|
|
|
|
add_dep(last_accumulator_write, n);
|
|
|
|
|
last_accumulator_write = n;
|
2014-04-04 16:51:59 +03:00
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* bottom-to-top dependencies: WAR */
|
2018-12-10 11:50:55 -08:00
|
|
|
memset(last_grf_write, 0, sizeof(schedule_node *) * grf_count * 16);
|
2011-01-18 17:16:49 -08:00
|
|
|
memset(last_mrf_write, 0, sizeof(last_mrf_write));
|
2012-12-06 10:36:11 -08:00
|
|
|
memset(last_conditional_mod, 0, sizeof(last_conditional_mod));
|
2014-04-04 16:51:59 +03:00
|
|
|
last_accumulator_write = NULL;
|
2011-05-23 09:12:07 -07:00
|
|
|
last_fixed_grf_write = NULL;
|
2011-01-18 17:16:49 -08:00
|
|
|
|
2016-02-14 22:28:51 -08:00
|
|
|
foreach_in_list_reverse_safe(schedule_node, n, &instructions) {
|
2013-04-29 14:05:33 -07:00
|
|
|
fs_inst *inst = (fs_inst *)n->inst;
|
2011-01-18 17:16:49 -08:00
|
|
|
|
|
|
|
|
/* write-after-read deps. */
|
2014-03-17 10:39:43 -07:00
|
|
|
for (int i = 0; i < inst->sources; i++) {
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->src[i].file == VGRF) {
|
2012-12-03 17:58:03 -08:00
|
|
|
if (post_reg_alloc) {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_read(inst, i); r++)
|
2015-10-26 04:35:14 -07:00
|
|
|
add_dep(n, last_grf_write[inst->src[i].nr + r], 0);
|
2012-12-03 17:58:03 -08:00
|
|
|
} else {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_read(inst, i); r++) {
|
2016-09-01 12:42:20 -07:00
|
|
|
add_dep(n, last_grf_write[inst->src[i].nr * 16 +
|
|
|
|
|
inst->src[i].offset / REG_SIZE + r], 0);
|
2013-10-08 22:54:46 -07:00
|
|
|
}
|
2012-12-03 17:58:03 -08:00
|
|
|
}
|
2015-10-26 17:52:57 -07:00
|
|
|
} else if (inst->src[i].file == FIXED_GRF) {
|
2014-11-12 10:17:36 -08:00
|
|
|
if (post_reg_alloc) {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_read(inst, i); r++)
|
2015-10-24 15:29:03 -07:00
|
|
|
add_dep(n, last_grf_write[inst->src[i].nr + r], 0);
|
2012-12-03 17:58:03 -08:00
|
|
|
} else {
|
2015-06-07 00:37:27 -04:00
|
|
|
add_dep(n, last_fixed_grf_write, 0);
|
2012-12-03 17:58:03 -08:00
|
|
|
}
|
2014-05-07 09:58:43 +02:00
|
|
|
} else if (inst->src[i].is_accumulator()) {
|
2015-06-07 00:37:27 -04:00
|
|
|
add_dep(n, last_accumulator_write, 0);
|
2016-02-14 23:21:03 -08:00
|
|
|
} else if (inst->src[i].file == ARF) {
|
2014-11-12 10:17:36 -08:00
|
|
|
add_barrier_deps(n);
|
|
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
i965/fs: Convert gen7 to using GRFs for texture messages.
Looking at Lightsmark's shaders, the way we used MRFs (or in gen7's
case, GRFs) was bad in a couple of ways. One was that it prevented
compute-to-MRF for the common case of a texcoord that gets used
exactly once, but where the texcoord setup all gets emitted before the
texture calls (such as when it's a bare fragment shader input, which
gets interpolated before processing main()). Another was that it
introduced a bunch of dependencies that constrained scheduling, and
forced waits for texture operations to be done before they are
required. For example, we can now move the compute-to-MRF
interpolation for the second texture send down after the first send.
The downside is that this generally prevents
remove_duplicate_mrf_writes() from doing anything, whereas previously
it avoided work for the case of sampling from the same texcoord twice.
However, I suspect that most of the win that originally justified that
code was in avoiding the WAR stall on the first send, which this patch
also avoids, rather than the small cost of the extra instruction. We
see instruction count regressions in shaders in unigine, yofrankie,
savage2, hon, and gstreamer.
Improves GLB2.7 performance by 0.633628% +/- 0.491809% (n=121/125, avg of
~66fps, outliers below 61 dropped).
Improves openarena performance by 1.01092% +/- 0.66897% (n=425).
No significant difference on Lightsmark (n=44).
v2: Squash in the fix for register unspilling for send-from-GRF, fixing a
segfault in lightsmark.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Acked-by: Matt Turner <mattst88@gmail.com>
2013-10-09 17:17:59 -07:00
|
|
|
if (inst->base_mrf != -1) {
|
2014-11-12 10:17:36 -08:00
|
|
|
for (int i = 0; i < inst->mlen; i++) {
|
|
|
|
|
/* It looks like the MRF regs are released in the send
|
|
|
|
|
* instruction once it's sent, not when the result comes
|
|
|
|
|
* back.
|
|
|
|
|
*/
|
|
|
|
|
add_dep(n, last_mrf_write[inst->base_mrf + i], 2);
|
|
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
2016-05-18 22:13:52 -07:00
|
|
|
if (const unsigned mask = inst->flags_read(v->devinfo)) {
|
|
|
|
|
assert(mask < (1 << ARRAY_SIZE(last_conditional_mod)));
|
|
|
|
|
|
|
|
|
|
for (unsigned i = 0; i < ARRAY_SIZE(last_conditional_mod); i++) {
|
|
|
|
|
if (mask & (1 << i))
|
|
|
|
|
add_dep(n, last_conditional_mod[i]);
|
|
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
2014-04-04 16:51:59 +03:00
|
|
|
if (inst->reads_accumulator_implicitly()) {
|
2014-05-07 09:58:43 +02:00
|
|
|
add_dep(n, last_accumulator_write);
|
2014-04-04 16:51:59 +03:00
|
|
|
}
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
/* Update the things this instruction wrote, so earlier reads
|
|
|
|
|
* can mark this as WAR dependency.
|
|
|
|
|
*/
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->dst.file == VGRF) {
|
2012-12-03 17:58:03 -08:00
|
|
|
if (post_reg_alloc) {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_written(inst); r++)
|
2015-10-26 04:35:14 -07:00
|
|
|
last_grf_write[inst->dst.nr + r] = n;
|
2012-12-03 17:58:03 -08:00
|
|
|
} else {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_written(inst); r++) {
|
2016-09-01 12:42:20 -07:00
|
|
|
last_grf_write[inst->dst.nr * 16 +
|
|
|
|
|
inst->dst.offset / REG_SIZE + r] = n;
|
2013-10-08 22:54:46 -07:00
|
|
|
}
|
2012-12-03 17:58:03 -08:00
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
} else if (inst->dst.file == MRF) {
|
2015-10-26 04:35:14 -07:00
|
|
|
int reg = inst->dst.nr & ~BRW_MRF_COMPR4;
|
2011-03-23 13:53:26 -07:00
|
|
|
|
2014-11-12 10:17:36 -08:00
|
|
|
last_mrf_write[reg] = n;
|
2011-03-23 13:53:26 -07:00
|
|
|
|
2014-11-12 10:17:36 -08:00
|
|
|
if (is_compressed(inst)) {
|
2015-10-26 04:35:14 -07:00
|
|
|
if (inst->dst.nr & BRW_MRF_COMPR4)
|
2014-11-12 10:17:36 -08:00
|
|
|
reg += 4;
|
|
|
|
|
else
|
|
|
|
|
reg++;
|
2011-03-23 13:53:26 -07:00
|
|
|
|
2014-11-12 10:17:36 -08:00
|
|
|
last_mrf_write[reg] = n;
|
|
|
|
|
}
|
2015-10-26 17:52:57 -07:00
|
|
|
} else if (inst->dst.file == FIXED_GRF) {
|
2012-12-03 17:58:03 -08:00
|
|
|
if (post_reg_alloc) {
|
2016-09-07 16:59:35 -07:00
|
|
|
for (unsigned r = 0; r < regs_written(inst); r++)
|
2015-10-24 15:29:03 -07:00
|
|
|
last_grf_write[inst->dst.nr + r] = n;
|
2012-12-03 17:58:03 -08:00
|
|
|
} else {
|
|
|
|
|
last_fixed_grf_write = n;
|
|
|
|
|
}
|
2014-05-07 09:58:43 +02:00
|
|
|
} else if (inst->dst.is_accumulator()) {
|
2014-04-04 16:51:59 +03:00
|
|
|
last_accumulator_write = n;
|
2016-02-14 23:21:03 -08:00
|
|
|
} else if (inst->dst.file == ARF && !inst->dst.is_null()) {
|
2014-11-12 10:17:36 -08:00
|
|
|
add_barrier_deps(n);
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
i965/fs: Convert gen7 to using GRFs for texture messages.
Looking at Lightsmark's shaders, the way we used MRFs (or in gen7's
case, GRFs) was bad in a couple of ways. One was that it prevented
compute-to-MRF for the common case of a texcoord that gets used
exactly once, but where the texcoord setup all gets emitted before the
texture calls (such as when it's a bare fragment shader input, which
gets interpolated before processing main()). Another was that it
introduced a bunch of dependencies that constrained scheduling, and
forced waits for texture operations to be done before they are
required. For example, we can now move the compute-to-MRF
interpolation for the second texture send down after the first send.
The downside is that this generally prevents
remove_duplicate_mrf_writes() from doing anything, whereas previously
it avoided work for the case of sampling from the same texcoord twice.
However, I suspect that most of the win that originally justified that
code was in avoiding the WAR stall on the first send, which this patch
also avoids, rather than the small cost of the extra instruction. We
see instruction count regressions in shaders in unigine, yofrankie,
savage2, hon, and gstreamer.
Improves GLB2.7 performance by 0.633628% +/- 0.491809% (n=121/125, avg of
~66fps, outliers below 61 dropped).
Improves openarena performance by 1.01092% +/- 0.66897% (n=425).
No significant difference on Lightsmark (n=44).
v2: Squash in the fix for register unspilling for send-from-GRF, fixing a
segfault in lightsmark.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Acked-by: Matt Turner <mattst88@gmail.com>
2013-10-09 17:17:59 -07:00
|
|
|
if (inst->mlen > 0 && inst->base_mrf != -1) {
|
2014-11-12 10:17:36 -08:00
|
|
|
for (int i = 0; i < v->implied_mrf_writes(inst); i++) {
|
|
|
|
|
last_mrf_write[inst->base_mrf + i] = n;
|
|
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
2016-05-18 22:13:52 -07:00
|
|
|
if (const unsigned mask = inst->flags_written()) {
|
|
|
|
|
assert(mask < (1 << ARRAY_SIZE(last_conditional_mod)));
|
|
|
|
|
|
|
|
|
|
for (unsigned i = 0; i < ARRAY_SIZE(last_conditional_mod); i++) {
|
|
|
|
|
if (mask & (1 << i))
|
|
|
|
|
last_conditional_mod[i] = n;
|
|
|
|
|
}
|
2012-06-18 14:50:04 -07:00
|
|
|
}
|
2014-04-04 16:51:59 +03:00
|
|
|
|
2015-04-17 12:15:58 -07:00
|
|
|
if (inst->writes_accumulator_implicitly(v->devinfo)) {
|
2014-05-07 09:58:43 +02:00
|
|
|
last_accumulator_write = n;
|
2014-04-04 16:51:59 +03:00
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
2018-12-10 11:50:55 -08:00
|
|
|
|
|
|
|
|
free(last_grf_write);
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
2012-11-30 16:13:34 -08:00
|
|
|
void
|
|
|
|
|
vec4_instruction_scheduler::calculate_deps()
|
|
|
|
|
{
|
|
|
|
|
schedule_node *last_grf_write[grf_count];
|
i965: Turn BRW_MAX_MRF into a macro that accepts a hardware generation
There are some bug reports about shaders failing to compile in gen6
because MRF 14 is used when we need to spill. For example:
https://bugs.freedesktop.org/show_bug.cgi?id=86469
https://bugs.freedesktop.org/show_bug.cgi?id=90631
Discussion in bugzilla pointed to the fact that gen6 might actually have
24 MRF registers available instead of 16, so we could use other MRF
registers and avoid these conflicts (we still need to investigate why
some shaders need up to MRF 14 anyway, since this is not expected).
Notice that the hardware docs are not clear about this fact:
SNB PRM Vol4 Part2's "Table 5-4. MRF Registers Available in Device
Hardware" says "Number per Thread" - "24 registers"
However, SNB PRM Vol4 Part1, 1.6.1 Message Register File (MRF) says:
"Normal threads should construct their messages in m1..m15. (...)
Regardless of actual hardware implementation, the thread should
not assume th at MRF addresses above m15 wrap to legal MRF registers."
Therefore experimentation was necessary to evaluate if we had these extra
MRF registers available or not. This was tested in gen6 using MRF
registers 21..23 for spilling and doing a full piglit run (all.py) forcing
spilling of everything on the FS backend. It was also tested by doing
spilling of everything on both the FS and the VS backends with a piglit run
of shader.py. In both cases no regressions were observed. In fact, many of
these tests where helped in the cases where we forced spilling, since that
triggered the same underlying problem described in the bug reports. Here are
some results using INTEL_DEBUG=spill_fs,spill_vec4 for a shader.py run on
gen6 hardware:
Using MRFs 13..15 for spilling:
crash: 2, fail: 113, pass: 6621, skip: 5461
Using MRFs 21..23 for spilling:
crash: 2, fail: 12, pass: 6722, skip: 5461
This patch sets the ground for later patches to implement spilling
using MRF registers 21..23 in gen6.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2015-09-15 16:00:26 +02:00
|
|
|
schedule_node *last_mrf_write[BRW_MAX_MRF(v->devinfo->gen)];
|
2012-11-30 16:13:34 -08:00
|
|
|
schedule_node *last_conditional_mod = NULL;
|
2014-04-04 16:51:59 +03:00
|
|
|
schedule_node *last_accumulator_write = NULL;
|
2012-11-30 16:13:34 -08:00
|
|
|
/* Fixed HW registers are assumed to be separate from the virtual
|
|
|
|
|
* GRFs, so they can be tracked separately. We don't really write
|
|
|
|
|
* to fixed GRFs much, so don't bother tracking them on a more
|
|
|
|
|
* granular level.
|
|
|
|
|
*/
|
|
|
|
|
schedule_node *last_fixed_grf_write = NULL;
|
|
|
|
|
|
|
|
|
|
memset(last_grf_write, 0, sizeof(last_grf_write));
|
|
|
|
|
memset(last_mrf_write, 0, sizeof(last_mrf_write));
|
|
|
|
|
|
|
|
|
|
/* top-to-bottom dependencies: RAW and WAW. */
|
2014-06-24 15:53:19 -07:00
|
|
|
foreach_in_list(schedule_node, n, &instructions) {
|
2012-11-30 16:13:34 -08:00
|
|
|
vec4_instruction *inst = (vec4_instruction *)n->inst;
|
|
|
|
|
|
2016-03-12 21:15:19 -08:00
|
|
|
if (is_scheduling_barrier(inst))
|
2013-10-20 14:02:08 -07:00
|
|
|
add_barrier_deps(n);
|
|
|
|
|
|
2012-11-30 16:13:34 -08:00
|
|
|
/* read-after-write deps. */
|
|
|
|
|
for (int i = 0; i < 3; i++) {
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->src[i].file == VGRF) {
|
2016-09-01 16:55:46 -07:00
|
|
|
for (unsigned j = 0; j < regs_read(inst, i); ++j)
|
2015-10-26 04:35:14 -07:00
|
|
|
add_dep(last_grf_write[inst->src[i].nr + j], n);
|
2015-10-26 17:52:57 -07:00
|
|
|
} else if (inst->src[i].file == FIXED_GRF) {
|
2012-11-30 16:13:34 -08:00
|
|
|
add_dep(last_fixed_grf_write, n);
|
2014-05-07 09:58:43 +02:00
|
|
|
} else if (inst->src[i].is_accumulator()) {
|
2014-04-04 16:51:59 +03:00
|
|
|
assert(last_accumulator_write);
|
|
|
|
|
add_dep(last_accumulator_write, n);
|
2016-02-14 23:21:03 -08:00
|
|
|
} else if (inst->src[i].file == ARF) {
|
2012-11-30 16:13:34 -08:00
|
|
|
add_barrier_deps(n);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2018-04-16 16:32:41 -07:00
|
|
|
if (inst->reads_g0_implicitly())
|
|
|
|
|
add_dep(last_fixed_grf_write, n);
|
|
|
|
|
|
2015-02-03 22:42:23 +02:00
|
|
|
if (!inst->is_send_from_grf()) {
|
|
|
|
|
for (int i = 0; i < inst->mlen; i++) {
|
|
|
|
|
/* It looks like the MRF regs are released in the send
|
|
|
|
|
* instruction once it's sent, not when the result comes
|
|
|
|
|
* back.
|
|
|
|
|
*/
|
|
|
|
|
add_dep(last_mrf_write[inst->base_mrf + i], n);
|
|
|
|
|
}
|
2012-11-30 16:13:34 -08:00
|
|
|
}
|
|
|
|
|
|
2014-03-12 00:16:24 -07:00
|
|
|
if (inst->reads_flag()) {
|
2012-11-30 16:13:34 -08:00
|
|
|
assert(last_conditional_mod);
|
|
|
|
|
add_dep(last_conditional_mod, n);
|
|
|
|
|
}
|
|
|
|
|
|
2014-04-04 16:51:59 +03:00
|
|
|
if (inst->reads_accumulator_implicitly()) {
|
2014-05-07 09:58:43 +02:00
|
|
|
assert(last_accumulator_write);
|
|
|
|
|
add_dep(last_accumulator_write, n);
|
2014-04-04 16:51:59 +03:00
|
|
|
}
|
|
|
|
|
|
2012-11-30 16:13:34 -08:00
|
|
|
/* write-after-write deps. */
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->dst.file == VGRF) {
|
2016-09-01 16:55:46 -07:00
|
|
|
for (unsigned j = 0; j < regs_written(inst); ++j) {
|
2015-10-26 04:35:14 -07:00
|
|
|
add_dep(last_grf_write[inst->dst.nr + j], n);
|
|
|
|
|
last_grf_write[inst->dst.nr + j] = n;
|
2015-02-05 22:39:33 +02:00
|
|
|
}
|
2012-11-30 16:13:34 -08:00
|
|
|
} else if (inst->dst.file == MRF) {
|
2015-10-26 04:35:14 -07:00
|
|
|
add_dep(last_mrf_write[inst->dst.nr], n);
|
|
|
|
|
last_mrf_write[inst->dst.nr] = n;
|
2015-10-26 17:52:57 -07:00
|
|
|
} else if (inst->dst.file == FIXED_GRF) {
|
2012-11-30 16:13:34 -08:00
|
|
|
last_fixed_grf_write = n;
|
2014-05-07 09:58:43 +02:00
|
|
|
} else if (inst->dst.is_accumulator()) {
|
2014-04-04 16:51:59 +03:00
|
|
|
add_dep(last_accumulator_write, n);
|
|
|
|
|
last_accumulator_write = n;
|
2016-02-14 23:21:03 -08:00
|
|
|
} else if (inst->dst.file == ARF && !inst->dst.is_null()) {
|
2012-11-30 16:13:34 -08:00
|
|
|
add_barrier_deps(n);
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-03 22:42:23 +02:00
|
|
|
if (inst->mlen > 0 && !inst->is_send_from_grf()) {
|
2012-11-30 16:13:34 -08:00
|
|
|
for (int i = 0; i < v->implied_mrf_writes(inst); i++) {
|
|
|
|
|
add_dep(last_mrf_write[inst->base_mrf + i], n);
|
|
|
|
|
last_mrf_write[inst->base_mrf + i] = n;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2014-03-12 00:14:07 -07:00
|
|
|
if (inst->writes_flag()) {
|
2012-11-30 16:13:34 -08:00
|
|
|
add_dep(last_conditional_mod, n, 0);
|
|
|
|
|
last_conditional_mod = n;
|
|
|
|
|
}
|
2014-04-04 16:51:59 +03:00
|
|
|
|
2015-04-17 12:15:58 -07:00
|
|
|
if (inst->writes_accumulator_implicitly(v->devinfo) &&
|
2014-05-07 09:58:43 +02:00
|
|
|
!inst->dst.is_accumulator()) {
|
|
|
|
|
add_dep(last_accumulator_write, n);
|
|
|
|
|
last_accumulator_write = n;
|
2014-04-04 16:51:59 +03:00
|
|
|
}
|
2012-11-30 16:13:34 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* bottom-to-top dependencies: WAR */
|
|
|
|
|
memset(last_grf_write, 0, sizeof(last_grf_write));
|
|
|
|
|
memset(last_mrf_write, 0, sizeof(last_mrf_write));
|
|
|
|
|
last_conditional_mod = NULL;
|
2014-04-04 16:51:59 +03:00
|
|
|
last_accumulator_write = NULL;
|
2012-11-30 16:13:34 -08:00
|
|
|
last_fixed_grf_write = NULL;
|
|
|
|
|
|
2016-02-14 22:28:51 -08:00
|
|
|
foreach_in_list_reverse_safe(schedule_node, n, &instructions) {
|
2012-11-30 16:13:34 -08:00
|
|
|
vec4_instruction *inst = (vec4_instruction *)n->inst;
|
|
|
|
|
|
|
|
|
|
/* write-after-read deps. */
|
|
|
|
|
for (int i = 0; i < 3; i++) {
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->src[i].file == VGRF) {
|
2016-09-01 16:55:46 -07:00
|
|
|
for (unsigned j = 0; j < regs_read(inst, i); ++j)
|
2015-10-26 04:35:14 -07:00
|
|
|
add_dep(n, last_grf_write[inst->src[i].nr + j]);
|
2015-10-26 17:52:57 -07:00
|
|
|
} else if (inst->src[i].file == FIXED_GRF) {
|
2012-11-30 16:13:34 -08:00
|
|
|
add_dep(n, last_fixed_grf_write);
|
2014-05-07 09:58:43 +02:00
|
|
|
} else if (inst->src[i].is_accumulator()) {
|
2014-04-04 16:51:59 +03:00
|
|
|
add_dep(n, last_accumulator_write);
|
2016-02-14 23:21:03 -08:00
|
|
|
} else if (inst->src[i].file == ARF) {
|
2012-11-30 16:13:34 -08:00
|
|
|
add_barrier_deps(n);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-03 22:42:23 +02:00
|
|
|
if (!inst->is_send_from_grf()) {
|
|
|
|
|
for (int i = 0; i < inst->mlen; i++) {
|
|
|
|
|
/* It looks like the MRF regs are released in the send
|
|
|
|
|
* instruction once it's sent, not when the result comes
|
|
|
|
|
* back.
|
|
|
|
|
*/
|
|
|
|
|
add_dep(n, last_mrf_write[inst->base_mrf + i], 2);
|
|
|
|
|
}
|
2012-11-30 16:13:34 -08:00
|
|
|
}
|
|
|
|
|
|
2014-03-12 00:16:24 -07:00
|
|
|
if (inst->reads_flag()) {
|
2012-11-30 16:13:34 -08:00
|
|
|
add_dep(n, last_conditional_mod);
|
|
|
|
|
}
|
|
|
|
|
|
2014-04-04 16:51:59 +03:00
|
|
|
if (inst->reads_accumulator_implicitly()) {
|
2014-05-07 09:58:43 +02:00
|
|
|
add_dep(n, last_accumulator_write);
|
2014-04-04 16:51:59 +03:00
|
|
|
}
|
|
|
|
|
|
2012-11-30 16:13:34 -08:00
|
|
|
/* Update the things this instruction wrote, so earlier reads
|
|
|
|
|
* can mark this as WAR dependency.
|
|
|
|
|
*/
|
2015-10-26 17:09:25 -07:00
|
|
|
if (inst->dst.file == VGRF) {
|
2016-09-01 16:55:46 -07:00
|
|
|
for (unsigned j = 0; j < regs_written(inst); ++j)
|
2015-10-26 04:35:14 -07:00
|
|
|
last_grf_write[inst->dst.nr + j] = n;
|
2012-11-30 16:13:34 -08:00
|
|
|
} else if (inst->dst.file == MRF) {
|
2015-10-26 04:35:14 -07:00
|
|
|
last_mrf_write[inst->dst.nr] = n;
|
2015-10-26 17:52:57 -07:00
|
|
|
} else if (inst->dst.file == FIXED_GRF) {
|
2012-11-30 16:13:34 -08:00
|
|
|
last_fixed_grf_write = n;
|
2014-05-07 09:58:43 +02:00
|
|
|
} else if (inst->dst.is_accumulator()) {
|
2014-04-04 16:51:59 +03:00
|
|
|
last_accumulator_write = n;
|
2016-02-14 23:21:03 -08:00
|
|
|
} else if (inst->dst.file == ARF && !inst->dst.is_null()) {
|
2012-11-30 16:13:34 -08:00
|
|
|
add_barrier_deps(n);
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-03 22:42:23 +02:00
|
|
|
if (inst->mlen > 0 && !inst->is_send_from_grf()) {
|
2012-11-30 16:13:34 -08:00
|
|
|
for (int i = 0; i < v->implied_mrf_writes(inst); i++) {
|
|
|
|
|
last_mrf_write[inst->base_mrf + i] = n;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2014-03-12 00:14:07 -07:00
|
|
|
if (inst->writes_flag()) {
|
2012-11-30 16:13:34 -08:00
|
|
|
last_conditional_mod = n;
|
|
|
|
|
}
|
2014-04-04 16:51:59 +03:00
|
|
|
|
2015-04-17 12:15:58 -07:00
|
|
|
if (inst->writes_accumulator_implicitly(v->devinfo)) {
|
2014-05-07 09:58:43 +02:00
|
|
|
last_accumulator_write = n;
|
2014-04-04 16:51:59 +03:00
|
|
|
}
|
2012-11-30 16:13:34 -08:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2013-04-29 16:45:10 -07:00
|
|
|
schedule_node *
|
2013-04-29 14:05:33 -07:00
|
|
|
fs_instruction_scheduler::choose_instruction_to_schedule()
|
2013-04-29 16:45:10 -07:00
|
|
|
{
|
|
|
|
|
schedule_node *chosen = NULL;
|
|
|
|
|
|
2013-11-19 13:07:12 -08:00
|
|
|
if (mode == SCHEDULE_PRE || mode == SCHEDULE_POST) {
|
2013-04-29 16:45:10 -07:00
|
|
|
int chosen_time = 0;
|
|
|
|
|
|
2016-08-12 16:13:16 -07:00
|
|
|
/* Of the instructions ready to execute or the closest to being ready,
|
|
|
|
|
* choose the one most likely to unblock an early program exit, or
|
|
|
|
|
* otherwise the oldest one.
|
2013-04-29 16:45:10 -07:00
|
|
|
*/
|
2014-06-24 15:53:19 -07:00
|
|
|
foreach_in_list(schedule_node, n, &instructions) {
|
2016-08-12 16:13:16 -07:00
|
|
|
if (!chosen ||
|
|
|
|
|
exit_unblocked_time(n) < exit_unblocked_time(chosen) ||
|
|
|
|
|
(exit_unblocked_time(n) == exit_unblocked_time(chosen) &&
|
|
|
|
|
n->unblocked_time < chosen_time)) {
|
2013-04-29 16:45:10 -07:00
|
|
|
chosen = n;
|
|
|
|
|
chosen_time = n->unblocked_time;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
/* Before register allocation, we don't care about the latencies of
|
|
|
|
|
* instructions. All we care about is reducing live intervals of
|
2013-11-12 15:33:27 -08:00
|
|
|
* variables so that we can avoid register spilling, or get SIMD16
|
2013-04-29 16:45:10 -07:00
|
|
|
* shaders which naturally do a better job of hiding instruction
|
|
|
|
|
* latency.
|
|
|
|
|
*/
|
2014-06-24 15:53:19 -07:00
|
|
|
foreach_in_list(schedule_node, n, &instructions) {
|
2013-04-29 14:05:33 -07:00
|
|
|
fs_inst *inst = (fs_inst *)n->inst;
|
2013-04-29 16:45:10 -07:00
|
|
|
|
2013-10-28 15:17:07 -07:00
|
|
|
if (!chosen) {
|
|
|
|
|
chosen = n;
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2013-10-14 11:38:09 -07:00
|
|
|
/* Most important: If we can definitely reduce register pressure, do
|
|
|
|
|
* so immediately.
|
|
|
|
|
*/
|
|
|
|
|
int register_pressure_benefit = get_register_pressure_benefit(n->inst);
|
|
|
|
|
int chosen_register_pressure_benefit =
|
|
|
|
|
get_register_pressure_benefit(chosen->inst);
|
|
|
|
|
|
|
|
|
|
if (register_pressure_benefit > 0 &&
|
|
|
|
|
register_pressure_benefit > chosen_register_pressure_benefit) {
|
|
|
|
|
chosen = n;
|
|
|
|
|
continue;
|
|
|
|
|
} else if (chosen_register_pressure_benefit > 0 &&
|
|
|
|
|
(register_pressure_benefit <
|
|
|
|
|
chosen_register_pressure_benefit)) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2013-11-06 17:38:23 -08:00
|
|
|
if (mode == SCHEDULE_PRE_LIFO) {
|
|
|
|
|
/* Prefer instructions that recently became available for
|
|
|
|
|
* scheduling. These are the things that are most likely to
|
|
|
|
|
* (eventually) make a variable dead and reduce register pressure.
|
|
|
|
|
* Typical register pressure estimates don't work for us because
|
|
|
|
|
* most of our pressure comes from texturing, where no single
|
|
|
|
|
* instruction to schedule will make a vec4 value dead.
|
2013-10-28 15:17:07 -07:00
|
|
|
*/
|
2013-11-06 17:38:23 -08:00
|
|
|
if (n->cand_generation > chosen->cand_generation) {
|
2013-10-28 15:17:07 -07:00
|
|
|
chosen = n;
|
|
|
|
|
continue;
|
2013-11-06 17:38:23 -08:00
|
|
|
} else if (n->cand_generation < chosen->cand_generation) {
|
2013-10-28 15:17:07 -07:00
|
|
|
continue;
|
|
|
|
|
}
|
2013-11-06 17:38:23 -08:00
|
|
|
|
|
|
|
|
/* On MRF-using chips, prefer non-SEND instructions. If we don't
|
|
|
|
|
* do this, then because we prefer instructions that just became
|
|
|
|
|
* candidates, we'll end up in a pattern of scheduling a SEND,
|
|
|
|
|
* then the MRFs for the next SEND, then the next SEND, then the
|
|
|
|
|
* MRFs, etc., without ever consuming the results of a send.
|
|
|
|
|
*/
|
2015-04-17 12:15:58 -07:00
|
|
|
if (v->devinfo->gen < 7) {
|
2013-11-06 17:38:23 -08:00
|
|
|
fs_inst *chosen_inst = (fs_inst *)chosen->inst;
|
|
|
|
|
|
2016-09-02 13:53:13 -07:00
|
|
|
/* We use size_written > 4 * exec_size as our test for the kind
|
|
|
|
|
* of send instruction to avoid -- only sends generate many
|
|
|
|
|
* regs, and a single-result send is probably actually reducing
|
|
|
|
|
* register pressure.
|
2013-11-06 17:38:23 -08:00
|
|
|
*/
|
2016-09-01 21:19:29 -07:00
|
|
|
if (inst->size_written <= 4 * inst->exec_size &&
|
|
|
|
|
chosen_inst->size_written > 4 * chosen_inst->exec_size) {
|
2013-11-06 17:38:23 -08:00
|
|
|
chosen = n;
|
|
|
|
|
continue;
|
2016-09-07 13:38:20 -07:00
|
|
|
} else if (inst->size_written > chosen_inst->size_written) {
|
2013-11-06 17:38:23 -08:00
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
}
|
2013-10-28 15:17:07 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* For instructions pushed on the cands list at the same time, prefer
|
|
|
|
|
* the one with the highest delay to the end of the program. This is
|
|
|
|
|
* most likely to have its values able to be consumed first (such as
|
|
|
|
|
* for a large tree of lowered ubo loads, which appear reversed in
|
|
|
|
|
* the instruction stream with respect to when they can be consumed).
|
|
|
|
|
*/
|
|
|
|
|
if (n->delay > chosen->delay) {
|
|
|
|
|
chosen = n;
|
|
|
|
|
continue;
|
|
|
|
|
} else if (n->delay < chosen->delay) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2016-08-12 16:13:16 -07:00
|
|
|
/* Prefer the node most likely to unblock an early program exit.
|
|
|
|
|
*/
|
|
|
|
|
if (exit_unblocked_time(n) < exit_unblocked_time(chosen)) {
|
|
|
|
|
chosen = n;
|
|
|
|
|
continue;
|
|
|
|
|
} else if (exit_unblocked_time(n) > exit_unblocked_time(chosen)) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2013-10-28 15:17:07 -07:00
|
|
|
/* If all other metrics are equal, we prefer the first instruction in
|
|
|
|
|
* the list (program execution).
|
|
|
|
|
*/
|
2013-04-29 16:45:10 -07:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return chosen;
|
|
|
|
|
}
|
|
|
|
|
|
2012-11-30 16:13:34 -08:00
|
|
|
schedule_node *
|
|
|
|
|
vec4_instruction_scheduler::choose_instruction_to_schedule()
|
|
|
|
|
{
|
|
|
|
|
schedule_node *chosen = NULL;
|
|
|
|
|
int chosen_time = 0;
|
|
|
|
|
|
|
|
|
|
/* Of the instructions ready to execute or the closest to being ready,
|
|
|
|
|
* choose the oldest one.
|
|
|
|
|
*/
|
2014-06-24 15:53:19 -07:00
|
|
|
foreach_in_list(schedule_node, n, &instructions) {
|
2012-11-30 16:13:34 -08:00
|
|
|
if (!chosen || n->unblocked_time < chosen_time) {
|
|
|
|
|
chosen = n;
|
|
|
|
|
chosen_time = n->unblocked_time;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return chosen;
|
|
|
|
|
}
|
|
|
|
|
|
2013-04-29 16:45:10 -07:00
|
|
|
int
|
2013-04-29 14:05:33 -07:00
|
|
|
fs_instruction_scheduler::issue_time(backend_instruction *inst)
|
2013-04-29 16:45:10 -07:00
|
|
|
{
|
2017-12-06 11:42:54 -08:00
|
|
|
const unsigned overhead = v->bank_conflict_cycles((fs_inst *)inst);
|
2013-04-29 14:05:33 -07:00
|
|
|
if (is_compressed((fs_inst *)inst))
|
2017-12-06 11:42:54 -08:00
|
|
|
return 4 + overhead;
|
2013-04-29 16:45:10 -07:00
|
|
|
else
|
2017-12-06 11:42:54 -08:00
|
|
|
return 2 + overhead;
|
2013-04-29 16:45:10 -07:00
|
|
|
}
|
|
|
|
|
|
2012-11-30 16:13:34 -08:00
|
|
|
int
|
2018-03-28 16:45:01 -07:00
|
|
|
vec4_instruction_scheduler::issue_time(backend_instruction *)
|
2012-11-30 16:13:34 -08:00
|
|
|
{
|
|
|
|
|
/* We always execute as two vec4s in parallel. */
|
|
|
|
|
return 2;
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
void
|
2014-08-31 21:19:47 -07:00
|
|
|
instruction_scheduler::schedule_instructions(bblock_t *block)
|
2011-01-18 17:16:49 -08:00
|
|
|
{
|
2016-08-22 15:01:08 -07:00
|
|
|
const struct gen_device_info *devinfo = bs->devinfo;
|
2016-11-28 13:29:45 -08:00
|
|
|
int time = 0;
|
2015-06-09 10:26:53 -07:00
|
|
|
if (!post_reg_alloc)
|
|
|
|
|
reg_pressure = reg_pressure_in[block->num];
|
|
|
|
|
block_idx = block->num;
|
2011-01-18 17:16:49 -08:00
|
|
|
|
|
|
|
|
/* Remove non-DAG heads from the list. */
|
2014-06-24 16:31:38 -07:00
|
|
|
foreach_in_list_safe(schedule_node, n, &instructions) {
|
2011-01-18 17:16:49 -08:00
|
|
|
if (n->parent_count != 0)
|
2014-11-12 10:17:36 -08:00
|
|
|
n->remove();
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
2013-10-28 15:17:07 -07:00
|
|
|
unsigned cand_generation = 1;
|
2011-01-18 17:16:49 -08:00
|
|
|
while (!instructions.is_empty()) {
|
2013-04-29 16:45:10 -07:00
|
|
|
schedule_node *chosen = choose_instruction_to_schedule();
|
2011-01-18 17:16:49 -08:00
|
|
|
|
|
|
|
|
/* Schedule this instruction. */
|
|
|
|
|
assert(chosen);
|
|
|
|
|
chosen->remove();
|
2016-02-15 10:43:39 -08:00
|
|
|
chosen->inst->exec_node::remove();
|
|
|
|
|
block->instructions.push_tail(chosen->inst);
|
2011-01-18 17:16:49 -08:00
|
|
|
instructions_to_schedule--;
|
2015-06-09 10:26:53 -07:00
|
|
|
|
|
|
|
|
if (!post_reg_alloc) {
|
|
|
|
|
reg_pressure -= get_register_pressure_benefit(chosen->inst);
|
|
|
|
|
update_register_pressure(chosen->inst);
|
|
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
|
2015-06-05 19:20:57 -04:00
|
|
|
/* If we expected a delay for scheduling, then bump the clock to reflect
|
|
|
|
|
* that. In reality, the hardware will switch to another hyperthread
|
|
|
|
|
* and may not return to dispatching our thread for a while even after
|
|
|
|
|
* we're unblocked. After this, we have the time when the chosen
|
|
|
|
|
* instruction will start executing.
|
|
|
|
|
*/
|
|
|
|
|
time = MAX2(time, chosen->unblocked_time);
|
|
|
|
|
|
2013-04-29 16:45:10 -07:00
|
|
|
/* Update the clock for how soon an instruction could start after the
|
|
|
|
|
* chosen one.
|
2011-01-18 17:16:49 -08:00
|
|
|
*/
|
2013-04-29 16:45:10 -07:00
|
|
|
time += issue_time(chosen->inst);
|
2012-12-05 16:17:58 -08:00
|
|
|
|
2012-12-04 13:52:19 -08:00
|
|
|
if (debug) {
|
2013-12-22 23:29:31 -08:00
|
|
|
fprintf(stderr, "clock %4d, scheduled: ", time);
|
2015-05-20 09:44:01 -07:00
|
|
|
bs->dump_instruction(chosen->inst);
|
2015-06-09 10:26:53 -07:00
|
|
|
if (!post_reg_alloc)
|
|
|
|
|
fprintf(stderr, "(register pressure %d)\n", reg_pressure);
|
2012-12-04 13:52:19 -08:00
|
|
|
}
|
|
|
|
|
|
2011-01-18 17:16:49 -08:00
|
|
|
/* Now that we've scheduled a new instruction, some of its
|
|
|
|
|
* children can be promoted to the list of instructions ready to
|
|
|
|
|
* be scheduled. Update the children's unblocked time for this
|
|
|
|
|
* DAG edge as we do so.
|
|
|
|
|
*/
|
i965: Try not to reverse-schedule things when doing LIFO scheduling.
The LIFO plan was simple: Take the most recently made available
instructions, and pick those first.
But because of the order we were pushing things onto our list of
available-to-schedule instructions, it meant that when a set of
instructions was made available at the same time (for example, everything
at the start of the program that didn't depend on other instructions) we'd
schedule them in reverse order.
If you had 10 texture calls in a row in your program, each with
independent argument setup, we'd set up the last texture call's args and
execute it first, even though we wouldn't be able to consume its results
until we'd finished the other 9 texture calls (assuming consumption of
texture results happens near each texture call, and combines it with
another texture result, which is normal for a convolution shader).
To fix this, walk the list for doing LIFO in the order that instructions
were originally generated in the program, but choose to push
newly-made-available instructions to the other end of the list instead.
total instructions in shared programs: 1587242 -> 1586290 (-0.06%)
instructions in affected programs: 7801 -> 6849 (-12.20%)
GAINED: 76
LOST: 67
Thanks to Chia-I Wu for pointing out the bug in my first version of the
patch that made it a huge loss.
Reviewed-by: Matt Turner <mattst88@gmail.com>
2013-10-22 12:27:06 -07:00
|
|
|
for (int i = chosen->child_count - 1; i >= 0; i--) {
|
2014-11-12 10:17:36 -08:00
|
|
|
schedule_node *child = chosen->children[i];
|
2011-01-18 17:16:49 -08:00
|
|
|
|
2014-11-12 10:17:36 -08:00
|
|
|
child->unblocked_time = MAX2(child->unblocked_time,
|
|
|
|
|
time + chosen->child_latency[i]);
|
2011-01-18 17:16:49 -08:00
|
|
|
|
i965: Print instructions' children during scheduling debugging.
Useful for tracking down problems in dependency calculations.
Scheduling debugging now prints:
clock 2, scheduled: linterp vgrf5, hw_reg2, hw_reg3, hw_reg0,
child 0, 53 parents: fb_write (null), (null), (null), (null),
child 1, 2 parents: tex vgrf4, vgrf5, (null), (null),
child 2, 52 parents: placeholder_halt (null), (null), (null), (null),
clock 4, scheduled: linterp vgrf5+1, hw_reg2, hw_reg3, hw_reg0+16,
child 0, 52 parents: fb_write (null), (null), (null), (null),
child 1, 1 parents: tex vgrf4, vgrf5, (null), (null),
now available
child 2, 51 parents: placeholder_halt (null), (null), (null), (null),
Reviewed-by: Eric Anholt <eric@anholt.net>
2013-10-08 23:03:41 -07:00
|
|
|
if (debug) {
|
2013-12-22 23:29:31 -08:00
|
|
|
fprintf(stderr, "\tchild %d, %d parents: ", i, child->parent_count);
|
2015-05-20 09:44:01 -07:00
|
|
|
bs->dump_instruction(child->inst);
|
i965: Print instructions' children during scheduling debugging.
Useful for tracking down problems in dependency calculations.
Scheduling debugging now prints:
clock 2, scheduled: linterp vgrf5, hw_reg2, hw_reg3, hw_reg0,
child 0, 53 parents: fb_write (null), (null), (null), (null),
child 1, 2 parents: tex vgrf4, vgrf5, (null), (null),
child 2, 52 parents: placeholder_halt (null), (null), (null), (null),
clock 4, scheduled: linterp vgrf5+1, hw_reg2, hw_reg3, hw_reg0+16,
child 0, 52 parents: fb_write (null), (null), (null), (null),
child 1, 1 parents: tex vgrf4, vgrf5, (null), (null),
now available
child 2, 51 parents: placeholder_halt (null), (null), (null), (null),
Reviewed-by: Eric Anholt <eric@anholt.net>
2013-10-08 23:03:41 -07:00
|
|
|
}
|
|
|
|
|
|
2013-10-28 15:17:07 -07:00
|
|
|
child->cand_generation = cand_generation;
|
2014-11-12 10:17:36 -08:00
|
|
|
child->parent_count--;
|
|
|
|
|
if (child->parent_count == 0) {
|
2012-12-04 13:52:19 -08:00
|
|
|
if (debug) {
|
2013-12-22 23:29:31 -08:00
|
|
|
fprintf(stderr, "\t\tnow available\n");
|
2012-12-04 13:52:19 -08:00
|
|
|
}
|
2014-11-12 10:17:36 -08:00
|
|
|
instructions.push_head(child);
|
|
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
2013-10-28 15:17:07 -07:00
|
|
|
cand_generation++;
|
2011-01-18 21:26:53 -08:00
|
|
|
|
2013-03-28 10:45:34 -07:00
|
|
|
/* Shared resource: the mathbox. There's one mathbox per EU on Gen6+
|
|
|
|
|
* but it's more limited pre-gen6, so if we send something off to it then
|
|
|
|
|
* the next math instruction isn't going to make progress until the first
|
|
|
|
|
* is done.
|
2011-01-18 21:26:53 -08:00
|
|
|
*/
|
2015-04-17 12:15:58 -07:00
|
|
|
if (devinfo->gen < 6 && chosen->inst->is_math()) {
|
2014-06-24 15:53:19 -07:00
|
|
|
foreach_in_list(schedule_node, n, &instructions) {
|
2014-11-12 10:17:36 -08:00
|
|
|
if (n->inst->is_math())
|
|
|
|
|
n->unblocked_time = MAX2(n->unblocked_time,
|
|
|
|
|
time + chosen->latency);
|
|
|
|
|
}
|
2011-01-18 21:26:53 -08:00
|
|
|
}
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
assert(instructions_to_schedule == 0);
|
2015-06-06 10:55:21 -04:00
|
|
|
|
|
|
|
|
block->cycle_count = time;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static unsigned get_cycle_count(cfg_t *cfg)
|
|
|
|
|
{
|
|
|
|
|
unsigned count = 0, multiplier = 1;
|
|
|
|
|
foreach_block(block, cfg) {
|
|
|
|
|
if (block->start()->opcode == BRW_OPCODE_DO)
|
|
|
|
|
multiplier *= 10; /* assume that loops execute ~10 times */
|
|
|
|
|
|
|
|
|
|
count += block->cycle_count * multiplier;
|
|
|
|
|
|
|
|
|
|
if (block->end()->opcode == BRW_OPCODE_WHILE)
|
|
|
|
|
multiplier /= 10;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return count;
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
2014-08-31 21:19:47 -07:00
|
|
|
instruction_scheduler::run(cfg_t *cfg)
|
2011-01-18 17:16:49 -08:00
|
|
|
{
|
2015-06-09 10:26:53 -07:00
|
|
|
if (debug && !post_reg_alloc) {
|
2013-12-22 23:29:31 -08:00
|
|
|
fprintf(stderr, "\nInstructions before scheduling (reg_alloc %d)\n",
|
|
|
|
|
post_reg_alloc);
|
2015-06-09 10:26:53 -07:00
|
|
|
bs->dump_instructions();
|
2012-12-04 13:52:19 -08:00
|
|
|
}
|
|
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
if (!post_reg_alloc)
|
|
|
|
|
setup_liveness(cfg);
|
2013-10-14 11:38:09 -07:00
|
|
|
|
2014-08-31 21:19:47 -07:00
|
|
|
foreach_block(block, cfg) {
|
2015-06-09 10:26:53 -07:00
|
|
|
if (reads_remaining) {
|
|
|
|
|
memset(reads_remaining, 0,
|
|
|
|
|
grf_count * sizeof(*reads_remaining));
|
|
|
|
|
memset(hw_reads_remaining, 0,
|
|
|
|
|
hw_reg_count * sizeof(*hw_reads_remaining));
|
|
|
|
|
memset(written, 0, grf_count * sizeof(*written));
|
|
|
|
|
|
|
|
|
|
foreach_inst_in_block(fs_inst, inst, block)
|
|
|
|
|
count_reads_remaining(inst);
|
|
|
|
|
}
|
|
|
|
|
|
2014-08-31 21:19:47 -07:00
|
|
|
add_insts_from_block(block);
|
2011-01-18 17:16:49 -08:00
|
|
|
|
2013-04-29 14:05:33 -07:00
|
|
|
calculate_deps();
|
2013-10-28 00:11:45 -07:00
|
|
|
|
2016-08-16 00:01:31 -07:00
|
|
|
compute_delays();
|
2016-08-16 00:56:04 -07:00
|
|
|
compute_exits();
|
2013-10-28 00:11:45 -07:00
|
|
|
|
2014-08-31 21:19:47 -07:00
|
|
|
schedule_instructions(block);
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
|
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
if (debug && !post_reg_alloc) {
|
2013-12-22 23:29:31 -08:00
|
|
|
fprintf(stderr, "\nInstructions after scheduling (reg_alloc %d)\n",
|
|
|
|
|
post_reg_alloc);
|
2015-05-20 09:44:01 -07:00
|
|
|
bs->dump_instructions();
|
2013-04-29 14:05:33 -07:00
|
|
|
}
|
2015-06-06 10:55:21 -04:00
|
|
|
|
|
|
|
|
cfg->cycle_count = get_cycle_count(cfg);
|
2013-04-29 14:05:33 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
2013-11-06 17:38:23 -08:00
|
|
|
fs_visitor::schedule_instructions(instruction_scheduler_mode mode)
|
2013-04-29 14:05:33 -07:00
|
|
|
{
|
2015-10-30 18:19:34 -04:00
|
|
|
if (mode != SCHEDULE_POST)
|
|
|
|
|
calculate_live_intervals();
|
2015-06-09 10:26:53 -07:00
|
|
|
|
2013-04-29 14:05:33 -07:00
|
|
|
int grf_count;
|
2013-11-06 17:38:23 -08:00
|
|
|
if (mode == SCHEDULE_POST)
|
2013-04-29 14:05:33 -07:00
|
|
|
grf_count = grf_used;
|
|
|
|
|
else
|
2015-02-10 15:51:34 +02:00
|
|
|
grf_count = alloc.count;
|
2013-04-29 14:05:33 -07:00
|
|
|
|
2015-06-09 10:26:53 -07:00
|
|
|
fs_instruction_scheduler sched(this, grf_count, first_non_payload_grf,
|
|
|
|
|
cfg->num_blocks, mode);
|
2014-08-31 21:19:47 -07:00
|
|
|
sched.run(cfg);
|
2013-04-29 14:05:33 -07:00
|
|
|
|
2014-09-01 10:54:00 -07:00
|
|
|
invalidate_live_intervals();
|
2011-01-18 17:16:49 -08:00
|
|
|
}
|
2012-11-30 16:13:34 -08:00
|
|
|
|
|
|
|
|
void
|
|
|
|
|
vec4_visitor::opt_schedule_instructions()
|
|
|
|
|
{
|
|
|
|
|
vec4_instruction_scheduler sched(this, prog_data->total_grf);
|
2014-08-31 21:19:47 -07:00
|
|
|
sched.run(cfg);
|
2012-11-30 16:13:34 -08:00
|
|
|
|
2014-09-01 10:54:00 -07:00
|
|
|
invalidate_live_intervals();
|
2012-11-30 16:13:34 -08:00
|
|
|
}
|