Iago Toral Quiroga
1fc846dce3
v3d: support 2712D0
...
2710D0 has V3D 7.1.10 which included draw index and
base vertex in the shader state record packet, shuffling
the locations of most of its fields. Handle this at run
time by emitting the appropriate packet based on the
V3D version since our current versoning framework doesn't
support changes based on revision number alone.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29189 >
2024-05-15 13:57:10 +00:00
Lionel Landwerlin
c518a176f5
nir: add ptr_bit_size parameter to nir_lower_printf
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25814 >
2024-05-15 13:13:37 +00:00
Lionel Landwerlin
2be28ee58a
nir: add a base offset for printf indexing
...
This will allow a driver to use a single table of printf strings
across all shaders.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25814 >
2024-05-15 13:13:37 +00:00
Karol Herbst
1e78e4a344
rusticl/device: properly handle devices with no support for images
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29205 >
2024-05-15 11:00:23 +00:00
Karol Herbst
017ae1f02d
rusticl/device/caps: move enough for has_images
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29205 >
2024-05-15 11:00:23 +00:00
Karol Herbst
e02b4e0d44
rusticl/device: add DeviceCaps and move timestamp stuff into it
...
We do query caps quite a lot and this struct should be used to cache
results and to make it easier to express more complex dependencies between
features (e.g. images being supported or not).
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29205 >
2024-05-15 11:00:23 +00:00
Paulo Zanoni
4384c8782e
anv+zink/ci: add failures related to multi-sampled sparse binding
...
After enabling multi-sampled sparse binding in Anv, we get these
failures. I've investigated them and none are trivial, it's not clear
if they're Anv's fault or not, especially considering how many other
texture-related failures we already have in this fails.txt file.
Since both deqp-vk and Vulkan native apps seem to be working with pure
Anv (no Zink), I don't think it's worth blocking multi-sampled sparse
on Anv just because of Zink.
From what I have investigated, the problems seem related to the
following:
- glcts is expecting 1D images to have 2D block shapes (this is
definitely the case for StandardPageSizesTestCase, we get rid of
the failure by either removing sparse support for 1D images or
telling their block shapes are the same as the 2D images)
- glcts/zink may be trying to use formats that are unsupported by Anv
as if they were supported
- there's probably something funny going on with the GL_R8 format
v2: Adjust test results after merging merging MR 29118.
v3: Zink test results are a moving target...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> (v1)
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27306 >
2024-05-15 08:00:16 +00:00
Marek Olšák
90b0925588
radeonsi: constify struct pipe_vertex_buffer *
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:34 +00:00
Marek Olšák
283f8af976
radeonsi/ci: remove some gfx11 flakes
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:34 +00:00
Marek Olšák
f237f497eb
radeonsi/ci: update failures for all generations
...
This also removes ASTC failures fixed by:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:34 +00:00
Marek Olšák
87fd149bd8
radeonsi/ci: fix caselists for vk-gl-cts/main
...
The files were moved in the repo.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:34 +00:00
Marek Olšák
b91220a825
radeonsi: remove slow code from si_msaa_resolve_blit_via_CB
...
This is mainly a cleanup. It wasn't faster.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
Marek Olšák
b771d13557
radeonsi: replace the clear_12bytes_buffer shader with the DMA compute shader
...
It can handle 12-byte clear values with these trivial changes.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
Marek Olšák
995e7d927c
radeonsi: use set_work_size for all internal compute dispatches
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
Marek Olšák
83d8b3bc1a
radeonsi: simplify the complex clear/copy_buffer shader
...
Remove the logic that we don't need. In a future commit, it will be
extended to optimize aspects of buffer clears and copies that need to be
optimized.
Changes:
- remove the logic that generated multiple loads/stores per thread,
only 1 load and store can occur in the shader now, allowing clearing/
copying max 4 dwords per thread
- put the src buffer in SSBO slot 0, and the dst buffer in SSBO slot 1
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
Marek Olšák
92497d1c8f
radeonsi: minor simplifications of clear/copy_buffer shaders
...
- always use L2_LRU (never use ACCESS_NON_TEMPORAL) - for better perf
- never use ACCESS_COHERENT because the address might not be aligned to
a cache line
- assume the wave size is always 64
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
Marek Olšák
81c90cded0
radeonsi: get NIR options from si_screen instead of calling get_compiler_options
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
Marek Olšák
56f2cc2277
radeonsi/gfx11: use a lighter workaround for Navi31 dEQP failures
...
This passes tests.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
Marek Olšák
602dd4c601
radeonsi: set flags directly instead of having needs_db_flush
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
Marek Olšák
5ebe75fab1
radeonsi: remove GDS tests
...
They were useful in the past. Not anymore.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
Marek Olšák
0e546fb683
radeonsi: validate the buffer range in si_set_shader_buffer
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
Marek Olšák
1d3dbb2bef
radeonsi: fix the size of the query result SSBO
...
This was harmless because the shader writes only 4 bytes if the type has
32 bits.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
Marek Olšák
96cf96f611
radeonsi: serialize shader disassembly string to fix asm dumps for ACO
...
Shaders loaded from the shader cache should be printable. Before this,
sometimes only "(null)" was printed.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29053 >
2024-05-15 06:42:33 +00:00
David Rosca
b33bb4077d
frontends/va: Only increment slice offset after first slice parameters
...
Fixes slice offset if app submits exactly one data buffer followed by
parameter buffers.
Fixes: 6746d4df6e ("frontends/va: Fix AV1 slice_data_offset with multiple slice data buffers")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11133
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11138
Tested-by: Marcus Seyfarth <m.seyfarth@gmail.com>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29124 >
2024-05-14 18:51:03 +00:00
Mike Blumenkrantz
f4a66eadf9
zink: set all spirv caps for the vvl vtn pass
...
this avoids internal warnings/errors from caps
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29195 >
2024-05-14 17:47:01 +00:00
Karol Herbst
48c752d3e0
event: break long dependency chains on drop
...
This prevents stack overflows on drop without making it expensive to read
from dependencies (e.g. my attempt to use Weak instead).
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29190 >
2024-05-14 17:26:39 +00:00
Karol Herbst
2f1f98e846
Revert "rusticl/event: use Weak refs for dependencies"
...
I didn't like the solution and I _think_ it even introduced a potential
regressions involving releasing failed events and that causing dependents
to run and succeed regardless.
This reverts commit a45f199086 .
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29190 >
2024-05-14 17:26:38 +00:00
Karol Herbst
be0a893a2e
rusticl/spirv: enable more caps
...
Silences warnings about them.
Fixes: ba11b12a82 ("rusticl: Use the new spirv_capabilities struct")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29193 >
2024-05-14 14:33:05 +00:00
Konstantin Seurer
1f0f76dbdc
radv/ci: Document recent flakes
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29188 >
2024-05-14 13:09:28 +00:00
Tapani Pälli
01608de875
iris: ForceZeroRTAIndexEnable if last geom stage does not write layer id
...
This matches anv and specification behavior, change makes us toggle the
field in tests/application that may use layered framebuffer but do not
assign any value to gl_Layer.
Example of such a test:
KHR-GL46.geometry_shader.layered_rendering_boundary_condition.layered_rendering_boundary_condition_no_default_layer
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29064 >
2024-05-14 08:09:17 +00:00
Alyssa Rosenzweig
ee9dab83e7
asahi: don't ralloc in agx_fast_link
...
let the driver allocate upfront so we can suballoc etc.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:27 +00:00
Alyssa Rosenzweig
c1d68da5e2
asahi: plumb tri fan flatshading through common
...
not yet used in the GL driver but we should probably fix that.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:27 +00:00
Alyssa Rosenzweig
cad60ab4b1
asahi: extend varying linking for tri fan weirdness
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:27 +00:00
Alyssa Rosenzweig
d763ab2de0
asahi: don't allocate for ppp updates
...
let the driver.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:27 +00:00
Alyssa Rosenzweig
3eacd8a8b2
asahi: don't allocate varyings ourselves
...
let the driver do it.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:27 +00:00
Alyssa Rosenzweig
96521fbce3
asahi: use ppp_merge
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:27 +00:00
Alyssa Rosenzweig
22292afd3c
asahi: pack tilebuffer usc word ahead-of-time
...
reduce draw time overhead.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
64e2502e54
asahi: eliminate num_workgroups for VS->GS + VS->TCS
...
this is a step towards simpler geom/tess uniform management.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
45e5b7ad50
asahi: mv initialization of grid z for indirect GS
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
4a344de276
asahi: rm redundant input_vertices
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
0b7b201ab6
asahi: move some GS lowering into lower_gs
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
f18f578b63
asahi: rm dead code
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
f6b863df30
asahi: set src_type for store_output
...
Fixes: 1632948a76 ("nir: validate src_type of store_output intrinsics, require bit_size >= 16")
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
5b3af5b7e6
asahi: rearrange VS uniforms
...
this puts draw parameters in the right order and adds in the draw ID. together
this makes MDI a lot more straightforward to do efficiently.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
6d518609e3
asahi: eliminate troublesome empty uniforms
...
these don't do what you expect and are wasteful.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
cccf0609a6
asahi: simplify image atomic lowering
...
Do more calculation in the preamble so we can do less pointer chasing and keep
everything within our 64-bit budget.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
afdc6891c1
asahi: mv AGX_MAX_OCCLUSION_QUERIES define
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
883b5407c8
asahi: rework VBO lower for divisor=0
...
silly special case that we should handle.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
3cb8c1de81
asahi: get debug in common
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00
Alyssa Rosenzweig
6373de5195
asahi: move agx_link_varyings_vs_fs
...
nothing gl here except for point sprites
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179 >
2024-05-14 04:57:26 +00:00