Timur Kristóf
7ee52b7066
radv: Don't call nir_remove_unused_varyings anymore
...
The nir_remove_unused_varyings pass is not necessary anymore,
because nir_opt_varyings already does the same.
Fossil DB stats on Strix Halo (GFX11.5):
Totals from 3085 (3.86% of 79825) affected shaders:
MaxWaves: 91286 -> 91290 (+0.00%)
Instrs: 1337749 -> 1335687 (-0.15%); split: -0.39%, +0.24%
CodeSize: 6625244 -> 6618148 (-0.11%); split: -0.38%, +0.27%
VGPRs: 140424 -> 140352 (-0.05%); split: -0.07%, +0.02%
Latency: 5028592 -> 5021465 (-0.14%); split: -0.26%, +0.12%
InvThroughput: 669773 -> 671718 (+0.29%); split: -0.24%, +0.53%
VClause: 24431 -> 24407 (-0.10%); split: -0.17%, +0.07%
SClause: 30114 -> 29435 (-2.25%); split: -2.28%, +0.03%
Copies: 99243 -> 101319 (+2.09%); split: -1.32%, +3.41%
Branches: 27445 -> 27599 (+0.56%)
PreSGPRs: 119444 -> 119472 (+0.02%); split: -0.67%, +0.69%
PreVGPRs: 96667 -> 96688 (+0.02%); split: -0.00%, +0.02%
VALU: 741846 -> 744017 (+0.29%); split: -0.14%, +0.44%
SALU: 197068 -> 195256 (-0.92%); split: -0.96%, +0.05%
VMEM: 54067 -> 54053 (-0.03%); split: -0.03%, +0.00%
SMEM: 56565 -> 55131 (-2.54%); split: -2.59%, +0.05%
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33979 >
2026-01-01 18:03:22 -06:00
Timur Kristóf
43496a6bf9
radv: Don't call nir_compact_varyings anymore
...
nir_compact_varyings is not necessary anymore, because everything
that it does, is also done by nir_opt_varyings.
The resulting shader stats are slightly negative because
without nir_compact_varyings, the I/O variables in TCS
are sorted less "fortunately".
After discussing this with the RADV team, we decided that
this is an acceptable loss.
Fossil DB stats on Strix Halo (GFX11.5):
Totals from 4577 (5.73% of 79825) affected shaders:
MaxWaves: 130456 -> 130532 (+0.06%); split: +0.06%, -0.00%
Instrs: 3012724 -> 3014809 (+0.07%); split: -0.06%, +0.13%
CodeSize: 15476368 -> 15484724 (+0.05%); split: -0.05%, +0.10%
VGPRs: 227976 -> 227832 (-0.06%); split: -0.14%, +0.07%
Latency: 13230769 -> 13237431 (+0.05%); split: -0.03%, +0.08%
InvThroughput: 1862029 -> 1864167 (+0.11%); split: -0.07%, +0.19%
VClause: 43128 -> 43123 (-0.01%); split: -0.08%, +0.07%
SClause: 61636 -> 61647 (+0.02%); split: -0.01%, +0.02%
Copies: 178023 -> 180309 (+1.28%); split: -0.80%, +2.09%
PreSGPRs: 195628 -> 195683 (+0.03%)
PreVGPRs: 161817 -> 161749 (-0.04%)
VALU: 1828727 -> 1831037 (+0.13%); split: -0.08%, +0.20%
SALU: 336688 -> 336668 (-0.01%); split: -0.01%, +0.00%
VMEM: 99441 -> 99545 (+0.10%); split: -0.00%, +0.11%
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33979 >
2026-01-01 18:01:34 -06:00
Timur Kristóf
e2fabb4e4a
radv: Don't call nir_opt_combine_stores anymore
...
Also no need for nir_lower_tess_level_array_vars_to_vec.
These should be now handled by nir_opt_vectorize_io.
Fossil DB stats on Strix Halo (GFX11.5):
Totals from 373 (0.47% of 79825) affected shaders:
Instrs: 381930 -> 380786 (-0.30%); split: -0.30%, +0.00%
CodeSize: 1888160 -> 1883644 (-0.24%); split: -0.24%, +0.01%
Latency: 1008755 -> 1008053 (-0.07%); split: -0.08%, +0.01%
InvThroughput: 156523 -> 155275 (-0.80%); split: -0.81%, +0.01%
Copies: 22357 -> 20812 (-6.91%); split: -6.93%, +0.02%
VALU: 240904 -> 239359 (-0.64%); split: -0.64%, +0.00%
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33979 >
2026-01-01 17:59:48 -06:00
Timur Kristóf
1106b0a1e2
radv: Only run some optimizations when scalarization made progress
...
These passes are called to clean up after scalarization, so
only call them when scalarization actually made progress.
No Fossil DB changes on Strix Halo (GFX11.5)
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33979 >
2026-01-01 17:54:55 -06:00
Timur Kristóf
58020fdc01
radv: Scalarize and re-vectorize unlinked shader I/O
...
Reasons to do this:
- Optimize VS inputs (always unlinked)
- Allow some optimization on unlinked shaders for GPL/ESO
- Prepare for retiring the old linking passes
Fossil DB stats on Strix Halo (GFX11.5):
Totals from 1814 (2.27% of 79825) affected shaders:
MaxWaves: 51232 -> 51434 (+0.39%)
Instrs: 1213430 -> 1212744 (-0.06%); split: -0.20%, +0.14%
CodeSize: 6124996 -> 6122472 (-0.04%); split: -0.17%, +0.13%
VGPRs: 93336 -> 92988 (-0.37%); split: -0.45%, +0.08%
Latency: 5360820 -> 5357501 (-0.06%); split: -0.29%, +0.23%
InvThroughput: 763087 -> 762937 (-0.02%); split: -0.11%, +0.09%
VClause: 22037 -> 22059 (+0.10%); split: -0.19%, +0.29%
SClause: 30971 -> 30884 (-0.28%); split: -0.46%, +0.17%
Copies: 73139 -> 73294 (+0.21%); split: -0.82%, +1.03%
Branches: 20370 -> 20346 (-0.12%)
PreSGPRs: 77373 -> 77404 (+0.04%)
PreVGPRs: 68218 -> 67093 (-1.65%); split: -1.78%, +0.13%
VALU: 662849 -> 663059 (+0.03%); split: -0.09%, +0.12%
SALU: 206745 -> 206781 (+0.02%); split: -0.06%, +0.08%
VMEM: 34230 -> 34250 (+0.06%)
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33979 >
2026-01-01 17:54:31 -06:00
Timur Kristóf
8e6bff4caa
radv: Lower 64-bit VS inputs to 32-bit
...
In RADV, we already lower all 64-bit I/O to 32-bit,
except VS inputs. Most of the newer NIR passes that
deal with I/O do not support 64-bit I/O, so now it's
time for us to also lower 64-bit VS inputs to 32-bit.
No Fossil DB changes on Strix Halo (GFX11.5).
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33979 >
2026-01-01 17:44:40 -06:00
Timur Kristóf
1981b9836b
nir/opt_vectorize_io: Fix allow_holes option
...
Only allow holes between the first and last used component.
Do not load unused components before the first used component.
This fixes test failures with a bunch of VK CTS tests
with allow_holes enabled on RADV:
dEQP-VK.tessellation.tess_io.max_in_out.with_f16.*
Fixes: 6286c1c66f
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33979 >
2026-01-01 17:38:01 -06:00
Dylan Baker
caf9c0ee3c
docs: update calendar for 25.3.3
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39121 >
2026-01-01 20:44:23 +00:00
Dylan Baker
319222c796
docs: Add 25.3.3 checksums
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39121 >
2026-01-01 20:44:23 +00:00
Dylan Baker
60e4bd4d0a
docs: add release notes for 25.3.3
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39121 >
2026-01-01 20:44:23 +00:00
Yiwei Zhang
f47c9b3f9c
venus: amend missing VKAPI_ATTR/CALL for render pass APIs
...
Fixes: c696ec3b73 ("venus: add missing VKAPI_ATTR/CALL")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39033 >
2026-01-01 20:11:28 +00:00
Marek Olšák
27dcc2b949
rusticl: call nir_opt_intrinsics
...
required by radeonsi
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:29 +00:00
Marek Olšák
b72b313d1d
radeonsi: move info fields from si_shader_selector to si_shader_info
...
also move the code into si_shader_info.c
si_shader_info::msaa_images becomes unused, so is removed.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:29 +00:00
Marek Olšák
3f23421dc5
radeonsi: remove si_shader_selector::*_descriptors_index fields
...
They are trivial to compute.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:29 +00:00
Marek Olšák
f00f054087
ac,radeonsi: move lowering to load_color0/1 to ac_nir_lower_ps_early
...
It's better to have these all in one pass.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:29 +00:00
Marek Olšák
99a42bdd4b
nir,radeonsi: simplify load_color0 & load_color1 intrinsics and shader_info
...
We don't need the shader_info fields anymore. sample and centroid fields
are unused. The interp field is already available from
si_shader_info::color_interpolate.
The loads don't need to be sysvals. Add also the _amd suffix.
Don't handle it in st_nir_lower_drawpixels either because the intrinsics
are created much later in compilation now.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:28 +00:00
Marek Olšák
86fc413098
radeonsi: merge 2 PS color input lowering passes for monolithic shaders
...
si_nir_lower_color_inputs_to_sysvals is mostly undone by
si_nir_lower_ps_color_inputs.
Merge them into a new pass si_nir_lower_color_flatshade_twoside, which
surprisingly doesn't need si_shader_info.
si_nir_lower_color_inputs_to_sysvals will continue to be used
by non-monolithic shaders.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:28 +00:00
Marek Olšák
80c26d3aec
radeonsi: call si_nir_lower_color_inputs_to_sysvals in si_preprocess_nir
...
si_shader_info gathering must be rewritten for colors because it no longer
receives load_color0/1 intrinsics. This makes radeonsi handle color inputs
more like all other drivers.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:27 +00:00
Marek Olšák
04047f0df6
radeonsi: remove the rest of si_lower_nir
...
st/mesa already calls all these passes.
Only our passthrough TCS was missing one pass.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:27 +00:00
Marek Olšák
d8f8b57686
radeonsi: move more lowering from si_lower_nir to si_preprocess_nir
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:27 +00:00
Marek Olšák
81adf1ea71
radeonsi: remove glsl_tests subdirectory
...
This hasn't been used for 9 years.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:26 +00:00
Marek Olšák
041cde6aa1
radeonsi: move sparse intrinsic lowering to a separate file, call it later
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:26 +00:00
Marek Olšák
2dc16ccb8f
radeonsi: lower task & mesh shader IO is si_preprocess_nir
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:26 +00:00
Marek Olšák
9d271d171a
radeonsi: call nir_lower_gs_intrinsics in si_preprocess_nir
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:25 +00:00
Marek Olšák
f2947e2fd8
radeonsi: use ac_nir_opt_vectorize_cb
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:25 +00:00
Marek Olšák
a32a189386
radeonsi: call nir_opt_16bit_tex_image in si_postprocess_nir
...
It's slightly changed and some cleanup passes are run afterwards
to do exactly what RADV does.
We also have to call nir_lower_alu_width, otherwise ACO fails.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:24 +00:00
Marek Olšák
a20f189a04
radeonsi: don't set progress uselessly in si_postprocess_nir
...
it's unused here
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:24 +00:00
Marek Olšák
6a1eeefce5
radeonsi: call nir_lower_fp16_casts in si_postprocess_nir
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:23 +00:00
Marek Olšák
cd1e6982a8
radeonsi: move NIR callbacks to si_get.c
...
they are only used to set NIR options
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:22 +00:00
Marek Olšák
823565fff1
radeonsi/ci: update gfx12 flakes
...
The uniform block tests are only flaky with LLVM.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:22 +00:00
Marek Olšák
55d53e827a
radeonsi: use si_preprocess/postprocess_nir function names
...
Most drivers use such names.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:22 +00:00
Marek Olšák
8ceef4e3d4
radeonsi: lower compute system values later
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:21 +00:00
Marek Olšák
3cc5517925
radeonsi: move CS sysval si_shader_info fields into si_shader_variant_info
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:21 +00:00
Marek Olšák
04e6e70e69
radeonsi: move CS user SGPR layout determination into si_shader_variant_info
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:20 +00:00
Marek Olšák
1bff4115e7
radeonsi: rename si_shader_info & si_shader_variant_info sysval fields
...
the prefix is changed to uses_sysval_*, some variables are renamed
completely to match the NIR names
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:19 +00:00
Marek Olšák
ce7c989b2b
radeonsi: fold nir_lower_compute_system_values_options into pass parameters
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:18 +00:00
Marek Olšák
2250b05067
radeonsi: lower nir_var_mem_shared later
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:18 +00:00
Marek Olšák
d320a6553c
radeonsi: update XFB info in the correct place after mediump IO lowering
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:16 +00:00
Marek Olšák
68690eaf4a
Revert "radeonsi: use nir_opt_large_constants earlier"
...
This reverts commit df2eaba411 .
We no longer use LCSSA because divergence analysis doesn't need it anymore.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:15 +00:00
Marek Olšák
7f7dbf68f4
radeonsi: call si_nir_mark_divergent_texture_non_uniform later
...
it doesn't have to be called in finalize_nir
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:15 +00:00
Marek Olšák
314e81def5
radeonsi: remove unnecessary NIR divergence analysis invocations
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:14 +00:00
Marek Olšák
e76fae1e0c
radeonsi: rename si_nir_scan_shader -> si_nir_gather_info, etc.
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:14 +00:00
Marek Olšák
4875e0a993
radeonsi: don't scalarize IO in finalize_nir
...
To make NIR more readable for ST_DEBUG=nir.
Shader info needs small changes to handle vector clipdist outputs.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:13 +00:00
Marek Olšák
904cc43556
radeonsi: remove unused FS input slots due to colors
...
This might have decreased performance due to extra LDS usage.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:12 +00:00
Marek Olšák
d06616063c
radeonsi: assert that IO bases don't have holes & the same base isn't used twice
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:11 +00:00
Marek Olšák
affaf36685
radeonsi: assert that invalid FS inputs aren't present
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:11 +00:00
Marek Olšák
e5b1c568b9
radeonsi: fix color interpolation when finalize_nir is called twice
...
Calling finalize_nir twice causes si_nir_lower_color_inputs_to_sysvals
to be called twice. The pass always sets color interpolation to FLAT
at the beginning, and then lowers color input loads and sets the correct
interpolation mode. However, when the pass is called for the second time,
it just sets color interpolation to flat and does nothing, which overrides
the original interpolation mode.
This fixes color interpolation for those cases. This only happens with
ATI_fragment_shader AFAIK.
Fixes: deda05e2b7 - nir: move nir_lower_color_inputs into radeonsi
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38802 >
2026-01-01 18:30:11 +00:00
Franz Hoeltermann
0b86e1f752
device-select: Avoid usage of legacy GetPhysicalDeviceProperties
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
This caused validation errors and redundantly called both the new "2"
variant and the legacy variant
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39058 >
2026-01-01 17:51:35 +00:00
Georg Lehmann
369a3b22b4
nir/opt_uniform_subgroup: optimize uniform ddx/ddy
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
We can't just use 0.0 as the replacement because of NaN/Inf.
But turning the intrinsic into a simple fsub should still be better
or at least equal.
Foz-DB Navi48:
Totals from 128 (0.10% of 125402) affected shaders:
MaxWaves: 3684 -> 3708 (+0.65%)
Instrs: 111150 -> 111055 (-0.09%); split: -0.20%, +0.11%
CodeSize: 587176 -> 590800 (+0.62%); split: -0.01%, +0.63%
VGPRs: 6540 -> 6480 (-0.92%)
Latency: 382775 -> 383332 (+0.15%); split: -0.15%, +0.29%
InvThroughput: 80909 -> 80530 (-0.47%); split: -0.51%, +0.04%
VClause: 1433 -> 1430 (-0.21%)
SClause: 1834 -> 1841 (+0.38%); split: -0.11%, +0.49%
Copies: 6130 -> 6096 (-0.55%); split: -1.29%, +0.73%
PreSGPRs: 7352 -> 7356 (+0.05%)
PreVGPRs: 4797 -> 4721 (-1.58%)
VALU: 71892 -> 71435 (-0.64%); split: -0.64%, +0.01%
SALU: 12665 -> 13056 (+3.09%); split: -0.06%, +3.14%
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39112 >
2026-01-01 08:43:55 +00:00
Marek Olšák
7ed6679361
mesa: allow pipeline statistics in glCreateQueries
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
All other functions use get_query_binding_point to validate the target.
Cc: mesa-stable
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39096 >
2025-12-31 17:07:31 +00:00