Commit graph

69589 commits

Author SHA1 Message Date
Valentine Burley
775cd85ed3 ci/android: Add a version and renderer check for android-angle-lavapipe
Add one GLES 2 test to run in the deqp-runner suite of the
android-angle-lavapipe job to verify the version and renderer used.

Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35337>
2025-06-05 11:43:18 +00:00
Martin Krastev
ca8719bebf svga/ci: vmware farm is out; temporary relegate piglit job to manual
Signed-off-by: Martin Krastev <martin.krastev@broadcom.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35364>
2025-06-05 10:57:20 +00:00
Icenowy Zheng
dca392b119 Revert "zink: reject Imagination proprietary driver w/o geometryShader"
This reverts commit ca087e2027.

It's discovered that the newest Rogue proprietary Vulkan driver does not
prevent us from running Zink (aside from an assert of geometryShader,
which is already changed to an if clause), and which fails previously is
because of some bugs in old driver blobs.

As the faulty blob versions are rejected now, revert this commit to
accept Rogue drivers.

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34183>
2025-06-05 10:37:56 +00:00
Icenowy Zheng
b6d7736792 zink: reject IMG blob < 24.1@6554834 unless enforced
Imagination closed blobs earlier than 24.1@6554834 has some issues about
NULL pCommandBuffers in VkSubmitInfo, which is present in VkSubmitInfo's
submitted by Zink.

Reject these drivers to prevent crashes, unless zink is enforced and the
user knows what they're doing.

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34183>
2025-06-05 10:37:56 +00:00
Icenowy Zheng
45d9d55cc1 zink: don't assert geometryShader for IMG proprietary driver
The proprietary driver for Imagination Rogue-architecture GPUs does not
come with geometryShader support.

Change the assert for it to another if condition.

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34183>
2025-06-05 10:37:56 +00:00
Mike Blumenkrantz
1ad37360de zink: update renderdoc layer string for android
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35350>
2025-06-04 19:08:48 +00:00
Marek Olšák
c3034fa82c amd: replace most u_bit_consecutive* with BITFIELD_MASK/RANGE
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35346>
2025-06-04 17:46:38 +00:00
Martin Krastev
f1f684ffa7 svga/ci: return svga piglit job to automatic rules pool
Make svga piglit job extend from vmware automatic (non-manual) rules pool
again. There was an issue with local nginx caching of FDO artifacts, which
led to jobs sporadically timing out on their http-download sections; the
issue has been resolved now.

Signed-off-by: Martin Krastev <martin.krastev@broadcom.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35341>
2025-06-04 17:04:34 +00:00
Antonio Ospite
859e903004 ci/android: skip org.skia.skqp.SkQPRunner#UnitTest_SurfaceResolveTest
Skip `org.skia.skqp.SkQPRunner#UnitTest_SurfaceResolveTest` when running
the `android-angle-android-cts` job, as it fails sporadically.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35126>
2025-06-04 15:43:42 +00:00
Antonio Ospite
0a8fec6c6d ci/android: skip org.skia.skqp.SkQPRunner#UnitTest_BulkTextureRectTest
Skip `org.skia.skqp.SkQPRunner#UnitTest_BulkTextureRectTest` when running
the `android-angle-android-cts` job, as it sometimes fails with memory
related issues.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35126>
2025-06-04 15:43:42 +00:00
Ashley Smith
c5500cd12f mesa: Add support for GL_EXT_shader_realtime_clock
This is similar to ARB_shader_clock

Signed-off-by: Ashley Smith <ashley.smith@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34345>
2025-06-04 14:49:00 +00:00
Jose Maria Casanova Crespo
e7de2bd086 v3d: Remove struct v3d_surface and create/destroy surface functions
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35288>
2025-06-04 11:18:32 +00:00
Jose Maria Casanova Crespo
5e4b66e226 v3d: Stop calling deprecated util_framebuffer_init
We remove all v3d usages of create_surface hooks.

See https://gitlab.freedesktop.org/mesa/mesa/-/issues/13262

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35288>
2025-06-04 11:18:32 +00:00
Jose Maria Casanova Crespo
680b6d0e9b v3d: Remove separate_stencil from v3d_surface
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35288>
2025-06-04 11:18:32 +00:00
Jose Maria Casanova Crespo
46ef49ab55 v3d: Remove internal_type and internal_bpp from v3d_surface
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35288>
2025-06-04 11:18:32 +00:00
Jose Maria Casanova Crespo
735cf1cb78 v3d: Remove padded_height_of_output_image_in_uif_blocks from v3d_surface
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35288>
2025-06-04 11:18:31 +00:00
Jose Maria Casanova Crespo
1fe0327255 v3d: Remove tiling from v3d_surface
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35288>
2025-06-04 11:18:31 +00:00
Jose Maria Casanova Crespo
b3228e0648 v3d: Remove never used offset from v3d_surface
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35288>
2025-06-04 11:18:30 +00:00
Jose Maria Casanova Crespo
c13135f7c3 v3d: Remove rt_format from v3d_surface
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35288>
2025-06-04 11:18:30 +00:00
Jose Maria Casanova Crespo
46b96e0079 v3d: Remove swap_rb logic from v3d_surface
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35288>
2025-06-04 11:18:29 +00:00
Jose Maria Casanova Crespo
27279b2cbe vc4: Remove struct vc4_surface and create/destroy surface functions
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35278>
2025-06-04 10:31:50 +00:00
Jose Maria Casanova Crespo
ba950f9556 vc4: Stop calling deprecated util_framebuffer_init
We remove all vc4 usages of create_surface hooks.

See https://gitlab.freedesktop.org/mesa/mesa/-/issues/13262

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35278>
2025-06-04 10:31:50 +00:00
Jose Maria Casanova Crespo
40f3dac716 vc4: Remove tiling from vc4_surface
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35278>
2025-06-04 10:31:50 +00:00
Jose Maria Casanova Crespo
51bc2e607f vc4: Remove offset from vc4_surface
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35278>
2025-06-04 10:31:49 +00:00
Lionel Landwerlin
79498a0849 brw: fix brw_nir_fs_needs_null_rt helper
In 9b42215e0d ("iris: ensure null render target for specific cases") I
wrongly assumed that writing gl_SampleMask would only happen in
multisampled cases.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 9b42215e0d ("iris: ensure null render target for specific cases")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13292
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35313>
2025-06-04 10:10:38 +00:00
Karol Herbst
fa94b1b29c rusticl: check the returned pointer of mmap
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Prior Linux 4.17 MAP_FIXED_NOREPLACE might not be respected and might
return a pointer different than the requested one.

Fixes: da4de8d7e3 ("rusticl: add support for coarse-grain buffer SVM")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35286>
2025-06-04 06:28:39 +00:00
Karol Herbst
9b28067b59 rusticl: move unmap out of debug_assert_eq statement
Fixes: da4de8d7e3 ("rusticl: add support for coarse-grain buffer SVM")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35286>
2025-06-04 06:28:39 +00:00
Karol Herbst
931ec3e954 rusticl: fix compilation on non Linux systems
Thanks to @jbeich to validate this on FreeBSD!

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13278
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35286>
2025-06-04 06:28:39 +00:00
Mauro Rossi
9fd6bae3c4 llvmpipe: Use mkdir instead of std::filesystem::create_directory on Android
libc++fs symbols are not available to vendor modules up to Android 15
this patch allows to build llvmpipe as module for Android 14 and older

Backport-to: 25.1
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35208>
2025-06-03 22:01:01 +00:00
Mauro Rossi
4aafb5fcc3 llvmpipe: Define LP_NIR_SHADER_DUMP_DIR differently on Android
Reference Android temporary path /data/local/tmp is used for Android builds

Backport-to: 25.1
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35208>
2025-06-03 22:01:01 +00:00
Mike Blumenkrantz
d8a6ec5985 lavapipe: undo fb remapping before poisoning memory at end of renderpass
in a scenario like:
* begin_rendering(cbuf1:store=DONTCARE, cbuf2)
* draw
* remap(cbuf2, NULL)
* draw
* end_rendering

cbuf1 will be poisoned at the end of the renderpass, but the corresponding
clear call to trigger the poisoning will not be able to detect that this
texture is being written by an async fs, causing a write hazard

unremapping the fb here ensures that all attachments are fb-referenced
as expected in order to guarantee threads sync before memory is poisoned

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35319>
2025-06-03 18:57:23 +00:00
Juan A. Suarez Romero
2cac70558d v3d,v3dv: set max supertiles to 256
So far the driver was configuring the supertiles to be less than 256.
But actually, there can be up to 256, not strictly less than 256.

There is one restriction though: the frame width or height in supertiles
must be less than 256.

It also moves this limit to the limits file, which is shared by v3d and
v3dv.

Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35257>
2025-06-03 11:21:14 +00:00
Karol Herbst
9e3f190e2e rusticl/kernel: rework unsafe block inside clSetKernelArg
No functional change

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35305>
2025-06-03 11:04:45 +00:00
Karol Herbst
f663e3330c rusticl/memory: properly set pipe_image_view::access
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13294
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35305>
2025-06-03 11:04:45 +00:00
Karol Herbst
868ae6a262 rusticl/kernel: implement CL_INVALID_ARG_VALUE for image args in clSetKernelArg
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35305>
2025-06-03 11:04:45 +00:00
Marek Olšák
bf2ed20eb9 nir: remove unused nir_io_semantics::invariant
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Acked-by: Alyssa on IRC
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35256>
2025-06-02 23:08:58 +00:00
Mike Blumenkrantz
a7e61f95b8 zink: delete zink_ctx_surface
finally the nightmare is over

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35240>
2025-06-02 20:51:47 +00:00
Mike Blumenkrantz
1d1ca611be zink: don't fixup depth buffer if it's already big enough
the zs buffer doesn't have to exactly match the size of the framebuffer,
it just has to be "big enough"

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35240>
2025-06-02 20:51:47 +00:00
Mike Blumenkrantz
3dc8d81332 zink: delete zink_ctx_surface::needs_mutable
this was some awfulness required because previously pipe_surface objects
could be created from a different thread, but now they are only ever created
by the driver

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35240>
2025-06-02 20:51:47 +00:00
Mike Blumenkrantz
8ad4b07c38 zink: delete zink_ctx_surface::transient
this untangles a lot of code and makes surfaces very nearly comprehensible

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35240>
2025-06-02 20:51:47 +00:00
Mike Blumenkrantz
92d76f16ed zink: delete another pipe_surface from msaa replicate
this was never used anyway

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35240>
2025-06-02 20:51:47 +00:00
Mike Blumenkrantz
92f4d506d7 zink: remove some trivial transient surface references in rt init
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35240>
2025-06-02 20:51:47 +00:00
Mike Blumenkrantz
ad5a115246 zink: slightly rework transient surface/image handling
this was a big nightmare because of how the pipe_surface object worked,
but now it's more possible to move the backing multisampled image
onto the base resource and reuse the 'valid' flag instead of the special
surface one for transients

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35240>
2025-06-02 20:51:47 +00:00
Mike Blumenkrantz
4f81f121e6 zink: remove a pipe_surface from blitting
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35240>
2025-06-02 20:51:47 +00:00
Alyssa Rosenzweig
e5e91887cf asahi: clang-format
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35295>
2025-06-02 20:34:32 +00:00
Alyssa Rosenzweig
49564786f7 asahi: drop dead surface stuff
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35295>
2025-06-02 20:34:32 +00:00
Mike Blumenkrantz
e0641fdac7 zink: fix ZINK_RENDERDOC=all
the intent of this option is to create a single capture for the lifetime
of the app, which is great for unit test debugging, and this instead
created a capture for every queue submission, which is a nightmare

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35292>
2025-06-02 17:34:04 +00:00
Mike Blumenkrantz
cb6dfc4169 zink: unlock instance mutex if creation fails
avoids a deadlock

Fixes: 015eda4a41 ("zink: deduplicate VkDevice and VkInstance")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35292>
2025-06-02 17:34:04 +00:00
Eric Engestrom
f611fb4af9 svga/ci: fix indentation
The list of files is _inside_ `changes:`, not alongside it.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35289>
2025-06-02 17:15:18 +00:00
Eric Engestrom
0c5fa54b5b svga/ci: fix job stages
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35289>
2025-06-02 17:15:18 +00:00