Commit graph

161059 commits

Author SHA1 Message Date
Konstantin Seurer
5f859f805b radv: Rename node_internal to node_box32
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19017>
2022-10-11 20:27:24 +00:00
Brian Paul
da856af2c9 draw: s/start_or_maxelt/start/ in llvm VS code
Per the now removed comment, the maxelt part of start_or_maxelt was
not used.  Rename to start to avoid confusion.

Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
4c73a503e3 draw: move vs_slot var in tgsi/llvm_fetch_gs_input()
Move the decl to where it's first used.  Remove the unneeded increment.

Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
717572e5be draw: fix some const-correctness in draw_vbo()
There's no need to cast away const for use_info and draw_info.  There
might have been a reason in the past.

Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
0a809fca61 draw: make draw_geometry_shader_run() return void
The return value was always zero and unused.

Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
8d8683ab1d draw: replace double conditional expression with if/else
This is a bit more verbose, but quicker to grok, IMHO.

Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
645a3d24a1 draw: asst. clean-ups in draw_pt_fetch_shade_pipeline_llvm.c
Also rename vid_base to vertex_id_offset to match code elsewhere.

Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
baee3c62f7 draw: asst. clean-ups in draw_private.h
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
bfaed9dd63 draw: clean-up count assignment in draw_pt_arrays()
count was initialized to draw_info[i].count but then re-assigned a few
lines later.  Remove the original assignment.  Move the var decl.

Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
e4552632aa draw: asst. clean-ups in draw_pt.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
529707d4ef draw: asst. clean-ups in draw_split_tmp.h
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
39a42c48e3 draw: asst. clean-ups in draw_pt_vsplit_tmp.h
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
0a340419cb draw: asst. clean-ups in draw_pipe.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
f83e284543 draw: asst. clean-ups in draw_prim_assembler.[ch]
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
8613316a31 draw: asst. clean-ups in draw_gs.[ch]
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:37 +00:00
Brian Paul
490f7a14f6 draw: asst. clean-ups in draw_cliptest_tmp.h
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
0d27e3b917 draw: asst. clean-ups in draw_llvm.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
4e6a32219b draw: asst. clean-ups in draw_pipe_aapoint.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
6af739bb9e draw: asst. clean-ups in draw_pt_so_emit.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
9daf8531e5 draw: asst. clean-ups in draw_vertex.[ch]
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
3ac0b2115c draw: asst. clean-ups in draw_pipe_wide_point.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
07e2ecd0cf draw: asst. clean-ups in draw_pipe_wide_line.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
0a31e24d22 draw: asst. clean-ups in draw_pipe_util.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
8a3b365b92 draw: asst. clean-ups in draw_pipe_user_cull.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
7488f0fe27 draw: asst. clean-ups in draw_pipe_unfilled.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
49705deb67 draw: asst. clean-ups in draw_pipe_twoside.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
aa2eabbc2d draw: asst. clean-ups in draw_pipe_pstipple.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
3c1cba7038 draw: asst. clean-ups in draw_pipe_offset.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
d654164041 draw: asst. clean-ups in draw_pipe_flatshade.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
ff329ac1e0 draw: asst. clean-ups in draw_pipe_clip.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
230584fed5 draw: asst. clean-ups in draw_pipe_cull.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
b813bab889 draw: asst. clean-ups in draw_pt_post_vs.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
6f1b99ab06 draw: asst. clean-ups in draw_pt_fetch.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
da2932c634 draw: asst. clean-ups in draw_pipe.h
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
67ee7ddfb7 draw: remove unused draw_has_llvm()
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
7178d30a52 draw: remove goto in llvm_pipeline_generic()
Just use an else clause.

Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
f058873832 draw: asst. clean-ups in draw_vs.[ch]
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
c5ddbc6ba7 draw: asst. clean-ups in draw_vs_variant.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
327742c2c9 draw: asst. clean-ups in draw_vs_llvm.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Brian Paul
32218eabdb draw: asst. clean-ups in draw_context.[ch]
Fix whitespace/formatting for consistency.  Move var decls to where
they're first used, etc.

Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19024>
2022-10-11 20:04:36 +00:00
Bas Nieuwenhuizen
243aa6b2ec radv: Consider inactive internal nodes never in the tree.
Since the parent doesn't know to signal it.

Fixes: e83e4fafc8 ("radv: Only emit parents from parents that actually end up in the tree.")
Reviewed-By: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19033>
2022-10-11 19:33:46 +00:00
Emma Anholt
8721323100 turnip: Add perf debug for more UBWC-disable cases that we could support.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18990>
2022-10-11 19:10:18 +00:00
Emma Anholt
c425b7342e turnip: Add perf_debug for UBWC being disabled due to mutable formats.
I suspect this is going to be a popular perf issue for zink and angle.  I
keep having to print out format lists for debug.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18990>
2022-10-11 19:10:18 +00:00
Emma Anholt
29488c4183 turnip: Move the ubwc_possible check before mutable formats.
I'm going to add some perf debug about mutable formats, and I don't want
to warn when UBWC would be impossible anyway.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18990>
2022-10-11 19:10:18 +00:00
Emma Anholt
4fe3330765 turnip: Add a perf_debug for feedback-related performance traps.
This can show up in layering drivers.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18990>
2022-10-11 19:10:18 +00:00
Emma Anholt
3c278c3f71 zink: Decorate mediump outputs as RelaxedPrecision.
The NIR lowering for mediump can sometimes detect stores of 16-bit values
and demote the outputs, but even better is to have them decorated properly
in the first place.  Fixes a bunch of full-precision outputs in gfxbench
Aztec Ruins.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18960>
2022-10-11 18:22:16 +00:00
Emma Anholt
2592749679 zink: Fix RelaxedPrecision decoration of texture samples.
You can't do it unless GL called the sampler mediump.  Also, the spirv
says "For image-sampling operations, decorations can appear on both the
sampling instruction and the image variable being sampled.  If either is
decorated, they both should be decorated, and if both are decorated their
decorations must match. If only one is decorated, the sampling instruction
can behave either as if both were decorated or neither were decorated." so
emit it on the declaration too.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18960>
2022-10-11 18:22:16 +00:00
Emma Anholt
f5f5fed7e2 ci/zink: Add some more flakes for turnip.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18960>
2022-10-11 18:22:16 +00:00
Bas Nieuwenhuizen
66664b8d7c radv: Implement pipeline-wide skiptriangles/skipaabbs.
Reviewed-By: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19030>
2022-10-11 18:03:23 +00:00
Samuel Pitoiset
65dd53ca97 radv: always re-emit patch control points when a pipeline with tess is bound
We already re-emit this state when it's static. It could be dirtied
conditionally but the number of parameters to check is not worth it.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7457
Fixes: eef1511437 ("radv: implement dynamic patch control points")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19021>
2022-10-11 17:21:56 +00:00