mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-20 04:48:07 +02:00
Addresses:
```
Indirect leak of 256 byte(s) in 2 object(s) allocated from:
#0 0x7faaf53ee0 in __interceptor_malloc
../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
#1 0x7fa8cfe900 in ralloc_size ../src/util/ralloc.c:118
#2 0x7fa8cfeb20 in rzalloc_size ../src/util/ralloc.c:152
#3 0x7fa8cff004 in rzalloc_array_size ../src/util/ralloc.c:232
#4 0x7fa8d06a84 in _mesa_set_init ../src/util/set.c:133
#5 0x7fa8d06bcc in _mesa_set_create ../src/util/set.c:152
#6 0x7fa8d0939c in _mesa_pointer_set_create ../src/util/set.c:613
#7 0x7fa95e5790 in nir_lower_mediump_vars
../src/compiler/nir/nir_lower_mediump.c:574
#8 0x7fa862c1c8 in tu_spirv_to_nir(tu_device*, void*, unsigned long,
VkPipelineShaderStageCreateInfo const*, tu_shader_key const*,
pipe_shader_type) ../src/freedreno/vulkan/tu_shader.cc:116
#9 0x7fa8646f24 in tu_compile_shaders(tu_device*, unsigned long,
VkPipelineShaderStageCreateInfo const**, nir_shader**,
tu_shader_key const*, tu_pipeline_layout*, unsigned char const*,
tu_shader**, char**, void*, nir_shader**, VkPipelineCreationFeedback*)
../src/freedreno/vulkan/tu_shader.cc:2741
#10 0x7fa85a16a4 in tu_pipeline_builder_compile_shaders
../src/freedreno/vulkan/tu_pipeline.cc:1887
#11 0x7fa85eb844 in tu_pipeline_builder_build<(chip)7>
../src/freedreno/vulkan/tu_pipeline.cc:3923
#12 0x7fa85e6bd8 in tu_graphics_pipeline_create<(chip)7>
../src/freedreno/vulkan/tu_pipeline.cc:4203
#13 0x7fa85c2588 in VkResult
tu_CreateGraphicsPipelines<(chip)7>(VkDevice_T*,
VkPipelineCache_T*, unsigned int, VkGraphicsPipelineCreateInfo const*,
VkAllocationCallbacks const*, VkPipeline_T**)
../src/freedreno/vulkan/tu_pipeline.cc:4234
```
seen in:
dEQP-VK.binding_model.mutable_descriptor.single.switches.uniform_texel_buffer_storage_image.update_write.no_source.no_source.pool_expand_types.pre_update.no_array.vert
Fixes:
|
||
|---|---|---|
| .. | ||
| tests | ||
| .clang-format | ||
| meson.build | ||
| nir.c | ||
| nir.h | ||
| nir_algebraic.py | ||
| nir_builder.c | ||
| nir_builder.h | ||
| nir_builder_opcodes_h.py | ||
| nir_builtin_builder.c | ||
| nir_builtin_builder.h | ||
| nir_clone.c | ||
| nir_constant_expressions.h | ||
| nir_constant_expressions.py | ||
| nir_control_flow.c | ||
| nir_control_flow.h | ||
| nir_control_flow_private.h | ||
| nir_conversion_builder.h | ||
| nir_deref.c | ||
| nir_deref.h | ||
| nir_divergence_analysis.c | ||
| nir_dominance.c | ||
| nir_format_convert.c | ||
| nir_format_convert.h | ||
| nir_from_ssa.c | ||
| nir_functions.c | ||
| nir_gather_info.c | ||
| nir_gather_tcs_info.c | ||
| nir_gather_types.c | ||
| nir_gather_xfb_info.c | ||
| nir_group_loads.c | ||
| nir_gs_count_vertices.c | ||
| nir_inline_helpers.h | ||
| nir_inline_uniforms.c | ||
| nir_instr_set.c | ||
| nir_instr_set.h | ||
| nir_intrinsics.py | ||
| nir_intrinsics_c.py | ||
| nir_intrinsics_h.py | ||
| nir_intrinsics_indices_h.py | ||
| nir_legacy.c | ||
| nir_legacy.h | ||
| nir_linking_helpers.c | ||
| nir_liveness.c | ||
| nir_loop_analyze.c | ||
| nir_loop_analyze.h | ||
| nir_lower_alpha_test.c | ||
| nir_lower_alu.c | ||
| nir_lower_alu_width.c | ||
| nir_lower_amul.c | ||
| nir_lower_array_deref_of_vec.c | ||
| nir_lower_atomics.c | ||
| nir_lower_atomics_to_ssbo.c | ||
| nir_lower_bit_size.c | ||
| nir_lower_bitmap.c | ||
| nir_lower_blend.c | ||
| nir_lower_blend.h | ||
| nir_lower_bool_to_bitsize.c | ||
| nir_lower_bool_to_float.c | ||
| nir_lower_bool_to_int32.c | ||
| nir_lower_cl_images.c | ||
| nir_lower_clamp_color_outputs.c | ||
| nir_lower_clip.c | ||
| nir_lower_clip_cull_distance_arrays.c | ||
| nir_lower_clip_disable.c | ||
| nir_lower_clip_halfz.c | ||
| nir_lower_const_arrays_to_uniforms.c | ||
| nir_lower_continue_constructs.c | ||
| nir_lower_convert_alu_types.c | ||
| nir_lower_discard_if.c | ||
| nir_lower_double_ops.c | ||
| nir_lower_drawpixels.c | ||
| nir_lower_fb_read.c | ||
| nir_lower_flatshade.c | ||
| nir_lower_flrp.c | ||
| nir_lower_fp16_conv.c | ||
| nir_lower_frag_coord_to_pixel_coord.c | ||
| nir_lower_fragcolor.c | ||
| nir_lower_fragcoord_wtrans.c | ||
| nir_lower_frexp.c | ||
| nir_lower_global_vars_to_local.c | ||
| nir_lower_goto_ifs.c | ||
| nir_lower_gs_intrinsics.c | ||
| nir_lower_helper_writes.c | ||
| nir_lower_idiv.c | ||
| nir_lower_image.c | ||
| nir_lower_image_atomics_to_global.c | ||
| nir_lower_indirect_derefs.c | ||
| nir_lower_input_attachments.c | ||
| nir_lower_int64.c | ||
| nir_lower_int_to_float.c | ||
| nir_lower_interpolation.c | ||
| nir_lower_io.c | ||
| nir_lower_io_arrays_to_elements.c | ||
| nir_lower_io_to_scalar.c | ||
| nir_lower_io_to_temporaries.c | ||
| nir_lower_io_to_vector.c | ||
| nir_lower_is_helper_invocation.c | ||
| nir_lower_load_const_to_scalar.c | ||
| nir_lower_locals_to_regs.c | ||
| nir_lower_mediump.c | ||
| nir_lower_mem_access_bit_sizes.c | ||
| nir_lower_memcpy.c | ||
| nir_lower_memory_model.c | ||
| nir_lower_multiview.c | ||
| nir_lower_non_uniform_access.c | ||
| nir_lower_packing.c | ||
| nir_lower_passthrough_edgeflags.c | ||
| nir_lower_patch_vertices.c | ||
| nir_lower_phis_to_scalar.c | ||
| nir_lower_pntc_ytransform.c | ||
| nir_lower_point_size.c | ||
| nir_lower_point_size_mov.c | ||
| nir_lower_point_smooth.c | ||
| nir_lower_poly_line_smooth.c | ||
| nir_lower_printf.c | ||
| nir_lower_readonly_images_to_tex.c | ||
| nir_lower_reg_intrinsics_to_ssa.c | ||
| nir_lower_returns.c | ||
| nir_lower_robust_access.c | ||
| nir_lower_samplers.c | ||
| nir_lower_scratch.c | ||
| nir_lower_shader_calls.c | ||
| nir_lower_single_sampled.c | ||
| nir_lower_ssbo.c | ||
| nir_lower_subgroups.c | ||
| nir_lower_system_values.c | ||
| nir_lower_sysvals_to_varyings.c | ||
| nir_lower_task_shader.c | ||
| nir_lower_terminate_to_demote.c | ||
| nir_lower_tess_coord_z.c | ||
| nir_lower_tex.c | ||
| nir_lower_tex_shadow.c | ||
| nir_lower_texcoord_replace.c | ||
| nir_lower_texcoord_replace_late.c | ||
| nir_lower_two_sided_color.c | ||
| nir_lower_ubo_vec4.c | ||
| nir_lower_undef_to_zero.c | ||
| nir_lower_uniforms_to_ubo.c | ||
| nir_lower_var_copies.c | ||
| nir_lower_variable_initializers.c | ||
| nir_lower_vars_to_ssa.c | ||
| nir_lower_vec3_to_vec4.c | ||
| nir_lower_vec_to_regs.c | ||
| nir_lower_view_index_to_device_index.c | ||
| nir_lower_viewport_transform.c | ||
| nir_lower_wpos_center.c | ||
| nir_lower_wpos_ytransform.c | ||
| nir_lower_wrmasks.c | ||
| nir_metadata.c | ||
| nir_mod_analysis.c | ||
| nir_move_vec_src_uses_to_dest.c | ||
| nir_normalize_cubemap_coords.c | ||
| nir_opcodes.py | ||
| nir_opcodes_c.py | ||
| nir_opcodes_h.py | ||
| nir_opt_access.c | ||
| nir_opt_algebraic.py | ||
| nir_opt_barriers.c | ||
| nir_opt_combine_stores.c | ||
| nir_opt_comparison_pre.c | ||
| nir_opt_conditional_discard.c | ||
| nir_opt_constant_folding.c | ||
| nir_opt_copy_prop_vars.c | ||
| nir_opt_copy_propagate.c | ||
| nir_opt_cse.c | ||
| nir_opt_dce.c | ||
| nir_opt_dead_cf.c | ||
| nir_opt_dead_write_vars.c | ||
| nir_opt_find_array_copies.c | ||
| nir_opt_frag_coord_to_pixel_coord.c | ||
| nir_opt_fragdepth.c | ||
| nir_opt_gcm.c | ||
| nir_opt_generate_bfi.c | ||
| nir_opt_idiv_const.c | ||
| nir_opt_if.c | ||
| nir_opt_intrinsics.c | ||
| nir_opt_large_constants.c | ||
| nir_opt_licm.c | ||
| nir_opt_load_store_vectorize.c | ||
| nir_opt_loop.c | ||
| nir_opt_loop_unroll.c | ||
| nir_opt_memcpy.c | ||
| nir_opt_move.c | ||
| nir_opt_move_discards_to_top.c | ||
| nir_opt_mqsad.c | ||
| nir_opt_non_uniform_access.c | ||
| nir_opt_offsets.c | ||
| nir_opt_peephole_select.c | ||
| nir_opt_phi_precision.c | ||
| nir_opt_preamble.c | ||
| nir_opt_ray_queries.c | ||
| nir_opt_reassociate_bfi.c | ||
| nir_opt_rematerialize_compares.c | ||
| nir_opt_remove_phis.c | ||
| nir_opt_shrink_stores.c | ||
| nir_opt_shrink_vectors.c | ||
| nir_opt_sink.c | ||
| nir_opt_undef.c | ||
| nir_opt_uniform_atomics.c | ||
| nir_opt_uniform_subgroup.c | ||
| nir_opt_varyings.c | ||
| nir_opt_vectorize.c | ||
| nir_opt_vectorize_io.c | ||
| nir_passthrough_gs.c | ||
| nir_passthrough_tcs.c | ||
| nir_phi_builder.c | ||
| nir_phi_builder.h | ||
| nir_print.c | ||
| nir_propagate_invariant.c | ||
| nir_range_analysis.c | ||
| nir_range_analysis.h | ||
| nir_remove_dead_variables.c | ||
| nir_remove_tex_shadow.c | ||
| nir_repair_ssa.c | ||
| nir_scale_fdiv.c | ||
| nir_schedule.c | ||
| nir_schedule.h | ||
| nir_search.c | ||
| nir_search.h | ||
| nir_search_helpers.h | ||
| nir_serialize.c | ||
| nir_serialize.h | ||
| nir_split_64bit_vec3_and_vec4.c | ||
| nir_split_per_member_structs.c | ||
| nir_split_var_copies.c | ||
| nir_split_vars.c | ||
| nir_sweep.c | ||
| nir_to_lcssa.c | ||
| nir_trivialize_registers.c | ||
| nir_use_dominance.c | ||
| nir_validate.c | ||
| nir_vla.h | ||
| nir_worklist.c | ||
| nir_worklist.h | ||
| nir_xfb_info.h | ||
| README | ||
New IR, or NIR, is an IR for Mesa intended to sit below GLSL IR and Mesa IR. Its design inherits from the various IRs that Mesa has used in the past, as well as Direct3D assembly, and it includes a few new ideas as well. It is a flat (in terms of using instructions instead of expressions), typeless IR, similar to TGSI and Mesa IR. It also supports SSA (although it doesn't require it). Variables ========= NIR includes support for source-level GLSL variables through a structure mostly copied from GLSL IR. These will be used for linking and conversion from GLSL IR (and later, from an AST), but for the most part, they will be lowered to registers (see below) and loads/stores. Registers ========= Registers are light-weight; they consist of a structure that only contains its size, its index for liveness analysis, and an optional name for debugging. In addition, registers can be local to a function or global to the entire shader; the latter will be used in ARB_shader_subroutine for passing parameters and getting return values from subroutines. Registers can also be an array, in which case they can be accessed indirectly. Each ALU instruction (add, subtract, etc.) works directly with registers or SSA values (see below). SSA ======== Everywhere a register can be loaded/stored, an SSA value can be used instead. The only exception is that arrays/indirect addressing are not supported with SSA; although research has been done on extensions of SSA to arrays before, it's usually for the purpose of parallelization (which we're not interested in), and adds some overhead in the form of adding copies or extra arrays (which is much more expensive than introducing copies between non-array registers). SSA uses point directly to their corresponding definition, which in turn points to the instruction it is part of. This creates an implicit use-def chain and avoids the need for an external structure for each SSA register. Functions ========= Support for function calls is mostly similar to GLSL IR. Each shader contains a list of functions, and each function has a list of overloads. Each overload contains a list of parameters, and may contain an implementation which specifies the variables that correspond to the parameters and return value. Inlining a function, assuming it has a single return point, is as simple as copying its instructions, registers, and local variables into the target function and then inserting copies to and from the new parameters as appropriate. After functions are inlined and any non-subroutine functions are deleted, parameters and return variables will be converted to global variables and then global registers. We don't do this lowering earlier (i.e. the fortranizer idea) for a few reasons: - If we want to do optimizations before link time, we need to have the function signature available during link-time. - If we do any inlining before link time, then we might wind up with the inlined function and the non-inlined function using the same global variables/registers which would preclude optimization. Intrinsics ========= Any operation (other than function calls and textures) which touches a variable or is not referentially transparent is represented by an intrinsic. Intrinsics are similar to the idea of a "builtin function," i.e. a function declaration whose implementation is provided by the backend, except they are more powerful in the following ways: - They can also load and store registers when appropriate, which limits the number of variables needed in later stages of the IR while obviating the need for a separate load/store variable instruction. - Intrinsics can be marked as side-effect free, which permits them to be treated like any other instruction when it comes to optimizations. This allows load intrinsics to be represented as intrinsics while still being optimized away by dead code elimination, common subexpression elimination, etc. Intrinsics are used for: - Atomic operations - Memory barriers - Subroutine calls - Geometry shader emitVertex and endPrimitive - Loading and storing variables (before lowering) - Loading and storing uniforms, shader inputs and outputs, etc (after lowering) - Copying variables (cases where in GLSL the destination is a structure or array) - The kitchen sink - ... Textures ========= Unfortunately, there are far too many texture operations to represent each one of them with an intrinsic, so there's a special texture instruction similar to the GLSL IR one. The biggest difference is that, while the texture instruction has a sampler dereference field used just like in GLSL IR, this gets lowered to a texture unit index (with a possible indirect offset) while the type information of the original sampler is kept around for backends. Also, all the non-constant sources are stored in a single array to make it easier for optimization passes to iterate over all the sources. Control Flow ========= Like in GLSL IR, control flow consists of a tree of "control flow nodes", which include if statements and loops, and jump instructions (break, continue, and return). Unlike GLSL IR, though, the leaves of the tree aren't statements but basic blocks. Each basic block also keeps track of its successors and predecessors, and function implementations keep track of the beginning basic block (the first basic block of the function) and the ending basic block (a fake basic block that every return statement points to). Together, these elements make up the control flow graph, in this case a redundant piece of information on top of the control flow tree that will be used by almost all the optimizations. There are helper functions to add and remove control flow nodes that also update the control flow graph, and so usually it doesn't need to be touched by passes that modify control flow nodes.