Gert Wollny
fcafe1ffc8
r600/sfn: Make use of variable length DOT
...
This frees some alu slots for better group scheduling.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20205 >
2022-12-09 08:26:31 +00:00
Gert Wollny
906c5efc37
r600/sfn: Don't require assignemnt in same block to copy-propagate
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20205 >
2022-12-09 08:26:31 +00:00
Gert Wollny
5f82b4cf5b
r600/sfn: No need to pin LDS dests to chan
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20205 >
2022-12-09 08:26:31 +00:00
Gert Wollny
6d93139061
r600/sfn: allow copy propagation to LDS read dest
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20205 >
2022-12-09 08:26:30 +00:00
Gert Wollny
d7d07d0d32
r600/sfn: allow more copy-propagate with dest chan fixed.
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20205 >
2022-12-09 08:26:30 +00:00
Gert Wollny
5dc35cf1d1
r600/sfn: Allow copy prop into GDS sources values
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20205 >
2022-12-09 08:26:30 +00:00
Tapani Pälli
68ef0d8448
anv: emit sample mask state independent of fragment stage
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7861
Fixes: 9f6af43743 ("anv: dynamic multisample sample mask")
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20221 >
2022-12-09 08:00:42 +00:00
Samuel Pitoiset
25a5d7ac0d
radv: fix re-emitting the RB+ state when dynamic color write mask change
...
Found by inspection.
Fixes: a92d1d13c5 ("radv: add support for dynamic color write mask")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20204 >
2022-12-09 07:37:00 +00:00
Konstantin Seurer
4c83a96f16
radv/rt: Discard metadata after lowering intersection shaders
...
We inserted some enstructions and control flow. Therefore, metadata is
not valid anymore.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19866 >
2022-12-09 07:07:10 +00:00
Konstantin Seurer
79b7ed61a8
radv/rt: Lower hit attributes to registers
...
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19866 >
2022-12-09 07:07:10 +00:00
Konstantin Seurer
a598263800
radv/rt: Move load_hit_attrib_amd to the top
...
Make sure to load hit attributes before a trace_ray call can overwrite them.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19866 >
2022-12-09 07:07:10 +00:00
Konstantin Seurer
36125598c8
nir: Add intrinsics for hit attribute io
...
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19866 >
2022-12-09 07:07:10 +00:00
Konstantin Seurer
5bfc4c293f
nir/split_vars: Handle ray hit attributes
...
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19866 >
2022-12-09 07:07:10 +00:00
Konstantin Seurer
9f03e9c286
radv: Add nir_foreach_variable_with_modes to .clang-format
...
Yet another loop macro.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19866 >
2022-12-09 07:07:10 +00:00
Emma Anholt
433c6f5d3a
egl: Drop backwards compat for missing __DRI_ATTRIB_*_SHIFT.
...
The only implementation supports it.
Reviewed-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20171 >
2022-12-09 05:32:18 +00:00
Emma Anholt
a145a8301e
gbm: Don't look up the DRI2_FENCE extension.
...
It's optional, and nothing references it.
Reviewed-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20171 >
2022-12-09 05:32:18 +00:00
Emma Anholt
5ff8edaa2a
egl: Replace sRGB support check with a pscreen query.
...
This drops the remaining use of rendererQuery from EGL.
Reviewed-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20171 >
2022-12-09 05:32:18 +00:00
Emma Anholt
eb2dcda50c
egl: Move common eglCreateContext() error checks from backends to core.
...
Reviewed-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20171 >
2022-12-09 05:32:18 +00:00
Emma Anholt
e6285ea55f
egl: Replace the robustness DRI2 ext check with a pipe cap query.
...
This means that swkms will now report it with llvmpipe. drisw reported it
with llvmpipe, and it appears to have been an oversight that got
refactored into an obvious "if !swkms" check later.
Reviewed-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20171 >
2022-12-09 05:32:18 +00:00
Emma Anholt
f4b2f9cff2
egl: Remove silly robustness support checks.
...
The EGL frontend checks for the extension's presence before allowing the
user to set these values.
Reviewed-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20171 >
2022-12-09 05:32:18 +00:00
Brian Paul
83b0f10941
gallivm: s/unsigned/enum util_format_type/ in lp_build_sample_common()
...
Use the actual type here for easier debugging.
Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20233 >
2022-12-09 05:04:37 +00:00
Brian Paul
bc048f5c51
gallivm: fix incorrect type for undefined texcoords
...
Texcoords may be 1-5 components in length. We initialize the
unused components with an LLVMGetUndef(). But we were using
an int vec type rather than a float vec type.
This eventually led to a failed assertion in lp_build_clamp()
where 'a' was a vec of int[8] but 'min' and 'max' were float[8]
in a trace of the game Tom Clancy's Splinter Cell: Blacklist.
The game seems to have a bug where a texture sampler mistakenly has
shadow comparison turned on, but the shader's tex sample instructions
are sampling a 2D R8G8B8A8_UNORM texture. The instruction has a
2-component texcoord so when we do the sampler comparison operation
we're using the undefined 5th coordinate component.
Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20233 >
2022-12-09 05:04:37 +00:00
Boyuan Zhang
5233551e19
radeonsi: disable av1 decode for navi24
...
Disable AV1 decode for Navi24 since hardware doesn't support.
fixed: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7855
cc: mesa-stable
Signed-off-by: Boyuan Zhang <boyuan.zhang@amd.com>
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20230 >
2022-12-09 04:38:40 +00:00
Brian Paul
f3d2d076ed
gallivm: misc clean-ups in lp_bld_nir.c
...
Use switch instead of if/else. Add some braces. 80-column wrapping, etc.
Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20211 >
2022-12-09 04:00:54 +00:00
Brian Paul
d44c4b1e0e
llvmpipe: misc clean-ups in lp_scene.c
...
Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20211 >
2022-12-09 04:00:54 +00:00
Brian Paul
7b7c2e3cac
llvmpipe: misc clean-ups in lp_rast.c
...
Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20211 >
2022-12-09 04:00:54 +00:00
Brian Paul
72f8e821e3
gallivm: minor clean-ups in lp_bld_quad.c
...
Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20211 >
2022-12-09 04:00:54 +00:00
Brian Paul
f83bf1adc4
gallivm: asst. clean-ups in lp_bld_sample_soa.c
...
Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20211 >
2022-12-09 04:00:54 +00:00
Brian Paul
b8e792e7cc
gallivm: clean-ups in lp_bld_sample.c
...
Formatting/whitespace fixes. Add const qualifiers, move var decls, etc.
Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20211 >
2022-12-09 04:00:54 +00:00
Marek Olšák
44614965a5
mesa: fix typos in gl_array_attrib comments
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19783 >
2022-12-09 03:18:53 +00:00
Marek Olšák
d25df150b8
mesa: use the format table for double attrib format translation too
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19783 >
2022-12-09 03:18:53 +00:00
Marek Olšák
593e4ae4b4
mesa: add a format table for GL_BGRA vertex format translation too
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19783 >
2022-12-09 03:18:53 +00:00
Marek Olšák
1b4278117a
mesa: add more cases to the gallium vertex_formats table
...
The way we convert gltype to the index changed to handle more enums.
The reason why (gltype & 0x3f) works is because of how the enums are
defined.
Also change the type to uint8_t. We only need the low 7 bits of
the pipe format enum.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19783 >
2022-12-09 03:18:53 +00:00
Marek Olšák
7089a4c59f
st/mesa: move setting draw_needs_minmax_index into st_update_array_templ
...
This removes several parameters from setup_array that become unused.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19783 >
2022-12-09 03:18:53 +00:00
Marek Olšák
4bf6ac2e42
st/mesa: simplify st_setup_current parameters
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19783 >
2022-12-09 03:18:53 +00:00
Marek Olšák
98b7c4ea09
st/mesa: optimize uploading zero-stride vertex attribs
...
Instead of memcpy into a temporary array and then upload from that,
upload into a buffer directly.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19783 >
2022-12-09 03:18:53 +00:00
Marek Olšák
a18b9d071d
st/mesa: remove alignment code from st_setup_current
...
I was the one who added this code and it doesn't seem useful.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19783 >
2022-12-09 03:18:53 +00:00
David Heidelberg
1d5962b0e6
ci: fix missing line after adding austraincoder's farm killswitch
...
Accidentally dropped.
Fixes: ff928d9567 ("ci: Allow disabling the whole of austriancoder's farm")
Reported-by: Ana Guerrero Lopez <anagl@igalia.com>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Reviewed-by: Ana Guerrero Lopez <anagl@igalia.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20236 >
2022-12-09 02:48:25 +00:00
Jordan Justen
0d9be82fe6
intel/genxml: Add genX_rt_pack.h
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20225 >
2022-12-09 01:43:39 +00:00
Lionel Landwerlin
b4b4294a78
intel/fs: add a saturation propagation test
...
Reviewed-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20206 >
2022-12-09 00:39:05 +00:00
Oleksii Bozhenko
d5d8bb1dbb
brw: fix saturate propagation region overlap range
...
Fixes: 947c828d5c
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7691
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Oleksii Bozhenko <oleksii.bozhenko@globallogic.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20206 >
2022-12-09 00:39:05 +00:00
Tapani Pälli
bc4b7de0d0
intel/fs: implement Wa_14017989577
...
The first instruction of any kernel should have non-zero emask. This
restriction needs to be obeyed to avoid GPU hangs.
Patch adds a function to insert dummy mov as first instruction
to make sure this requirement is fulfilled.
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20194 >
2022-12-08 23:58:32 +00:00
Chia-I Wu
5ba35fd6cc
freedreno: fix compute shared_size underflow
...
It caused ~5% of perf regression for some gfxbench benchmarks.
Fixes: b8d10d9e87 ("gallium: split up req_local_mem")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20219 >
2022-12-08 22:33:56 +00:00
Ruijing Dong
a7b3a279fb
radeonsi/vcn: av1 film_grain output fix
...
use film grain surface as the output instead of target,
which should be kept for DPB process.
fixed: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6903
CC: 22.3
Reviewed-by: Leo Liu <leo.liu@amd.com>
Signed-off-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20139 >
2022-12-08 21:59:24 +00:00
Ruijing Dong
af695149e9
frontends/va: pass in film_grain_target as new output
...
In av1 film grain case, to use the film_grain_target
as the output, instead of target buffer, which is kept
as the input for DPB processing in film_grain output
scenario.
CC: 22.3
Reviewed-by: Leo Liu <leo.liu@amd.com>
Signed-off-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20139 >
2022-12-08 21:59:24 +00:00
Ruijing Dong
7e91f94864
frontneds/va: use current_display_picture from VA for film grain
...
use the interface defined in vaapi for av1 film grain's output
https://github.com/intel/libva/blob/master/va/va_dec_av1.h#L296-L304
CC: 22.3
Reviewed-by: Leo Liu <leo.liu@amd.com>
Signed-off-by: Mark Thompson <sw@jkqxz.net>
Signed-off-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20139 >
2022-12-08 21:59:24 +00:00
Ruijing Dong
7f71f732ea
frontends/omx: initialize film_grain_target
...
set film_grain_target to NULL, and not using it
in omx path.
CC: 22.3
Reviewed-by: Leo Liu <leo.liu@amd.com>
Signed-off-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20139 >
2022-12-08 21:59:24 +00:00
Ruijing Dong
b70953f5ba
gallium: add film_grain_target into av1 dec desc
...
In vaapi, film_grain output will need to direct into
other output surface instead of the current render_target.
CC: 22.3
Reviewed-by: Leo Liu <leo.liu@amd.com>
Signed-off-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20139 >
2022-12-08 21:59:24 +00:00
Max Lee
2db09f5b22
drm-shim: add __readlink_chk as readlink with overflow check
...
As per Linux Standard Base Core Specification 4.0, __readlink_chk
display value of a symbolic link, with buffer overflow checking.
if size > buflen, abort() is called.
Signed-off-by: Max Lee <endlesspring@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19045 >
2022-12-08 21:05:15 +00:00
Matt Coster
3068f046bc
pvr: Check depth/stencil attachment is tile-aligned
...
The hardware requires depth/stencil attachments to be size-aligned to
the zls tile size (as defined by rogue_get_zls_tile_size_xy()).
In practice however, this is a tiny edge case. The restriction only
applies during some operations, and any attachment larger than the tile
size will be twiddled and over-allocated into alignment beforehand.
This commit also adds the mentioned rogue_get_zls_tile_size_xy()
function. These values differ from the regular tile_size_{x,y} feature
values in some cases. Instead of including them as features as well, we
compute them directly.
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20160 >
2022-12-08 14:53:13 +00:00