17189 commits

Author	SHA1	Message	Date
Samuel Pitoiset	7affd623c0	radv: slightly change the COND_EXEC for sampling performance counters ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34223>	2025-03-28 07:49:04 +00:00
Samuel Pitoiset	8d12578989	radv: add a helper to emit SPM muxsel ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34223>	2025-03-28 07:49:04 +00:00
Samuel Pitoiset	f12bf800e3	radv: add a helper to emit indirect buffer for draws/dispatches ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34223>	2025-03-28 07:49:04 +00:00
Samuel Pitoiset	af5cde7107	radv: apply some cosmetic changes for future begin/end CS sequences ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34223>	2025-03-28 07:49:04 +00:00
Samuel Pitoiset	391da996ed	radv: rework the shader pointer emit as macros ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34223>	2025-03-28 07:49:04 +00:00
Daniel Stone	df97f243e6	ci: Re-enable Collabora CI ... Now that all our S3 issues have been resolved, let's start running some tests again. Signed-off-by: Daniel Stone <daniels@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34244>	2025-03-27 20:23:15 +00:00
Samuel Pitoiset	09656e3dc4	radv/ci: fix renaming the VKCTS job for tahiti ... This one has been missing during the renames. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34226>	2025-03-27 08:00:57 +00:00
Samuel Pitoiset	ae8c0b06a7	radv: add radeon_event_write() macros ... Similar to RadeonSI. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34145>	2025-03-27 07:09:07 +00:00
Samuel Pitoiset	344aa38925	radv: add new helper to emit PKT3_EVENT_WRITE for sampling queries ... Everything in one function is easier to share. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34145>	2025-03-27 07:09:07 +00:00
Samuel Pitoiset	e2e8dca941	radv: rework radeon_set_uconfig_perfctr_reg_seq to use amd_ip_type ... To be more generic. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34145>	2025-03-27 07:09:07 +00:00
Samuel Pitoiset	88df7e709a	radv: move the optimized context reg macros with other similar ones ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34145>	2025-03-27 07:09:07 +00:00
Samuel Pitoiset	30948e63f4	radv: switch all emit helpers to macros ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34145>	2025-03-27 07:09:07 +00:00
Samuel Pitoiset	74a5266d8f	radv: replace radeon_set_reg_seq by a macro ... To be more close to RadeonSI, other similar functions will be replaced by macros in the next commits. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34145>	2025-03-27 07:09:07 +00:00
Georg Lehmann	8648d7cf75	ac/nir: set has_mul24_relaxed ... This is only used by OpenCL. Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33871>	2025-03-27 06:24:16 +00:00
Georg Lehmann	7c6a2b16e0	ac/llvm: support mul24_relaxed ... I didn't find dedicated 24bit intrinsics, but I also haven't looked that hard. Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33871>	2025-03-27 06:24:16 +00:00
Georg Lehmann	7631b10984	aco: implement mul24_relaxed ... Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33871>	2025-03-27 06:24:16 +00:00
Marek Olšák	219b2cde13	radeonsi: remove clover support ... Only Rusticl is supported. Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34215>	2025-03-27 01:59:19 +00:00
Valentine Burley	55749a5bbb	amd/ci: Rename AMD jobs to follow unified naming convention ... All AMD jobs now follow the new naming convention: {driver}-{gpu}-{test}. Signed-off-by: Valentine Burley <valentine.burley@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34147>	2025-03-26 22:27:00 +00:00
Valentine Burley	74ebd5d5b2	radv/ci: Delete obsolete vkcts-stoney-valve job ... This job won't be re-enabled, so delete it. Suggested by @mupuf. Signed-off-by: Valentine Burley <valentine.burley@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34147>	2025-03-26 22:27:00 +00:00
Samuel Pitoiset	c168fdcd50	radv/ci: delete empty radv-hawaii-skips.txt ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34147>	2025-03-26 22:27:00 +00:00
Samuel Pitoiset	a78eccdb9b	radv/ci: rename radv-gfx1200 to radv-gfx1201 ... Also create an empty file for flakes, otherwise deqp-runner complains. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34147>	2025-03-26 22:27:00 +00:00
Samuel Pitoiset	a6d47aeaa3	radv/ci: drop aco suffix for CI files ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34147>	2025-03-26 22:27:00 +00:00
Samuel Pitoiset	b89f45c5d8	radv/ci: remove radv-stoney-flakes.txt ... This file was never used because GPU_VERSION is radv-stoney-aco. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34147>	2025-03-26 22:26:59 +00:00
Samuel Pitoiset	7233df3d10	radv/ci: remove vkcts-navi21-llvm-valve completely ... This is disabled since a very long time and testing LLVM support with RADV in CI is kind of pointless. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34147>	2025-03-26 22:26:59 +00:00
Samuel Pitoiset	d73d570fa7	ci: uprev vkd3d-proton to 078f07f588c849c52fa21c8cfdd1c201465b1932 ... This contains few more tests as usual. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33941>	2025-03-26 21:16:39 +00:00
Rhys Perry	0619cc45b7	radv/winsys: set has_distributed_tess for null winsys ... Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33978>	2025-03-26 20:52:53 +00:00
Rhys Perry	ee0be147b9	radv/winsys: set gart_page_size for null winsys ... Fixes assertion failure when initializing memory types for devices without dedicated vram. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33978>	2025-03-26 20:52:53 +00:00
Rhys Perry	4632ca258b	radv/winsys: increase gfx12 vgprs for null winsys ... LLVM has Feature1_5xVGPRs for both gfx1200 and gfx1201. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33978>	2025-03-26 20:52:53 +00:00
Natalie Vock	d6cb45dbb0	aco/spill: Allow spilling live-through operands ... Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29730>	2025-03-26 19:18:30 +00:00
Natalie Vock	416a016127	aco: Add RegisterDemand(Temp) constructor ... Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29730>	2025-03-26 19:18:30 +00:00
Natalie Vock	ca7ce1fb33	aco/spill: Invert reloads map ... So we can quickly look up if an operand was reloaded without having to check renames. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29730>	2025-03-26 19:18:30 +00:00
Natalie Vock	39413ef78f	aco: Add get_temp_reg_changes helper ... Similar to get_live_changes, but considers live temporary registers as well. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29730>	2025-03-26 19:18:30 +00:00
Samuel Pitoiset	c036736e2e	radv/video: rework command buffer emission ... This is much closer to RadeonSI and could be shared at some point. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34150>	2025-03-26 14:59:12 +00:00
Samuel Pitoiset	0e0a393a4a	radv/video: use a pointer to write the total task size ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34150>	2025-03-26 14:59:12 +00:00
Samuel Pitoiset	2c3b9312cc	radv/meta: fix color<->depth/stencil image copies ... The color format needs to be compatible with depth or stencil. Also the depth/stencil format was incorrect when it's the source. Fixes dEQP-VK.api.ds_color_copy.* and VKD3D_TEST_FILTER=test_copy_texture. Fixes: d4ff011b12 ("radv: advertise VK_KHR_maintenance8") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34142>	2025-03-26 13:27:03 +00:00
Samuel Pitoiset	ef0a6f59f3	radv: use PM4 for setting specific graphics registers in the preamble ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34172>	2025-03-26 10:14:22 +00:00
Samuel Pitoiset	c5d0764fce	radv: remove radv_force_pstate_peak_gfx11_dgpu=true for Helldivers 2 ... Our QA team extensively tested Helldivers 2 on AMD RX 7800 XT/RX 7600 with many different presents and didn't get any GPU hangs. Few users also reported the game being very stable without this workaround. Few other users reported issues with the workaround itself (like pstate not correctly restored etc), so let's remove it. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34164>	2025-03-26 09:33:19 +00:00
Daniel Schürmann	afc605bc9b	aco: Remove empty exec skipping after demote ... Totals from 858 (1.08% of 79377) affected shaders: (Navi31) Instrs: 678713 -> 677694 (-0.15%); split: -0.15%, +0.00% CodeSize: 3732576 -> 3729104 (-0.09%); split: -0.10%, +0.01% Latency: 4199397 -> 4198632 (-0.02%); split: -0.06%, +0.04% InvThroughput: 691391 -> 691122 (-0.04%); split: -0.04%, +0.00% SClause: 14593 -> 14605 (+0.08%) Copies: 41279 -> 41288 (+0.02%); split: -0.04%, +0.06% Branches: 13575 -> 13452 (-0.91%) PreSGPRs: 29069 -> 29039 (-0.10%) VALU: 426261 -> 426215 (-0.01%); split: -0.01%, +0.00% SALU: 60458 -> 60471 (+0.02%); split: -0.02%, +0.04% Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33619>	2025-03-26 08:45:12 +00:00
Daniel Schürmann	90faadae72	aco/insert_exec_mask: don't disable dead quads on demote in divergent CF ... Also force-enalbe helpers in case of demote in divergent CF. Totals from 1305 (1.64% of 79377) affected shaders: (Navi31) Instrs: 926923 -> 922516 (-0.48%); split: -0.48%, +0.00% CodeSize: 5045292 -> 5027408 (-0.35%); split: -0.36%, +0.00% Latency: 6176577 -> 6174708 (-0.03%); split: -0.03%, +0.00% InvThroughput: 931603 -> 931583 (-0.00%); split: -0.00%, +0.00% SClause: 22816 -> 22855 (+0.17%); split: -0.17%, +0.34% Copies: 57347 -> 55170 (-3.80%); split: -3.81%, +0.01% Branches: 18990 -> 18974 (-0.08%) PreSGPRs: 42734 -> 43248 (+1.20%) SALU: 90511 -> 86153 (-4.81%); split: -4.85%, +0.04% Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33619>	2025-03-26 08:45:12 +00:00
Daniel Schürmann	b872ff6ef2	aco/insert_exec_mask: if applicable, use s_wqm to restore exec after divergent CF ... Totals from 4740 (5.97% of 79377) affected shaders: (Navi31) Instrs: 6273963 -> 6273410 (-0.01%); split: -0.01%, +0.00% CodeSize: 34306560 -> 34304284 (-0.01%); split: -0.01%, +0.00% SpillSGPRs: 1793 -> 1797 (+0.22%); split: -0.11%, +0.33% Latency: 62599300 -> 62598714 (-0.00%); split: -0.00%, +0.00% InvThroughput: 9117199 -> 9117189 (-0.00%); split: -0.00%, +0.00% SClause: 223548 -> 223529 (-0.01%); split: -0.02%, +0.01% Copies: 464248 -> 454711 (-2.05%); split: -2.06%, +0.00% Branches: 161446 -> 161443 (-0.00%); split: -0.00%, +0.00% PreSGPRs: 226278 -> 225608 (-0.30%) VALU: 3793235 -> 3793244 (+0.00%); split: -0.00%, +0.00% SALU: 606184 -> 605759 (-0.07%); split: -0.08%, +0.01% Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33619>	2025-03-26 08:45:12 +00:00
Daniel Schürmann	69dcd5be3a	aco: don't assume that demote doesn't cause an empty exec mask ... Totals from 188 (0.24% of 79377) affected shaders: (Navi31) Instrs: 209239 -> 209473 (+0.11%); split: -0.01%, +0.12% CodeSize: 1101124 -> 1101744 (+0.06%); split: -0.02%, +0.07% Latency: 1672182 -> 1672748 (+0.03%); split: -0.11%, +0.14% InvThroughput: 237276 -> 237546 (+0.11%); split: -0.00%, +0.12% SClause: 5694 -> 5690 (-0.07%); split: -0.28%, +0.21% Copies: 21685 -> 21682 (-0.01%); split: -0.12%, +0.10% Branches: 5740 -> 5863 (+2.14%) PreSGPRs: 7004 -> 7034 (+0.43%) VALU: 123595 -> 123641 (+0.04%); split: -0.00%, +0.04% SALU: 28418 -> 28411 (-0.02%); split: -0.09%, +0.06% Fixes: f35e229fae ('aco: skip code if exec is empty') Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33619>	2025-03-26 08:45:12 +00:00
Daniel Schürmann	c1b124ab6c	aco/lower_branches: properly consider exec mask needs of branch targets ... No fossil changes. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33619>	2025-03-26 08:45:11 +00:00
Samuel Pitoiset	4d68875acd	radv: cleanup passing the aspect mask for SDMA operations ... Less error prone than it used to be. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34143>	2025-03-25 19:13:20 +00:00
Samuel Pitoiset	e60cafa533	radv: remove useless parameter to radv_sdma_get_buf_surf() ... Same aspect mask is passed through. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34143>	2025-03-25 19:13:20 +00:00
Samuel Pitoiset	114fbdc534	radv: fix compresed depth/stencil copies on transfer queue ... HTILE is always pipe aligned. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34143>	2025-03-25 19:13:20 +00:00
Samuel Pitoiset	7b15e85b95	radv: fix bpe for the stencil aspect of depth/stencil copies on transfer queue ... Using the bpe of depth+stencil when copying the stencil aspect only doesn't work. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34143>	2025-03-25 19:13:20 +00:00
Rhys Perry	80fef30531	aco/ra: fix free register counting when moving variables ... info.bounds might be smaller than the bounds available for the moved variables. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Fixes: 626aa7b648 ("aco: workaround GFX9 hardware bug for D16 image instructions") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34158>	2025-03-25 15:14:16 +00:00
Samuel Pitoiset	d712c34a62	radv: add a helpers to know whether video decode/encode queues are enabled ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34144>	2025-03-25 12:49:10 +00:00
Samuel Pitoiset	2b2423f100	radv: remove meaningless comment when resetting SQTT trace ... It's just a NULL check. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34144>	2025-03-25 12:49:10 +00:00
Samuel Pitoiset	b1818a3ca9	radv: add a helper to know whether compute queue is enabled ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34144>	2025-03-25 12:49:10 +00:00