fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 00:10:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

radv: remove radv_force_pstate_peak_gfx11_dgpu=true for Helldivers 2
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
Our QA team extensively tested Helldivers 2 on AMD RX 7800 XT/RX 7600
with many different presents and didn't get any GPU hangs. Few users
also reported the game being very stable without this workaround.

Few other users reported issues with the workaround itself (like
pstate not correctly restored etc), so let's remove it.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34164>
This commit is contained in:
Samuel Pitoiset 2025-03-24 18:30:42 +01:00 • committed by Marge Bot
parent afc605bc9b
commit c5d0764fce
5 changed files with 0 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/amd/vulkan/radv_device.c
View file

@ -1378,11 +1378,6 @@ radv_CreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCr
device->capture_replay_arena_vas = _mesa_hash_table_u64_create(NULL);
}
if (pdev->info.gfx_level == GFX11 && pdev->info.has_dedicated_vram && instance->drirc.force_pstate_peak_gfx11_dgpu) {
if (!radv_device_acquire_performance_counters(device))
fprintf(stderr, "radv: failed to set pstate to profile_peak.\n");
}
*pDevice = radv_device_to_handle(device);
return VK_SUCCESS;

4
src/amd/vulkan/radv_instance.c
View file

@ -186,7 +186,6 @@ static const driOptionDescription radv_dri_options[] = {
DRI_CONF_RADV_FLUSH_BEFORE_TIMESTAMP_WRITE(false)
DRI_CONF_RADV_RT_WAVE64(false)
DRI_CONF_RADV_DISABLE_DEDICATED_SPARSE_QUEUE(false)
DRI_CONF_RADV_FORCE_PSTATE_PEAK_GFX11_DGPU(false)
DRI_CONF_RADV_OVERRIDE_GRAPHICS_SHADER_VERSION(0)
DRI_CONF_RADV_OVERRIDE_COMPUTE_SHADER_VERSION(0)
DRI_CONF_RADV_OVERRIDE_RAY_TRACING_SHADER_VERSION(0)
@ -262,9 +261,6 @@ radv_init_dri_options(struct radv_instance *instance)
instance->drirc.disable_dedicated_sparse_queue = driQueryOptionb(&instance->drirc.options, "radv_disable_dedicated_sparse_queue");
instance->drirc.force_pstate_peak_gfx11_dgpu =
driQueryOptionb(&instance->drirc.options, "radv_force_pstate_peak_gfx11_dgpu");
instance->drirc.override_graphics_shader_version =
driQueryOptioni(&instance->drirc.options, "radv_override_graphics_shader_version");
instance->drirc.override_compute_shader_version =

1
src/amd/vulkan/radv_instance.h
View file

@ -64,7 +64,6 @@ struct radv_instance {
bool ssbo_non_uniform;
bool flush_before_timestamp_write;
bool disable_dedicated_sparse_queue;
bool force_pstate_peak_gfx11_dgpu;
bool clear_lds;
bool enable_khr_present_wait;
bool report_llvm9_version_string;

4
src/util/00-radv-defaults.conf
View file

@ -171,10 +171,6 @@ Application bugs worked around in this file:
<option name="radv_disable_ngg_gs" value="true" />
</application>
<application name="Helldivers 2" executable="helldivers2.exe">
<option name="radv_force_pstate_peak_gfx11_dgpu" value="true" />
</application>
<!-- OpenGL Game workarounds (zink) -->
<application name="Black Geyser: Couriers of Darkness" executable="BlackGeyser.x86_64">
<option name="radv_zero_vram" value="true" />

4
src/util/driconf.h
View file

@ -766,10 +766,6 @@
DRI_CONF_OPT_B(radv_disable_dedicated_sparse_queue, def, \
"Disables the dedicated sparse queue. This replaces radv_legacy_sparse_binding as a compatible drirc workaround for games that might not expect a separate SPARSE queue")
#define DRI_CONF_RADV_FORCE_PSTATE_PEAK_GFX11_DGPU(def) \
DRI_CONF_OPT_B(radv_force_pstate_peak_gfx11_dgpu, def, \
"Force the performance level to profile_peak (all clocks to the highest levels) for RDNA3 dGPUs")
/**
* Overrides for forcing re-compilation of pipelines when RADV_BUILD_ID_OVERRIDE is enabled.
* These need to be bumped every time a compiler bugfix is backported (up to 8 shader