Sidney Just
ab87b19088
loader: Add missing brace to fix compile
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Fixes: 1a0ec8e8d3 ("loader,glx,egl,vl,d3d: loader_get_user_preferred_fd() function to return original_fd")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21115 >
2023-02-08 08:49:57 +00:00
Dave Airlie
53283bc26d
anv/video: fix video memory bindings.
...
A break snuck in here.
Fixes: 98c58a16ef ("anv: add initial video decode support for h264.")
Acked-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21184 >
2023-02-08 06:42:09 +00:00
Chia-I Wu
d6fb4d8d7d
freedreno/registers: correct WFM bit in CP_REG_TEST
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21151 >
2023-02-08 06:17:12 +00:00
Yiwei Zhang
dda85cf94b
venus: move exp features init back to use ring submit
...
Since largeRing has been enforced, there's no need to do renderer
submission to fill the exp features. So we move it back after ring has
been initialized. Meanwhile, vn_renderer_submit_simple_sync is
intentionally left there to be re-used soon for server ping purpose.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21153 >
2023-02-08 05:34:13 +00:00
Yiwei Zhang
830c7a9f1a
venus: render server enforces blob_id_0
...
Render server enforcement has guaranteed blob_id_0. Meanwhile, blob_id_0
has deprecated largeRing feature.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21153 >
2023-02-08 05:34:13 +00:00
Yiwei Zhang
0938c1f7e2
venus: fix tracing init to include instance creation
...
The issue was hidden so far because:
- wsi_device_init does the perfetto tracing init
- Android atrace does lazy tracing init
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21153 >
2023-02-08 05:34:13 +00:00
Yiwei Zhang
91b0ae93b2
venus: fix formating
...
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21153 >
2023-02-08 05:34:13 +00:00
Patrick Lerda
66313732a7
mesa/program: fix memory leak triggered by parser errors
...
This change requires the %destructor directive which is supported
by bison or yacc, yacc needs to be compiled with the back-tracking
functionality.
This issue could be checked with the following piglit programs:
glsl-invalid-asm-01, glsl-invalid-asm-02 or vp-bad-program
Direct leak of 5 byte(s) in 1 object(s) allocated from:
#0 0x7f8dc89050 in __interceptor_strdup (/usr/lib64/libasan.so.6+0x59050)
#1 0x7f83791cbc in handle_ident ../src/mesa/program/program_lexer.l:129
#2 0x7f83791cbc in _mesa_program_lexer_lex ../src/mesa/program/program_lexer.l:312
#3 0x7f8377e8d8 in yylex ../src/mesa/program/program_parse.y:289
#4 0x7f8377e8d8 in yyparse src/mesa/program/program_parse.tab.c:2124
#5 0x7f83788c14 in _mesa_parse_arb_program ../src/mesa/program/program_parse.y:2584
#6 0x7f8377371c in _mesa_parse_arb_fragment_program ../src/mesa/program/arbprogparse.c:82
#7 0x7f8372d42c in set_program_string ../src/mesa/main/arbprogram.c:402
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Acked-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21150 >
2023-02-08 04:58:33 +00:00
Juston Li
3061ec366e
venus: add SHADER_DEVICE_ADDRESS_BIT to buffer cache
...
VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT is being set by zink.
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21177 >
2023-02-08 04:14:42 +00:00
Chia-I Wu
4054b08f39
turnip: reorder tu6_format_*
...
This is cosmetic.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21117 >
2023-02-08 03:26:05 +00:00
Chia-I Wu
6a76bd8d4c
turnip: handle ubwc in blit_base_format
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21117 >
2023-02-08 03:26:05 +00:00
Chia-I Wu
3c4eea2aab
turnip: add blit_format_color and blit_base_format
...
Similar to blit_format_texture but for blit dst.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21117 >
2023-02-08 03:26:05 +00:00
Chia-I Wu
75f601279b
turnip: add blit_format_texture
...
The use of FMT6_8_8_8_8_UNORM for z24s8/z24x8 is for blit src. Make
that clear by moving the logic from fd6_texture_format to the newly
added blit_format_texture. Add a comment on why this is simpler than in
fdl6_view_init.
This should have no functional change in practice.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21117 >
2023-02-08 03:26:04 +00:00
Chia-I Wu
659b2e56bd
turnip: let tu6_format_vtx* take pipe format
...
For consistency with other tu6_format_* functions.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21117 >
2023-02-08 03:26:04 +00:00
Chia-I Wu
41bf169a93
turnip: make tu6_format_*_supported static
...
They have no external user.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21117 >
2023-02-08 03:26:04 +00:00
Chia-I Wu
f710911f2f
turnip: remove tu_native_format::tile_mode
...
It is dead code.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21117 >
2023-02-08 03:26:04 +00:00
Chia-I Wu
de45fc8d80
turnip: move a comment about FMT6_Z24_UNORM_S8_UINT_AS_R8G8B8A8
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21117 >
2023-02-08 03:26:04 +00:00
Chia-I Wu
273a01f43e
turnip: add a comment to tu_format_for_aspect
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21117 >
2023-02-08 03:26:04 +00:00
Dave Airlie
633efa7af7
anv: enable video decode extensions.
...
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20782 >
2023-02-08 02:56:28 +00:00
Dave Airlie
76e8d015d8
anv/query: add query status report
...
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20782 >
2023-02-08 02:56:28 +00:00
Dave Airlie
98c58a16ef
anv: add initial video decode support for h264.
...
This just adds the files with the programming info, it doesn't
enable the extensions etc
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20782 >
2023-02-08 02:56:28 +00:00
Dave Airlie
41caf3665c
anv/image: allocate some memory for mv storage after video images.
...
these images need motion vector storage allocated with them
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20782 >
2023-02-08 02:56:28 +00:00
Dave Airlie
bff627142d
intel/genxml: add missing power well control bits
...
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20782 >
2023-02-08 02:56:28 +00:00
Dave Airlie
cfc62802f8
intel/genxml: align some of the fields with the media driver
...
These values are taking from runtime interrogation of the media driver.
It would be nice to know if they are correct, but they work.
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20782 >
2023-02-08 02:56:28 +00:00
Dave Airlie
3b110efccb
anv/format: handle video extensions structs by ignoring them
...
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20782 >
2023-02-08 02:56:28 +00:00
Dave Airlie
9361481780
anv: add video format features for the one supported video output format
...
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20782 >
2023-02-08 02:56:28 +00:00
Dave Airlie
61618b0569
anv: set Y/4 tiling for video decode images
...
The video decode hw only works with Y/4 tiled images.
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20782 >
2023-02-08 02:56:28 +00:00
Dave Airlie
056b0cb87f
anv: add video engine support in various places
...
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20782 >
2023-02-08 02:56:28 +00:00
Mike Blumenkrantz
faaf6f95cc
zink: use screen indexing for bindless descriptor set in template bind
...
Fixes: 8636717270 ("zink: add a "compact" descriptor mode")
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:37 +00:00
Mike Blumenkrantz
7bd5122430
zink: use screen indexing for bindless descriptor set in db bind
...
Fixes: 99ba529fee ("zink: implement descriptor buffer handling of bindless texture")
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:37 +00:00
Mike Blumenkrantz
4cf54e2ed2
zink: fix gpl lib hashing
...
this was including the generated tcs bits, which was likely to be wrong
and thus break optimal key hashing, requiring more pipelines
it also wasn't setting the optimal key value correctly during precompile,
which meant the wrong hash value was used and the precompiled libs were never
actually accessible
cc: mesa-stable
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:37 +00:00
Mike Blumenkrantz
bbae237258
zink: set zs feedback loop bit from driver workaround on ctx create
...
this may otherwise not be set until the cache has been broken
Fixes: 56fb258064 ("zink: replace mixed_zs with zs feedback loops")
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:37 +00:00
Mike Blumenkrantz
0cb326cc74
zink: set gfx feedback loop bit in pipeline state for driver workaround
...
this needs to be set on context create or it may never get set
Fixes: 645f2da3fa ("zink: always set VK_PIPELINE_CREATE_COLOR_ATTACHMENT_FEEDBACK_LOOP_BIT_EXT sometimes")
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:37 +00:00
Mike Blumenkrantz
3ca3a26f9c
zink: don't set blend_id with full_ds3
...
this no longer needs to be part of the pso hash
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
d584f320b8
zink: add VK_PIPELINE_CREATE_DESCRIPTOR_BUFFER_BIT_EXT for gpl libs
...
required by spec
Fixes: 7ab5c5d36d ("zink: use EXT_descriptor_buffer with ZINK_DESCRIPTORS=db")
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
7c021cc5f0
zink: add a define for testing that an optimal key is the default
...
tcs values here are ignored since they only matter for generated tcs
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
1f08a6dcdb
zink: add a define for the "default" optimal key
...
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
9e0e6708ed
zink: ralloc zink_shader structs
...
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
77d8cd9c07
zink: make last_vertex_stage the first bit in zink_vs_key_base
...
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
94d9d832f6
zink: delete zink_screen::framebuffer_cache
...
no longer used
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
115e0446dc
zink: pass screen to descriptor_util_pool_key_get()
...
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
be8b7980e6
zink: store last pipeline directly for zink_gfx_program::last_pipeline
...
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
45ece56b75
zink: remove duplicated gpl output blend initializations
...
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
fa69db6e68
zink: move gpl usability checks to static inline for reuse
...
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
958c4d82d6
zink: const-ify a bunch of shader key inlines
...
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
5bba2eb13b
zink: take screen param in init_db_template_entry()
...
ctx is no longer used
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
e132af9192
zink: move bindless_layout to screen and init on creation
...
this is more consistent with the actual usage
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169 >
2023-02-08 02:35:36 +00:00
Mike Blumenkrantz
b9181c3218
zink: set PIPE_CAP_VALIDATE_ALL_DIRTY_STATES
...
failing to set this yields patterns like
* bind fs
* bind samplerviews
* draw
* bind fs2
* ~~unbind samplerviews~~ (eliminated)
* draw
the eliminated unbinding of samplerviews between draws also eliminates a descriptor update,
triggering various artifacts in certain corner cases (like DOOM2016 shadows)
it's possible to manage the updating during shader binding, but the detection is a bit more
complex, and the cpu overhead from maintaining the current codepath with an
extra pipe_context::set_sampler_views (et al) isn't high enough to warrant further investigation
at this time
fixes #8252
Fixes: 153af03b94 ("gallium: Add cap to request state validation for all dirty state")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21176 >
2023-02-08 02:17:28 +00:00
Yiwei Zhang
dba8bb08ac
venus: disable non AHB external memory bits on Android
...
We are allowed to enable them in theory. However, the non-AHB external
memory support in Venus is very broken at this moment.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21155 >
2023-02-08 02:01:17 +00:00
Juston Li
5c7e60362c
venus: enable timeline semaphore feedback
...
At vkQueueSubmit time, for each batch with timeline semaphores to
signal, append cmd_buffers with feedback cmds to update the counter
value in its respective feedback slot.
Since multiple signals on the same semaphore could be pending at the
same time across batches/vkQueueSubmits, src slots and commands are
allocated on demand. These src slots can be reused after they've been
signaled (if the current semaphore counter is greater/equal than the
src value) and are cleaned up on vkDestroySemaphore.
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20500 >
2023-02-08 00:09:18 +00:00