18610 commits

Author	SHA1	Message	Date
Martin Roukala (né Peres)	40a632cb18	radv/ci: switch to default kernel to b2c's default kernel ... This brings linux v6.16.3 to most jobs but the following ones: * navi21/31: still waiting for the zerovram bug fix * polaris10: 6.16 introduced an sdma-related hang that is being bisected Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37085>	2025-09-02 07:48:53 +00:00
Samuel Pitoiset	ff0197d44a	radv: disable VK_EXT_image_compression_control on GFX12 ... This extension is mostly only used by vkd3d-proton to disable DCC for game bugs. On GFX12 DCC is completely transparent to the userspace driver, so exposing this extension isn't very useful. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37122>	2025-09-02 06:36:16 +00:00
Samuel Pitoiset	9b90d3fa4d	radv: remove unnecessary radv_graphics_pipeline::is_ngg ... Use the last VGT shader to know if it's using NGG. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37120>	2025-09-02 06:18:05 +00:00
Samuel Pitoiset	2ccdae24cf	radv: remove set but unused radv_graphics_pipeline fields ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37120>	2025-09-02 06:18:05 +00:00
Samuel Pitoiset	478cbb6113	radv: remove set but unused has_nggc in radv_cmd_state ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37120>	2025-09-02 06:18:05 +00:00
Samuel Pitoiset	8958acb424	radv: remove unused radv_pipeline::user_data_0 ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37120>	2025-09-02 06:18:04 +00:00
Eric Engestrom	b599fd8612	radv/ci: document recent flakes ... Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37127>	2025-09-01 20:46:42 +00:00
Eric Engestrom	5177ee68de	radeonsi/ci: document recent flakes ... Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37127>	2025-09-01 20:46:42 +00:00
David Rosca	e394244a89	radv: Use extra context for video encode queue with multiple VCN instances ... amdgpu does VCN instance scheduling per context, so we need to use different context in order to allow decode to run on one instance and encode on the other one. Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36642>	2025-09-01 10:56:31 +00:00
David Rosca	2667db1114	radeonsi/vcn: Correctly set chroma location with EFC ... EFC supports horizontal left and vertical top/center. Reviewed-by: Ruijing Dong <ruijing.dong@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36977>	2025-09-01 10:30:38 +00:00
Mike Blumenkrantz	213a63f236	radv: ALWAYS_INLINE radv_upload_graphics_shader_descriptors and relateds ... Reduce the CPU overhead of these functions. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:53:02 +00:00
Samuel Pitoiset	4046317040	radv: fix compiler warnings when uploading cmdbuf data might fail ... Just need to return to avoid possible uninitialized variables. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:53:02 +00:00
Samuel Pitoiset	f3e0d4a60b	radv: translate stencil op earlier ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:53:01 +00:00
Samuel Pitoiset	a9cae4d43c	radv: remove unnecessary ternary expressions in radv_emit_depth_stencil_state() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:53:01 +00:00
Samuel Pitoiset	1cbb9dc846	radv: rename DIRTY_PATCH_CONTROL_POINTS_STATE to DIRTY_LS_HS_CONFIG ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:53:00 +00:00
Samuel Pitoiset	41ad7e6eaf	radv: do not trigger PATCH_CONTROL_POINTS_STATE on GFX12 ... The number of patch control points is emitted as part of VGT_PRIM_STATE. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:53:00 +00:00
Samuel Pitoiset	47d2af814f	radv: pre-compute tessellation num patches/lds size earlier ... This will also pre-compute when the state is static but I think it's less error prone like this and also more consistent. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:52:59 +00:00
Samuel Pitoiset	51d16e9aec	radv: dirty the raster state when setting the primitive topology ... Instead of the dynamic state which is equivalent but abusing dirty_dynamic for stuff like that isn't a good idea. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:52:59 +00:00
Samuel Pitoiset	0e398ddc43	radv: cleanup configuring AUTO_RESET_CNTL ... There is already a different branch for >= GFX12 and older gens. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:52:58 +00:00
Samuel Pitoiset	93d3427543	radv: emit BREAK_BATCH when the PS changes also for ESO ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:52:58 +00:00
Samuel Pitoiset	93ffb0db03	radv: add an early return to radv_flush_vertex_descriptors() ... To prevent mesh shaders to potentially crash. Also remove the assertion which is now useless. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:52:57 +00:00
Samuel Pitoiset	be8ccf6378	radv: use radv_get_vgt_outprim_type() for the NGG SGPRs state ... Shouldn't change anything either but vgt_outprim_type will be pre-computed later. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:52:56 +00:00
Samuel Pitoiset	d14ff3eafe	radv: use radv_get_vgt_outprim_type() to disable NGGC for points/lines ... This shouldn't change anything because NGGC for points/lines are disabled at compile time for TES/GS. It's only unconditionally enabled for VS because with fast-GPL/ESO, the driver might not know the primitive topology at compile time and it must be disabled dynamically later. Note that NGGC supports culling lines now, so it could be enabled. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:52:56 +00:00
Samuel Pitoiset	4cbadc85e0	radv: clear dynamic states earlier ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:52:55 +00:00
Samuel Pitoiset	12d618ef64	radv: split RADV_CMD_DIRTY_NGGC_STATE in two states ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:52:55 +00:00
Samuel Pitoiset	bc9a020dd3	radv: rename NGG culling user SGPRs ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37022>	2025-09-01 08:52:55 +00:00
Samuel Pitoiset	0c6b39d4fb	radv: add RADV_GFX12_HIZ_WA to select the HiZ wa behavior on GFX12 ... Will be useful for benchmarking. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36839>	2025-09-01 07:02:24 +00:00
Samuel Pitoiset	e4ef804013	radv: allow to select a different HiZ workaround on GFX12 ... And describe all of them better. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36839>	2025-09-01 07:02:24 +00:00
Samuel Pitoiset	4ce8d471b5	radv: fix setting VBO misaligned mask in graphics pipelines ... Typo. Fixes: 3eed98d122 ("radv: move VBO misaligned/unaligned info to radv_vertex_input_state") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37078>	2025-09-01 06:24:55 +00:00
Marek Olšák	9e16ed7a13	ac/nir: switch nir_load_smem_amd uses to ac_nir_load_smem wrapper ... ac_nir_load_smem will use load_global_amd Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37101>	2025-08-30 15:04:32 -04:00
Marek Olšák	4c87d002e3	aco,radeonsi: expand 32-bit shader arg pointers to 64 bits for ACO ... Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37101>	2025-08-30 15:04:32 -04:00
Marek Olšák	9a33c03654	ac/llvm: port load_smem_amd behavior to load_global_amd ... Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37101>	2025-08-30 15:04:32 -04:00
Marek Olšák	f5ba2d3e8f	ac/llvm: fix handling COHERENT and VOLATILE flags for global access ... Fixes: c181db0660 - ac/llvm: rewrite global & shared stores to share code Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37101>	2025-08-30 15:04:32 -04:00
Marek Olšák	7d5288b5b7	aco: check that global addresses are 64bit, apply_nuw_to_ssa to global_amd/smem ... Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37101>	2025-08-30 15:04:32 -04:00
Antonio Ospite	b39046b9ba	radv: fix building with libdrm as a submodule ... When building with libdrm as an internal fallback dependency, i.e. a submodule, meson does not find `amdgpu.h` from the installed external dep, failing to build with the following error: ----------------------------------------------------------------------- In file included from ../src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c:10: In file included from ../src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h:18: ../src/amd/common/ac_linux_drm.h:14:10: fatal error: 'amdgpu.h' file not found 14 | #include "amdgpu.h" | ^~~~~~~~~~ 1 error generated. ----------------------------------------------------------------------- Make libvulkan_radeon depend explicitly on dep_libdrm_amdgpu to also use the include_directories declared for that dependency in case it's an internal dependency. Acked-by: Valentine Burley <valentine.burley@collabora.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36932>	2025-08-28 18:08:20 +00:00
Antonio Ospite	18ef7b82c6	radv: don't include amdgpu.h directly ... Don't include amdgpu.h directly in AMDGPU/RADV code, the only libdrm pieces that are needed are handled in src/amd/common/ac_linux_drm.h which already includes amdgpu.h Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36932>	2025-08-28 18:08:20 +00:00
Samuel Pitoiset	4022b5c94a	radv: bind the vertex input state like a normal dynamic state ... This is much cleaner. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37025>	2025-08-28 17:46:26 +00:00
Samuel Pitoiset	2f7e8751ea	radv: replace an assertion with a check when emitting VS prolog ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37025>	2025-08-28 17:46:26 +00:00
Samuel Pitoiset	d29087d353	radv: use the dynamic state to store vertex input state ... This is also a dynamic state. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37025>	2025-08-28 17:46:26 +00:00
Samuel Pitoiset	d48096aed4	radv: remove unused parameter to radv_pipeline_init_dynamic_state() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37025>	2025-08-28 17:46:25 +00:00
Samuel Pitoiset	3eed98d122	radv: move VBO misaligned/unaligned info to radv_vertex_input_state ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37025>	2025-08-28 17:46:25 +00:00
Samuel Pitoiset	53ce957983	radv: move radv_vertex_input_state to radv_pipeline_graphics.h ... Like other similar states that are shared between graphics pipeline and command buffers. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37025>	2025-08-28 17:46:24 +00:00
Samuel Pitoiset	d7f401c2bb	radv: bind the vertex binding strides like a normal dynamic state ... This is much cleaner. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37025>	2025-08-28 17:46:24 +00:00
Samuel Pitoiset	9a5c540b75	radv: use the dynamic state to store vertex binding strides ... This is a dynamic state. This also replaces the stride by a 16-bit value because it's required to not exceed VkPhysicalDeviceLimits::maxVertexInputBindingStride which is defined to 2048. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37025>	2025-08-28 17:46:24 +00:00
Samuel Pitoiset	9597a3c13f	radv: only update vertex stride if pStrides is non-NULL when binding VBO ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37025>	2025-08-28 17:46:23 +00:00
Georg Lehmann	38e32e39a9	aco: never end wqm early for vmem ... The remaining cases where disable_wqm isn't set are either uniform loads or loads that influence control flow. In the first case, not ending WQM early is free, and in the second case it's likely still better to not block scheduling. Foz-DB GFX1201: Totals from 483 (0.60% of 80287) affected shaders: MaxWaves: 12654 -> 12642 (-0.09%) Instrs: 485234 -> 484830 (-0.08%); split: -0.19%, +0.11% CodeSize: 2630876 -> 2629184 (-0.06%); split: -0.15%, +0.08% VGPRs: 29980 -> 30004 (+0.08%) Latency: 4908015 -> 4813167 (-1.93%); split: -1.95%, +0.02% InvThroughput: 751059 -> 748582 (-0.33%); split: -0.35%, +0.02% VClause: 8723 -> 8705 (-0.21%); split: -0.30%, +0.09% SClause: 11085 -> 10986 (-0.89%); split: -1.45%, +0.56% Copies: 25155 -> 25183 (+0.11%); split: -0.26%, +0.37% Branches: 6203 -> 6204 (+0.02%) PreSGPRs: 23763 -> 23780 (+0.07%) VALU: 296576 -> 296593 (+0.01%); split: -0.01%, +0.02% SALU: 49095 -> 49416 (+0.65%); split: -0.04%, +0.69% Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36785>	2025-08-28 06:29:04 +00:00
Georg Lehmann	3d190f2e9c	aco: implement skip_helpers for load_global_amd ... Foz-DB GFX1201: Totals from 119 (0.15% of 80287) affected shaders: Instrs: 212449 -> 213452 (+0.47%) CodeSize: 1120656 -> 1124708 (+0.36%) Latency: 2854370 -> 2855772 (+0.05%); split: -0.02%, +0.07% InvThroughput: 586142 -> 586210 (+0.01%); split: -0.00%, +0.01% VClause: 3556 -> 3656 (+2.81%) SClause: 2708 -> 2710 (+0.07%) Copies: 14410 -> 14509 (+0.69%) PreSGPRs: 6810 -> 6850 (+0.59%); split: -0.12%, +0.70% VALU: 135945 -> 135942 (-0.00%); split: -0.01%, +0.01% SALU: 22147 -> 23121 (+4.40%) Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36785>	2025-08-28 06:29:04 +00:00
Georg Lehmann	ee7069f875	aco: implement skip_helpers for load_scratch ... Foz-DB GFX1201: Totals from 2 (0.00% of 80287) affected shaders: Instrs: 4016 -> 4054 (+0.95%) CodeSize: 22104 -> 22256 (+0.69%) Latency: 17123 -> 17129 (+0.04%) Copies: 406 -> 415 (+2.22%) SALU: 323 -> 353 (+9.29%) Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36785>	2025-08-28 06:29:04 +00:00
Georg Lehmann	2bfd8918a5	aco: implement skip_helpers for load_ssbo/ubo/constant ... Foz-DB GFX1201: Totals from 6676 (8.32% of 80287) affected shaders: Instrs: 8786161 -> 8829091 (+0.49%); split: -0.01%, +0.50% CodeSize: 47141800 -> 47320480 (+0.38%); split: -0.01%, +0.39% VGPRs: 376624 -> 376600 (-0.01%) SpillSGPRs: 1251 -> 1250 (-0.08%) Latency: 99716626 -> 99642361 (-0.07%); split: -0.11%, +0.04% InvThroughput: 14893179 -> 14898323 (+0.03%); split: -0.01%, +0.04% VClause: 149425 -> 153539 (+2.75%); split: -0.04%, +2.79% SClause: 251247 -> 251842 (+0.24%); split: -0.06%, +0.30% Copies: 580304 -> 586424 (+1.05%); split: -0.21%, +1.26% Branches: 163014 -> 163013 (-0.00%); split: -0.00%, +0.00% PreSGPRs: 356548 -> 357109 (+0.16%); split: -0.18%, +0.33% VALU: 5149733 -> 5149797 (+0.00%); split: -0.00%, +0.00% SALU: 1082176 -> 1122718 (+3.75%); split: -0.06%, +3.80% Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36785>	2025-08-28 06:29:03 +00:00
Georg Lehmann	bdae511b18	aco: implement skip_helpers for image loads ... Foz-DB GFX1201: Totals from 5 (0.01% of 80287) affected shaders: Instrs: 1406 -> 1417 (+0.78%) CodeSize: 8012 -> 8056 (+0.55%) Latency: 7279 -> 7282 (+0.04%) Copies: 84 -> 85 (+1.19%) SALU: 170 -> 180 (+5.88%) Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36785>	2025-08-28 06:29:02 +00:00