mesa/src/compiler/nir/nir_opt_offsets.c

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

408 lines
15 KiB
C
Raw Normal View History

/*
* Copyright © 2021 Valve Corporation
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
* IN THE SOFTWARE.
*
* Authors:
* Timur Kristóf
*
*/
#include "nir.h"
#include "nir_builder.h"
#include "util/u_overflow.h"
typedef struct
{
struct hash_table *range_ht;
const nir_opt_offsets_options *options;
bool progress;
} opt_offsets_state;
static bool
try_extract_const_addition(nir_builder *b, opt_offsets_state *state, nir_scalar *out_val, int64_t *out_const,
int32_t min, uint32_t max, bool need_nuw)
{
bool is_unsigned = min == 0;
assert(is_unsigned || max <= INT32_MAX);
nir_scalar val = nir_scalar_chase_movs(*out_val);
if (!nir_scalar_is_alu(val))
return false;
nir_alu_instr *alu = nir_def_as_alu(val.def);
if (alu->op != nir_op_iadd)
return false;
nir_scalar src[2] = {
{ alu->src[0].src.ssa, alu->src[0].swizzle[val.comp] },
{ alu->src[1].src.ssa, alu->src[1].swizzle[val.comp] },
};
/* Make sure that we aren't taking out an addition that could trigger
* unsigned wrapping in a way that would change the semantics of the load.
* Ignored for ints-as-floats (lower_bitops is a proxy for that), where
* unsigned wrapping doesn't make sense.
*/
if (need_nuw && !alu->no_unsigned_wrap &&
!b->shader->options->lower_bitops) {
assert(is_unsigned);
if (!state->range_ht) {
/* Cache for nir_unsigned_upper_bound */
state->range_ht = _mesa_pointer_hash_table_create(NULL);
}
/* Check if there can really be an unsigned wrap. */
uint32_t ub0 = nir_unsigned_upper_bound(b->shader, state->range_ht, src[0]);
uint32_t ub1 = nir_unsigned_upper_bound(b->shader, state->range_ht, src[1]);
if ((UINT32_MAX - ub0) < ub1)
return false;
/* We proved that unsigned wrap won't be possible, so we can set the flag too. */
alu->no_unsigned_wrap = true;
state->progress = true;
}
for (unsigned i = 0; i < 2; ++i) {
src[i] = nir_scalar_chase_movs(src[i]);
if (nir_scalar_is_const(src[i])) {
int64_t offset;
if (is_unsigned)
offset = nir_scalar_as_uint(src[i]);
else
offset = nir_scalar_as_int(src[i]);
int64_t new_offset = 0;
if (!util_add_overflow(int64_t, offset, *out_const, &new_offset)) {
if (new_offset >= min && new_offset <= max) {
*out_const = new_offset;
try_extract_const_addition(b, state, &src[1 - i], out_const, min, max, need_nuw);
*out_val = src[1 - i];
return true;
}
}
}
}
bool changed_src0 = try_extract_const_addition(b, state, &src[0], out_const, min, max, need_nuw);
bool changed_src1 = try_extract_const_addition(b, state, &src[1], out_const, min, max, need_nuw);
if (!changed_src0 && !changed_src1)
return false;
state->progress = true;
b->cursor = nir_before_instr(&alu->instr);
nir_def *r = nir_iadd(b, nir_mov_scalar(b, src[0]),
nir_mov_scalar(b, src[1]));
*out_val = nir_get_scalar(r, 0);
return true;
}
static bool
try_fold_load_store(nir_builder *b,
nir_intrinsic_instr *intrin,
opt_offsets_state *state,
unsigned offset_src_idx,
int32_t min,
uint32_t max,
bool need_nuw)
{
bool is_unsigned = min == 0;
assert(is_unsigned || max <= INT32_MAX);
/* Assume that BASE is the constant offset of a load/store.
* Try to constant-fold additions to the offset source
* into the actual const offset of the instruction.
*/
int64_t off_const = nir_intrinsic_base(intrin);
nir_src *off_src = &intrin->src[offset_src_idx];
nir_def *replace_src = NULL;
if (off_const > max || off_const < min)
return false;
if (!nir_src_is_const(*off_src)) {
nir_scalar val = { .def = off_src->ssa, .comp = 0 };
if (!try_extract_const_addition(b, state, &val, &off_const, min, max, need_nuw))
return false;
b->cursor = nir_before_instr(&intrin->instr);
replace_src = nir_mov_scalar(b, val);
} else {
int64_t src_off_const;
if (is_unsigned)
src_off_const = nir_src_as_uint(*off_src);
else
src_off_const = nir_src_as_int(*off_src);
if (!src_off_const)
return false;
int64_t new_off_const = 0;
if (!util_add_overflow(int64_t, src_off_const, off_const, &new_off_const)) {
if (new_off_const < min || new_off_const > max)
return false;
off_const = new_off_const;
b->cursor = nir_before_instr(&intrin->instr);
replace_src = nir_imm_zero(b, off_src->ssa->num_components, off_src->ssa->bit_size);
}
}
if (!replace_src)
return false;
nir_src_rewrite(&intrin->src[offset_src_idx], replace_src);
assert(off_const <= max && off_const >= min);
nir_intrinsic_set_base(intrin, off_const);
return true;
}
/* Nvidia's load/store/atomic instructions are a bit weird. If you have a constant offset, the
* instruction's base is an unsigned offset. If it's not constant, it's a _signed_ offset. In
* the ISA the difference is encoded via selection of the zero register RZ, e.g. for 24 bit:
* [RZ + 0x900000] -> access at 0x900000
* [R0 + 0x900000] -> access at R0 - 0x700000
*/
static bool
try_fold_load_store_nv(nir_builder *b,
nir_intrinsic_instr *intrin,
opt_offsets_state *state)
{
unsigned offset_bits = nir_get_io_base_size_nv(intrin);
int offset_idx = nir_get_io_offset_src_number(intrin);
assert(offset_idx >= 0);
nir_src src = intrin->src[offset_idx];
int32_t min = 0;
uint32_t max = BITFIELD_MASK(offset_bits);
if (!nir_src_is_const(src)) {
max >>= 1;
min = ~max;
}
/* We rely on opt_algebraic to order things so that nir_opt_offset can fold
* constant offsets into instructions first without having to take the offset
* shift into account. */
if (nir_intrinsic_has_offset_shift_nv(intrin) &&
nir_intrinsic_offset_shift_nv(intrin) != 0) {
assert(!"nir_opt_offset encountered non 0 offset_shift_nv");
return false;
}
return try_fold_load_store(b, intrin, state, offset_idx, min, max, false);
}
static bool
decrease_shared2_offsets(uint32_t offset0, uint32_t offset1, uint32_t stride, uint32_t *excess)
{
/* Make the offsets a multiple of the stride. */
if (offset0 % stride != offset1 % stride)
return false;
*excess = offset0 % stride;
/* Ensure both offsets are not too large. */
uint32_t range = 256 * stride;
if (offset0 / range != offset1 / range) {
*excess += ROUND_DOWN_TO(MIN2(offset0, offset1), stride);
if (offset0 - *excess >= range || offset1 - *excess >= range)
return false;
} else {
*excess += ROUND_DOWN_TO(offset0, range);
}
return true;
}
static bool
try_fold_shared2(nir_builder *b,
nir_intrinsic_instr *intrin,
opt_offsets_state *state,
unsigned offset_src_idx,
bool need_nuw)
{
bool is_load = intrin->intrinsic == nir_intrinsic_load_shared2_amd;
unsigned comp_size = (is_load ? intrin->def.bit_size : intrin->src[0].ssa->bit_size) / 8;
unsigned stride = (nir_intrinsic_st64(intrin) ? 64 : 1) * comp_size;
uint32_t offset0 = nir_intrinsic_offset0(intrin) * stride;
uint32_t offset1 = nir_intrinsic_offset1(intrin) * stride;
nir_src *off_src = &intrin->src[offset_src_idx];
int64_t const_offset = 0;
nir_scalar replace_src = { NULL, 0 };
bool modified_shader = false;
if (!nir_src_is_const(*off_src)) {
uint32_t max = INT32_MAX - MAX2(offset0, offset1); /* Avoid negative offsets. */
replace_src = nir_get_scalar(off_src->ssa, 0);
if (!try_extract_const_addition(b, state, &replace_src, &const_offset, 0, max, need_nuw))
return false;
modified_shader = true;
} else {
const_offset = nir_src_as_uint(*off_src);
}
offset0 += const_offset;
offset1 += const_offset;
uint32_t excess_normal = 0, excess_st64 = 0;
bool normal = decrease_shared2_offsets(offset0, offset1, comp_size, &excess_normal);
bool st64 = decrease_shared2_offsets(offset0, offset1, 64 * comp_size, &excess_st64);
/* Use ST64 if the normal mode is impossible or using ST64 saves an addition. */
st64 &= !normal || (excess_normal > 0 && excess_st64 == 0);
uint32_t excess = st64 ? excess_st64 : excess_normal;
assert(st64 || normal);
if (excess == const_offset && !modified_shader)
return false;
b->cursor = nir_before_instr(&intrin->instr);
/* Even if the constant offset doesn't fit in offset0/offset1, this addition is likely to be CSE'd. */
if (replace_src.def)
nir_src_rewrite(off_src, nir_iadd_imm(b, nir_mov_scalar(b, replace_src), excess));
else
nir_src_rewrite(off_src, nir_imm_int(b, excess));
stride = (st64 ? 64 : 1) * comp_size;
nir_intrinsic_set_offset0(intrin, (offset0 - excess) / stride);
nir_intrinsic_set_offset1(intrin, (offset1 - excess) / stride);
nir_intrinsic_set_st64(intrin, st64);
return true;
}
static uint32_t
get_max(opt_offsets_state *state, nir_intrinsic_instr *intrin, uint32_t default_val)
{
if (default_val)
return default_val;
if (state->options->max_offset_cb)
return state->options->max_offset_cb(intrin, state->options->cb_data);
return 0;
}
static bool
allow_offset_wrap(opt_offsets_state *state, nir_intrinsic_instr *intr)
{
if (state->options->allow_offset_wrap_cb)
return state->options->allow_offset_wrap_cb(intr, state->options->cb_data);
return false;
}
static bool
process_instr(nir_builder *b, nir_instr *instr, void *s)
{
if (instr->type != nir_instr_type_intrinsic)
return false;
opt_offsets_state *state = (opt_offsets_state *)s;
nir_intrinsic_instr *intrin = nir_instr_as_intrinsic(instr);
bool need_nuw = !allow_offset_wrap(state, intrin);
switch (intrin->intrinsic) {
case nir_intrinsic_load_uniform:
case nir_intrinsic_load_const_ir3:
return try_fold_load_store(b, intrin, state, 0, 0, get_max(state, intrin, state->options->uniform_max), need_nuw);
case nir_intrinsic_load_ubo_vec4:
return try_fold_load_store(b, intrin, state, 1, 0, get_max(state, intrin, state->options->ubo_vec4_max), need_nuw);
case nir_intrinsic_shared_atomic:
case nir_intrinsic_shared_atomic_swap:
return try_fold_load_store(b, intrin, state, 0, 0, get_max(state, intrin, state->options->shared_atomic_max), need_nuw);
case nir_intrinsic_load_shared:
case nir_intrinsic_load_shared_ir3:
return try_fold_load_store(b, intrin, state, 0, 0, get_max(state, intrin, state->options->shared_max), need_nuw);
case nir_intrinsic_store_shared:
case nir_intrinsic_store_shared_ir3:
return try_fold_load_store(b, intrin, state, 1, 0, get_max(state, intrin, state->options->shared_max), need_nuw);
case nir_intrinsic_load_shared2_amd:
return try_fold_shared2(b, intrin, state, 0, need_nuw);
case nir_intrinsic_store_shared2_amd:
return try_fold_shared2(b, intrin, state, 1, need_nuw);
case nir_intrinsic_load_buffer_amd:
need_nuw &= !!(nir_intrinsic_access(intrin) & ACCESS_IS_SWIZZLED_AMD);
return try_fold_load_store(b, intrin, state, 1, 0, get_max(state, intrin, state->options->buffer_max), need_nuw);
case nir_intrinsic_store_buffer_amd:
need_nuw &= !!(nir_intrinsic_access(intrin) & ACCESS_IS_SWIZZLED_AMD);
return try_fold_load_store(b, intrin, state, 2, 0, get_max(state, intrin, state->options->buffer_max), need_nuw);
case nir_intrinsic_load_ssbo_intel:
case nir_intrinsic_load_ssbo_uniform_block_intel:
case nir_intrinsic_load_ubo_uniform_block_intel:
return try_fold_load_store(b, intrin, state, 1, 0, get_max(state, intrin, state->options->buffer_max), need_nuw);
case nir_intrinsic_store_ssbo_intel:
return try_fold_load_store(b, intrin, state, 2, 0, get_max(state, intrin, state->options->buffer_max), need_nuw);
case nir_intrinsic_load_ssbo_ir3:
return try_fold_load_store(b, intrin, state, 2, 0, get_max(state, intrin, state->options->buffer_max), need_nuw);
case nir_intrinsic_store_ssbo_ir3:
return try_fold_load_store(b, intrin, state, 3, 0, get_max(state, intrin, state->options->buffer_max), need_nuw);
case nir_intrinsic_load_urb_lsc_intel:
return try_fold_load_store(b, intrin, state, 0, 0, UINT32_MAX, false);
case nir_intrinsic_store_urb_lsc_intel:
case nir_intrinsic_load_urb_vec4_intel:
return try_fold_load_store(b, intrin, state, 1, 0, UINT32_MAX, false);
case nir_intrinsic_store_urb_vec4_intel:
return try_fold_load_store(b, intrin, state, 2, 0, UINT32_MAX, false);
case nir_intrinsic_global_atomic_nv:
case nir_intrinsic_global_atomic_swap_nv:
case nir_intrinsic_ldc_nv:
case nir_intrinsic_ldcx_nv:
case nir_intrinsic_load_global_nv:
case nir_intrinsic_load_scratch_nv:
case nir_intrinsic_load_shared_nv:
case nir_intrinsic_load_shared_lock_nv:
case nir_intrinsic_shared_atomic_nv:
case nir_intrinsic_shared_atomic_swap_nv:
case nir_intrinsic_store_global_nv:
case nir_intrinsic_store_scratch_nv:
case nir_intrinsic_store_shared_nv:
case nir_intrinsic_store_shared_unlock_nv:
case nir_intrinsic_vild_nv:
return try_fold_load_store_nv(b, intrin, state);
/* Always signed offset */
case nir_intrinsic_cmat_load_shared_nv:
return try_fold_load_store(b, intrin, state, 0, -8388608, 0x7fffff, false);
default:
return false;
}
build: avoid redefining unreachable() which is standard in C23 In the C23 standard unreachable() is now a predefined function-like macro in <stddef.h> See https://android.googlesource.com/platform/bionic/+/HEAD/docs/c23.md#is-now-a-predefined-function_like-macro-in And this causes build errors when building for C23: ----------------------------------------------------------------------- In file included from ../src/util/log.h:30, from ../src/util/log.c:30: ../src/util/macros.h:123:9: warning: "unreachable" redefined 123 | #define unreachable(str) \ | ^~~~~~~~~~~ In file included from ../src/util/macros.h:31: /usr/lib/gcc/x86_64-linux-gnu/14/include/stddef.h:456:9: note: this is the location of the previous definition 456 | #define unreachable() (__builtin_unreachable ()) | ^~~~~~~~~~~ ----------------------------------------------------------------------- So don't redefine it with the same name, but use the name UNREACHABLE() to also signify it's a macro. Using a different name also makes sense because the behavior of the macro was extending the one of __builtin_unreachable() anyway, and it also had a different signature, accepting one argument, compared to the standard unreachable() with no arguments. This change improves the chances of building mesa with the C23 standard, which for instance is the default in recent AOSP versions. All the instances of the macro, including the definition, were updated with the following command line: git grep -l '[^_]unreachable(' -- "src/**" | sort | uniq | \ while read file; \ do \ sed -e 's/\([^_]\)unreachable(/\1UNREACHABLE(/g' -i "$file"; \ done && \ sed -e 's/#undef unreachable/#undef UNREACHABLE/g' -i src/intel/isl/isl_aux_info.c Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36437>
2025-07-23 09:17:35 +02:00
UNREACHABLE("Can't reach here.");
}
bool
nir_opt_offsets(nir_shader *shader, const nir_opt_offsets_options *options)
{
opt_offsets_state state;
state.range_ht = NULL;
state.options = options;
state.progress = false;
bool p = nir_shader_instructions_pass(shader, process_instr,
nir_metadata_control_flow,
&state);
if (state.range_ht)
_mesa_hash_table_destroy(state.range_ht, NULL);
return p || state.progress;
}