Most were caught by applying libX11 lists, but BadKeyboard & XKB*_Bad*
are XKB-specific. (Plus some were badly split across tag boundaries.)
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
All the places marked by these have been turned into the appropriate
link, xref, or olink tags now.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
- Stop placing <emphasis> on empty space, commas, and periods.
- Move periods & commas after closing </emphasis> tag
- move <emphasis> open & close tags to same line, instead of mirroring
nroff layout.
Simplifies automating further transformations of these tags.
Performed via:
perl -i -0 -p \
-e 's{<emphasis>(\s*)</emphasis>}{}msg;' \
-e 's{<emphasis>([\s\.,]*)</emphasis>\s*}{\1}msg;' \
-e 's{\n([\.,])\s*}{\1\n}msg;' \
-e 's{([^\.])([\.,])\s*</emphasis>}{\1</emphasis>\2}msg;' \
-e 's{\s*<emphasis>\n\s*}{\n<emphasis>}msg;' *xml
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
- Merge some functionargdecl entries incorrectly split across rows
- Add missing parameter name markup to some functionargdecls
- Add missing function prototype markup to a functiondecl
- Remove stray emphasis tags in a functiondecl
Allows them to correctly convert to funcsynopsis markup in next step.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Xutil.h has always had a value of 3 for IconicState, since 2 was
previously used for the long-obsolete ZoomState, so make the spec
match what programs have used for decades.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
Forces compiler to zero-fill unset fields in the struct (fixing bug 81236)
and allows optimizer to order field initialization to best fit cache layout
or other considerations.
Before & after output of gcc -S on AMD64 shows insertion of "rep stosq"
instructions to rapidly zero-fill structs.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
Nothing in the XKB spec states that the memory pointed to by ctrls has to
be initialized to any given value when passed to the function, only that
it is set by the function to the values returned by the X server:
http://www.x.org/releases/X11R7.7/doc/libX11/XKB/xkblib.html#The_Miscellaneous_Per_client_Controls
The check for the incoming value seems to be copied from
XkbSetPerClientControls without explanation.
Instead change it to checking if ctrls is non-NULL, since there's no
point asking the X server to return a value the caller won't even see.
Found while investigating report from cppcheck-1.65:
[src/xkb/XKB.c:699] -> [src/xkb/XKB.c:719]: (warning) Possible null pointer
dereference: ctrls - otherwise it is redundant to check it against null.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Check is intended to ensure we allocate at least XkbNumRequiredTypes
in map, but was accidentally marked with a ! causing the wrong check.
Reported-by: Harms <wharms@bfs,de>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
"unsigned int width, unsigned int height", not a single parameter "height"
of type "unsignedintwidth,".
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Do not use variables before checked for NULL.
* remove some superfluid spaces (Mark Kettenis)
Signed-off-by: Harms <wharms@bfs,de>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
This patch removes the last remaining NULL checks for Xfree()
Signed-off-by: Harms <wharms@bfs,de>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This patch removes some redundant null checks before free.
It should not change the code otherwise. Be aware that this
is only the first series.
Signed-off-by: Harms <wharms@bfs,de>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Do not use variables before checked for NULL.
Signed-off-by: Harms <wharms@bfs,de>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Do not use variables before checked for NULL.
Signed-off-by: Harms <wharms@bfs,de>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Do not use variables before checked for NULL.
Signed-off-by: Harms <wharms@bfs,de>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
All other vowels with ogoneks can already be composed using <comma>.
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: James Cloos <cloos@jhcloos.com>
It existed for lowercase i, but not for uppercase I nor the other vowels.
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: James Cloos <cloos@jhcloos.com>
When XCB owns the X socket, dpy->request is not updated, so
NextRequest() and XNextRequest() return the wrong value. There's
nothing we can do to fix NextRequest() while retaining ABI compat,
but change XNextRequest() to grab the socket back from XCB,
updating dpy->request.
Signed-off-by: Owen W. Taylor <otaylor@fishsoup.net>
Reviewed-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Having every table cell be a text diversion (T{...T}) was too much for
Solaris tbl to handle, and thus "man XCreateGC" would print the error
/usr/man/man3x11/XCreateGC.3x11: line 402: Too many text block diversions
tbl quits
and not display the table of mask bits or any text in the man page after
that table. Since the #define column doesn't need special handling,
making it not use text diversions brings the table under the tbl limit.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Parenleft is already in use for sequences of the form <(> <letter> <)>
to generate circled letters.
Eg, <Multikey> <parenleft> <a> <parenright> generates ⓐ.
This reverts commit f020235f4b.
Signed-off-by: James Cloos <cloos@jhcloos.com>
Compose sequences with <dead_belowcomma> exist, but very few keyboard
layouts contain that symbol. So a more usual character is needed to be
able to easily compose Ș, ș, Ț and ț. The semicolon is normally only
used for composing letters with ogoneks -- but only vowels take ogoneks,
so the character is free for consonants, and thus <semicolon> is used
here to compose commas below. It is somewhat fitting, because on most
Romanian keyboards the Ș is placed on that key, and the Ț next to it.
(Oh -- the more obvious sequences with <comma> were already taken for
composing S and T with cedillas.)
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: James Cloos <cloos@jhcloos.com>
The custom seems to be: pairing the ones that have only the sequence of
two keys reversed, and putting the one with the diacritic first first.
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: James Cloos <cloos@jhcloos.com>
Returned structure must be freed with XkbFreeKeyboard().
Reported-by: Morten Bøgeskov <mb@dbc.dk>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
