fdo-mirrors/xorg-libx11
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/xorg/lib/libx11.git synced 2026-05-05 19:18:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove more redundant null checks before Xfree()

Browse source 
Signed-off-by: Harms <wharms@bfs,de>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
This commit is contained in:
walter harms 2014-06-06 22:53:05 +02:00 • committed by Alan Coopersmith
parent 0b7fd7dbec
commit d81fed4614
11 changed files with 102 additions and 163 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/im/ximcp/imCallbk.c
View file

@ -553,10 +553,8 @@ static void
_free_memory_for_text(XIMText* text)
{
if (text) {
if (text->string.multi_byte)
Xfree(text->string.multi_byte);
if (text->feedback)
Xfree(text->feedback);
Xfree(text->string.multi_byte);
Xfree(text->feedback);
Xfree(text);
}
}

7
modules/im/ximcp/imDefIc.c
View file

@ -1595,10 +1595,9 @@ _XimProtoCreateIC(
ErrorOnCreatingIC:
_XimUnregisterFilter(ic);
if (ic->private.proto.ic_resources)
Xfree(ic->private.proto.ic_resources);
if (ic->private.proto.ic_inner_resources)
Xfree(ic->private.proto.ic_inner_resources);
Xfree(ic->private.proto.ic_resources);
Xfree(ic->private.proto.ic_inner_resources);
Xfree(ic);
return (XIC)NULL;
}

6
modules/im/ximcp/imDefIm.c
View file

@ -1775,10 +1775,8 @@ _XimEncodingNegotiation(
detail_ptr, detail_len)))
goto free_preply;
if (name_ptr)
Xfree(name_ptr);
if (detail_ptr)
Xfree(detail_ptr);
Xfree(name_ptr);
Xfree(detail_ptr);
if(reply != preply)
Xfree(preply);

13
modules/im/ximcp/imDefLkup.c
View file

@ -599,10 +599,9 @@ _XimUnregCommitInfo(
if (!(info = ic->private.proto.commit_info))
return;
if (info->string)
Xfree(info->string);
if (info->keysym)
Xfree(info->keysym);
Xfree(info->string);
Xfree(info->keysym);
ic->private.proto.commit_info = info->next;
Xfree(info);
return;
@ -696,10 +695,8 @@ _XimCommitRecv(
}
if (!(_XimRegCommitInfo(ic, string, string_len, keysym, keysym_len))) {
if (string)
Xfree(string);
if (keysym)
Xfree(keysym);
Xfree(string);
Xfree(keysym);
_XimError(im, ic, XIM_BadAlloc, (INT16)0, (CARD16)0, (char *)NULL);
return False;
}

9
modules/im/ximcp/imInt.c
View file

@ -239,14 +239,11 @@ Error4 :
Xfree(im);
return NULL;
Error3 :
if(im->core.im_name)
Xfree(im->core.im_name);
Xfree(im->core.im_name);
Error2:
if(im->core.res_class)
Xfree(im->core.res_class);
Xfree(im->core.res_class);
Error1:
if(im->core.res_name)
Xfree(im->core.res_name);
Xfree(im->core.res_name);
Xfree(im);
return NULL;
}

102
modules/im/ximcp/imLcIm.c
View file

@ -131,13 +131,14 @@ XimFreeDefaultTree(
}
#endif
Xfree (b->tree);
if (b->mb) Xfree (b->mb);
if (b->wc) Xfree (b->wc);
if (b->utf8) Xfree (b->utf8);
b->tree = NULL;
Xfree (b->mb);
b->mb = NULL;
Xfree (b->wc);
b->wc = NULL;
Xfree (b->utf8);
b->utf8 = NULL;
b->treeused = b->treesize = 0;
b->mbused = b->mbsize = 0;
b->wcused = b->wcsize = 0;
@ -151,38 +152,30 @@ _XimLocalIMFree(
XimFreeDefaultTree(&im->private.local.base);
im->private.local.top = 0;
if(im->core.im_resources) {
Xfree(im->core.im_resources);
im->core.im_resources = NULL;
}
if(im->core.ic_resources) {
Xfree(im->core.ic_resources);
im->core.ic_resources = NULL;
}
if(im->core.im_values_list) {
Xfree(im->core.im_values_list);
im->core.im_values_list = NULL;
}
if(im->core.ic_values_list) {
Xfree(im->core.ic_values_list);
im->core.ic_values_list = NULL;
}
if(im->core.styles) {
Xfree(im->core.styles);
im->core.styles = NULL;
}
if(im->core.res_name) {
Xfree(im->core.res_name);
im->core.res_name = NULL;
}
if(im->core.res_class) {
Xfree(im->core.res_class);
im->core.res_class = NULL;
}
if(im->core.im_name) {
Xfree(im->core.im_name);
im->core.im_name = NULL;
}
Xfree(im->core.im_resources);
im->core.im_resources = NULL;
Xfree(im->core.ic_resources);
im->core.ic_resources = NULL;
Xfree(im->core.im_values_list);
im->core.im_values_list = NULL;
Xfree(im->core.ic_values_list);
im->core.ic_values_list = NULL;
Xfree(im->core.styles);
im->core.styles = NULL;
Xfree(im->core.res_name);
im->core.res_name = NULL;
Xfree(im->core.res_class);
im->core.res_class = NULL;
Xfree(im->core.im_name);
im->core.im_name = NULL;
if (im->private.local.ctom_conv) {
_XlcCloseConverter(im->private.local.ctom_conv);
im->private.local.ctom_conv = NULL;
@ -576,19 +569,15 @@ _XimCreateDefaultTree(
encoding, 0, 1, &cachename, &size);
if (cachefd != -1) {
if (_XimLoadCache (cachefd, intname, encoding, size, im)) {
if (tmpcachedir)
Xfree (tmpcachedir);
if (tmpname)
Xfree (tmpname);
if (cachename)
Xfree (cachename);
Xfree (tmpcachedir);
Xfree (tmpname);
Xfree (cachename);
close (cachefd);
return;
}
close (cachefd);
}
if (cachename)
Xfree (cachename);
Xfree (cachename);
cachename = NULL;
}
@ -603,12 +592,9 @@ _XimCreateDefaultTree(
euid, 0, &cachename, &size);
if (cachefd != -1) {
if (_XimLoadCache (cachefd, intname, encoding, size, im)) {
if (tmpcachedir)
Xfree (tmpcachedir);
if (tmpname)
Xfree (tmpname);
if (cachename)
Xfree (cachename);
Xfree (tmpcachedir);
Xfree (tmpname);
Xfree (cachename);
close (cachefd);
return;
}
@ -618,12 +604,9 @@ _XimCreateDefaultTree(
#endif
if (! (fp = _XFopenFile (name, "r"))) {
if (tmpcachedir)
Xfree (tmpcachedir);
if (tmpname)
Xfree (tmpname);
if (cachename)
Xfree (cachename);
Xfree (tmpcachedir);
Xfree (tmpname);
Xfree (cachename);
return;
}
_XimParseStringFile(fp, im);
@ -636,12 +619,9 @@ _XimCreateDefaultTree(
}
#endif
if (tmpcachedir)
Xfree (tmpcachedir);
if (tmpname)
Xfree (tmpname);
if (cachename)
Xfree (cachename);
Xfree (tmpcachedir);
Xfree (tmpname);
Xfree (cachename);
}
static XIMMethodsRec Xim_im_local_methods = {

24
modules/im/ximcp/imRmAttr.c
View file

@ -972,8 +972,7 @@ _XimEncodePreeditValue(
if (!p->value)
return False;
if (ic->private.proto.preedit_font)
Xfree(ic->private.proto.preedit_font);
Xfree(ic->private.proto.preedit_font);
list_ret = XFontsOfFontSet((XFontSet)p->value,
&struct_list, &name_list);
@ -1024,8 +1023,7 @@ _XimEncodeStatusValue(
if (!p->value)
return False;
if (ic->private.proto.status_font)
Xfree(ic->private.proto.status_font);
Xfree(ic->private.proto.status_font);
list_ret = XFontsOfFontSet((XFontSet)p->value,
&struct_list, &name_list);
@ -1243,8 +1241,7 @@ _XimEncodeSavedStatusValue(
if (!value)
return False;
if (ic->private.proto.status_font)
Xfree(ic->private.proto.status_font);
Xfree(ic->private.proto.status_font);
list_ret = XFontsOfFontSet((XFontSet)value,
&struct_list, &name_list);
@ -1460,10 +1457,9 @@ _XimGetAttributeID(
}
_XIMCompileResourceList(res, n);
if (im->core.im_resources)
Xfree(im->core.im_resources);
if (im->core.im_values_list)
Xfree(im->core.im_values_list);
Xfree(im->core.im_resources);
Xfree(im->core.im_values_list);
im->core.im_resources = res;
im->core.im_num_resources = n;
im->core.im_values_list = values_list;
@ -1506,10 +1502,10 @@ _XimGetAttributeID(
}
_XIMCompileResourceList(res, n);
if (im->core.ic_resources)
Xfree(im->core.ic_resources);
if (im->core.ic_values_list)
Xfree(im->core.ic_values_list);
Xfree(im->core.ic_resources);
Xfree(im->core.ic_values_list);
im->core.ic_resources = res;
im->core.ic_num_resources = n;
im->core.ic_values_list = values_list;

18
modules/im/ximcp/imThaiIc.c
View file

@ -65,18 +65,20 @@ _XimThaiDestroyIC(
if(((Xim)ic->core.im)->private.local.current_ic == (XIC)ic) {
_XimThaiUnSetFocus(xic);
}
if(ic->private.local.ic_resources) {
Xfree(ic->private.local.ic_resources);
ic->private.local.ic_resources = NULL;
}
if (b->tree) Xfree (b->tree);
if (b->mb) Xfree (b->mb);
if (b->wc) Xfree (b->wc);
if (b->utf8) Xfree (b->utf8);
Xfree(ic->private.local.ic_resources);
ic->private.local.ic_resources = NULL;
Xfree (b->tree);
b->tree = NULL;
Xfree (b->mb);
b->mb = NULL;
Xfree (b->wc);
b->wc = NULL;
Xfree (b->utf8);
b->utf8 = NULL;
return;
}

3
modules/lc/def/lcDefConv.c
View file

@ -563,9 +563,8 @@ static void
close_converter(
XlcConv conv)
{
if (conv->state)
Xfree(conv->state);
Xfree(conv->state);
Xfree(conv);
}

34
modules/lc/gen/lcGenConv.c
View file

@ -1225,8 +1225,7 @@ stdc_wcstocts(
goto ret;
ret:
if (buf)
Xfree(buf);
Xfree(buf);
return (unconv_num1 + unconv_num2);
}
@ -1548,8 +1547,7 @@ stdc_ctstowcs(
goto ret;
ret:
if (buf)
Xfree(buf);
Xfree(buf);
return (unconv_num1 + unconv_num2);
}
@ -1584,8 +1582,7 @@ stdc_cstowcs(
goto ret;
ret:
if (buf)
Xfree(buf);
Xfree(buf);
return (unconv_num1 + unconv_num2);
}
@ -1620,8 +1617,7 @@ mbstocts(
goto ret;
ret:
if (buf)
Xfree(buf);
Xfree(buf);
return (unconv_num1 + unconv_num2);
}
@ -2071,8 +2067,7 @@ stdc_wcstostr(
goto ret;
ret:
if (buf)
Xfree(buf);
Xfree(buf);
return (unconv_num1 + unconv_num2);
}
@ -2346,8 +2341,7 @@ ctstombs(
goto ret;
ret:
if (buf)
Xfree(buf);
Xfree(buf);
return (unconv_num1 + unconv_num2);
}
@ -2382,8 +2376,7 @@ cstombs(
goto ret;
ret:
if (buf)
Xfree(buf);
Xfree(buf);
return (unconv_num1 + unconv_num2);
}
@ -2591,8 +2584,7 @@ stdc_strtowcs(
goto ret;
ret:
if (buf)
Xfree(buf);
Xfree(buf);
return (unconv_num1 + unconv_num2);
}
@ -2605,14 +2597,8 @@ static void
close_converter(
XlcConv conv)
{
if (conv->state) {
Xfree(conv->state);
}
if (conv->methods) {
Xfree(conv->methods);
}
Xfree(conv->state);
Xfree(conv->methods);
Xfree(conv);
}

43
modules/om/generic/omGeneric.c
View file

@ -196,16 +196,12 @@ init_fontset(
return True;
err:
if(font_set->font_data)
Xfree(font_set->font_data);
if(font_set->substitute)
Xfree(font_set->substitute);
if(font_set->vmap)
Xfree(font_set->vmap);
if(font_set->vrotate)
Xfree(font_set->vrotate);
if(font_set)
Xfree(font_set);
Xfree(font_set->font_data);
Xfree(font_set->substitute);
Xfree(font_set->vmap);
Xfree(font_set->vrotate);
Xfree(font_set);
gen->font_set = (FontSet) NULL;
gen->font_set_num = 0;
return False;
@ -504,8 +500,8 @@ init_core_part(
return True;
err:
if (font_name_list)
Xfree(font_name_list);
Xfree(font_name_list);
Xfree(font_struct_list);
return False;
@ -1486,24 +1482,15 @@ destroy_oc(
*/
/* For VW/UDC end */
if (oc->core.base_name_list)
Xfree(oc->core.base_name_list);
if (oc->core.font_info.font_name_list)
XFreeStringList(oc->core.font_info.font_name_list);
if (oc->core.font_info.font_struct_list) {
Xfree(oc->core.font_info.font_struct_list);
}
if (oc->core.missing_list.charset_list)
XFreeStringList(oc->core.missing_list.charset_list);
Xfree(oc->core.base_name_list);
XFreeStringList(oc->core.font_info.font_name_list);
Xfree(oc->core.font_info.font_struct_list);
XFreeStringList(oc->core.missing_list.charset_list);
#ifdef notdef
if (oc->core.res_name)
Xfree(oc->core.res_name);
if (oc->core.res_class)
Xfree(oc->core.res_class);
Xfree(oc->core.res_name);
Xfree(oc->core.res_class);
#endif
Xfree(oc);