Samuel Pitoiset
f8ce76e996
radv: remove declared but unused create_null_physical_device()
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41755 >
2026-05-26 10:18:50 +00:00
Samuel Pitoiset
921eedee8b
radv: add a separate function to query allocated/usage for each heap
...
This is just a cleanup that will be useful for upcoming changes.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41755 >
2026-05-26 10:18:50 +00:00
Samuel Pitoiset
25a53ab412
radv: pre-compute a mask of supported global queue priorities
...
That removes the winsys dependency when querying that.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41755 >
2026-05-26 10:18:49 +00:00
Samuel Pitoiset
c1a3619d2c
radv: use radv_device::ws directly for quering sync payloads
...
Easier to spot the remaining occurrences.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41755 >
2026-05-26 10:18:49 +00:00
David Rosca
dfc608260a
radv: Add support for timestamps on video queue
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41744 >
2026-05-26 09:29:42 +00:00
David Rosca
581bf2e3b0
ac/cmdbuf: Add ac_emit_video_write_timestamp
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41744 >
2026-05-26 09:29:42 +00:00
David Rosca
165a0105d3
ac/vcn_dec: Move register defines to ac_vcn_dec.c
...
Also remove unused struct jpeg_params.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41743 >
2026-05-26 08:31:12 +00:00
David Rosca
fa96c3781c
radv: Use ac_emit_video_write_memory
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41743 >
2026-05-26 08:31:12 +00:00
David Rosca
8f2ee52c0e
ac/cmdbuf: Add ac_emit_video_write_memory
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41743 >
2026-05-26 08:31:10 +00:00
David Rosca
e1e65e47d4
ac/vcn: Add ac_vcn_sq_header/tail and use it for decode
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41743 >
2026-05-26 08:31:10 +00:00
David Rosca
f775ecb143
ac/vcn_dec: Add ac_vcn_dec_init_regs to get register offsets
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41743 >
2026-05-26 08:31:10 +00:00
Timur Kristóf
af8c3eb3d6
ac/nir: Fix SMEM workaround with emulated RT
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Use the RT descriptors pointer as dummy VA.
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Natalie Vock <natalie.vock@gmx.de>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41780 >
2026-05-25 23:32:13 +00:00
Timur Kristóf
3ff698e9fc
ac/nir: When loading an arg, assert that it's used
...
To avoid weird crashes caused by trying to load unused attributes.
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Natalie Vock <natalie.vock@gmx.de>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41780 >
2026-05-25 23:32:13 +00:00
Samuel Pitoiset
e2e7fce6e9
radv: rename radv_zero_vram to vk_zero_vram
...
More common and this implicitly enables this for Path Of Exile and X4
Foundations. Though, zero VRAM allocs is already the default in AMDGPU,
so that doesn't change anything in practice (except for very old
kernels).
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41735 >
2026-05-25 16:49:28 +00:00
Samuel Pitoiset
e2631eca0f
radv: close the local fd immediately after the winsys is created
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
libdrm dups the fd internally, so local_fd and get_fd() are different
fd number but they point to the same file descriptor. Close it right
after the amdgpu device is initialized to avoid keeping two fds open
for the same thing.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41753 >
2026-05-25 16:26:19 +00:00
Marek Olšák
1b45a8aee2
radv: select frag_coord_xy and pixel_coord conditionally based on dynamic state
...
the code explains it
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> (shader parts)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41689 >
2026-05-25 13:38:08 +00:00
Marek Olšák
22e40edfb9
radv: move SPI_PS_INPUT_ENA emission into radv_emit_ps_state
...
The register values will depend on new fields in PS_STATE and it doesn't
seem like dynamic state belongs in radv_emit_fragment_shader_state.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41689 >
2026-05-25 13:38:07 +00:00
Marek Olšák
caef0aebba
radv: remove dead load_sample_pos code
...
lowered by radv_nir_lower_opt_fs_frag_pos
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41689 >
2026-05-25 13:38:06 +00:00
Marek Olšák
6cd04ca6e5
radv: add a pass that selects either frag_coord_xy or pixel_coord, but not both
...
to reduce the number of initialized PS VGPRs, increasing the PS wave launch
rate.
The pass will have more RADV-specific stuff.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41689 >
2026-05-25 13:38:06 +00:00
Georg Lehmann
f43bc8e8be
radv: support VK_KHR_shader_fma
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41649 >
2026-05-25 11:50:38 +00:00
Georg Lehmann
3ea594f42b
ac/llvm: never create ffmaz for broken llvm
...
The workaround wasn't proper fused ffma.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41649 >
2026-05-25 11:50:38 +00:00
Georg Lehmann
015b1d9e6d
ac/llvm: don't assert on 32bit ffma before gfx9
...
Yes it's slow, but it's better than nothing.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41649 >
2026-05-25 11:50:38 +00:00
Georg Lehmann
a92d0356eb
nir: seperate ffmaz from has_fmulz
...
There is no hardware which supports ffmaz with denorms.
We also need this to be seperate because there is AMD hardware
with ffma but not ffmaz.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41649 >
2026-05-25 11:50:38 +00:00
Georg Lehmann
19e56904f2
aco/optimizer: only create v_fma_legacy_f32 when denorms are disabled
...
For some reasons, this instruction always flushes denorms.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41649 >
2026-05-25 11:50:38 +00:00
Samuel Pitoiset
07754c960a
radv: validate drirc option names at compile time
...
This would prevent any typos or if something is backported incorrectly
in the future.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41700 >
2026-05-21 14:26:28 +00:00
Samuel Pitoiset
e685f8d6aa
radv/ci: cleanup list of expected failures
...
Triage invalid tests to make it easier to see real failures.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41717 >
2026-05-21 14:03:22 +00:00
Samuel Pitoiset
91cf0a6e6d
radv: use the new generation script for drirc
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41634 >
2026-05-21 12:57:43 +00:00
Samuel Pitoiset
bf787fd91b
radv: rename few drirc options for consistency
...
So that the option name matches everywhere.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41634 >
2026-05-21 12:57:41 +00:00
Timothy Arceri
ca88f851c8
ac/nir/lower_tex_coord: basic lower tex coord test
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Tests issue from: https://gitlab.freedesktop.org/mesa/mesa/-/work_items/15494
Assisted-by: ChatGPT (GPT-5.5)
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41666 >
2026-05-21 00:54:56 +00:00
David Rosca
2c0caee6db
ac/info: Print number of VPE instances
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35431 >
2026-05-20 13:36:25 +00:00
David Rosca
c5a9bfc210
ac/info: Remove old video codec caps
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35431 >
2026-05-20 13:36:25 +00:00
David Rosca
280cb489ae
radv/video: Use new video codec caps
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35431 >
2026-05-20 13:36:24 +00:00
David Rosca
914b4a700c
ac/info: Add video codec caps
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35431 >
2026-05-20 13:36:24 +00:00
Georg Lehmann
1234a01dda
radv: add radv_force_64_byte_sampled_image dri conf option
...
Cc: mesa-stable
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41680 >
2026-05-20 13:03:01 +00:00
Georg Lehmann
1b8465a38f
radv: use radv_get_sampled_image_desc_size instead of open coding it
...
Cc: mesa-stable
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41680 >
2026-05-20 13:03:01 +00:00
Pierre-Eric Pelloux-Prayer
0ecc6eb2f5
ac/sqtt: add ac_sqtt_update_bo_size
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
buffer_size is uint32_t so we must be careful to not overflow it.
radeonsi had code for this but radv doesn't, which means it will
hang if RADV_THREAD_TRACE_BUFFER_SIZE is too big or if buffer_size
is being doubled up to the point it overflows.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41383 >
2026-05-20 08:33:22 +00:00
Pierre-Eric Pelloux-Prayer
2854c1b778
radv, radeonsi: do sqtt buffer_size calc using uint64
...
The final size is uint64_t so use it from the start to avoid
overflow issues.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41383 >
2026-05-20 08:33:22 +00:00
Thong Thai
d7f72e4e5b
amd: Build nir files only when with_gfx_compute
...
Signed-off-by: Thong Thai <thong.thai@amd.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Acked-by: Benjamin Cheng <benjamin.cheng@amd.com>
Reviewed-by: Marek Olšák <maraeo@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41494 >
2026-05-19 22:14:41 +00:00
Samuel Pitoiset
54b71e9e77
util: pass a struct to driParseConfigFiles()
...
It would be easier to add more functionalities like shader hashes etc.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41657 >
2026-05-19 19:51:45 +00:00
Karol Herbst
e9c1cce35f
nir: remove ffma_old
...
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41165 >
2026-05-19 18:13:42 +00:00
Karol Herbst
109d93dd98
nir: update ffma helpers to use new opcodes
...
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41165 >
2026-05-19 18:13:41 +00:00
Karol Herbst
6cf3cba68c
radv: use nir_op_ffma_weak
...
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41165 >
2026-05-19 18:13:36 +00:00
Karol Herbst
3e334ea0d3
aco: support new multadd opcodes
...
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41165 >
2026-05-19 18:13:36 +00:00
Karol Herbst
04696f9bf9
ac/llvm: support new multadd opcodes
...
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41165 >
2026-05-19 18:13:35 +00:00
Karol Herbst
a80e254fd4
ac: use nir_op_ffma_weak
...
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41165 >
2026-05-19 18:13:35 +00:00
Karol Herbst
570bfe1ee0
ac: handle new float multadd opcodes
...
This advertizes both ffma and fmad on a couple of chipsets to support
VK_KHR_shader_fma and to improve OpenCL fma performance, where fma is not
optional and the emulation is more expensive than slow fma.
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41165 >
2026-05-19 18:13:35 +00:00
Karol Herbst
a9b18f8607
nir: rename ffma to ffma_old
...
We'll get three new opcodes to properly model float multiply-add.
ffma_old is temporary and will be deleted at the end of this series.
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41165 >
2026-05-19 18:13:27 +00:00
Samuel Pitoiset
29b86874c3
radv: move radv_GetDeviceFaultInfoEXT() to radv_device.c
...
Because radv_debug.c will be moved to a subdirectory called tools/ and
this is entrypoint from VK_EXT_device_fault.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41598 >
2026-05-19 17:48:46 +00:00
Samuel Pitoiset
4dc158a8cb
radv: remove an outdated comment in radv_GetDeviceFaultInfoEXT()
...
The driver exports GPU hang reports already.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41598 >
2026-05-19 17:48:46 +00:00
Samuel Pitoiset
d348e324da
radv: advertise VK_EXT_device_fault by default
...
This is can still be useful if the kernel has no GPUVM query support
becuse it's possible to export GPU hang reports.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41598 >
2026-05-19 17:48:45 +00:00