10138 commits

Author	SHA1	Message	Date
Samuel Pitoiset	effa563bb0	radv: adjust computing the PC from the trap handler on GFX12 ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34840>	2025-05-09 09:04:57 +00:00
Samuel Pitoiset	4b76d04f7f	radv: ignore conditional rendering with vkCmdTraceRays* ... CmdTraceRays is neither a dispatch or a draw command which means it shouldn't be affected by conditional rendering. Fixes recent VKCTS coverage. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34868>	2025-05-08 19:08:10 +00:00
Samuel Pitoiset	b7d2cdd2b4	radv: ignore radv_disable_dcc_stores on GFX12 ... It's not necessary because DCC is completely transparent to the userspace driver. Also it's causing issues with scanout. This fixes rendering issues with scanout in Indiana Jones. Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12924 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34859>	2025-05-08 17:17:28 +02:00
Rhys Perry	2704a30df0	radv: perform nir_opt_access before the first radv_optimize_nir ... Two lowered loads might not be CSE'd after nir_lower_explicit_io if one of them is shrinked. This doesn't happen for deref loads, but it needs the CAN_REORDER flag first. fossil-db (gfx1201): Totals from 556 (0.70% of 79377) affected shaders: MaxWaves: 14936 -> 14940 (+0.03%); split: +0.05%, -0.03% Instrs: 2140334 -> 2140942 (+0.03%); split: -0.07%, +0.10% CodeSize: 11137948 -> 11145416 (+0.07%); split: -0.07%, +0.13% SpillSGPRs: 2385 -> 2527 (+5.95%); split: -0.34%, +6.29% Latency: 12310570 -> 12305011 (-0.05%); split: -0.08%, +0.04% InvThroughput: 2136142 -> 2135516 (-0.03%); split: -0.06%, +0.03% VClause: 47419 -> 47420 (+0.00%); split: -0.01%, +0.01% SClause: 58423 -> 58290 (-0.23%); split: -0.36%, +0.14% Copies: 160626 -> 161321 (+0.43%); split: -0.25%, +0.68% Branches: 69693 -> 69710 (+0.02%); split: -0.04%, +0.06% PreSGPRs: 34824 -> 34945 (+0.35%); split: -0.24%, +0.58% PreVGPRs: 28682 -> 28649 (-0.12%); split: -0.36%, +0.24% VALU: 1080800 -> 1081171 (+0.03%); split: -0.04%, +0.08% SALU: 353112 -> 353770 (+0.19%); split: -0.15%, +0.34% SMEM: 81587 -> 81364 (-0.27%) Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34162>	2025-05-08 13:30:50 +00:00
Rhys Perry	8abb787c6b	radv/gfx12: use dword3 smem loads for push constants ... fossil-db (gfx1201): Totals from 5 (0.01% of 79377) affected shaders: (no affected stats) Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34162>	2025-05-08 13:30:50 +00:00
Marek Olšák	b960137ebf	aco: remove unused aco_shader_info::tcs_offchip_layout ... Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34863>	2025-05-08 02:54:13 +00:00
Marek Olšák	f58c0cbb6a	nir: split *_accessed_indirectly* bitmasks into *_read/written_indirectly* ... for AMD Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34863>	2025-05-08 02:54:12 +00:00
Konstantin Seurer	84b9c281fe	radv: Return VK_ERROR_INCOMPATIBLE_DRIVER for unsupported devices ... VK_ERROR_INITIALIZATION_FAILED will fail physical device enumeration. Returning VK_ERROR_INCOMPATIBLE_DRIVER means that the driver can still be used on supported GPUs when multiple GPUs are installed. cc: mesa-stable Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34783>	2025-05-07 08:26:33 +02:00
Samuel Pitoiset	1aa5fd5da2	radv: promote VK_EXT_robustness2 to VK_KHR_robustness2 ... This is a 1:1 promotion. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34810>	2025-05-05 15:02:19 +00:00
Samuel Pitoiset	0684dc5fa8	radv: fix GPU hangs with image copies for ASTC/ETC2 formats on transfer queue ... Emitting compute dispatches on SDMA just hangs. It might be needed to switch to gang submit for these to work but fixing the GPU hang is more important for now. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34805>	2025-05-05 13:50:25 +00:00
Samuel Pitoiset	1356d20042	radv: disable SINGLE clear codes to workaround a hw bug with DCC on GFX11 ... This fixes a very weird cache-related corruption with DCC on GFX11 due to a hw bug according to PAL. Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12932 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34790>	2025-05-05 07:07:58 +00:00
Samuel Pitoiset	55ad0fd35c	radv: do not clear unwritten color attachments with dual-source blending ... This is incorrect because the color format at slot 0 needs to be replicated to the slot 1. But with dual-source blending the colors written mask is only 0xf and this was clearing the color format at slot 1. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13082 Fixes: e1483d022b ("radv: clear unwritten color attachments for monolithic PS earlier") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34773>	2025-05-05 06:46:32 +00:00
Marek Olšák	7f0de1a512	ac: remove gfx11_emulate_clear_state ... We don't use CLEAR_STATE on gfx11 anymore. Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34589>	2025-05-02 18:40:11 +00:00
Philip Rebohle	4cb358f1c2	radv: Remove offset parameter from radv_make_texel_buffer_descriptor. ... This is already only used in vkCreateBufferView, and causes a vkd3d-proton test to fail with >4GB offsets since the parameter was 32-bit only. Signed-off-by: Philip Rebohle <philip.rebohle@tu-dortmund.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34760>	2025-05-02 09:13:14 +00:00
Paul Gofman	96765935e8	radv/amdgpu: Fix hash key in radv_amdgpu_winsys_destroy(). ... Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34774>	2025-05-02 07:51:23 +00:00
Ricardo Garcia	bc44d029df	radv: Ignore image barrier queue families if equal ... The src and dst queue family indices in an image memory barrier may contain arbitrary values that can be ignored unless both are different. This fixes a crash in upcoming CTS tests. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34691>	2025-04-29 08:15:28 +00:00
Samuel Pitoiset	1fccc09abe	radv: fix re-emitting VRS state when rendering begins ... This state also depends on whether a VRS attachment is used. Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11693 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34735>	2025-04-29 07:00:09 +00:00
Timur Kristóf	3ad385b9cc	radv: Clear dirty flag for clip rects state after emitting it. ... Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Tested-by: Marcus Seyfarth <m.seyfarth@gmail.com> Fixes: 0ba3a8b3cc Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34686>	2025-04-24 15:13:44 +00:00
Timur Kristóf	3a05477ac6	radv: Clear dirty flag for MSAA state after emitting it. ... Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Tested-by: Marcus Seyfarth <m.seyfarth@gmail.com> Fixes: 08918f0880 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13022 Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34686>	2025-04-24 15:13:44 +00:00
Georg Lehmann	6d2190300a	radv/nir/lower_cmat: tightly pack 8bit gfx11 acc matrix ... Invalid for now, but used by vkd3d-proton, where the use case is to convert a result matrix to lower precision, followed by a store. For 16bit accumulation matrices, GFX11 only uses 16bits per 32bit register. RADV's coop matrix code pads the unused space with undefs and uses a vector with twice as many elements as the matrix length. Extending that to 8bit by leaving 24 bits unused is unnecessary as these matrices as there is no hw unit that requires it. And in wave32, it would also result in vectors larger than NIR's limit. So tightly pack 8bit matrices without any undef padding. Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34382>	2025-04-24 06:37:44 +00:00
Georg Lehmann	bbc9bc9d24	radv/nir/lower_cmat: use cmat_mul instead of duplicating hw details for type conversion ... Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34382>	2025-04-24 06:37:44 +00:00
Georg Lehmann	31a3430570	radv/nir/lower_cmat: use radv_nir_cmat_bits consistently ... Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34382>	2025-04-24 06:37:44 +00:00
Georg Lehmann	c3964e87f8	radv: apply fneg/fabs modifiers to wmma ... Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34396>	2025-04-22 16:08:55 +00:00
Georg Lehmann	6d7e67d986	nir,amd: add neg_lo/hi modifiers to cmat_matmul_amd ... Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34396>	2025-04-22 16:08:55 +00:00
Marek Olšák	4a51089f30	radv: fix incorrect patch_outputs_read for TCS with dynamic state ... Fixes: 8c2f9f0665 - radv: switch to the new TCS LDS/offchip size computation Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34544>	2025-04-19 22:55:00 -04:00
Marek Olšák	be8977811b	ac/nir: remove shader_info parameter from ac_nir_compute_tess_wg_info ... Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34544>	2025-04-19 22:55:00 -04:00
Marek Olšák	d82eda72a1	ac/gpu_info: move HS info into radeon_info ... Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34544>	2025-04-19 22:55:00 -04:00
Marek Olšák	ea294349bd	radv: move the tess factor ring after the tess offchip ring ... to match radeonsi Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34544>	2025-04-19 22:54:59 -04:00
Marek Olšák	c057d9105f	ac/gpu_info: add total_tess_ring_size ... Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34544>	2025-04-19 22:54:59 -04:00
Samuel Pitoiset	792c30dd32	radv/meta: remove redundant parameter to blit_surf_for_image_level_layer() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34558>	2025-04-18 17:21:24 +02:00
Samuel Pitoiset	a3f2c5f05e	radv/meta: remove unnecessary radv_meta_blit2d_buffer::bs ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34558>	2025-04-18 17:21:24 +02:00
Samuel Pitoiset	78c2feed00	radv/meta: rename more buffer->memory for fill/copy/update operations ... Recently, I renamed most of the helpers for future work but I forgot few things like meta keys, etc. This is for consistency. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34558>	2025-04-18 17:21:24 +02:00
Samuel Pitoiset	43c8cb1ae2	radv/meta: remove unused functions/prototypes ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34558>	2025-04-18 17:21:24 +02:00
Samuel Pitoiset	78f03dcf70	radv/meta: simplify dealing with image layouts for blits/resolves ... This doesn't do anything useful. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34558>	2025-04-18 17:21:24 +02:00
Konstantin Seurer	76031ba53d	radv: Optimize the gfx12 encode shader ... Reviewed-by: Natalie Vock <natalie.vock@gmx.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34273>	2025-04-17 20:20:40 +00:00
Konstantin Seurer	97f6287827	radv: Use the BVH8 format on GFX12 ... Reviewed-by: Natalie Vock <natalie.vock@gmx.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34273>	2025-04-17 20:20:40 +00:00
Konstantin Seurer	95e7343a7d	radv/bvh: Add helpers for encoding ... The build and update paths can use the same code. Reviewed-by: Natalie Vock <natalie.vock@gmx.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34273>	2025-04-17 20:20:40 +00:00
Konstantin Seurer	3af19f336c	radv/bvh: Document GFX12 BVH encoding ... Reviewed-by: Natalie Vock <natalie.vock@gmx.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34273>	2025-04-17 20:20:40 +00:00
Konstantin Seurer	2942e3affb	radv/rra: Set rra_accel_struct_header::rtip_level ... Reviewed-by: Natalie Vock <natalie.vock@gmx.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34273>	2025-04-17 20:20:40 +00:00
Konstantin Seurer	fa99eeb2b4	radv/rra: Move gfx10_3 specific code to a new file ... gfx12 needs completely different code and having them in different files is cleaner. Reviewed-by: Natalie Vock <natalie.vock@gmx.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34273>	2025-04-17 20:20:40 +00:00
Konstantin Seurer	9d157173b2	radv: Refactor create_bvh_descriptor ... Make it a bit more extendable since GFX12 introduced more fields. Reviewed-by: Natalie Vock <natalie.vock@gmx.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34273>	2025-04-17 20:20:40 +00:00
Konstantin Seurer	978e9b670e	aco,nir: Add support for new GFX12 ray tracing instructions ... Adds image_bvh_dual_intersect_ray and image_bvh8_intersect_ray which can handle the new BVH format. Both instructions write up to 10 VGPRs so they need to use a vec16 definition in nir. Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34273>	2025-04-17 20:20:40 +00:00
Konstantin Seurer	2dee1117b7	vulkan: Add a vk_device parameter to get_encode_key ... Useful for selecting different encoding options based on hardware generation. Reviewed-by: Natalie Vock <natalie.vock@gmx.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34273>	2025-04-17 20:20:40 +00:00
Caio Oliveira	fd0a7efb5a	spirv, nir: Delay calculation of shared_size when using explicit layout ... Move the calculation to nir_lower_vars_to_explicit_types(). This consolidates the check of shader_info::shared_memory_explicit_layout in a single place instead of in all drivers. This is motivated by SPV_KHR_untyped_pointers. Before that extension we had essentially two modes for shared memory variables - No layout decorations in the SPIR-V, and both internal layout and driver location was _given by the driver_. - Explicitly laid out, i.e. they are blocks, and decorated with Aliased. Because they all alias, we could assign them driver location directly to the start of the shared memory. With the untyped pointers extension, there's a third option, to be added by a later commit - Explicitly laid out, i.e. they are blocks, and NOT decorated with Aliased. Driver location is _given by the driver_. Blocks with and without Aliased can be mixed. The driver location of multiple blocks that don't alias depend on alignment that is driver-specific, which we can more easily do from the nir_lower_vars_to_explicit_types() that already has access to a function to obtain such value. Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> (hk) Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> (v3dv) Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> (anv/hasvk) Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> (panvk) Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> (radv) Reviewed-by: Rob Clark <robdclark@gmail.com> (tu) Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34139>	2025-04-17 19:13:17 +00:00
Samuel Pitoiset	209a0ede98	radv: add a function to emit meshlet registers on GFX11+ ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34518>	2025-04-17 12:49:47 +00:00
Samuel Pitoiset	836757bec3	radv: tidy up radv_emit_ps_epilog_state() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34518>	2025-04-17 12:49:47 +00:00
Samuel Pitoiset	dca35b7226	radv: tidy up radv_emit_geometry_shader() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34518>	2025-04-17 12:49:47 +00:00
Samuel Pitoiset	d999afeb7a	radv: tidy up radv_emit_vertex_shader() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34518>	2025-04-17 12:49:47 +00:00
Samuel Pitoiset	85fdf69027	radv: simplify combining TES/VS+GS config registers ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34518>	2025-04-17 12:49:47 +00:00
Samuel Pitoiset	0dd9833348	radv: remove redundant assertion when emitting PS epilog state ... It's already checked by radv_emit_32bit_pointer(). Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34518>	2025-04-17 12:49:47 +00:00