69545 commits

Author	SHA1	Message	Date
Alyssa Rosenzweig	e5e91887cf	asahi: clang-format ... Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35295>	2025-06-02 20:34:32 +00:00
Alyssa Rosenzweig	49564786f7	asahi: drop dead surface stuff ... Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35295>	2025-06-02 20:34:32 +00:00
Mike Blumenkrantz	e0641fdac7	zink: fix ZINK_RENDERDOC=all ... the intent of this option is to create a single capture for the lifetime of the app, which is great for unit test debugging, and this instead created a capture for every queue submission, which is a nightmare Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35292>	2025-06-02 17:34:04 +00:00
Mike Blumenkrantz	cb6dfc4169	zink: unlock instance mutex if creation fails ... avoids a deadlock Fixes: 015eda4a41 ("zink: deduplicate VkDevice and VkInstance") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35292>	2025-06-02 17:34:04 +00:00
Eric Engestrom	f611fb4af9	svga/ci: fix indentation ... The list of files is _inside_ `changes:`, not alongside it. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35289>	2025-06-02 17:15:18 +00:00
Eric Engestrom	0c5fa54b5b	svga/ci: fix job stages ... Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35289>	2025-06-02 17:15:18 +00:00
Mike Blumenkrantz	a321b3207c	util/dd: delete surface object hooks ... Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	ddef6be19a	noop: delete surface object hooks ... Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	bbc4a2d2d9	aux/trace: delete surface object hooks ... should never be used Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	0100e44a8c	util/tc: delete surface hooks ... these should never be called from a frontend now Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	94979fec2c	vl: delete a missed pipe_surface_reference usage ... Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: David Rosca <david.rosca@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	06cf5794b1	vdpau: de-pointerize surfaces ... Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: David Rosca <david.rosca@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	b36fba19cc	va: remove one more pipe_surface object ... Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: David Rosca <david.rosca@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	5607797743	d3d10umd: update to latest pipe_surface changes ... does it work? nobody knows! Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	561fed955b	d3d10umd: stop using pipe_surface::width/height ... these were deleted months ago Fixes: 9d359c6d10 ("gallium: delete pipe_surface::width and pipe_surface::height") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	3ecec254a7	util/tc: fix surface refcounting (by deleting it) ... missed this in earlier series Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	11a3f2f3d1	lavapipe: kill off pipe_surface objects ... Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	db500d4a56	gallium: kill off pipe_surface_unref_no_context() ... Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	718e277ab5	util/surface: delete more pipe_context::create_surface usage ... Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	2d9f5d3bcd	util/debug: delete more pipe_context::create_surface usage ... Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Mike Blumenkrantz	b92b67c941	util/blitter: delete more pipe_context::create_surface usage ... Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35236>	2025-06-02 16:49:32 +00:00
Collabora's Gfx CI Team	64a3ab35a9	Uprev Piglit to 685ea49b47ae52560975cfcdb0ea0d4d27fead16 ... c32e5cc717...685ea49b47 Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35223>	2025-06-02 15:39:02 +02:00
Samuel Pitoiset	47f5d25f93	radv,radeonsi: emit UPDATE_DB_SUMMARIZER_TIMEOUT on GFX12 ... This try to mitigate the HiZ GPU hang by increasing a timeout. Loosely based on PAL but I can confirm it delays the hang when BOTTOM_OF_PIPE_TS is used as a workaround. This must be emitted when the GFX queue is idle. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35212>	2025-06-02 07:30:18 +00:00
Karol Herbst	ad08dc9549	llvmpipe remove llvmpipe_screen::allow_cl ... Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35275>	2025-06-02 07:13:54 +00:00
Maíra Canal	9e4e8542d4	v3d: make sure all jobs are done before destroying the context ... Currently, Mesa CI is reporting the following kernel OOPS in the RPi 4: [ 800.139824] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000588 [ 800.148619] Mem abort info: [ 800.151402] ESR = 0x0000000096000005 [ 800.155141] EC = 0x25: DABT (current EL), IL = 32 bits [ 800.160444] SET = 0, FnV = 0 [ 800.163488] EA = 0, S1PTW = 0 [ 800.166619] FSC = 0x05: level 1 translation fault [ 800.171487] Data abort info: [ 800.174357] ISV = 0, ISS = 0x00000005, ISS2 = 0x00000000 [ 800.179832] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [ 800.184873] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [ 800.190176] user pgtable: 4k pages, 39-bit VAs, pgdp=00000001014c2000 [ 800.196607] [0000000000000588] pgd=0000000000000000, p4d=0000000000000000, pud=0000000000000000 [ 800.205305] Internal error: Oops: 0000000096000005 [#1] PREEMPT SMP [ 800.211564] Modules linked in: vc4 snd_soc_hdmi_codec drm_display_helper v3d cec gpu_sched drm_dma_helper drm_shmem_helper drm_kms_helper drm drm_panel_orientation_quirks snd_soc_core snd_compress snd_pcm_dmaengine snd_pcm i2c_brcmstb snd_timer snd backlight [ 800.234448] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.12.25+rpt-rpi-v8 #1 Debian 1:6.12.25-1+rpt1 [ 800.244182] Hardware name: Raspberry Pi 4 Model B Rev 1.4 (DT) [ 800.250005] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 800.256959] pc : v3d_job_update_stats+0x60/0x130 [v3d] [ 800.262112] lr : v3d_job_update_stats+0x48/0x130 [v3d] [ 800.267251] sp : ffffffc080003e60 [ 800.270555] x29: ffffffc080003e60 x28: ffffffd842784980 x27: 0224012000000000 [ 800.277687] x26: ffffffd84277f630 x25: ffffff81012fd800 x24: 0000000000000020 [ 800.284818] x23: ffffff8040238b08 x22: 0000000000000570 x21: 0000000000000158 [ 800.291948] x20: 0000000000000000 x19: ffffff8040238000 x18: 0000000000000000 [ 800.299078] x17: ffffffa8c1bd2000 x16: ffffffc080000000 x15: 0000000000000000 [ 800.306208] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 [ 800.313338] x11: 0000000000000040 x10: 0000000000001a40 x9 : ffffffd83b39757c [ 800.320468] x8 : ffffffd842786420 x7 : 7fffffffffffffff x6 : 0000000000ef32b0 [ 800.327598] x5 : 00ffffffffffffff x4 : 0000000000000015 x3 : ffffffd842784980 [ 800.334728] x2 : 0000000000000004 x1 : 0000000000010002 x0 : 000000ba4c0ca382 [ 800.341859] Call trace: [ 800.344294] v3d_job_update_stats+0x60/0x130 [v3d] [ 800.349086] v3d_irq+0x124/0x2e0 [v3d] [ 800.352835] __handle_irq_event_percpu+0x58/0x218 [ 800.357539] handle_irq_event+0x54/0xb8 [ 800.361369] handle_fasteoi_irq+0xac/0x240 [ 800.365458] handle_irq_desc+0x48/0x68 [ 800.369200] generic_handle_domain_irq+0x24/0x38 [ 800.373810] gic_handle_irq+0x48/0xd8 [ 800.377464] call_on_irq_stack+0x24/0x58 [ 800.381379] do_interrupt_handler+0x88/0x98 [ 800.385554] el1_interrupt+0x34/0x68 [ 800.389123] el1h_64_irq_handler+0x18/0x28 [ 800.393211] el1h_64_irq+0x64/0x68 [ 800.396603] default_idle_call+0x3c/0x168 [ 800.400606] do_idle+0x1fc/0x230 [ 800.403827] cpu_startup_entry+0x40/0x50 [ 800.407742] rest_init+0xe4/0xf0 [ 800.410962] start_kernel+0x5e8/0x790 [ 800.414616] __primary_switched+0x80/0x90 [ 800.418622] Code: 8b170277 8b160296 11000421 b9000861 (b9401ac1) [ 800.424707] ---[ end trace 0000000000000000 ]--- [ 800.429316] Kernel panic - not syncing: Oops: Fatal exception in interrupt [ 800.436181] SMP: stopping secondary CPUs [ 800.440097] Kernel Offset: 0x17c1000000 from 0xffffffc080000000 [ 800.446007] PHYS_OFFSET: 0x0 [ 800.448877] CPU features: 0x08,00002013,c0200000,0200421b [ 800.454267] Memory Limit: none [ 800.457313] ---[ end Kernel panic - not syncing: Oops: Fatal exception in interrupt ]--- The NULL pointer in question is the `job->file`, which represents the DRM state for a file descriptor. This means that the process is finishing before the job completes. To avoid such issue, make sure all jobs are done before flushing the jobs when destroying the context. Backport-to: 25.1 Signed-off-by: Maíra Canal <mcanal@igalia.com> Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com> Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35233>	2025-06-02 06:10:16 +00:00
Brian Paul	f29d939824	svga: rework framebuffer state ... Create svga_framebuffer_state as a subclass of pipe_framebuffer_state. This contains pointers to svga_surface objects which correspond to pipe_framebuffer_state's surfaces. Replace pipe_surface with svga_surface in many functions. Stop using deprecated util_framebuffer_init() function. See https://gitlab.freedesktop.org/mesa/mesa/-/issues/13262 Signed-off-by: Brian Paul <brian.paul@broadcom.com>x Reviewed-by: Neha Bhende <neha.bhende@broadcom.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35238>	2025-05-30 16:40:56 +00:00
Brian Paul	b7774effbf	svga: asst. clean-ups in svga_surface.c ... - whitespace fixes - move var decls - add const qualifiers No functional changes. Signed-off-by: Brian Paul <brian.paul@broadcom.com> Reviewed-by: Neha Bhende <neha.bhende@broadcom.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35238>	2025-05-30 16:40:56 +00:00
Brian Paul	24a57350eb	svga: whitespace clean-ups in svga_screen_cache.h ... Signed-off-by: Brian Paul <brian.paul@broadcom.com> Reviewed-by: Neha Bhende <neha.bhende@broadcom.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35238>	2025-05-30 16:40:56 +00:00
Brian Paul	ce70baeef3	gallium/util: minor clean-ups in u_framebuffer.c ... Replace tabs w/ spaces, move vars. Signed-off-by: Brian Paul <brian.paul@broadcom.com> Reviewed-by: Neha Bhende <neha.bhende@broadcom.com> Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35238>	2025-05-30 16:40:56 +00:00
Brian Paul	64da531799	svga: remove unneeded assignments in svga_set_framebuffer_state() ... The util_copy_framebuffer_state() function copies the width, height, nr_cbufs fields. Also move a loop variable. Signed-off-by: Brian Paul <brian.paul@broadcom.com> Reviewed-by: Neha Bhende <neha.bhende@broadcom.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35238>	2025-05-30 16:40:56 +00:00
Brian Paul	dac04694b2	svga: handle NULL surface in svga_surface_needs_propagation() ... To avoid null checks at the call sites. Signed-off-by: Brian Paul <brian.oaul@broadcom.com> Reviewed-by: Neha Bhende <neha.bhende@broadcom.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35238>	2025-05-30 16:40:56 +00:00
Brian Paul	e6058e5ab0	svga: 80-column wrapping and misc code cleanups ... No functional changes. Signed-off-by: Brian Paul <brian.paul@broadcom.com> Reviewed-by: Neha Bhende <neha.bhende@broadcom.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35238>	2025-05-30 16:40:56 +00:00
David Rosca	3bb9905e7f	radeonsi/vcn: Use picture fence in JPEG decode ... The fence needs to be passed to frontend to make vaSyncSurface work correctly. Cc: mesa-stable Reviewed-by: Leo Liu <leo.liu@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35258>	2025-05-30 16:17:42 +00:00
Yao Zi	b1d81a7df1	radeonsi: Fix violation of aliasing rules in radeon_ws_bo_reference ... Applications using Mesa built with LLVM 20.1.4 fail to start with strange segmentfaults/bus errors when radeonsi driver is used. The last piece of stacktrace looks like - pipe_reference_described - pipe_reference - radeon_bo_reference - radeon_ws_bo_reference - radeon_lookup_or_add_real_buffer Coredump shows the pointer dst passed to pipe_reference_described() is either unaligned or even invalid, which is the reason of crashing. The crash goes away when Mesa is built without optimization. Looking through the related functions, it's found that radeon_ws_bo_reference() contains unsafe type cast from radeon_bo to pb_buffer_lean: though the former's first field is just the later, this violates strict aliasing rules as pb_buffer_lean isn't compatible with radeon_bo. Such violation ultimately results in miscompilation. Let's take the address of pb_buffer_lean field, avoiding the unsafe cast. It's still required to cast pb_buffer_lean back to radeon_bo since radeon_bo_reference may update the pointer, which is safe as radeon_bo contains a pb_buffer_lean member and C language permits access members through a pointer in type of the container. Fixes: 6d913a2bcc ("r300,r600,radeonsi: switch to pb_buffer_lean") Link: https://www.gnu.org/software/c-intro-and-ref/manual/html_node/Aliasing-Type-Rules.html Signed-off-by: Yao Zi <ziyao@disroot.org> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35249>	2025-05-30 12:48:18 +00:00
Juan A. Suarez Romero	62ba0d7bf8	vc4: don't use deprecated NIR_PASS_V macro ... Check more details at https://gitlab.freedesktop.org/mesa/mesa/-/issues/10409. Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35127>	2025-05-30 14:24:24 +02:00
Juan A. Suarez Romero	b5706ef70a	vc4: return progress on custom nir lowering ... Report if the vc4 specific NIR lowering did any progress. Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35127>	2025-05-30 14:24:24 +02:00
David Rosca	a9a54632af	frontends/va: Fix H264 top/bottom is reference flags ... All pics in the ReferenceFrames array should be references, so there is no need to require the SHORT_TERM_REFERENCE flag to actually treat them as references. This fixes decoding with apps that doesn't set this flag, eg. NoMachine remote desktop viewer (nxplayer). See: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13229 Cc: mesa-stable Reviewed-by: Ruijing Dong <ruijing.dong@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35186>	2025-05-30 08:54:31 +00:00
David Rosca	8f4e251c98	radeonsi/vcn: Support disabling HEVC dependent slice segments ... With older FW this needs to be always enabled, but it can now be disabled when using the new separate header instructions for dependent_slice_segment_flag and slice_segment_address. Reviewed-by: Ruijing Dong <ruijing.dong@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35072>	2025-05-30 08:29:53 +00:00
David Rosca	09a1429a00	radeonsi/vcn: Remove carrizo workaround ... Carrizo has UVD so this can never be true. Reviewed-by: Ruijing Dong <ruijing.dong@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35072>	2025-05-30 08:29:53 +00:00
David Rosca	f17ea8e901	radeonsi/vcn: Get rid of not_referenced ... Reviewed-by: Ruijing Dong <ruijing.dong@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35072>	2025-05-30 08:29:52 +00:00
Jesse Natalie	47f4d3e701	d3d12: Handle a null threaded context ... When GALLIUM_THREAD=0, the threaded context doesn't get created and the following lines would fault. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35248>	2025-05-30 02:19:26 +00:00
Jesse Natalie	0c0f6c6df1	d3d12: Handle sampler view creation on B8G8R8X8 ... Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35142>	2025-05-30 01:24:10 +00:00
Jesse Natalie	f5781553f6	winsys/d3d12: Support no-alpha formats through the DXGI swapchain path ... Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35142>	2025-05-30 01:24:10 +00:00
Eric R. Smith	13b35a3c9c	panfrost, panvk: fix G31 use of SHADER_MODE_EARLY_ZS_ALWAYS ... PRE_POST_FRAME_SHADER_MODE_EARLY_ZS_ALWAYS was introduced in architecture version 7.2, not 7.0 as we assumed. Using it on G31 (a 7.0 device) caused some CTS failures. Cc: mesa-stable Reviewed-by: Olivia Lee <olivia.lee@collabora.com> Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34744>	2025-05-29 21:50:52 +00:00
Mike Blumenkrantz	44bff7eb05	zink: fix queue transition check in check_for_layout_update() ... this only applies if the resource has active binds, otherwise it triggers crashes Fixes: 18d206d67c ("zink: Check queue families when binding image resources") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35234>	2025-05-29 15:25:04 -04:00
Mike Blumenkrantz	d8d913c341	zink: also check for host-visible on staging uploads ... this has strange mechanics on lavapipe Fixes: e63acdd2b7 ("zink: force cached mem for streaming uploads") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35239>	2025-05-29 13:18:23 -04:00
Mike Blumenkrantz	05f8b59c90	gallium: delete union pipe_surface_desc ... this is no longer used Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35168>	2025-05-29 13:07:02 +00:00
Mike Blumenkrantz	ca65f2cf1c	gallium: delete pipe_surface::writable ... no longer used Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35168>	2025-05-29 13:07:02 +00:00
Karmjit Mahil	688d8217a5	tu,freedreno: Add pkt_field_{get,set} helper macro ... It's very common needing to extract or overwrite a certain field in an already packed register value, so add macros to do that instead of manually doing that each time. Signed-off-by: Karmjit Mahil <karmjit.mahil@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35088>	2025-05-29 10:54:28 +01:00
Olivia Lee	104ea2e4cf	panfrost: legalize afbc before zs and rt clears ... In panfrost_clear_depth_stencil and panfrost_clear_render_target, we start the blit context before binding the clear targets. If we don't legalize AFBC beforehand, we get a recursive blit crash. panfrost_clear does not need this because the resource should already be legalized in panfrost_batch_add_surface. Fixes the following piglit tests with pan_force_afbc_packing: - spec@arb_clear_texture@arb_clear_texture-base-formats - spec@arb_clear_texture@arb_clear_texture-simple - spec@arb_clear_texture@arb_clear_texture-sized-formats Fixes: 17a62ff993 ("panfrost: legalize afbc before blitting") Signed-off-by: Olivia Lee <olivia.lee@collabora.com> Reviewed-by: Eric R. Smith <eric.smith@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34992>	2025-05-29 01:50:31 +00:00