Marek Olšák
dca8a71ff0
vc4: don't use index_bias if indexed
...
index_bias is undefined if index_size == 0.
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
40c3a743ef
svga: fix handling draw info
...
index_bias is undefined if index_size == 0.
index bounds are undefined if index_bounds_valid == false.
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Reviewed-by: Charmaine Lee <charmainel@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
609d25c161
swr: fix handling draw info
...
index_bias is undefined if index_size == 0.
index bounds are undefined if index_bounds_valid == false.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
41ee139b6d
r600: fix handling draw info
...
has_user_indices is undefined if index_size == 0.
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
b41938eba6
panfrost: don't use index_bias if not indexed
...
index_bias is undefined if index_size == 0.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
cbdc00ac3a
nouveau: fix handling draw info
...
index_bias is undefined if index_size == 0.
index bounds are undefined if index_bounds_valid == false.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
f2e281c231
iris: don't use index_bias if not indexed
...
index_bias is undefined if index_size == 0.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
7e1d03f0df
freedreno: fixes handling draw info
...
index_bias is undefined if index_size == 0.
index bounds are undefined if index_bounds_valid == false.
Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
26dcbdb8e2
gallium: fix draw info setup in draw and utilities
...
index_bias is undefined if index_size == 0.
index bounds are undefined if index_bounds_valid == false.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
05f35a50e3
gallium: remove and emulate PIPE_CAP_MULTI_DRAW
...
To remove PIPE_CAP checking in the common code.
It's better if drivers lower multi draws even if the hardware doesn't
support it beause the multi draw loop can be moved deeper into the driver
to remove more overhead.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
87b57aa30f
gallium/u_threaded: clear vertices_per_patch if prim type != PATCHES
...
We use memcmp when combining back-to-back draws into a multi draw.
Clear vertices_per_patch if it's irrelevant to help memcmp return
a match.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
375453bb8b
vbo: switch immediate Begin/End to DrawGallium
...
This makes gallium faster because st/mesa doesn't have to translate
_mesa_prim.
Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
bc6741832e
vbo: remove _mesa_prim parameter from vbo_copy_vertices
...
glBegin/End won't use _mesa_prim, so we need to stop using it.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
d2982f6061
vbo: remove _mesa_prim parameter from vbo_merge_draws
...
glBegin/End won't use _mesa_prim, so we need to stop using it.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
9088058df0
vbo: remove _mesa_prim parameter from vbo_try_prim_conversion
...
glBegin/End won't use _mesa_prim, so we need to stop using it.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
9d90b44a23
mesa: switch MultiDrawElements(BaseVertex) to DrawGallium*
...
This makes gallium faster because st/mesa doesn't have to translate
_mesa_prim.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
e99e7aa4c1
mesa: switch Draw(Range)Elements(BaseVertex) calls to DrawGallium
...
This makes gallium faster because st/mesa doesn't have to translate
_mesa_prim.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
2358da81d2
mesa: switch (Multi)DrawArrays to DrawGallium
...
This makes gallium faster because st/mesa doesn't have to translate
_mesa_prim.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
fc3d165354
vbo: add vbo_get_minmax_indices_gallium
...
to be used by st/mesa to get index bounds because it won't have _mesa_prim
with the new draw interface.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
bd54e34e4f
mesa: add a fallback for drivers not implementing Driver.DrawGallium*
...
This is for classic drivers and it translates pipe_draw_info to the old
interface using _mesa_prim.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
dee3f34a8e
gallium: add pipe_draw_info::index::gl_bo
...
mesa/main will fill pipe_draw_info but it has no access to pipe_resources,
so we need gl_buffer_object here.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
3e7a8c4ac4
mesa: add Driver.DrawGallium* functions to be used by main/draw.c
...
This is a new Draw interface using the same parameters as draw_vbo.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
d1a19907f9
vbo: change the parameters of vbo_get_minmax_index to get rid of _mesa_prim
...
This will be used by a new Draw interface.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
3013ce766a
vbo: only set count and end when closing _mesa_prim
...
It's already set everywhere except vbo_exec_wrap_buffers.
This is a small optimization removing superfluous code.
Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Marek Olšák
641dd03f15
mesa: fix an overflow check for MultiDrawElements
...
Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7679 >
2021-01-04 19:22:33 -05:00
Jesse Natalie
ecac89b732
CI: Enable d3d12 driver for Linux CI builds
...
Acked-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8251 >
2021-01-04 23:03:01 +00:00
Jesse Natalie
7452a96e91
CI: Install DirectX-Headers package for x86 container
...
Acked-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8251 >
2021-01-04 23:03:01 +00:00
Adam Jackson
90de4ec129
drisw: Use debug_screen_wrap like everybody else
...
I tried to use GALLIUM_TRACE with llvmpipe and it didn't work, because
we were never letting the debug wrappers initialize.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8166 >
2021-01-04 22:28:17 +00:00
Jesse Natalie
dcd8adcc28
microsoft/clc: Fix const violations from ralloc_steal
...
Fixes: ff05da7f8d ("microsoft: Add CLC frontend and kernel/compute support to DXIL converter")
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7697 >
2021-01-04 22:05:02 +00:00
Adam Jackson
e33cb6a763
virgl: Enable GL_EXT_texture_sRGB_RG8
...
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8060 >
2021-01-04 21:19:35 +00:00
Adam Jackson
30bf04e2f1
zink: Enable GL_EXT_texture_sRGB_RG8
...
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8060 >
2021-01-04 21:19:35 +00:00
Adam Jackson
089371df16
zink: Enable GL_EXT_texture_sRGB_R8
...
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8060 >
2021-01-04 21:19:35 +00:00
Adam Jackson
dd05cbf5e0
mesa: Implement GL_EXT_texture_sRGB_RG8 for softpipe and llvmpipe
...
sRGB_RG8 is not registered for big-GL yet, see this Khronos issue
for updates on that:
https://github.com/KhronosGroup/OpenGL-Registry/issues/450
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8060 >
2021-01-04 21:19:35 +00:00
Adam Jackson
7b38031fb6
mesa: Cosmetic cleanups to GL_EXT_texture_sRGB_R8
...
This extension dates to 2015 not 2018, and since there's only one
texture format to check for the additional GL_TRUE is meaningless.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8060 >
2021-01-04 21:19:35 +00:00
Adam Jackson
8ddddfb516
treewide: Disambiguate various variables named "debug_options"
...
Name them after what they control so 'vi -t' can take you somewhere
useful.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8165 >
2021-01-04 20:51:28 +00:00
Mike Blumenkrantz
ebfe3e7d1b
zink: handle gl_SampleMaskIn loading in ntv
...
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8316 >
2021-01-04 18:59:06 +00:00
Mike Blumenkrantz
ad68f2c065
zink: set PIPE_CAP_MAX_VIEWPORTS
...
enables ARB_viewport_array
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8311 >
2021-01-04 18:50:29 +00:00
Mike Blumenkrantz
8676bd4420
zink: handle fs interpolation functions in ntv
...
basically load_deref but with different ops
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8203 >
2021-01-04 18:45:24 +00:00
Erik Faye-Lund
96746d6557
zink: only emit each cap once
...
This just prevents us from emitting some caps a bunch of times. Since
there's few caps in use, it seems reasonable to use this mechanism for
all caps, as it's unlikely to add up to anything worth worrying about.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8312 >
2021-01-04 18:39:35 +00:00
Mauro Rossi
c5a5009b09
android: pan/bi: Remove old IR opcode table
...
Fixes the following building error:
clang: error: no such file or directory: 'external/mesa/src/panfrost/bifrost/bi_tables.c'
clang: error: no input files
Fixes: b691aeaacf ("pan/bi: Remove old IR opcode table")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8294 >
2021-01-04 17:32:31 +00:00
Mauro Rossi
e53bf25ea4
android: pan/bi: Remove NIR->old IR
...
Fixes the following building error:
clang: error: no such file or directory: 'external/mesa/src/panfrost/bifrost/bi_special.c'
clang: error: no input files
Fixes: e5ec0dc183 ("pan/bi: Remove NIR->old IR")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8294 >
2021-01-04 17:32:31 +00:00
Mauro Rossi
c77c2cf809
android: pan/bi: Remove old IR packs
...
Necessary for Android build after commit a1e150fc4d
Fixes: a1e150fc4d ("pan/bi: Remove old IR packs")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8294 >
2021-01-04 17:32:31 +00:00
Mauro Rossi
084cb25d41
android: pan/bi: Remove combine lowering
...
Fixes the following building error:
clang: error: no such file or directory: 'external/mesa/src/panfrost/bifrost/bi_lower_combine.c'
clang: error: no input files
Fixes: 8b0d0a931b ("pan/bi: Remove combine lowering")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8294 >
2021-01-04 17:32:31 +00:00
Mauro Rossi
95af4994e5
android: pan/bi: Generate instruction packer for new IR
...
Necessary for Android build after commit 82328a5245
Fixes: 82328a5245 ("pan/bi: Generate instruction packer for new IR")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8294 >
2021-01-04 17:32:31 +00:00
Mauro Rossi
6a2ae4e35c
android: pan/bi: Generate builder routines
...
Fixes the following building error:
external/mesa/src/panfrost/bifrost/bifrost_compile.c:38:10: fatal error: 'bi_builder.h' file not found
^~~~~~~~~~~~~~
1 error generated.
Fixes: 8ef0d41170 ("pan/bi: Generate builder routines")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8294 >
2021-01-04 17:32:31 +00:00
Mauro Rossi
0fb8223f29
android: pan/bi: Generate instruction printer
...
To avoid building errors in Android
Fixes: 1893a3805e ("pan/bi: Generate instruction printer")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8294 >
2021-01-04 17:32:31 +00:00
Samuel Pitoiset
3ae1c6a4fb
radv: disable A2 SNORM/SSCALED/SINT for texel buffers & images on all gens
...
AMDVLK and AMDGPU-PRO also don't support these formats for texel
buffers and images.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3386
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8315 >
2021-01-04 17:19:41 +00:00
Rhys Perry
b2d000513e
aco: fix incorrect address calculation for load_barycentric_at_sample
...
Fix address calculation for indirect load_barycentric_at_sample on GFX6-8
with a uniform sample index.
A non-zero uniform sample index does not seem to be tested by CTS.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Gitlab: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3966
Fixes: 93c8ebfa78 ("aco: Initial commit of independent AMD compiler")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8302 >
2021-01-04 16:53:29 +00:00
Alyssa Rosenzweig
b32834e5f7
pan/bi: Fix TEXS register counts
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Fixes: cffc1d90da ("pan/bi: Add staging register counts to ISA.xml")
Reported-by: Icecream95
Tested-by: macc24
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8310 >
2021-01-04 16:41:55 +00:00
Boris Brezillon
20f7a73a2c
panfrost: Allow 3D AFBC on Bifrost v7
...
This feature doesn't seem to work properly on Midgard, and is flagged
as unsupported on Bifrost v6.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8125 >
2021-01-04 17:05:42 +01:00