Rob Clark
c9fe3e189b
freedreno/registers: Deprecate non-variant reg builders
...
For registers with variants, mark the legacy (non-variant) builders as
deprecated to help avoid using the wrong one.
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30452 >
2024-08-10 16:25:30 +00:00
Rob Clark
75e0290e42
tu: Use CHIP variant reg builders
...
Avoid using the non-variant builders for regs that differ btwn
generations. This will become deprecated.
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30452 >
2024-08-10 16:25:30 +00:00
Rob Clark
47468554d9
tu: Add helper to calculate layer address
...
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30452 >
2024-08-10 16:25:30 +00:00
Rob Clark
9f433a32cc
freedreno/computerator: Use CHIP variant reg builders
...
Avoid using the non-variant builders for regs that differ btwn
generations. This will become deprecated.
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30452 >
2024-08-10 16:25:30 +00:00
Alyssa Rosenzweig
16cadc04f3
nir/opt_reassociate_bfi: use alu_pass
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30582 >
2024-08-10 13:40:21 +00:00
Alyssa Rosenzweig
2643b3cfbf
nir/lower_packing: use alu_pass
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30582 >
2024-08-10 13:40:21 +00:00
Alyssa Rosenzweig
6e39379183
nir/opt_idiv_const: use alu_pass
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30582 >
2024-08-10 13:40:21 +00:00
Alyssa Rosenzweig
b6daa35d9d
nir/scale_fdiv: use alu_pass
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30582 >
2024-08-10 13:40:21 +00:00
Alyssa Rosenzweig
d2780d871b
nir/lower_alu: use alu_pass
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30582 >
2024-08-10 13:40:21 +00:00
Alyssa Rosenzweig
9b07550908
treewide: use nir_shader_alu_pass
...
@def@
typedef bool;
typedef nir_builder;
typedef nir_instr;
typedef nir_def;
identifier fn, instr, intr, x, builder, data;
@@
static fn(nir_builder* builder,
-nir_instr *instr,
+nir_alu_instr *intr,
...)
{
(
- if (instr->type != nir_instr_type_alu)
- return false;
- nir_alu_instr *intr = nir_instr_as_alu(instr);
|
- nir_alu_instr *intr = nir_instr_as_alu(instr);
- if (instr->type != nir_instr_type_alu)
- return false;
)
<...
(
-instr->x
+intr->instr.x
|
-instr
+&intr->instr
)
...>
}
@pass depends on def@
identifier def.fn;
expression shader, progress;
@@
(
-nir_shader_instructions_pass(shader, fn,
+nir_shader_alu_pass(shader, fn,
...)
|
-NIR_PASS_V(shader, nir_shader_instructions_pass, fn,
+NIR_PASS_V(shader, nir_shader_alu_pass, fn,
...)
|
-NIR_PASS(progress, shader, nir_shader_instructions_pass, fn,
+NIR_PASS(progress, shader, nir_shader_alu_pass, fn,
...)
)
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30582 >
2024-08-10 13:40:21 +00:00
Alyssa Rosenzweig
cc1f092b62
nir: add nir_shader_alu_pass
...
after the smashing success of nir_shader_intrinsics_pass, let's add the ALU
version to help the odd non-algebraic ALU lowering pass.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30582 >
2024-08-10 13:40:21 +00:00
Collabora's Gfx CI Team
d330870f9c
Uprev Piglit to f11abb664bfcad09586f32f411b90331e23be2e5
...
0453436872...f11abb664b
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30597 >
2024-08-10 07:39:41 +00:00
David Heidelberg
d0420c0990
ci/alpine: libclc on Alpine offering necessary targets spirv-mesa3d-;spirv64-mesa3d-
...
No need for any Debian specific hacks.
Reviewed-by: Eric Engestrom <eric@igalia.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30482 >
2024-08-10 15:13:33 +09:00
David Heidelberg
6d09671b67
ci/alpine: enable ORCJIT
...
Recommended for LLVM 18+, let's test it on Alpine builds.
Reviewed-by: Eric Engestrom <eric@igalia.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30482 >
2024-08-10 15:13:33 +09:00
David Heidelberg
9cec4aec09
ci/alpine: use packaged spirv-llvm-translator-dev
...
Reviewed-by: Eric Engestrom <eric@igalia.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30482 >
2024-08-10 15:13:33 +09:00
David Heidelberg
09f8df82c8
ci/alpine: build test with LLVM 18
...
Reviewed-by: Eric Engestrom <eric@igalia.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30482 >
2024-08-10 15:13:33 +09:00
David Heidelberg
34753cefd8
ci/alpine: use llvm variables
...
Fixes: da391650f5 ("ci: build a host version of mesa for cross builds")
Reviewed-by: Eric Engestrom <eric@igalia.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30482 >
2024-08-10 15:13:33 +09:00
David Heidelberg
bda1a0596e
meson/addrlib: allow unintialized callbacks
...
Resolves:
[328/4125] Compiling C++ object src/amd/addrlib/libaddrlib.a.p/src_core_addrlib1.cpp.o
In static member function 'static VOID Addr::Object::ClientFree(VOID*, const Addr::Client*)',
inlined from 'static VOID Addr::Object::operator delete(VOID*)' at ../src/amd/addrlib/src/core/addrobject.cpp:190:15,
inlined from 'virtual Addr::Object::~Object()' at ../src/amd/addrlib/src/core/addrobject.cpp:71:1:
../src/amd/addrlib/src/core/addrobject.cpp:129:28: error: '*(const Addr::Client*)((char*)this + 8).Addr::Client::callbacks._ADDR_CALLBACKS::freeSysMem' is used uninitialized [-Werror=uninitialized]
129 | if (pClient->callbacks.freeSysMem != NULL)
| ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11634
Suggested-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30482 >
2024-08-10 15:13:33 +09:00
David Heidelberg
9c8e75e256
llvmpipe: Silence "possibly uninitialized value" warning for ssbo_limit (cont)
...
Fixes: ce611935df ("llvmpipe: Silence "possibly uninitialized value" warning for ssbo_limit.")
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30482 >
2024-08-10 15:13:32 +09:00
Marek Olšák
07554d32db
ac/nir: adjust gfx11 tuning for the compute blit
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30208 >
2024-08-10 02:14:44 +00:00
Marek Olšák
db7823e8b9
ac/nir: adjust performance-related decisions for clear/copy_buffer shader
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30208 >
2024-08-10 02:14:44 +00:00
Marek Olšák
361266fec7
ac/nir: import the clear/copy_buffer compute shader from radeonsi
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30208 >
2024-08-10 02:14:44 +00:00
Marek Olšák
e41fec7812
radeonsi: align waves to 256B clear/copy area for the clear/copy_buffer shader
...
This is about 10% faster in certain unaligned cases.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30208 >
2024-08-10 02:14:44 +00:00
Marek Olšák
2f9201e91b
radeonsi: implement optimized unaligned clear/copy_buffer compute shader
...
This totally beats CP DMA on Navi31.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30208 >
2024-08-10 02:14:44 +00:00
Marek Olšák
fa85b4b49e
radeonsi: minor changes at the beginning of si_compute_clear_copy_buffer
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30208 >
2024-08-10 02:14:44 +00:00
Marek Olšák
4d78052321
radeonsi: add correctness tests for the clear/copy_buffer compute shader
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30208 >
2024-08-10 02:14:44 +00:00
Marek Olšák
a48a376bc5
radeonsi: test more alignment cases in si_test_dma_perf
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30208 >
2024-08-10 02:14:44 +00:00
Marek Olšák
fa53a23031
radeonsi: reject insert/extract opcodes in si_vectorize_callback
...
The vector variants are not implemented by ac_nir_to_llvm.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30208 >
2024-08-10 02:14:44 +00:00
Marek Olšák
d34a450098
util: move util_lower_clearsize_to_dword here
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30208 >
2024-08-10 02:14:44 +00:00
Marek Olšák
1d66acf993
nir: add ACCESS_KEEP_SCALAR, preventing vectorization
...
The comment explains the reason.
Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30208 >
2024-08-10 02:14:44 +00:00
Faith Ekstrand
3f1c3f04be
nvk: Advertise VK_EXT_descriptor_buffer
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
0f8f407e57
zink: Align descriptor buffers to descriptorBufferOffsetAlignment
...
Instead of aligning offsets, we just align the size every time we query
it. This simplifies our offset and size calculations later since we can
always just add up descriptor buffer sizes and know that we'll be okay.
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Fixes: 7ab5c5d36d ("zink: use EXT_descriptor_buffer with ZINK_DESCRIPTORS=db")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
fdf580bf74
nvk: Add support for embedded immutable samplers
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
832f67e187
nvk: Implement descriptor buffer binding
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
b6c862bed7
nvk: Rework descriptor set bindings
...
This switches from struct-of-array to array-of-struct and also addes a
new nvk_descriptor_set_type enum to make it more clear exactly what, if
anything, is bound at any give time.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
6c54344f5b
nvk: Properly indent a comment
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
f7638ff1dc
nvk: Implement descriptor capture/replay
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
ef9d9b70a6
nvk/descriptor_table: Add support for requesting a specific index
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
77db71db7d
nvk: Implement GetDescriptorEXT
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
237c5d505a
nvk: Refactor some descriptor set helpers
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
ad9a13a163
nvk: Implement GetDescriptorLayoutSize/BindingOffsetEXT()
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
fc0f0725a4
nvk: Use the EDB buffer view path with NVK_DEBUG=edb_bview
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
677f40383d
nvk: Use nvk_edb_buffer_view_descriptor for EDB descriptor set layouts
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
3b94c5c22a
nvk: Lower descriptors for VK_EXT_descriptor_buffer buffer views
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
8cafd2667f
nvk: Refactor image intrinsic lowering a bit
...
This makes lower_msaa_image_intrin do all of the lowering for MSAA
images. It's a tiny bit of duplicated code but it'll make more sense
when we work buffer views in the next commit.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
93b30bb353
nvk: Add a VK_EXT_descriptor_buffer buffer view cache
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
0f65011157
nvk/nvkmd: Advertise the usable VA range
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
6db3609eaf
nvk: s/device/dev/ in nvk_buffer_view.c
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
1940c8e543
nvk: Move descrptor structs into a separate header
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00
Faith Ekstrand
8244b87822
nvk: Support STORAGE_READ_WITHOUT_FORMAT on buffers
...
Fixes: fc19173014 ("nvk: Rework format features queries")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30580 >
2024-08-10 00:42:59 +00:00