fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 02:28:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
124416 commits 66 branches 934 tags 954 MiB
Commit graph

124416 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jason Ekstrand
a7c8811fe4 intel/vec4: Stomp the return type of RESINFO to UINT32 
We already do this in the FS back-end; we just weren't doing it in vec4
so RESINFO messages weren't returning the right data.

Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5243>
 2020-05-30 01:08:50 -05:00
Timothy Arceri
e843303d6f radv: fix regression with builtin cache 
If the ~/.cache dir already exists continue on without failing.

Fixes: cd61f5234d ("radv: Handle failing to create .cache dir.")

Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5249>
 2020-05-30 04:01:28 +00:00
Bas Nieuwenhuizen
7e4c8949c6 gallium/dri: Remove lowered_yuv tracking for plane mapping. 
Just heard that etnaviv is also compatible with it even
in the non-lowered cases, so let us enable it for everyone.

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5253>
 2020-05-30 02:49:54 +00:00
Vinson Lee
13735c4f47 panfrost: Fix printf format specifier. 
bifrost_sampler_descriptor.zero1 is of type uint8_t.

Fix warning reported by Coverity.

Invalid type in argument to printf format specifier (PRINTF_ARGS)
invalid_type: Argument s->zero1 to format specifier %lx was expected to
have type unsigned long but has type unsigned char.

Fixes: 6148d1be4b ("panfrost: Fix size of bifrost sampler descriptor")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5248>
 2020-05-30 02:10:12 +00:00
Marek Olšák
4925fb97f6 glthread: don't upload for glDraw inside a display list and always sync 
Let the vbo module handle it, not glthread.

This handles functions set in vbo_initialize_save_dispatch.

Fixes: 2840bc3065 ("glthread: upload non-VBO vertices and indices for non-Indirect non-IBM draws")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3001

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5246>
 2020-05-30 01:42:56 +00:00
Bas Nieuwenhuizen
cf99267147 util/format: Add more multi-planar formats. 
These don't have a fourcc code as far as I can tell, but we want
them for internal Vulkan use.

Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5195>
 2020-05-30 01:22:51 +00:00
Bas Nieuwenhuizen
d491b0dfd9 util/format: Use correct pipe format for VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM. 
NV12 is UVUVUV (https://wiki.videolan.org/YUV#NV12) and in Vulkan is
VK_FORMAT_G8_B8R8_2PLANE_420_UNORM. So U=B and V=R. So plane order in
VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM is YUV, which is PIPE_FORMAT_IYUV.

Further confirmation: https://fourcc.org/yuv.php U=Cb V=Cr. From the nir
ycbcr conversion, B=Cb and R=Cr.

Fixes: 75d7ee8029 "util/format: translate 422_UNORM and 420_UNORM vulkan formats"
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5195>
 2020-05-30 01:22:51 +00:00
Bas Nieuwenhuizen
273ead81f1 util/format: Add VK_FORMAT_D16_UNORM_S8_UINT. 
Not participating in packing/unpacking/stencil-only/depth-only,
because it doesn't mix well in a single plane.

Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5195>
 2020-05-30 01:22:51 +00:00
Vinson Lee
f047d585ee etnaviv: Fix memory leak on error path. 
Fix warning reported by Coverity Scan.

Resource leak (RESOURCE_LEAK)
leaked_storage: Variable pq going out of scope leaks the storage it
points to.

Suggested-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Fixes: eed5a00989 ("etnaviv: convert perfmon queries to acc queries")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5220>
 2020-05-30 01:04:30 +00:00
Alyssa Rosenzweig
bccb3deee2 panfrost: Probe G31/G52 if PAN_MESA_DEBUG=bifrost 
We're not *quite* ready to open the flood gates on Bifrost (a major
blocker is CI, which is itself blocked on the lockdowns - expected to be
resolved in the coming months..)

Nevertheless, let's add a debug option to probe on compatible Bifrost
devices to avoid keeping out-of-tree patches around.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5272>
 2020-05-29 19:24:45 -04:00
Alyssa Rosenzweig
be8cbe0b41 panfrost: Add GPU IDs for G31/G52 
Dvalin/Gondul respectively.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5272>
 2020-05-29 19:24:05 -04:00
Alyssa Rosenzweig
229084f5de panfrost: Disable QUAD_STRIP/POLYGON on Bifrost 
Support was dropped and now raises a DATA_INVALID_FAULT on G31. Unknown
if retained on other devices. GL_QUADS is still ok.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:56 +00:00
Alyssa Rosenzweig
4be2cd604b pan/bi: Passthrough deps of the branch target 
Now that we have the infrastructure, follow the branch.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:56 +00:00
Alyssa Rosenzweig
8230a04f51 pan/bi: Allow two successors in header packing 
We need to take the union of the dependencies.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:56 +00:00
Alyssa Rosenzweig
db2c10d032 pan/bi: Measure backwards branches as well 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:56 +00:00
Alyssa Rosenzweig
a42731536d pan/bi: Add bi_foreach_block_from_rev helper 
Needed for next commit.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
c697992ca1 pan/bi: Defer block naming until after emit 
This ensures names are meaningful.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
bd6ff4f7e1 pan/bi: Pack unconditional branch 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
e4791d2bf8 pan/bi: Set branch conditional bit 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
ffe7a61a46 pan/bi: Set back-to-back bit more accurately 
See Connor's ISA notes. Basically set unless it's a branch (explicit or
fallthrough).

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
3aacfaf87e pan/bi: Set branch_conditional if b2b is set 
Match the blob.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
e945d4f79d pan/bi: Pack proper clause offsets 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
682b63cdc2 pan/bi: Measure distance between blocks 
For branch offset calculation.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
64c49ab1fc pan/bi: Add bi_foreach_clause_in_block_from{_rev} helpers 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
64bedbfa67 pan/bi: Link clauses back to their blocks 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
9c32956750 pan/bi: Preliminary branch packing 
Simple == 0 branch packing. Offset is still to-do.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
cd9a08d4f2 pan/bi: Assign constant port for branch offsets 
By convention.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
cdff3ebc9a pan/bi: Set branch_constant if there is a branch 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
b9967ab6da pan/bi: Pack branch offset constants 
This is not fully generic but for a single constant it will do.
Extensions left for future work.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
627872ef7f pan/bi: Add branch constant field to IR 
The offsets used for branches need some extra bits twiddled, so add a
field to the clause to indicate this is happening. This is not ambiguous
since a clause can only have a single branch.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
f1298ae336 pan/bi: Passthrough ZERO in branch packing 
There's a special mode for it.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
d619ff009b pan/bi: Fix branch condition typesize 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
1cdd55a81e pan/bi: Fix CONVERT component counting 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
d8c6a71878 pan/bi: Only rewrite COMBINE dest if not SSA 
If it's already a register, there's no point in rewriting and it will
disturb the existing register, i.e. for

   if (..) {
      r0 = vecN ..
   } else {
      r0 = vecN ..
   }

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
e42a5dfd4f pan/bi: Fix emit_if successor assignment 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Fixes: 9a00cf3d1e ("pan/bi: Add support for if-else blocks")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
b34eb94d9c pan/bi: Allow printing branches without targets 
Useful for debugging codegen.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
a4fc16a1d4 pan/bi: Remove schedule_barrier 
Legacy from Midgard.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
b3ae088b96 pan/bi: Add helper to measure clause size 
Useful for branching.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
2a4e4477fc pan/bi: Add bi_layout.c for clause layout helpers 
Figuring out what "shapes" of clauses are kosher happens during
scheduling, not packing, but shouldn't distract the scheduler. So let's
add a new file for these sorts of questions.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
c3de28bb49 pan/bi: Remove more artefacts of 2-pass scheduling 
A clause is, by definition, already scheduled.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
4096be05af pan/bi: Add MUL.i32 to disasm 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
ec8665615f pan/bi: Disassemble pos=0xe 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
a658a4f7a5 pan/bi: Document constant count invariant 
constants + instructions <= 13

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
ac64bf9b20 pan/bi: Move bi_flip_ports out of port assignment 
It's more of a packing fixup than anything scheduler-y, and port
assignment will soon be the domain of the scheduler.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
95e3776d3e pan/bi: Add FILE* argument to bi_print_registers 
In case we need it in general IR printing.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
dd96b451f6 pan/bi: Drop struct from bi_registers 
It's a full-fledged part of the IR now.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
b042ddef32 pan/bi: Move bi_registers to bi_bundle 
Make it a part of the IR itself.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
79f30d8a86 pan/bi: Move bi_registers to common IR structures 
Port assignments are critical to scheduling, this can't just live in
bi_pack.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
59f8f20306 pan/bi: Remove comment about old scheduler design 
I've realized it really has to be 1-pass to be sane.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00
Alyssa Rosenzweig
635bf652ed pan/bi: Remove FMA? parameter from get_src 
We can lower away zeroes a bit earlier.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
 2020-05-29 20:34:55 +00:00