fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 09:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

v3d: assert if v3d_compile returns NULL

Browse source 
Ideally we would like to trigger a compilation error like we do on
v3dv (VK_ERROR_UNKNOWN). But with v3d we can't really do that, as this
could happen on a draw call. Let's at least assert so debug builds
stops at this point.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23203>
This commit is contained in:
Alejandro Piñeiro 2023-05-24 10:43:55 +02:00 • committed by Marge Bot
parent 470b8567a5
commit b6d874ade2
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/gallium/drivers/v3d/v3d_program.c
View file

@ -407,6 +407,14 @@ v3d_get_compiled_shader(struct v3d_context *v3d,
v3d_shader_debug_output,
v3d,
program_id, variant_id, &shader_size);
/* qpu_insts being NULL can happen if the register allocation
* failed. At this point we can't really trigger an OpenGL API
* error, as the final compilation could happen on the draw
* call. So let's at least assert, so debug builds finish at
* this point.
*/
assert(qpu_insts);
ralloc_steal(shader, shader->prog_data.base);
if (shader_size) {