fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-14 13:40:26 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
26291 commits 495 branches 611 tags 238 MiB
Commit graph

26291 commits

This branch
This branch
All branches
Author SHA1 Message Date
Beniamino Galvani
338690eec5 initrd: merge branch 'bg/initrd-mac-iface' 
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/632

(cherry picked from commit 613f74b545)
 2020-09-24 10:58:01 +02:00
Beniamino Galvani
09804cac6e initrd: fix parsing IPv6 prefix length 
The generator didn't accept prefix lengths > 32 for IPv6:

$ src/initrd/nm-initrd-generator --stdout -- ip=[fd01::1]:::40::ens0
 <warn>  [1600851580.7875] cmdline-reader: Invalid IP mask: 40

https://bugzilla.redhat.com/show_bug.cgi?id=1879795
(cherry picked from commit 364c7c278a)
 2020-09-24 10:58:01 +02:00
Beniamino Galvani
eeef91aa6e initrd: accept mac address as interface specifier 
The interface can be specified either by name or MAC address:

ip=192.0.2.2:::::eth0
ip=192.0.2.2:::::00-11-22-33-44-55

https://bugzilla.redhat.com/show_bug.cgi?id=1879795
(cherry picked from commit f223644291)
 2020-09-24 10:58:01 +02:00
Thomas Haller
2d8c6343e0
core: fix D-Bus type for "org.freedesktop.NetworkManager.Capabilities" property 
Fixes: 297d4985ab ('core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API')
(cherry picked from commit 51b7d351fa)
 2020-09-18 15:31:20 +02:00
Thomas Haller
ed9f63724a
supplicant: fix crash in _scan_notify_allowed() when supplicant disconnects 
When stopping wpa_supplicant, I got an assertion failure:

  #0  g_logv (log_domain=0x55f8e4a43013 "NetworkManager", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=<optimized out>) at ../glib/gmessages.c:1377
  #1  0x00007f2d33245233 in g_log (log_domain=log_domain@entry=0x55f8e4a43013 "NetworkManager", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x7f2d332976ff "%s: assertion '%s' failed") at ../glib/gmessages.c:1415
  #2  0x00007f2d33245a2d in g_return_if_fail_warning (log_domain=log_domain@entry=0x55f8e4a43013 "NetworkManager", pretty_function=pretty_function@entry=0x55f8e4acc1e0 <__func__.14> "nm_supplicant_interface_get_state", expression=expression@entry=0x55f8e4acb450 "NM_IS_SUPPLICANT_INTERFACE (self)") at ../glib/gmessages.c:2771
  #3  0x000055f8e49ab3f2 in nm_supplicant_interface_get_state (self=0x0) at src/supplicant/nm-supplicant-interface.c:2581
  #4  0x00007f2d1f7307a4 in _scan_notify_allowed (self=self@entry=0x55f8e5199cf0 [NMDeviceWifi], do_kickoff=do_kickoff@entry=NM_TERNARY_FALSE) at src/devices/wifi/nm-device-wifi.c:514
  #5  0x00007f2d1f730ed3 in supplicant_iface_state (self=0x55f8e5199cf0 [NMDeviceWifi], new_state=<optimized out>, old_state=NM_SUPPLICANT_INTERFACE_STATE_COMPLETED, disconnect_reason=<optimized out>, is_real_signal=<optimized out>) at src/devices/wifi/nm-device-wifi.c:2492
  #6  0x00007f2d32339af0 in ffi_call_unix64 () at ../src/x86/unix64.S:76
  #7  0x00007f2d323392ab in ffi_call (cif=cif@entry=0x7ffcaf6c3120, fn=fn@entry=0x7f2d1f731920 <supplicant_iface_state_cb>, rvalue=<optimized out>, avalue=avalue@entry=0x7ffcaf6c3050) at ../src/x86/ffi64.c:525
  #12 0x00007f2d3334ac63 in <emit signal ??? on instance 0x55f8e4f49bb0 [NMSupplicantInterface]> (instance=instance@entry=0x55f8e4f49bb0, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3554
      #8  0x00007f2d3333238d in g_cclosure_marshal_generic (closure=closure@entry=0x55f8e521eb10, return_gvalue=return_gvalue@entry=0x0, n_param_values=n_param_values@entry=4, param_values=param_values@entry=0x7ffcaf6c3320, invocation_hint=invocation_hint@entry=0x7ffcaf6c32a0, marshal_data=marshal_data@entry=0x0) at ../gobject/gclosure.c:1500
      #9  0x00007f2d3333188a in g_closure_invoke (closure=0x55f8e521eb10, return_value=return_value@entry=0x0, n_param_values=4, param_values=param_values@entry=0x7ffcaf6c3320, invocation_hint=invocation_hint@entry=0x7ffcaf6c32a0) at ../gobject/gclosure.c:810
      #10 0x00007f2d33344423 in signal_emit_unlocked_R (node=node@entry=0x7f2d200066c0, detail=detail@entry=0, instance=instance@entry=0x55f8e4f49bb0, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffcaf6c3320) at ../gobject/gsignal.c:3742
      #11 0x00007f2d3334aaf9 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffcaf6c34f0) at ../gobject/gsignal.c:3498
  #13 0x000055f8e49a880b in _emit_signal_state (disconnect_reason=0, old_state=NM_SUPPLICANT_INTERFACE_STATE_COMPLETED, new_state=<optimized out>, self=0x55f8e4f49bb0 [NMSupplicantInterface]) at src/supplicant/nm-supplicant-interface.c:1083
  #14 set_state_down (self=0x55f8e4f49bb0 [NMSupplicantInterface], force_remove_from_supplicant=0, reason=0x55f8e4acd918 "InterfaceRemoved signal from wpa_supplicant") at src/supplicant/nm-supplicant-interface.c:1083
  #15 0x000055f8e49acb0b in _supp_iface_remove_one (self=0x55f8e51990c0 [NMSupplicantManager], supp_iface=0x55f8e4f49bb0 [NMSupplicantInterface], force_remove_from_supplicant=0, reason=0x55f8e4acd918 "InterfaceRemoved signal from wpa_supplicant") at src/supplicant/nm-supplicant-manager.c:1067
  #16 0x000055f8e49accec in _dbus_interface_removed_cb (connection=<optimized out>, sender_name=0x7f2d20038f20 ":1.4741", object_path=<optimized out>, signal_interface_name=<optimized out>, signal_name=<optimized out>, parameters=<optimized out>, user_data=0x55f8e51990c0) at src/supplicant/nm-supplicant-manager.c:902
  #17 0x00007f2d33483c0f in emit_signal_instance_in_idle_cb (data=data@entry=0x7f2d20034750) at ../gio/gdbusconnection.c:3777
  #18 0x00007f2d3323945b in g_idle_dispatch (source=source@entry=0x7f2d20038db0, callback=0x7f2d33483b90 <emit_signal_instance_in_idle_cb>, user_data=0x7f2d20034750) at ../glib/gmain.c:5755
  #19 0x00007f2d3323d78f in g_main_dispatch (context=0x55f8e4ee31e0) at ../glib/gmain.c:3309
  #20 g_main_context_dispatch (context=0x55f8e4ee31e0) at ../glib/gmain.c:3974
  #21 0x00007f2d3323db18 in g_main_context_iterate (context=0x55f8e4ee31e0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4047
  #22 0x00007f2d3323de33 in g_main_loop_run (loop=0x55f8e4ec4d20) at ../glib/gmain.c:4241
  #23 0x000055f8e4755a3b in main (argc=<optimized out>, argv=<optimized out>) at src/main.c:456

Fixes: 7500e90b53 ('wifi: rework scanning of Wi-Fi device')
(cherry picked from commit 026389fc1f)
 2020-09-18 15:31:20 +02:00
Thomas Haller
fb2788952c
bond: merge branch 'th/bond-options-reapply-fix' (part 1) 
https://bugzilla.redhat.com/show_bug.cgi?id=1876577

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/622

(cherry picked from commit 75ff7a6daf)
 2020-09-10 22:17:46 +02:00
Thomas Haller
7ff222c051
tui: allow configuring "primary" bond option with "balance-{alb,tlb}" 
(cherry picked from commit b5041c14f4)
 2020-09-10 22:17:05 +02:00
Thomas Haller
2d4e604007
libnm: allow setting "primary" option with modes "tlb" and "alb" 
(cherry picked from commit cb3a73af92)
 2020-09-10 22:17:01 +02:00
Thomas Haller
97f7d4f64f
device: inline check_changed_options() in can_reapply_change() 
Code doesn't get simpler by having more functions -- if these functions
are only called once.

What actually is a problem is repeated, redundant code. Like the list of
bond options that can be reapplied. But the function didn't help to
avoid repeating the list.

(cherry picked from commit f807b68376)
 2020-09-10 22:16:57 +02:00
Thomas Haller
7030cd2c8b
device: unify setting of bond options 
Add a macro for the list of bond options we are going to set. By seeing
them side-by-side, it is hopefully simpler to see that all options are
specified correctly.

We see that:

- the *_SUBSET defines don't include the options that we are explicitly
  setting, that is "mode", "active_slave" and "arp_ip_target".

- OPTIONS_REAPPLY_SUBSET contains 4 options less than OPTIONS_APPLY_SUBSET:
  "ad_select", "ad_user_port_key", "lacp_rate" and "tlb_dynamic_lb".
  These are the options that are marked as BOND_OPTFLAG_IFDOWN in
  kernel.

(cherry picked from commit 5402943420)
 2020-09-10 22:16:45 +02:00
Thomas Haller
a0ae53c8bb
device: remove duplicate option "primary" from list to reapply 
(cherry picked from commit 0ea73cdcec)
 2020-09-10 22:16:36 +02:00
Thomas Haller
4c83321286
device: allow "active_slave" and "arp_ip_target" bond option for reapply 
I guess the idea was to only accept options that can be changed without
taking the interface !IFF_UP. "active_slave" is wrongly omitted from
that list.

Also, "active_slave" option doesn't really make sense for NetworkManager
to configure. Instead "primary" should be used. In the future, we should
re-map the properties and deprecate "active_slave" for "primary" ([1]).

Fixes: 746dc119a6 ('bond: let 'reapply()' reapply all supported options')

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1856640#c19

https://bugzilla.redhat.com/show_bug.cgi?id=1876577
(cherry picked from commit 2eea22ae95)
 2020-09-10 22:16:22 +02:00
Thomas Haller
882a79adf2
shared: extend NM_IN_SET()/NM_IN_STRSET() macros to support up to 30 arguments 
(cherry picked from commit 0f4221da42)
 2020-09-10 22:15:01 +02:00
Beniamino Galvani
0adfcadc9d device: fix wrongly considering ipv6.may-fail for ipv4 
Fixes: 5e71f01605 ('device: merge stage3 and stage4 ip-config function for IPv4 and IPv6')
(cherry picked from commit a017936223)
 2020-09-09 11:15:46 +02:00
Valentin David
7d26773138
build/docs: fix generated XML syntax in tools/generate-docs-nm-settings-docs-gir.py 
Class description may contains double quotes which is not valid as XML
attribute value.

[thaller@redhat.com: adjust original patch to reformat code with python black]

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/620
(cherry picked from commit 54e25f23f5)
 2020-09-08 17:36:27 +02:00
Thomas Haller
561bd7bba6
tests: ignore valgrind warning about unhandled syscalls 
On Fedora rawhide (34), valgrind gives a lot of warnings like:

    ./src/platform/tests/test-cleanup-linux.valgrind-log:--48279-- WARNING: unhandled amd64-linux syscall: 439
    ./src/platform/tests/test-cleanup-linux.valgrind-log:--48279-- You may be able to write your own handler.
    ./src/platform/tests/test-cleanup-linux.valgrind-log:--48279-- Read the file README_MISSING_SYSCALL_OR_IOCTL.
    ./src/platform/tests/test-cleanup-linux.valgrind-log:--48279-- Nevertheless we consider this a bug.  Please report
    ./src/platform/tests/test-cleanup-linux.valgrind-log:--48279-- it at http://valgrind.org/support/bug_reports.html.

Ignore them.

(cherry picked from commit 2cb40f6e36)
 2020-09-08 13:05:55 +02:00
Thomas Haller
74a5be64b8
po: merge branch 'th/po-fix-fr-ja-zh_CN' 
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/526

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/619

(cherry picked from commit a39e1ab16e)
 2020-09-08 13:05:54 +02:00
Thomas Haller
9b5ef3aaea
build: fix test for valid po files (msgfmt -vc) 
Otherwise, the test generates an "messages.mo" file.

Fixes: 97c1bed37e ('build: add test for valid po files (msgfmt -vc)')
(cherry picked from commit ad55cf86e8)
 2020-09-08 13:05:54 +02:00
Thomas Haller
a26ea9a634
build: add test for valid po files (msgfmt -vc) 
(cherry picked from commit 97c1bed37e)
 2020-09-08 13:05:54 +02:00
Thomas Haller
51c68c06b6
gitlab-ci: add test for checking po files 
(cherry picked from commit a4f99bab1d)
 2020-09-08 13:05:53 +02:00
Thomas Haller
7c6454269b
po: disable invalid translations from po/ko.po 
Mark invalid translations as fuzzy and run `make -C po update-po`
to cleanup the po file.
 2020-09-08 13:05:49 +02:00
Thomas Haller
3f29e17507
po: remove invalid translations from po/{fr,ja,zh_CN}.po 
And `make -C po update-po` to regenerate the default.

(cherry picked from commit 60b2e7452f)
 2020-09-08 12:54:38 +02:00
Thomas Haller
54dcfeffa0
po: make update-po 
(cherry picked from commit 9ee13a5656)
 2020-09-08 12:54:02 +02:00
Thomas Haller
5bea8db7ca
initrd/tests: fix memleak in test_dhcp_vendor_class_id() 
Having leaks in the tests, breaks running the test under valgrind. There
must be no leaks.

Fixes: c056cb9306 ('initrd: parse 'rd.net.dhcp.vendor-class' kernel cmdline arg')
(cherry picked from commit bff23d15d4)
 2020-09-03 11:38:22 +02:00
Antonio Cardace
bba54613eb
initrd: fix memory leak 
Signed-off-by: Antonio Cardace <acardace@redhat.com>
Fixes: 9f9609555d ('initrd: add configuration generator')
(cherry picked from commit d5c05d07c7)
 2020-09-02 10:10:09 +02:00
Antonio Cardace
ad36890282
initrd: merge branch 'ac/dhcpclass-initrd' 
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/614

Signed-off-by: Antonio Cardace <acardace@redhat.com>

(cherry picked from commit 5748e986aa)
 2020-09-01 17:07:01 +02:00
Antonio Cardace
15856a4fa2
initrd: parse 'rd.net.dhcp.vendor-class' kernel cmdline arg 
This arguments makes NM set the ipv4.dhcp-vendor-class-identifier
property for all connections.

https://bugzilla.redhat.com/show_bug.cgi?id=1872299

Signed-off-by: Antonio Cardace <acardace@redhat.com>
(cherry picked from commit c056cb9306)
 2020-09-01 17:07:00 +02:00
Antonio Cardace
847488cb2f
core: add 'dhcp-vendor-class-identifier' validation function 
So that it can be reused.

Signed-off-by: Antonio Cardace <acardace@redhat.com>
(cherry picked from commit 5cca669ff3)
 2020-09-01 17:07:00 +02:00
Beniamino Galvani
dac89c0727 device: fix autoactivating virtual devices after a failure 
When a virtual device fails, its state goes to FAIL and then
DISCONNECTED. In DISCONNECTED we call schedule_activate_check() to
schedule an auto-activation if needed. We also schudule the deletion
of the link through delete_on_deactivate_check_and_schedule(). The
auto-activation attempt fails because the link deletion unmanages the
device; as a result, the device doesn't try to auto-activate again.

To fix this:

 - don't allow the device to auto-activate if the device deletion is
   pending;

 - check again if the device can be auto-activated after its deletion.

https://bugzilla.redhat.com/show_bug.cgi?id=1818697
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/613
(cherry picked from commit e404585e60)
 2020-08-31 11:48:35 +02:00
Thomas Haller
9f7736ea8e
gitlab-ci: fix workarounds for Ubuntu 16.04 in tests 
The detection for Ubuntu 16.04 was broken. By now /etc/os-release
contains

    VERSION="16.04.7 LTS (Xenial Xerus)"

(cherry picked from commit 12e8557476)
 2020-08-28 16:16:45 +02:00
Thomas Haller
32641b9fca
device: fix casting pointer to enum for sriov_reset_on_deactivate_cb() 
Avoids a compiler warning:

    ../src/devices/nm-device.c:16079:26: error: cast to smaller integer type 'NMDeviceStateReason' from 'gpointer' (aka 'void *') [-Werror,-Wvoid-pointer-to-enum-cast]
            deactivate_ready (self, (NMDeviceStateReason) reason);
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 121c58f0c4 ('core: set number of SR-IOV VFs asynchronously')
(cherry picked from commit 918ebd600a)
 2020-08-28 12:54:12 +02:00
Antonio Cardace
43774ec13a
dhcp: merge branch 'ac/dhcp_vendor_class_opt' 
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/610

(cherry picked from commit 21e6ed2852)
 2020-08-26 12:01:30 +02:00
Antonio Cardace
76820f04c7
dhcp: implement dhcp-vendor-class-identifier option for systemd's DHCP 
client

https://bugzilla.redhat.com/show_bug.cgi?id=1871042
Signed-off-by: Antonio Cardace <acardace@redhat.com>
(cherry picked from commit 5da0939a3f)
 2020-08-26 11:57:21 +02:00
Antonio Cardace
18ff5984f7
dhcp: implement dhcp-vendor-class-identifier option for internal DHCP client 
https://bugzilla.redhat.com/show_bug.cgi?id=1871042
Signed-off-by: Antonio Cardace <acardace@redhat.com>
(cherry picked from commit f8a7290153)
 2020-08-26 11:57:21 +02:00
Antonio Cardace
c7c5b88a83
core: add support for dhcpv4 vendor class identifier option 
https://bugzilla.redhat.com/show_bug.cgi?id=1871042
Signed-off-by: Antonio Cardace <acardace@redhat.com>
(cherry picked from commit f71f40bc20)
 2020-08-26 11:57:20 +02:00
Antonio Cardace
8b791c9837
ifcfg-rh: add support for the DHCP_VENDOR_CLASS_IDENTIFIER option 
https://bugzilla.redhat.com/show_bug.cgi?id=1871042
Signed-off-by: Antonio Cardace <acardace@redhat.com>
(cherry picked from commit e9ed5f02ba)
 2020-08-26 11:57:20 +02:00
Antonio Cardace
555f2bfc61
libnm-core,clients: add support for ipv4.dhcp-vendor-class-identifier option 
https://bugzilla.redhat.com/show_bug.cgi?id=1871042
Signed-off-by: Antonio Cardace <acardace@redhat.com>
(cherry picked from commit d7235394b2)
 2020-08-26 11:57:19 +02:00
Antonio Cardace
00132cecb5
version: add NM_VERSION_1_26_4/NM_AVAILABLE_IN_1_26_4 macros 
Signed-off-by: Antonio Cardace <acardace@redhat.com>
 2020-08-26 11:57:07 +02:00
Thomas Haller
5c6d996825
release: bump version to 1.26.3 (development) 2020-08-19 09:39:39 +02:00
Thomas Haller
c3c6c426df
release: bump version to 1.26.2 2020-08-19 09:39:39 +02:00
Thomas Haller
50761daae8
NEWS: update 
(cherry picked from commit 5409db9fbd)
 2020-08-19 09:36:01 +02:00
Thomas Haller
853ab22cf6
gitlab-ci: enable fedora:33 build and generate pages on F32 
(cherry picked from commit e1e1241aae)
 2020-08-18 23:49:02 +02:00
Thomas Haller
2845a28c6a
tools: minor cleanup to ensure "from_meson" variable is yet set from extern 
(cherry picked from commit 3b70efa9b6)
 2020-08-18 23:06:10 +02:00
Thomas Haller
ca19b12dc2
contrib/rpm: enable LTO by default on RHEL-9 and newer 
(cherry picked from commit 2c12786e3d)
 2020-08-18 23:05:18 +02:00
Thomas Haller
75e8f4c36f
ndisc/tests: relax assertion in "test-ndisc-fake.c" 
Still assertion failures:

  ERROR:../src/ndisc/tests/test-ndisc-fake.c:375:test_preference_changed_cb: assertion failed (_a->timestamp >= _ts): (9 >= 10)

(cherry picked from commit a5133e708e)
 2020-08-17 15:55:55 +02:00
Thomas Haller
60f92ca403
contrib/rpm: prefer keyfile settings plugin from Fedora 33 and newer 
This change is for Fedora 33 and newer. For now, also enable it for RHEL
9 and newer, but it must still be decided whether that will be done
there as well.

https://mail.gnome.org/archives/networkmanager-list/2020-May/msg00002.html
https://fedoraproject.org/wiki/Changes/NetworkManager_keyfile_instead_of_ifcfg_rh
https://lists.fedoraproject.org/archives/list/devel-announce@lists.fedoraproject.org/thread/OLOU27DAON2TYGTAVZ35GZE2BEIN42U3/
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/OLOU27DAON2TYGTAVZ35GZE2BEIN42U3/
https://pagure.io/fesco/issue/2432

https://bugzilla.redhat.com/show_bug.cgi?id=1857391
(cherry picked from commit 3e475e5cd1)
 2020-08-17 15:41:57 +02:00
Thomas Haller
53d15e95c1
scripts: use "/bin/cat" in NM-log 
Ubuntu 16.04 doesn't have merged /usr directories and cat is in
/bin/cat.

(cherry picked from commit 67cc4544f7)
 2020-08-17 15:41:32 +02:00
Thomas Haller
18171a3a33
build: merge branch 'th/fix-lto' 
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/605

(cherry picked from commit b8ac53905d)
 2020-08-17 15:40:06 +02:00
Thomas Haller
8fbf6aeced
contrib/rpm: enable LTO by default on Fedora 33 
With Fedora 33, LTO will be enabled by default via CFLAGS in
redhat-rpm-config ([1]).

That basically sets "CFLAGS=-flto -ffat-lto-objects".

Note that we have our own configure/meson option to enable LTO.
With "--with-lto" we set CFLAGS="-flto -flto-partition=none". This
is necessary due ([2], [3]).

So, disable Fedora's automatism, but turn on the suitable configure
option to get working LTO.

[1] 5baaf4a99c
[2] e6cf4213a7 ('build: fix building with LTO')
[3] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48200#c28

(cherry picked from commit 839ba57c7f)
 2020-08-17 15:40:06 +02:00
Thomas Haller
aabbd0e8de
build: disable "-Wstringop-overflow" warning with LTO enabled 
No amount of _Pragma was able to disable this warning.

    In function ‘strncpy’,
        inlined from ‘_nm_strndup_a_step’ at ./shared/nm-glib-aux/nm-macros-internal.h:1367:3,
        inlined from ‘nms_keyfile_nmmeta_check_filename’ at src/settings/plugins/keyfile/nms-keyfile-utils.c:61:0:
    /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
      106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
          |          ^
    src/settings/plugins/keyfile/nms-keyfile-utils.c: In function ‘nms_keyfile_nmmeta_check_filename’:
    src/settings/plugins/keyfile/nms-keyfile-utils.c:44: note: length computed here
       44 |  len = strlen (filename);
          |
    lto1: all warnings being treated as errors

Oddly enough, gcc is still emitting the warning even with "-Wno-stringop-overflow",
but at least it doesn't break the build.

(cherry picked from commit 407a1f1e98)
 2020-08-17 15:40:05 +02:00