ICWrap.c dereferences the xim parameter passed in from client code without a
NULL check. I have seen mplayer trigger this resulting in a segfault. In this
case mplayer had called XOpenIM and NULL was returned which was later passed
into XCreateIC.
Patch originally by Drew Moseley <drew_moseley@mentor.com>.
Signed-off-by: Ross Burton <ross.burton@intel.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Incorrect parameter usage with sizeof. Earlier passed argument FontData
will be 4 bytes always as its a pointer hence the change is needed and
FontDataRec should be used for memset.
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
False positive, if rlen/nbytes are unset we quit early before using it. Still,
initialize it so we don't have to deal with these warnings again.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
If we hit the depth limit, filename leaks. Move the depth check up before we
allocate filename.
Introduced in 226622349a.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Sorry, my patch to fix the spelling mistakes in the ks_IN and sd_IN
locales fixed it only partly, I introduced a new spelling mistake
in the sd_IN locales. This patch fixes this.
Signed-off-by: James Cloos <cloos@jhcloos.com>
The codeset must be *before* the modifier.
See also: http://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html
opengroup> The syntax for these environment variables is thus defined as:
opengroup>
opengroup> [language[_territory][.codeset][@modifier]]
Signed-off-by: James Cloos <cloos@jhcloos.com>
See also: https://bugzilla.redhat.com/show_bug.cgi?id=1066910
If these are not in locale.dir,
$ LANG=sr_RS.UTF-8@latin xterm
and
$ LANG=sr_RS@latin xterm
give the warning:
Warning: locale not supported by Xlib, locale set to C
and some programs (like xmms) fail to find translations for Serbian
in Latin because of this.
Signed-off-by: James Cloos <cloos@jhcloos.com>
In the man page the field "resourceid" was in a different place than
in the actual struct layout in Xlib.h
Signed-off-by: Joonas Javanainen <joonas.javanainen@gmail.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
The Compose format has a feature which allows specifying certain
modifiers must (or must not) be present with a given keysym in the
sequence.
The grammar in imLcPrs.c and the Compose man page both do not match what
the code actually does (see the handling of the variables
`modifier_mask` and `modifier` in parseline() in imLcPrs.c, which are
eventually matched as `ev->state & modifier_mask == modifier`).
Also explicitly list the accepted modifier names, since they are
not standard (e.g. "Ctrl" instead of "Control").
Signed-off-by: Ran Benita <ran234@gmail.com>
Signed-off-by: James Cloos <cloos@jhcloos.com>
In the spec and the man page the `mods_rtrn` argument is described as
"backfilled with unconsumed modifiers" but actually it is backfilled
with the *consumed* modifiers. This is also mentioned a few lines below
in each case.
Signed-off-by: Ran Benita <ran234@gmail.com>
Signed-off-by: James Cloos <cloos@jhcloos.com>
Also improve the grammar of the initial comment.
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: James Cloos <cloos@jhcloos.com>
The lines around them also contain the characters in the comments.
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: James Cloos <cloos@jhcloos.com>
The compose sequence for the new Indian Rupee sign is modelled after
the sequence for the Euro sign.
Signed-off-by: Gioele Barabucci <gioele@svario.it>
Signed-off-by: James Cloos <cloos@jhcloos.com>
Signed-off-by: Gabriel Souza Franco <gabrielfrancosouza@gmail.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Based on the iso8859-2 compose, and a bug report by Vladimír Marek,
override the en_US.UTF-8 use of <dead_caron> <u> to enter »ǔ« instead
to enter »ů«, and likewise for the majuscule, for the Czech locale.
This evidently is the norm for Czech keyboards.
Fixes bz#81875.
The XI18N_OBJS and XLC_LOCALE.pre files are empty, as they are for
several other locales. That may require an update.
Reported-by: Vladimír Marek <vlmarek@volny.cz>
Signed-off-by: James Cloos <cloos@jhcloos.com>
Get rid of unwanted whitespace before punctuation by moving them to the
lines with the tags, instead of before & after.
perl -i -0 -p -e 's{\>\s*\n([\.,;:])}{>\1\n}g' *xml
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Get rid of unwanted whitespace inside parens by moving them to the
lines with the tags, instead of before & after.
perl -i -0 -p \
-e 's{(?<!--) \(\s*\n\<}{\n(<}g;' \
-e 's{\>\s*\n\)([\.,;]?)(?! [^\n]*--)}{>)\1\n}g' *xml
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Also add <indexterm> entries for most of them, to make their definitions
or introductions easy to find from the index.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
