Fixes leaks in error paths found by Parfait 1.0.0:
Error: X Resource Leak
Leaked X Resource pix
at line 62 of CrBFData.c in function 'XCreateBitmapFromData'.
pix initialized at line 60 with XCreatePixmap
Error: X Resource Leak
Leaked X Resource pix
at line 70 of CrPFBData.c in function 'XCreatePixmapFromBitmapData'.
pix initialized at line 66 with XCreatePixmap
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Reassigned squences with minus and a or o (vice versa and lower and
upper case) to conform existing series and not resulting in tilde.
Also added noe missing underscore sequence.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
The compose-check script only handles compiled Compose files, not
the Compose.pre files. One must remember to use:
./autogen.sh; make; make check
when reviewing patches to the Compose.pre files....
Signed-off-by: James Cloos <cloos@jhcloos.com>
autoconf 2.63 doesn't seem to like the nested AC_CHECK_DECL/FUNC. So do
the tests separately.
Reported-by: Dave Airlie
Signed-off-by: Julien Cristau <jcristau@debian.org>
GNU/kFreeBSD has issetugid in libc (for legacy apps?), but doesn't
declare it anywhere, causing gcc to error out with
-Werror=implicit-function-declaration. Use AC_CHECK_DECL in addition to
AC_CHECK_FUNC so we disable this code instead of failing to build it.
Debian bug#669670 <http://bugs.debian.org/669670>
Signed-off-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
(Some of) the Dstroke and dstroke entries already were present as U011[01],
even though XK_Dstroke and XK_dstroke are part of the latin2 set in keysymdef.h.
The addition of <Multi_key> <o> <apostrophe> as a postfix version of
<Multi_key> <apostrophe> <o> blocks the existing entries for ǻ and Ǻ.
That prevents its and <Multi_key> <O> <apostrophe>’s addition.
Signed-off-by: James Cloos <cloos@jhcloos.com>
Wait for all other threads to release the user-level lock when
acquiring it. This ensures that only one thread at a time holds the
user-level lock, necessary as it is a nesting lock and a single
variable is used to determine when the lock is nesting and when it is
contended.
Signed-off-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Jamey Sharp <jamey@minilop.net>
(caddr_t) isn't used anywhere else in xcb or libX11.
Cast to (char *) for consistency.
Removing this cast allows building for MinGW without patching.
v2: Cast to (char *) rather than just dropping the cast
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
This reverts commit f09c5299a3.
The TCP fallback ended up falling back to UNIX socket connection if
$DISPLAY was set to e.g. some.host:0 and the initial attempt failed.
Debian bug#659558 <http://bugs.debian.org/659558>
Signed-off-by: Julien Cristau <jcristau@debian.org>
Conflicts:
src/OpenDis.c
There is no XK_Ssharp symbol for U+1E9E LATIN CAPITAL LETTER SHARP S,
so use the U1e9e symbol in the Compose sequence.
(Compose sequences do not work when the target symbol is unknown.)
Signed-off-by: James Cloos <cloos@jhcloos.com>
Related: https://bugs.freedesktop.org/show_bug.cgi?id=19687
Signed-off-by: Marko Myllynen <myllynen@redhat.com>
Reviewed-by: Matt Dew <marcoz@osource.org>
Signed-off-by: James Cloos <cloos@jhcloos.com>
Use pthreads (provided by the pthreads-win32 compatability library which implements
them using native Win32 threading) on MinGW
Reviewed-by: Jon TURNEY <jon.turney@dronecode.org.uk>
This avoids some conflicting type re-definition errors which occur if
we attempt to include Windows headers after Xmd.h
Reviewed-by: Jon TURNEY <jon.turney@dronecode.org.uk>
On certain tables, add top and bottom borders to table header
and a bottom border to the table. This matches what those
tables in the old pdfs looked like.
the <?dbfo keep-together='always'> prevents tables from
splitting across pages. Useful for tiny tables.
Converting the colwidth to a floating point, IE, 1* -> 1.0*
cleans up these build errors:
WARNING: table-layout="fixed" and column-width unspecified =>
falling back to proportional-column-width(1)
Signed-off-by: Matt Dew <marcoz@osource.org>
Rather than referring to the external xorg.css stylesheet, embed the content
of the file in the html output produced. This is accomplished by using
version 1.10 of xorg-xhtml.xsl.
This makes the whole html docs tree much more relocatable.
In addition, it eliminates xorg.css as a runtime file which makes
xorg-sgml-doctools a build time only package.
Signed-off-by: Gaetan Nadon <nadon@memsize.(none)>
The global was only referenced in the main() function, which passes it
as an argument of the same name to the parse_line() function, leading
to gcc -Wshadow warnings:
makekeys.c: In function ‘parse_line’:
makekeys.c:58:24: warning: declaration of ‘buf’ shadows a global declaration
makekeys.c:54:13: warning: shadowed declaration is here
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Currently, only non-modifier keys (actually, keysyms) can be part of a compose
sequence, and they are matched against the defined compose sequences at the
time the key is pressed. The patch allows to use modifier keys an well, but
matches them on key release, and only if no other key has been pressed after
the modifier.
Releasing a non-matched modifier during an ongoing compose sequence only aborts
the sequence if any modifier release would have matched. In particular, if no
compose sequences with modifiers are specified, the compose mechanism works
exactly as without this patch.
Even if modifiers are part of a compose sequence, they are not filtered. This
is because modifiers affect the keyboard state no matter what we do here and,
therefore, filtering them only could confuse clients.
The purpose is this extension to the compose mechanism is to allow to make
better use of keys in convenient reach for touch typing.
Signed-off-by: Andreas Wettstein <wettstein509@solnet.ch>
Signed-off-by: James Cloos <cloos@jhcloos.com>
Silences parfait warning of a potential memory leak:
Memory leak of pointer 'dst' allocated with malloc(length)
at line 160 of FSWrap.c in function 'copy_string_list'.
'dst' allocated at line 145 with malloc(length).
dst leaks when count <= 0 at line 154.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Since makekeys is built using build environment's gcc and
runs natively, we have to make sure that the size of the
Signature type is the same on both the native environment
and the target, otherwise we get mismatches upon running X,
and some LSB test failures (xts5).
Use an unsigned 32-bit integer on all platforms. Also,
eliminate the redundant multiple typedefs for the
Signature type.
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
GetEmptyReq and GetResReq cannot do this due to the final typecast -
typically requests that need either of those do not have their own typedef
in the protocol headers.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Jamey Sharp <jamey@minilop.net>
Some XI2 requests change in size over different versions and libXi would
need to hack around GetReq and GetReqExtra. Add a new GetReqSized so the
library can explicitly specify the size of the request in 4-byte units.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Jamey Sharp <jamey@minilop.net>
