fdo-mirrors/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston.git synced 2026-05-06 12:38:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

drm/state-propose: remove output asserts in z_order_list walks

Browse source 
We already validate the paint node list in weston_output_repaint,
immediately after we conditionally rebuild the z_order_list.

These asserts are thus completely redundant, as we've already
performed them in the front end.

My reason for removing this now is to drop weston_view usage
from the backend.

Signed-off-by: Derek Foreman <derek.foreman@collabora.com>
This commit is contained in:
Derek Foreman 2026-03-16 10:00:22 -05:00
parent 96676d114c
commit c1fcfd288d
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
libweston/backend-drm/state-propose.c
View file

@ -1279,8 +1279,6 @@ drm_output_propose_state(struct weston_output *output_base,
wl_array_init(&visible_pnodes);
wl_list_for_each(pnode, &output->base.paint_node_z_order_list,
z_order_link) {
struct weston_view *ev = pnode->view;
pnode->try_view_on_plane_failure_reasons = FAILURE_REASONS_NONE;
drm_debug(b, "\t\t\t[paint node] evaluating paint node %s for scene-graph "
@ -1288,8 +1286,6 @@ drm_output_propose_state(struct weston_output *output_base,
pnode->internal_name, output->base.name,
(unsigned long) output->base.id);
assert(ev->output_mask & (1u << output->base.id));
/* Cannot show anything without a color transform. */
if (!pnode->surf_xform_valid) {
drm_debug(b, "\t\t\t\t[paint node] ignoring paint node %s "
@ -1624,8 +1620,6 @@ drm_assign_planes(struct weston_output *output_base)
struct drm_plane *target_plane = NULL;
struct drm_plane_handle *target_handle = NULL;
assert(ev->output_mask & (1u << output->base.id));
/* Update dmabuf-feedback if needed */
if (ev->surface->dmabuf_feedback)
dmabuf_feedback_maybe_update(device, pnode);