Commit graph

339 commits

Author SHA1 Message Date
Rosen Zhelev
e1d77594fb Merge 'VK_EXT_frame_boundary: Fixing the sType used in VkFrameBoundaryEXT' into 'main'
See merge request mesa/vulkan-wsi-layer!202
2025-09-22 16:41:28 +01:00
Ginu Jacob
5a2bc13570 VK_EXT_frame_boundary: Fixing the sType used in VkFrameBoundaryEXT
In this change, the sType used in VkFrameBoundaryEXT instance is fixed.

Signed-off-by: Ginu Jacob <ginu.jacob@arm.com>
Change-Id: Id1dab87b9b4144d6030c57dbe4e33a41e7045a9f
2025-09-22 16:31:11 +01:00
Rosen Zhelev
2f7e6e7ff3 Merge 'Update the layer's readme and release notes with VK_KHR_present_wait2 support' into 'main'
See merge request mesa/vulkan-wsi-layer!205
2025-09-18 10:20:43 +01:00
Nir Ekhauz
8c65fb2af7 Update the layer's readme and release notes with VK_KHR_present_wait2 support
1. Update the README file.
2. Remove the guards from the code.

Signed-off-by: Nir.Ekhauz <nir.ekhauz@arm.com>
Change-Id: Idf65baee25d09a3b4bc3b563455468bac4d5bddf
2025-09-18 10:20:43 +01:00
Rosen Zhelev
4ed20527c3 Merge 'Fix Wayland swapchain to support present_id2' into 'main'
See merge request mesa/vulkan-wsi-layer!199
2025-09-17 10:20:46 +01:00
Nir Ekhauz
ee6d45430f Fix Wayland swapchain to support present_id2
Adding support for present_id2

Signed-off-by: Nir.Ekhauz <nir.ekhauz@arm.com>
Change-Id: Ie30caf423902fea9f2bc3341c3b61390b09c0f7c
2025-09-17 10:20:46 +01:00
Rosen Zhelev
623f803387 Merge 'Implement schedule present at relative time on headless' into 'main'
See merge request mesa/vulkan-wsi-layer!201
2025-09-15 12:40:06 +01:00
Ginu Jacob
7a46cdb679 Implement schedule present at relative time on headless
In this change, the schedule present at relative time is enabled for
headless backend.

Signed-off-by: Ginu Jacob <ginu.jacob@arm.com>
Change-Id: I15ff8170dfe93539e4c9a7ff20868b0916129546
2025-09-15 12:40:06 +01:00
Rosen Zhelev
a29eae014e Merge 'Silence clang-tidy warnings' into 'main'
See merge request mesa/vulkan-wsi-layer!203
2025-09-15 12:31:41 +01:00
Maged Elnaggar
c175b19ccb Silence clang-tidy warnings
Silence warnings till we investigate
unrelated warnings to the project

Signed-off-by: Maged Elnaggar <maged.elnaggar@arm.com>
Change-Id: Id557ffcd96dcccfb8f8a2c58d84a229e53b2ab03
2025-09-15 12:31:41 +01:00
Iason Paraskevopoulos
681648c9e9 Merge 'Query pool reads for QUEUE_OPERATIONS_END_BIT_EXT skipped when not ready' into 'main'
See merge request mesa/vulkan-wsi-layer!198
2025-09-11 15:47:13 +00:00
Ginu Jacob
1346705513 Query pool reads for QUEUE_OPERATIONS_END_BIT_EXT skipped when not ready
In this change, the return status from query pool reads for
QUEUE_OPERATIONS_END_BIT_EXT are checked and skipped when not ready.
To cater for correctness of any later reads, the value returned is
cached and compared. Additionally, a fix is added to avoid data
corruption with presentation feedback object in present timing when
vector was used.

Signed-off-by: Ginu Jacob <ginu.jacob@arm.com>
Change-Id: I5f26b6a3c81eb73eff8a4073be7d7ffc81f9eef8
2025-09-11 15:47:13 +00:00
Rosen Zhelev
22502056af Merge 'Set the default DRM device node for the VK_KHR_display backend' into 'main'
See merge request mesa/vulkan-wsi-layer!196
2025-09-11 11:50:02 +01:00
Fufu Fang
5e53d9637f Scan DRM device nodes for the VK_KHR_display backend
To specify a DRM device node for the VK_KHR_display backend,
WSI_DISPLAY_DRI_DEV environment variable needs to be set. If
WSI_DISPLAY_DRI_DEV is not set, the VK_KHR_display backend
now scans all DRM device node, and uses the first node
that has a display connected.

Signed-off-by: Fufu Fang <fufu.fang@arm.com>
Change-Id: Idbcda60cf3b1656784e6d3b0547cc70e99f0fc52
2025-09-11 11:50:01 +01:00
Rosen Zhelev
6319d7dde0 Merge 'Support VK_KHR_swapchain_mutable_format extension' into 'main'
See merge request mesa/vulkan-wsi-layer!197
2025-09-11 09:28:04 +01:00
Maged Elnaggar
fb23a9b14e Support VK_KHR_swapchain_mutable_format extension
- Add support for VK_KHR_swapchain_mutable_format extension to the Layer.
- Expose support for the VK_KHR_swapchain_mutable_format extension.
- Improve find_extension helper API to be spec-correct, const-correct,
  and clearer by using the right base type (VkBaseInStructure for input,
  VkBaseOutStructure for output),
  and concise docs explaining it returns the first matching struct or nullptr.
- Correctly use image_create_info instead of m_image_create_info in
  create_swapchain_image function for Wayland.

Signed-off-by: Maged Elnaggar <maged.elnaggar@arm.com>
Change-Id: Id40b28977e63ba76012d3a8f693327f757d75dcd
2025-09-11 09:28:03 +01:00
Rosen Zhelev
edcd2c2629 Merge 'Add clang-tidy linting to merge requests CI' into 'main'
See merge request mesa/vulkan-wsi-layer!200
2025-09-10 14:31:36 +01:00
Maged Elnaggar
9608f70237 Add clang-tidy linting to merge requests CI
Introduce a new clang_tidy job that runs on merge requests
and the default branch. The job configures CMake to export
compile_commands.json and runs run-clang-tidy restricted to
repo files. Any warnings or errors cause the job to fail.

Artifacts include clang-tidy.log and compile_commands.json
to aid local reproduction. Shared Vulkan Loader setup was
factored into a YAML anchor for reuse across jobs.

Signed-off-by: Maged Elnaggar <maged.elnaggar@arm.com>
Change-Id: I61b48656e68e0e83725500ae1b37f8626f9a248c
2025-09-10 14:31:35 +01:00
Rosen Zhelev
f9b4a0df56 Merge 'Adding exception-safe custom mutex to the WSI layer' into 'main'
See merge request mesa/vulkan-wsi-layer!188
2025-09-05 16:06:38 +01:00
Maged Elnaggar
78b21da4ef Adding exception-safe custom mutex to the WSI layer
Introduce util::mutex, util::recursive_mutex
and util::unique_lock; switch WSI layer call sites to it.
All locks are acquired via try_lock(), no system_error leaks.

Signed-off-by: Maged Elnaggar <maged.elnaggar@arm.com>
Change-Id: Ide9ef4318be7cc47e9577059695cc298f8b8e579
2025-09-05 16:06:38 +01:00
Rosen Zhelev
ef9b134054 Merge 'Update present timing types' into 'main'
See merge request mesa/vulkan-wsi-layer!195
2025-09-04 17:48:10 +01:00
Iason Paraskevopoulos
b02e682d30 Update present timing types
Updates the present timing implementation and types to be aligned with
the latest commit.

Fixes an issue, where the queue used for the presentation feedback
events was destroyed before getting the last events.

Signed-off-by: Iason Paraskevopoulos <iason.paraskevopoulos@arm.com>
Change-Id: I1dba2fd0e4ad9ec8c02d71c58c93edceaa75d07e
2025-09-04 17:48:10 +01:00
Iason Paraskevopoulos
deb70d9473 Merge 'Add JSON schema to layer manifest' into 'main'
See merge request mesa/vulkan-wsi-layer!193
2025-09-03 14:51:37 +00:00
Rosen Zhelev
6baf6ff52a Merge 'Implement vkWaitForPresent2KHR' into 'main'
See merge request mesa/vulkan-wsi-layer!194
2025-08-28 15:46:50 +01:00
Nir Ekhauz
5060dbbc3a Implement vkWaitForPresent2KHR
Add the entry point for VK_KHR_present_wait2.

Signed-off-by: Nir.Ekhauz <nir.ekhauz@arm.com>
Change-Id: I8b0ad681a6c02ea646d072e69b25113a8c8ad3ce
2025-08-28 15:46:50 +01:00
Alex Bates
88be0b1649 Add JSON schema to layer manifest
Change-Id: I00fb3306a88f9c24932ee1e9f0d623076118e6d0
Signed-off-by: Alex Bates <alex.bates@arm.com>
2025-08-26 14:16:08 +01:00
Rosen Zhelev
76771e7f67 Merge 'Initial support for VK_KHR_present_wait2' into 'main'
See merge request mesa/vulkan-wsi-layer!192
2025-08-26 13:42:14 +01:00
Nir Ekhauz
64c1c46609 Initial support for VK_KHR_present_wait2
Add support for present wait2 ext. for physical, surface and sc.

Signed-off-by: Nir.Ekhauz <nir.ekhauz@arm.com>
Change-Id: I0f7cdadb2d3ea0ecbc32b8b2efe9fc3bb4ba0369
2025-08-26 13:42:14 +01:00
Rosen Zhelev
ad2767ee77 Merge 'Update the layer's readme and release notes with VK_KHR_present_id2 support' into 'main'
See merge request mesa/vulkan-wsi-layer!191
2025-08-20 12:45:47 +01:00
Nir Ekhauz
7fac7b1339 Update the layer's readme and release notes with VK_KHR_present_id2 support
Removed experimental flags around this extension.

Signed-off-by: Nir.Ekhauz <nir.ekhauz@arm.com>
Change-Id: If314e8c05d0f0fd7405379fe1c714f0e56519b4b
2025-08-20 12:45:46 +01:00
Rosen Zhelev
60f53bddd0 Merge 'Add initial support for VK_KHR_present_id2 in the layer' into 'main'
See merge request mesa/vulkan-wsi-layer!190
2025-08-18 10:23:02 +01:00
Nir Ekhauz
8256b027d7 Add initial support for VK_KHR_present_id2 in the layer
Add support for present id2 ext. for physical, surface and sc.

Signed-off-by: Nir Ekhauz <nir.ekhauz@arm.com>
Change-Id: I934d5d8ef7e0fde2de8682bb54696a4044edb047
2025-08-18 10:23:02 +01:00
Rosen Zhelev
a0700e3e86 Merge 'Add initial support for VK_KHR_present_id2 in the layer' into 'main'
See merge request mesa/vulkan-wsi-layer!181
2025-08-13 09:41:22 +01:00
Nir Ekhauz
472597ed42 Add initial support for VK_KHR_present_id2 in the layer
Add support for present id2 ext.

Signed-off-by: Nir.Ekhauz <nir.ekhauz@arm.com>
Change-Id: Ic4cf137158188e9b6db1fa999f2c61248456c139
2025-08-13 09:41:21 +01:00
Rosen Zhelev
467d6af310 Merge 'Append WSI layer warning flags' into 'main'
See merge request mesa/vulkan-wsi-layer!187
2025-08-05 13:34:59 +01:00
Maged Elnaggar
d1ade3d218 Append WSI layer warning flags
- switch CMAKE_CXX_FLAGS and C_FLAGS to string(APPEND)
- concatenate flags without semicolons or list issues
- preserve existing: -Wall -Werror -Wextra -pthread -fPIC
- add new diagnostics:
  Wdouble-promotion, Wnon-virtual-dtor,
  Wdelete-non-virtual-dtor, Woverloaded-virtual,
  Wcast-qual, Wmissing-field-initializers,
  Werror=return-type, Wmissing-format-attribute
- add C-only check: -Wstrict-prototypes

Change-Id: Icae6cf649b9ab88c1d0bc736b91b4bc50e24c9dd
Signed-off-by: Maged Elnaggar <maged.elnaggar@arm.com>
2025-08-05 13:34:59 +01:00
Iason Paraskevopoulos
050b43c769 Merge 'Implement scheduling for headless present stages' into 'main'
See merge request mesa/vulkan-wsi-layer!184
2025-07-30 12:27:09 +00:00
Normunds Rieksts
dfe88e3c1c The patch changes the following:
* Implement scheduling support for headless present stages.
* Fix a bug where present query stages were added to the internal queue when application did not request any.
* Change the implementation of present timing extension to store device_private_data rather than VkDevice as all queries require it.
* Document the shortcomings of implenting scheduling support for Wayland backends.

Change-Id: I050cc700a88bce476b350caf8cc23dfb551f4a0c 
Signed-off-by: Normunds Rieksts normunds.rieksts@arm.com
2025-07-30 12:27:09 +00:00
Rosen Zhelev
e0cd3c645f Merge 'Retry mechanism for Wayland image presented event' into 'main'
See merge request mesa/vulkan-wsi-layer!185
2025-07-29 15:52:21 +01:00
Ginu Jacob
27430b2138 Retry mechanism for Wayland image presented event
In this change, when performing dispatch_queue for the present timing
VK_PRESENT_STAGE_IMAGE_FIRST_PIXEL_OUT_BIT_EXT stage a retry mechanism
is implemented to dispatch Wayland events until there are no more
events in the queue or till we get the Wayland presented event.

Signed-off-by: Ginu Jacob <ginu.jacob@arm.com>
Change-Id: Ieb9c2f3360d6f7c06167fb8096a398adaf71cdd2
2025-07-28 11:53:10 +01:00
Iason Paraskevopoulos
1016e4d2e9 Merge 'Timestamp for VK_PRESENT_STAGE_IMAGE_FIRST_PIXEL_OUT_BIT_EXT in Wayland' into 'main'
See merge request mesa/vulkan-wsi-layer!177
2025-07-24 08:39:10 +00:00
Ginu Jacob
d807a089c3 Timestamp for VK_PRESENT_STAGE_IMAGE_FIRST_PIXEL_OUT_BIT_EXT in Wayland
In this change, support for the presentation stage
VK_PRESENT_STAGE_IMAGE_FIRST_PIXEL_OUT_BIT_EXT is added for the Wayland
backend.

Signed-off-by: Ginu Jacob <ginu.jacob@arm.com>
Change-Id: I866f8c55cfb6b69ba03761706d838ea17acf9651
2025-07-24 08:39:09 +00:00
Rosen Zhelev
d0a267380c Merge 'Missing return wsi_alloc_utils.hpp in WSI layer' into 'main'
See merge request mesa/vulkan-wsi-layer!183
2025-07-22 14:47:13 +01:00
Maged Elnaggar
5dbb34a16d Missing return wsi_alloc_utils.hpp in WSI layer
Ensure the move-assignment operator in
swapchain_wsialloc_allocator returns *this on all
code paths. This avoids undefined behavior and satisfies
the function’s return type requirements.

Signed-off-by: Maged Elnaggar <maged.elnaggar@arm.com>
Change-Id: I99762484d7a02c24a4632a7a84b415a3842d02a3
2025-07-21 14:30:08 +01:00
Iason Paraskevopoulos
ba93b67fb6 Merge 'Fix check for present_id feature in present timing' into 'main'
See merge request mesa/vulkan-wsi-layer!182
2025-07-18 14:59:53 +00:00
Iason Paraskevopoulos
d344eeae70 Fix check for present_id feature in present timing
Signed-off-by: Iason Paraskevopoulos <iason.paraskevopoulos@arm.com>
Change-Id: I04f02372758d64ec8230d6f0ba9a6b5f882668cd
2025-07-18 15:26:54 +01:00
Iason Paraskevopoulos
8b7103e0e3 Merge 'Improve wait_for_pending_buffers' into 'main'
See merge request mesa/vulkan-wsi-layer!175
2025-07-18 11:44:25 +00:00
Iason Paraskevopoulos
e34e3775d6 Merge 'Implement monotonic stage timestamps on headless' into 'main'
See merge request mesa/vulkan-wsi-layer!176
2025-07-18 11:39:41 +00:00
Alex Bates
c43dd058ed Implement monotonic stage timestamps on headless
Sets timestamps for `vkGetPastPresentationTimingEXT` for the remaining
present stages on headless:

- VK_PRESENT_STAGE_IMAGE_LATCHED_BIT_EXT
- VK_PRESENT_STAGE_IMAGE_FIRST_PIXEL_OUT_BIT_EXT
- VK_PRESENT_STAGE_IMAGE_FIRST_PIXEL_VISIBLE_BIT_EXT

These are all set to the same value: when swapchain::present_image is
called. It uses the best monotonic clock supported by the driver.

No need for slot member variables to be atomic any more because they
are only accessed while a lock on m_queue_mutex is held.

Signed-off-by: Alex Bates <alex.bates@arm.com>
Change-Id: I90ffc876890ee74620b7ba8da753794cae51dd36
2025-07-18 11:39:41 +00:00
Iason Paraskevopoulos
24a77e8300 Merge 'Update time domain handling to comply with Vulkan spec' into 'main'
See merge request mesa/vulkan-wsi-layer!180
2025-07-11 10:13:34 +00:00