The show_messages function shows any queued messages sent to the
daemon on the active boot splash. It's currently only ever called
in a place in the code where the splash hasn't yet been assigned,
so it's effectively always a noop.
This commit moves the call a little later so it won't bail immediately.
commit 74346ec268 tried to fix a case where views are
added after the text splash is shown. That commit inadvertently
removed the code that adds a view for a new text display.
This commit adds back the accidentaly excised line.
If a renderer fails to open, then we need to make sure we nullify,
the renderer variable after freeing it, since subsequent code checks
if the renderer is null to know whether or not to proceed with
fallback.
If we're already chugging along, and a new display
gets added make sure to load the view associated with
that display right away.
Using an unloaded view can lead to crashes.
When a new renderer gets created, we should activate it, if the device
manager is already active.
At the moment we call create_pixel_displays_for_renderer which would
implicitly activate it (from a callback), except we call it one line
too early, so the renderer isn't in the list of known renderers yet.
This commit swaps the two lines and also adds an explicit renderer
activation for clarity. For symmetry it makes the same change to
keyboards that it makes to renderers.
If you set PLYMOUTH_THEME_NAME to override the theme in an initrd
(as e.g. lorax does when building upgrade.img), plymouth-populate-initrd
tries to edit plymouthd.conf to enable that theme.
Unfortunately, the existing `sed` line doesn't work if your
plymouthd.conf is empty or all commented out - which is how we currently
ship it.
So before modifying the config, make sure it has a [Daemon] section
header, and a Theme=[placeholder] line for us to modify.
Resolves: RHBZ#1223344
it's unexpected for plymouth to show boot messages on the local console
if there is not console=tty0 on the kernel command line.
This commit fixes that.
https://lists.freedesktop.org/archives/systemd-devel/2015-March/029184.html
As explained there, plymouth watching for coldplug events is not the
behaviour we're looking for.
Replace this with a configurable timeout. We claim DRM devices as soon as
we're aware of them (displaying the splash still subject to ShowDelay),
but legacy framebuffer and text console devices are only claimed after
this new DeviceTimeout.
This avoids an issue where the initramfs finishes (generating a coldplug
event) before udev has informed plymouth of the DRM devices. This was
causing plymouth to activate text mode and ignore the DRM devices appearing
a moment later.
https://bugs.freedesktop.org/show_bug.cgi?id=95356
Some themes like to keep their content in subfolders,
but plymouth-populate-initrd currently fails to copy
those subfolders over to the initrd.
This commit fixes that.
https://bugzilla.gnome.org/show_bug.cgi?id=94883
Apply the same heuristics as the DRM code, and set a device
scale on the pixel buffer. An environment variable is introduced
to force a scale different than the native one.
https://bugs.freedesktop.org/show_bug.cgi?id=84482
The background image is tiled to cover the entire screen, so
we must pass a fill area that covers the screen or sampling
will be wrong. But we must also pass a clip area or we will
have expensive overdraw.
https://bugs.freedesktop.org/show_bug.cgi?id=84482
The device scale is a scale transformation that is applied to
the pixel buffer contents, but is transparent to the user of
the buffer (all pixel values are in logical pixels, not device
pixels).
The concept is modeled after the cairo API, and it is useful
to implement HiDPI monitor support.
https://bugs.freedesktop.org/show_bug.cgi?id=84482
There are strange red and black dots in a 1280x800 splash screen with
Debian Jessie theme. The problem comes from image rescaling and is
caused by:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=799953
on i386. The conversion from double to int in functions
ply_pixel_buffer_resize and ply_pixel_buffer_interpolate happens
through an intermediate float. This sometimes results in a truncated
value being larger than the original value.
This commit changes the code to use an intermediate double to
work around the bug.
ply_boot_splash_free currently calls some code that depends
on a module being loaded. We call ply_boot_splash_free to
clean up the boot splash object if a module can't be loaded,
leading to crash.
This commit addresses that issue by only calling the module
specific destruction code in ply_boot_splash_free in the case
where a module is loaded.
https://bugs.freedesktop.org/show_bug.cgi?id=91590
The code currently does a faulty heuristic to figure out which
drm device is associated with the tty. We shouldn't actually
even need an accurate association, so this commit just makes
sure the terminal gets used for the first device.
The seat abstraction isn't really right, since it forces creating a
link between terminal and video output device, which isn't really
necessary (and other reasons).
This commit drops the abstraction, and moves all the code that was
in ply-seat.c directly to ply-device-manager.c.
Right now if a user calls ply_throbber_stop or ply_animation_stop
after the animation is stopped things malfunction. In the case
of the throbber we end up never calling the stop completion handler
passed in, and in the case of the animation, we end up setting
some state that shouldn't be set.
This commit checks if the animation and throbber objects are stopped,
and if so does the necessary steps to process the late stop request.
Spotted by Dave Airlie
When drawing sprites it's a waste to draw the background if the target
area will be obscured by the sprit to draw. Optimize for the common case
where only one sprite is being drawn by peeking at the first item in the
sprite list to check if it is opaque and fills the area.
https://bugs.freedesktop.org/show_bug.cgi?id=87105
When transforming the output of libpng to ARG32 with pre-multiplied
alpha, only do the multiplications if the pixel isn't opaque. Otherwise
plymouth is just applying a very complicated identity function.
https://bugs.freedesktop.org/show_bug.cgi?id=87105
If the source buffer is known to be fully opaque and the fill is done at
full opacity, simply memcpy the data row-by-row instead of iterating over
every pixel and blending it with the target buffer.
This could be optimized more, in the future, in some cases, by memcpy of
the entire block instead of row-by-row.
https://bugs.freedesktop.org/show_bug.cgi?id=87105
Pixel buffers contain ARGB32 data. Add functionality to mark a buffer as
containing only fully opaque pixels. This functionality can be used by
rendering functions to be able to optimize drawing of such buffers.
https://bugs.freedesktop.org/show_bug.cgi?id=87105
We only support the generic driver now, and it doesn't
support mapping the console.
This commit removes the supports_mapping_console boolean,
and any code that checks for console mapping.
systemd isn't necessarily in the buildroot at the time that plymouth
gets built, so autodetection of the unitdir from pkgconfig isn't
necessarily feasible.
This commit adds a new option to configure, --with-systemdunitdir,
that lets distros specify the unit directory manually.
https://bugs.gentoo.org/show_bug.cgi?id=543712
