Commit graph

455 commits

Author SHA1 Message Date
Daniel Macks
a4ef3552eb Bump scanned_dir_count even if dir cannot be read
This allows the --debug output to follow the actual order of the
directories specified in the path.

  $ PKG_CONFIG_PATH=/nosuch1:/nosuch2:/dir-with-foo.pc
  $ pkg-config --debug foo
  [...]
  Path position of 'foo' is 1

With this change, the path position above would be 3, matching the
position in PKG_CONFIG_PATH.

Freedesktop #80380 (https://bugs.freedesktop.org/show_bug.cgi?id=80380)
2014-11-12 07:45:19 -08:00
Dan Nicholson
0e847a2201 Add --validate option to check .pc syntax without dependencies
Provide developers a way to check their .pc files prior to release. This
works the same as --exists except that package dependencies are not
processed. That allows the .pc file to be checked in complete isolation
of others.

Freedesktop #7000 (https://bugs.freedesktop.org/show_bug.cgi?id=7000)
2014-09-27 16:45:50 -07:00
Andrew Oakley
ce1a2416ce Strip system library directories reliably
This loop was changed from a while loop to a for loop in commit
9bf6277b, but the iterator is now advanced twice each time round the
loop.
2014-09-27 16:20:37 -07:00
Dan Nicholson
82316c17b4 Ensure usage of serial test driver in automake
Automake has a nice parallel test driver available since 1.12 which
became the default in 1.13. Unfortunately, it breaks the pkg-config
testsuite, so we need to ensure the serial test driver is used. On 1.12,
we can specify the option 'serial-tests', but this doesn't exist on
1.11. Kludge around this by detecting if the automake version is less
than 1.12 and leaving the option out in that case.
2014-09-27 16:20:32 -07:00
Dan Nicholson
29cddacd30 Update overlinking URL in guide
The Mandriva wiki is just being archived now, so point to the active
OpenMandriva article instead.
2014-09-22 12:25:16 -07:00
Dan Nicholson
4f0084d9d3 glib: Fix Makefiles to suppress warnings from automake
With the newly added glib.mk, some of the noinst_* variables need to use
+= in the evaluation to avoid multiple definition warnings from
automake.
2014-02-03 16:07:31 -08:00
Dan Nicholson
90320817dc glib: Update snapshot version to 2.38.2
This is the latest stable release from upstream. Patches have been
refreshed, including putting the removal of most pkg-config checks into
the glib-only patch. A few more files, most notably the large NEWS file,
have also been removed from the repo to keep the size of the snapshot
down.
2014-02-03 15:41:27 -08:00
Dan Nicholson
e1d44d2362 Don't used C reserved identifiers
Seems incredibly unlikely this would ever be an issue, but it's easy
enough to fix it. I fear for the Glib/GObject world where this is a
standard design pattern.

https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Freedesktop #70690 (https://bugs.freedesktop.org/show_bug.cgi?id=70690)
2013-12-16 05:32:04 -08:00
Dan Nicholson
abdbaba3e0 Ensure -isystem Cflags not compressed like -I
Treat -isystem specially like -idirafter so that multiple arguments
retain the preceding -isystem.

Freedesktop #72584 (https://bugs.freedesktop.org/show_bug.cgi?id=72584)
2013-12-14 10:47:56 -08:00
Dan Nicholson
860cab9a3e check: Rework dirafter test to handle all special cases
Expand the special flags test to check -framework usage and the handling
of multiple arguments.
2013-12-14 10:47:56 -08:00
Matthias Clasen
9f65411341 Add missing options to manual
Freedesktop #66155 (https://bugs.freedesktop.org/show_bug.cgi?id=66155)
2013-09-21 07:58:02 -07:00
Marek Kasik
50c2867f4a Unquote values of requested variables
If a --variable is requested, make sure to remove the quoting since it's
likely the value will be used verbatim in shell command substitution. If
the quotes remain in the value, they'd get embedded in the shell
variable, too.

Freedesktop #67904 (https://bugs.freedesktop.org/show_bug.cgi?id=67904)
2013-09-15 10:27:35 -07:00
Dan Nicholson
f26a505826 Strip trailing space from --cflags/--libs output
pkg-config leaves a trailing space on the flags output as it may have to
do multiple iterations to collect all output and adding the space makes
concatenation simple. However, this leaves a trailing space on the full
returned string unless it's empty. Strip the trailing space after all
the processing is complete.
2013-05-31 05:53:47 -07:00
Dan Nicholson
dbf1b7cd09 check: Convert paths to Windows format when using --define-prefix
When pkg-config redefines the .pc file's prefix variable, it will be in
the platform's native format. Convert the expected results as
necessary. This only affects the relocatable test because it explicitly
sets --define-prefix or uses .pc files in a pkgconfig/ directory. Other
tests do not have their prefixes redefined for this reason.
2013-05-31 05:31:02 -07:00
Dan Nicholson
719abc7910 check: Make relocatable script executable 2013-05-22 05:28:54 -07:00
Dan Nicholson
a65ee007bb Avoid const warning on Win32
scan_dir() alters the directory name in place on Win32 to convert \ to
/, so it can't be treated as const.
2013-05-20 05:56:50 -07:00
Dan Nicholson
0efb668bd5 Add static linking variant of PKG_CHECK_MODULES
PKG_CHECK_MODULES_STATIC is a convenience autoconf macro wrapping
PKG_CHECK_MODULES with --static enabled. This gives developers a way to
get static linking information from a specific set of modules.

Freedesktop #19541 (https://bugs.freedesktop.org/show_bug.cgi?id=19541)
2013-05-18 19:37:24 -07:00
Dan Nicholson
715cc306b0 Allow errors in .pc files for --list-all
Normally, the parser will exit immediately when it encounters errors in
.pc files. This is good most of the time, but for --list-all, the
purpose is to just get a quick list of packages and not to validate .pc
files. This is especially the case for pkg-config wrappers such as the
Ruby or Bash completion modules that scrape the output from --list-all
and don't expect to encounter errors there.

Freedesktop #26615 (https://bugs.freedesktop.org/show_bug.cgi?id=26615)
2013-05-17 05:53:13 -07:00
Dan Nicholson
2f41b2de42 Silence errors by default with --list-all
When listing all packages, the purpose is to get a quick look at what's
installed and not to scrutinize the validity of each .pc file. To see
errors from the parser during --list-all, the user can just add
--print-errors.
2013-05-17 05:49:02 -07:00
Dan Nicholson
1085ba7377 rpmvercmp: Use helper macros to match upstream code better
Upstream rpm has some convenience inline functions for strcmp and the
character class functions. Define some macros here to make our code look
more like upstream despite being the same functionally.

One difference noted while investigating the inline functions in
upstream is that the rpm character class functions are slightly
different from the standard functions. The rpm functions are independent
of locale, unlike the libc routines. pkg-config should probably do the
same and could easily use the g_ascii_is* macros from glib.
2013-05-17 05:36:12 -07:00
Dan Nicholson
f78b014371 rpmvercmp: Return -1/0/1 as function says it will
strcmp is only guaranteed to return !0 when the strings are unmatched
while rpmvercmp says it will return only -1 or 1 in those cases.

pkg-config currently only checks for !0, so this doesn't actually fix
any issues here. However, this is harmless and helps minimize the diff
with upstream rpmvercmp.

http://rpm.org/gitweb?p=rpm.git;a=commitdiff;h=ee64849e
2013-05-17 05:36:12 -07:00
Dan Nicholson
f50ba60ceb rpmvercmp: Formatting & comment updates to reduce upstream diff
No changes to code, only to comments and formatting so that diff with
upstream rpmvercmp is reduced.
2013-05-17 05:36:12 -07:00
Dan Nicholson
4623b5e85a Split rpmvercmp code into separate file
The rpmvercmp code is taken directly from upstream. Moving it to a
separate file allows it to be diffed and synced easily with the upstream
version. It also becomes really easy to switch to the actual rpmlib
version if that's ever desired.
2013-05-17 05:36:12 -07:00
Dan Nicholson
32427bf2c6 check: Test relocatable features
Exercise the ${pcfiledir} and --define-prefix features for allowing
relocation of packages. The --define-prefix test .pc files are put in a
pkgconfig subdirectory since the feature will only be enabled in that
situation.
2013-05-17 05:13:15 -07:00
Dan Nicholson
e7238e823f check: Define all useful build directories in config.sh
Define all the autoconf build directories besides srcdir, which is
required to run the test scripts and set by "make check", and builddir,
which is always assumed to be ".".
2013-05-17 05:13:15 -07:00
Dan Nicholson
925119ce51 Document all pkg-config derived metadata variables
The derived variables pcfiledir, pc_top_builddir and pc_sysrootdir were
lacking in documentation. Rework the "QUERYING PKG-CONFIG'S DEFAULTS"
section to describe these and pc_path.

The example of using "pkg-config --modversion pkg-config" was removed
since it's superfluous to "pkg-config --version".

Freedesktop #62018 (https://bugs.freedesktop.org/show_bug.cgi?id=62018)
2013-05-17 05:13:15 -07:00
Dan Nicholson
43c1e0e4af Make the --define-prefix feature available on all platforms
Allowing pkg-config to override the prefix variable in .pc files is a
useful feature for making packages relocatable. There's nothing Windows
specific about it.

Freedesktop #63602 (https://bugs.freedesktop.org/show_bug.cgi?id=63602)
2013-05-17 05:13:15 -07:00
Dan Nicholson
755639aac0 Remove compat definition of G_IS_DIR_SEPARATOR
This has been available on glib since 2.5.4, and pkg-config requires at
least 2.16.
2013-05-17 05:13:15 -07:00
Dan Nicholson
f655cf91a0 Store the original prefix value in the package
Avoids making implicit assumptions about parse ordering needed to store
the original prefix as a static file local variable.
2013-05-17 05:13:14 -07:00
Dan Nicholson
a65d5cff5f Allow Windows prefix redefinition in any pkgconfig directory
The prefix redefinition feature on Windows to make packages relocatable
was being confined only to locations where the .pc file was in a
directory ending in lib/pkgconfig or share/pkgconfig. This is too
restrictive as it's quite common for the libdir to have a different name
such as lib64. This keeps the convention that the feature will only be
enabled when the .pc file is in a pkgconfig directory, and it continues
to define the prefix to the grandparent of the pkgconfig directory.

The path handling is switched over to standard glib functions
g_path_get_basename and g_path_get_dirname to avoid handrolled handling
of Windows paths.
2013-05-17 05:13:14 -07:00
Dan Nicholson
409ee76ce1 Allow more control of redefined prefix behavior
Currently the native Win32 builds default to redefining the prefix
variable in .pc files based on their installation paths. This behavior
is not always desired when pkg-config is being used in a traditional
fixed path environment (e.g., /mingw like /usr).

Allow the default to be set via configure switch
--enable/disable-define-prefix, and allow it to be set both ways at
runtime through the --[dont-]define-prefix pkg-config option.
2013-05-17 05:13:14 -07:00
Dan Nicholson
636e804ded Fix default path in PKG_CONFIG_LIBDIR description
It's been a long time that $datadir/pkgconfig was in the default path.
2013-04-20 10:18:18 -07:00
Dan Nicholson
d04105f2e2 check: Make check-tilde executable like all other test scripts 2013-04-20 08:38:02 -07:00
Dan Nicholson
cf21a002be Document search path construction on Windows 2013-04-18 05:43:23 -07:00
Dan Nicholson
ec844f503c Fix regression in -L mangling for MSVC
Commit 9bf6277b reworked how Libs arguments are parsed but unfortunately
added an extra library suffix component into -L arguments. This only
affects MSVC syntax where the suffix is .libs. All other platforms use a
blank suffix in linker commands.
2013-04-18 05:42:59 -07:00
Dan Nicholson
7328e6fc9e Run cmd through Wine when available
If we have Wine, it will provide cmd so we can build the pkg-config path
for the test.
2013-04-09 05:45:40 -07:00
Dan Nicholson
4a0ab4be0b Check for Wine when cross-compiling to Windows
If Wine is available when cross-compiling to Windows, it can be used to
run the test suite from the build machine.
2013-04-09 05:45:40 -07:00
Dan Nicholson
80c2777b22 Substitute TESTS_PKG_CONFIG from configure
This just paves the way to calculate more useful defaults in a shell.
2013-04-09 05:45:40 -07:00
Dan Nicholson
85dce61788 Adjust PKG_CONFIG_PATH for tests correctly on Windows
For native Windows, the PKG_CONFIG_PATH separator is ; rather than :.
2013-04-09 05:45:07 -07:00
Dan Nicholson
bfe139da8c Mangle expected sysroot output to match MSYS shell
MSYS mangles UNIX paths on execution such that it prepends its root in
Windows format. This affects PKG_CONFIG_SYSROOT_DIR and thus the
check-sysroot test. Detect MSYS from the OSTYPE environment variable and
adjust the expected test results to match. This likely means that
sysroot support doesn't actually work on MSYS, but there probably aren't
any toolchains that support sysroot there, anyway.
2013-04-09 05:43:24 -07:00
Dan Nicholson
5f9116931d Flush stderr when not immediately exiting
When printing warnings on stderr that don't immediately exit pkg-config,
flush it so that the messages appear in order with stdout. This is
mostly to keep the test suite passing on Windows where output may appear
differently than on Linux.
2013-04-09 05:41:38 -07:00
Dan Nicholson
f6212f6b97 Adjust expected path for native Windows test
When check-path is run on native Windows (MINGW), that path reported
by `pkg-config --variable=pc_path pkg-config` is adjusted to the
directory pkg-config is run from. Adjust the expected result based on
getting the current directory from cmd in Windows format.
2013-04-09 05:41:38 -07:00
Dan Nicholson
df1ac943d4 Check $host rather than $build when deciding native Win32
The host triplet describes the machine the program will run on while the
build triplet describes the machine the program is being built on. The
determination of native Win32 should be based on where pkg-config is
going to be running. This makes pkg-config cross-compiled for windows
work as if it was built on windows.
2013-04-09 05:41:38 -07:00
Dan Nicholson
4ccdb947dd Remove duplicate LIBRARIES in manual
Freedesktop #62374 (https://bugs.freedesktop.org/show_bug.cgi?id=62374)
2013-04-06 11:29:57 -07:00
Dan Nicholson
74ceac54ef Update NEWS and bump version for release 2013-01-24 05:42:44 -08:00
Dan Nicholson
3da597804f Fix srcdir != builddir error in check-debug
Another fix for the fragile check-debug test where a message about
adding to the pkg-config path expected '.' to be the srcdir.
2013-01-23 11:11:21 -08:00
Dan Nicholson
8b7489a36f Remove $host-pkg-config when uninstalling
Fixes an error from distcheck about files left in the destdir after
uninstalling.
2013-01-23 11:09:56 -08:00
Dan Nicholson
1694230365 Merge branch 'flag-order-fixes' 2013-01-22 05:11:59 -08:00
Dan Nicholson
7867cbd79c Use the standard pkg-config macros to check for glib
By using our PKG_CHECK_MODULES from our in-tree pkg.m4, the check for
glib will be done the same way pkg-config is used everywhere else. This
includes the usage of AC_PATH_TOOL in PKG_PROG_PKG_CONFIG, which will
check for $host-pkg-config when --host is set during configure.

Freedesktop #59435 (https://bugs.freedesktop.org/show_bug.cgi?id=59435)
2013-01-17 05:39:00 -08:00
Dan Nicholson
ae2fef2c05 Greatly simplify circular Requires checking
Instead of keeping of list of packages in the current Requires chain and
searching it repeatedly, just mark each package as part of the chain or
not. This nearly cuts in half the time on a particularly rough torture
test I have.
2013-01-16 16:42:48 -08:00