mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-01-07 06:30:11 +01:00
The current SSA def validation we do in nir_validate validates three
things:
1. That each SSA def is only ever used in the function in which it is
defined.
2. That an nir_src exists in an SSA def's use list if and only if it
points to that SSA def.
3. That each nir_src is in the correct use list (uses or if_uses) based
on whether it's an if condition or not.
The way we were doing this before was that we had a hash table which
provided a map from SSA def to a small ssa_def_validate_state data
structure which contained a pointer to the nir_function_impl and two
hash sets, one for each use list. This meant piles of allocation and
creating of little hash sets. It also meant one hash lookup for each
SSA def plus one per use as well as two per src (because we have to look
up the ssa_def_validate_state and then look up the use.) It also
involved a second walk over the instructions as a post-validate step.
This commit changes us to use a single low-collision hash set of SSA
sources for all of this by being a bit more clever. We accomplish the
objectives above as follows:
1. The list is clear when we start validating a function. If the
nir_src references an SSA def which is defined in a different
function, it simply won't be in the set.
2. When validating the SSA defs, we walk the uses and verify that they
have is_ssa set and that the SSA def points to the SSA def we're
validating. This catches the case of a nir_src being in the wrong
list. We then put the nir_src in the set and, when we validate the
nir_src, we assert that it's in the set. This takes care of any
cases where a nir_src isn't in the use list. After checking that
the nir_src is in the set, we remove it from the set and, at the end
of nir_function_impl validation, we assert that the set is empty.
This takes care of any cases where a nir_src is in a use list but
the instruction is no longer in the shader.
3. When we put a nir_src in the set, we set the bottom bit of the
pointer to 1 if it's the condition of an if. This lets us detect
whether or not a nir_src is in the right list.
When running shader-db with an optimized debug build of mesa on my
laptop, I get the following shader-db CPU times:
With NIR_VALIDATE=0 3033.34 seconds
Before this commit 20224.83 seconds
After this commit 6255.50 seconds
Assuming shader-db is a representative sampling of GLSL shaders, this
means that making this change yields an 81% reduction in the time spent
in nir_validate. It still isn't cheap but enabling validation now only
increases compile times by 2x instead of 6.6x.
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Thomas Helland <thomashelland90@gmail.com>
|
||
|---|---|---|
| .. | ||
| tests | ||
| meson.build | ||
| nir.c | ||
| nir.h | ||
| nir_algebraic.py | ||
| nir_builder.h | ||
| nir_builder_opcodes_h.py | ||
| nir_builtin_builder.c | ||
| nir_builtin_builder.h | ||
| nir_clone.c | ||
| nir_constant_expressions.h | ||
| nir_constant_expressions.py | ||
| nir_control_flow.c | ||
| nir_control_flow.h | ||
| nir_control_flow_private.h | ||
| nir_deref.c | ||
| nir_deref.h | ||
| nir_dominance.c | ||
| nir_format_convert.h | ||
| nir_from_ssa.c | ||
| nir_gather_info.c | ||
| nir_gather_ssa_types.c | ||
| nir_gather_xfb_info.c | ||
| nir_gs_count_vertices.c | ||
| nir_inline_functions.c | ||
| nir_instr_set.c | ||
| nir_instr_set.h | ||
| nir_intrinsics.py | ||
| nir_intrinsics_c.py | ||
| nir_intrinsics_h.py | ||
| nir_linking_helpers.c | ||
| nir_liveness.c | ||
| nir_loop_analyze.c | ||
| nir_loop_analyze.h | ||
| nir_lower_alpha_test.c | ||
| nir_lower_alu.c | ||
| nir_lower_alu_to_scalar.c | ||
| nir_lower_array_deref_of_vec.c | ||
| nir_lower_atomics_to_ssbo.c | ||
| nir_lower_bit_size.c | ||
| nir_lower_bitmap.c | ||
| nir_lower_bool_to_float.c | ||
| nir_lower_bool_to_int32.c | ||
| nir_lower_clamp_color_outputs.c | ||
| nir_lower_clip.c | ||
| nir_lower_clip_cull_distance_arrays.c | ||
| nir_lower_constant_initializers.c | ||
| nir_lower_double_ops.c | ||
| nir_lower_drawpixels.c | ||
| nir_lower_fb_read.c | ||
| nir_lower_flrp.c | ||
| nir_lower_fragcoord_wtrans.c | ||
| nir_lower_frexp.c | ||
| nir_lower_global_vars_to_local.c | ||
| nir_lower_gs_intrinsics.c | ||
| nir_lower_idiv.c | ||
| nir_lower_indirect_derefs.c | ||
| nir_lower_int64.c | ||
| nir_lower_int_to_float.c | ||
| nir_lower_io.c | ||
| nir_lower_io_arrays_to_elements.c | ||
| nir_lower_io_to_scalar.c | ||
| nir_lower_io_to_temporaries.c | ||
| nir_lower_io_to_vector.c | ||
| nir_lower_load_const_to_scalar.c | ||
| nir_lower_locals_to_regs.c | ||
| nir_lower_non_uniform_access.c | ||
| nir_lower_packing.c | ||
| nir_lower_passthrough_edgeflags.c | ||
| nir_lower_patch_vertices.c | ||
| nir_lower_phis_to_scalar.c | ||
| nir_lower_regs_to_ssa.c | ||
| nir_lower_returns.c | ||
| nir_lower_scratch.c | ||
| nir_lower_sincos.c | ||
| nir_lower_subgroups.c | ||
| nir_lower_system_values.c | ||
| nir_lower_tex.c | ||
| nir_lower_to_source_mods.c | ||
| nir_lower_two_sided_color.c | ||
| nir_lower_uniforms_to_ubo.c | ||
| nir_lower_var_copies.c | ||
| nir_lower_vars_to_ssa.c | ||
| nir_lower_vec_to_movs.c | ||
| nir_lower_viewport_transform.c | ||
| nir_lower_wpos_center.c | ||
| nir_lower_wpos_ytransform.c | ||
| nir_metadata.c | ||
| nir_move_load_const.c | ||
| nir_move_vec_src_uses_to_dest.c | ||
| nir_normalize_cubemap_coords.c | ||
| nir_opcodes.py | ||
| nir_opcodes_c.py | ||
| nir_opcodes_h.py | ||
| nir_opt_algebraic.py | ||
| nir_opt_combine_stores.c | ||
| nir_opt_comparison_pre.c | ||
| nir_opt_conditional_discard.c | ||
| nir_opt_constant_folding.c | ||
| nir_opt_copy_prop_vars.c | ||
| nir_opt_copy_propagate.c | ||
| nir_opt_cse.c | ||
| nir_opt_dce.c | ||
| nir_opt_dead_cf.c | ||
| nir_opt_dead_write_vars.c | ||
| nir_opt_find_array_copies.c | ||
| nir_opt_gcm.c | ||
| nir_opt_idiv_const.c | ||
| nir_opt_if.c | ||
| nir_opt_intrinsics.c | ||
| nir_opt_large_constants.c | ||
| nir_opt_loop_unroll.c | ||
| nir_opt_move_comparisons.c | ||
| nir_opt_move_load_ubo.c | ||
| nir_opt_peephole_select.c | ||
| nir_opt_remove_phis.c | ||
| nir_opt_shrink_load.c | ||
| nir_opt_trivial_continues.c | ||
| nir_opt_undef.c | ||
| nir_phi_builder.c | ||
| nir_phi_builder.h | ||
| nir_print.c | ||
| nir_propagate_invariant.c | ||
| nir_remove_dead_variables.c | ||
| nir_repair_ssa.c | ||
| nir_search.c | ||
| nir_search.h | ||
| nir_search_helpers.h | ||
| nir_serialize.c | ||
| nir_serialize.h | ||
| nir_split_per_member_structs.c | ||
| nir_split_var_copies.c | ||
| nir_split_vars.c | ||
| nir_strip.c | ||
| nir_sweep.c | ||
| nir_to_lcssa.c | ||
| nir_validate.c | ||
| nir_vla.h | ||
| nir_worklist.c | ||
| nir_worklist.h | ||
| nir_xfb_info.h | ||
| README | ||
New IR, or NIR, is an IR for Mesa intended to sit below GLSL IR and Mesa IR. Its design inherits from the various IRs that Mesa has used in the past, as well as Direct3D assembly, and it includes a few new ideas as well. It is a flat (in terms of using instructions instead of expressions), typeless IR, similar to TGSI and Mesa IR. It also supports SSA (although it doesn't require it). Variables ========= NIR includes support for source-level GLSL variables through a structure mostly copied from GLSL IR. These will be used for linking and conversion from GLSL IR (and later, from an AST), but for the most part, they will be lowered to registers (see below) and loads/stores. Registers ========= Registers are light-weight; they consist of a structure that only contains its size, its index for liveness analysis, and an optional name for debugging. In addition, registers can be local to a function or global to the entire shader; the latter will be used in ARB_shader_subroutine for passing parameters and getting return values from subroutines. Registers can also be an array, in which case they can be accessed indirectly. Each ALU instruction (add, subtract, etc.) works directly with registers or SSA values (see below). SSA ======== Everywhere a register can be loaded/stored, an SSA value can be used instead. The only exception is that arrays/indirect addressing are not supported with SSA; although research has been done on extensions of SSA to arrays before, it's usually for the purpose of parallelization (which we're not interested in), and adds some overhead in the form of adding copies or extra arrays (which is much more expensive than introducing copies between non-array registers). SSA uses point directly to their corresponding definition, which in turn points to the instruction it is part of. This creates an implicit use-def chain and avoids the need for an external structure for each SSA register. Functions ========= Support for function calls is mostly similar to GLSL IR. Each shader contains a list of functions, and each function has a list of overloads. Each overload contains a list of parameters, and may contain an implementation which specifies the variables that correspond to the parameters and return value. Inlining a function, assuming it has a single return point, is as simple as copying its instructions, registers, and local variables into the target function and then inserting copies to and from the new parameters as appropriate. After functions are inlined and any non-subroutine functions are deleted, parameters and return variables will be converted to global variables and then global registers. We don't do this lowering earlier (i.e. the fortranizer idea) for a few reasons: - If we want to do optimizations before link time, we need to have the function signature available during link-time. - If we do any inlining before link time, then we might wind up with the inlined function and the non-inlined function using the same global variables/registers which would preclude optimization. Intrinsics ========= Any operation (other than function calls and textures) which touches a variable or is not referentially transparent is represented by an intrinsic. Intrinsics are similar to the idea of a "builtin function," i.e. a function declaration whose implementation is provided by the backend, except they are more powerful in the following ways: - They can also load and store registers when appropriate, which limits the number of variables needed in later stages of the IR while obviating the need for a separate load/store variable instruction. - Intrinsics can be marked as side-effect free, which permits them to be treated like any other instruction when it comes to optimizations. This allows load intrinsics to be represented as intrinsics while still being optimized away by dead code elimination, common subexpression elimination, etc. Intrinsics are used for: - Atomic operations - Memory barriers - Subroutine calls - Geometry shader emitVertex and endPrimitive - Loading and storing variables (before lowering) - Loading and storing uniforms, shader inputs and outputs, etc (after lowering) - Copying variables (cases where in GLSL the destination is a structure or array) - The kitchen sink - ... Textures ========= Unfortunately, there are far too many texture operations to represent each one of them with an intrinsic, so there's a special texture instruction similar to the GLSL IR one. The biggest difference is that, while the texture instruction has a sampler dereference field used just like in GLSL IR, this gets lowered to a texture unit index (with a possible indirect offset) while the type information of the original sampler is kept around for backends. Also, all the non-constant sources are stored in a single array to make it easier for optimization passes to iterate over all the sources. Control Flow ========= Like in GLSL IR, control flow consists of a tree of "control flow nodes", which include if statements and loops, and jump instructions (break, continue, and return). Unlike GLSL IR, though, the leaves of the tree aren't statements but basic blocks. Each basic block also keeps track of its successors and predecessors, and function implementations keep track of the beginning basic block (the first basic block of the function) and the ending basic block (a fake basic block that every return statement points to). Together, these elements make up the control flow graph, in this case a redundant piece of information on top of the control flow tree that will be used by almost all the optimizations. There are helper functions to add and remove control flow nodes that also update the control flow graph, and so usually it doesn't need to be touched by passes that modify control flow nodes.