Ian Romanick d2a9ba03e3 Revert "nir: add late opt to turn inot/b2f combos back to bcsel" ... This reverts commit 7acc865226. With these optimizations in place, the extra constant folding added in the next commit extends some live ranges of 0.0 and ±1.0 constants, and that causes several hundred shaders to have more spills and fills. I believe this optimization we made basically irrelevant by 7725d60938 "intel/fs: Emit better code for b2f(inot(a)) and b2i(inot(a))". All Gen7.5+ platforms had similar results. (Ice Lake shown) total instructions in shared programs: 17225303 -> 17224634 (<.01%) instructions in affected programs: 879402 -> 878733 (-0.08%) helped: 679 HURT: 1 helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 helped stats (rel) min: 0.03% max: 0.93% x̄: 0.24% x̃: 0.05% HURT stats (abs) min: 10 max: 10 x̄: 10.00 x̃: 10 HURT stats (rel) min: 0.45% max: 0.45% x̄: 0.45% x̃: 0.45% 95% mean confidence interval for instructions value: -1.02 -0.95 95% mean confidence interval for instructions %-change: -0.26% -0.22% Instructions are helped. total cycles in shared programs: 360842595 -> 360828542 (<.01%) cycles in affected programs: 110443594 -> 110429541 (-0.01%) helped: 389 HURT: 265 helped stats (abs) min: 1 max: 7525 x̄: 162.81 x̃: 28 helped stats (rel) min: <.01% max: 18.66% x̄: 1.11% x̃: 0.11% HURT stats (abs) min: 1 max: 7614 x̄: 185.96 x̃: 48 HURT stats (rel) min: <.01% max: 25.08% x̄: 0.95% x̃: 0.10% 95% mean confidence interval for cycles value: -75.65 32.67 95% mean confidence interval for cycles %-change: -0.49% -0.06% Inconclusive result (value mean confidence interval includes 0). total spills in shared programs: 12159 -> 12161 (0.02%) spills in affected programs: 13 -> 15 (15.38%) helped: 0 HURT: 1 total fills in shared programs: 25207 -> 25208 (<.01%) fills in affected programs: 25 -> 26 (4.00%) helped: 0 HURT: 1 Ivy Bridge total instructions in shared programs: 12082019 -> 12082013 (<.01%) instructions in affected programs: 1033 -> 1027 (-0.58%) helped: 6 HURT: 0 helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 helped stats (rel) min: 0.41% max: 0.83% x̄: 0.61% x̃: 0.59% 95% mean confidence interval for instructions value: -1.00 -1.00 95% mean confidence interval for instructions %-change: -0.78% -0.45% Instructions are helped. total cycles in shared programs: 179849270 -> 179849157 (<.01%) cycles in affected programs: 4735 -> 4622 (-2.39%) helped: 4 HURT: 0 helped stats (abs) min: 2 max: 74 x̄: 28.25 x̃: 18 helped stats (rel) min: 0.13% max: 6.53% x̄: 2.85% x̃: 2.36% 95% mean confidence interval for cycles value: -82.73 26.23 95% mean confidence interval for cycles %-change: -7.98% 2.28% Inconclusive result (value mean confidence interval includes 0). Sandy Bridge total instructions in shared programs: 10882750 -> 10882748 (<.01%) instructions in affected programs: 266 -> 264 (-0.75%) helped: 2 HURT: 0 Iron Lake total cycles in shared programs: 188609440 -> 188609448 (<.01%) cycles in affected programs: 4320 -> 4328 (0.19%) helped: 0 HURT: 2 GM45 total cycles in shared programs: 129016868 -> 129016872 (<.01%) cycles in affected programs: 2302 -> 2306 (0.17%) helped: 0 HURT: 1 Reviewed-by: Matt Turner <mattst88@gmail.com>		2019-05-14 11:38:22 -07:00
..
glsl	glsl: s/GLboolean/bool/ to silence MSVC compiler warning	2019-05-08 10:05:41 -06:00
nir	Revert "nir: add late opt to turn inot/b2f combos back to bcsel"	2019-05-14 11:38:22 -07:00
spirv	spirv/cl: support vload/vstore	2019-05-04 12:27:51 +02:00
Android.glsl.gen.mk	mesa: android: Remove unnecessary dependency tracking rules	2019-05-06 11:29:25 +00:00
Android.glsl.mk	android: glsl: build shader cache sources	2017-02-20 16:30:37 +00:00
Android.mk	Android: glsl: add rules to generate ir_expression*.h header files	2016-09-06 15:58:55 +01:00
Android.nir.gen.mk	mesa: android: Remove unnecessary dependency tracking rules	2019-05-06 11:29:25 +00:00
Android.nir.mk	android: fix libmesa_nir build	2017-07-21 08:47:56 +03:00
blob.c	compiler/blob: Add blob_skip_bytes	2018-07-09 23:02:33 -07:00
blob.h	compiler/blob: Add blob_skip_bytes	2018-07-09 23:02:33 -07:00
builtin_type_macros.h	glsl_types: vec8/vec16 support	2018-03-25 10:42:54 -04:00
glsl_types.cpp	compiler/glsl: handle case where we have multiple users for types	2019-04-16 12:58:00 +03:00
glsl_types.h	compiler/glsl: handle case where we have multiple users for types	2019-04-16 12:58:00 +03:00
Makefile.sources	nir: implement lowering for fsin and fcos	2019-05-07 15:25:21 +00:00
meson.build	meson: Build with Python 3	2018-08-10 15:15:09 -07:00
nir_types.cpp	nir: fix a few signed/unsigned comparison warnings	2019-03-25 06:51:31 -06:00
nir_types.h	nir: move gls_type_get_{sampler,image}_count()	2019-03-21 09:13:05 -04:00
SConscript	spirv: Fix building with SCons	2018-03-30 14:33:03 -06:00
SConscript.glsl	scons: Generate float64_glsl.h for glsl_to_nir fp64 lowering	2019-03-02 14:33:44 -08:00
SConscript.nir	nir: mako all the intrinsics	2018-03-27 08:36:37 -04:00
SConscript.spirv	spirv: Fix building with SCons	2018-03-30 14:33:03 -06:00
shader_enums.c	compiler: rename SYSTEM_VALUE_VARYING_COORD	2019-04-25 14:13:31 -07:00
shader_enums.h	compiler: Add enums for blend state	2019-05-10 15:49:01 +00:00
shader_info.h	spirv: add missing SPV_EXT_descriptor_indexing capabilities	2019-04-30 09:22:45 +02:00