mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-21 08:58:10 +02:00
cc980ee0ed
Pandecode is not thread-safe (for a large number of reasons) and does not even try to be. This is a problem when tracing (or just using PAN_MESA_DEBUG=sync) multithreaded applications. The most common symptom of the problem are assertion failures deep in the red-black tree implementation, which is not thread-safe. Just protect the whole thing by a "in pandecode?" mutex, since this is not performance sensitive code and we don't really care about the extra serialization incurred. As pandecode does not recurse into itself, we may simply lock at the beginning and unlock at the end of each entrypoint in pandecode, which is thread-safe regardless of how pandecode is used. A few entrypoints are refactored to avoid early returns to keep the lock/unlock calls in obvious visual pairs. Fixes flakes when running the CL CTS with PAN_MESA_DEBUG=sync like we would in CI (e.g: events.event_flush) Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Tested-by: Icecream95 <ixn@disroot.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17409> |
||
|---|---|---|
| .. | ||
| genxml | ||
| tests | ||
| .gitignore | ||
| meson.build | ||
| pan_afbc.c | ||
| pan_attributes.c | ||
| pan_blend.c | ||
| pan_blend.h | ||
| pan_blitter.c | ||
| pan_blitter.h | ||
| pan_bo.c | ||
| pan_bo.h | ||
| pan_clear.c | ||
| pan_cs.c | ||
| pan_cs.h | ||
| pan_device.h | ||
| pan_encoder.h | ||
| pan_format.c | ||
| pan_format.h | ||
| pan_indirect_dispatch.c | ||
| pan_indirect_dispatch.h | ||
| pan_indirect_draw.c | ||
| pan_indirect_draw.h | ||
| pan_layout.c | ||
| pan_pool.h | ||
| pan_props.c | ||
| pan_samples.c | ||
| pan_scoreboard.h | ||
| pan_scratch.c | ||
| pan_shader.c | ||
| pan_shader.h | ||
| pan_texture.c | ||
| pan_texture.h | ||
| pan_tiler.c | ||
| pan_util.c | ||
| pan_util.h | ||
| wrap.h | ||