fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-22 21:48:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
mesa/src/mesa
History
Sergii Romantsov 1931c97a1d i965: leaking of upload-BO with push constants 
In case of any enabled VS members from: uses_firstvertex,
uses_baseinstance, uses_drawid, uses_is_indexed_draw
leaks may happens.
Call gen6_upload_push_constants allocates
stage_stat->push_const_bo. It than takes pointer from
push_const_bo to draw_params_bo (in the call
brw_prepare_shader_draw_parameters by brw_upload_data)
and do reference which finally haven't got unreferenced.

Fixes leak:
 136 bytes in 1 blocks are definitely lost in loss record 6 of 13
    at 0x4C31B25: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    by 0xC2B64B7: bo_alloc_internal (brw_bufmgr.c:596)
    by 0xC2B6748: brw_bo_alloc (brw_bufmgr.c:672)
    by 0xC314BB3: brw_upload_space (intel_upload.c:88)
    by 0xC2EBBC5: gen6_upload_push_constants (gen6_constant_state.c:155)
    by 0xC9E4FA6: gen9_upload_vs_push_constants (genX_state_upload.c:3300)
    by 0xC2E0EDA: check_and_emit_atom (brw_state_upload.c:540)
    by 0xC2E0EDA: brw_upload_pipeline_state (brw_state_upload.c:659)
    by 0xC2E0FF1: brw_upload_render_state (brw_state_upload.c:681)
    by 0xC2C5D2D: brw_draw_single_prim (brw_draw.c:1052)
    by 0xC2C62CB: brw_draw_prims (brw_draw.c:1175)
    by 0xC488AD1: vbo_exec_vtx_flush (vbo_exec_draw.c:386)
    by 0xC485270: vbo_exec_FlushVertices_internal (vbo_exec_api.c:652)

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reported-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Signed-off-by: Sergii Romantsov <sergii.romantsov@globallogic.com>
2019-06-25 12:26:25 +00:00
..
drivers i965: leaking of upload-BO with push constants 2019-06-25 12:26:25 +00:00
main glspirv: Call pass to lower frexp instructions 2019-06-19 22:07:57 -07:00
math mesa: include mtypes.h less 2018-04-12 19:31:30 -04:00
program glsl/types: Rename is_integer to is_integer_32 2019-06-19 20:28:52 +00:00
sparc tree-wide: remove trailing backslash 2017-06-07 01:18:09 +01:00
state_tracker st/nir: Use gl_nir_opt_access 2019-06-19 14:08:28 +02:00
swrast mesa: Replace MaxTextureLevels with MaxTextureSize. 2019-05-13 12:03:05 -07:00
swrast_setup mesa: replace VP/FP/ATIfs _Enabled flags with helper functions 2017-06-22 01:51:02 +02:00
tnl mesa: Factor out struct gl_vertex_format. 2018-11-21 06:27:19 +01:00
tnl_dd mesa: replace ctx->Polygon._FrontBit with a helper function 2017-06-22 01:51:02 +02:00
vbo Change a few frequented uses of DEBUG to !NDEBUG 2019-05-29 21:13:35 -04:00
x86 mesa: fix x86 builds 2018-04-13 22:13:46 +10:00
x86-64
Android.gen.mk mesa: Fix Android build 2017-06-28 14:41:45 -07:00
Android.libmesa_dricore.mk intel: compiler option msse2 and mstackrealign 2018-09-07 13:45:46 +01:00
Android.libmesa_git_sha1.mk git_sha1: simplify logic 2018-08-16 17:38:31 +01:00
Android.libmesa_glsl_utils.mk
Android.libmesa_sse41.mk intel: compiler option msse2 and mstackrealign 2018-09-07 13:45:46 +01:00
Android.libmesa_st_mesa.mk svga: fix git_sha1.h include path in Android.mk (v3) 2017-06-15 15:46:44 +01:00
Android.mesa_gen_matypes.mk
Android.mk svga: fix git_sha1.h include path in Android.mk (v3) 2017-06-15 15:46:44 +01:00
Makefile.sources st/mesa: move utility functions, macros into new st_util.h file 2019-03-11 20:08:16 -06:00
meson.build st/mesa: move utility functions, macros into new st_util.h file 2019-03-11 20:08:16 -06:00
SConscript scons: Remove gles option. 2018-10-19 16:50:26 +01:00