mesa/src/intel
Kenneth Graunke 8e45bd6365 brw: Fix try_rebuild_source's ult32/ushr handling to use unsigned types
We were accidentally doing a signed integer comparison here for ult32,
or a sign-extending shift for ushr.

One notable bit of fallout was that load_global_uniform_block_intel
address calculations broke on platforms that don't have native 64-bit
integer support, as the iadd64 lowering for "do I need to carry?" was
using ult32...and performing the wrong comparison.  We spotted this in
Borderlands 3 on Alchemist once we turned on other optimizations.

Thanks to Lionel Landwerlin for helping spot the problem!

Fixes: c7b312ad45 ("brw: factor out source extraction for rematerialization")
Fixes: 339630ab05 ("brw: enable A64 loads source rematerialization")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
(cherry picked from commit 5848035443)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32261>
2024-11-18 09:40:15 -08:00
..
blorp intel: Switch to COMPUTE_WALKER_BODY 2024-10-29 15:54:43 +00:00
ci anv: Access more colors in fast_clear_memory_range 2024-10-28 17:43:21 +00:00
common intel/measure: increase size of filename malloc to account for \0 2024-11-06 22:12:29 +00:00
compiler brw: Fix try_rebuild_source's ult32/ushr handling to use unsigned types 2024-11-18 09:40:15 -08:00
decoder intel/decoder: decode the 8 BLEND_STATEs 2024-09-25 12:51:07 +00:00
dev intel: Fix a typo in intel_device_info.c:has_get_tiling 2024-11-05 04:31:50 +01:00
ds intel/ds: add L3 fabric flush support 2024-10-08 08:45:40 +00:00
executor intel: Switch to COMPUTE_WALKER_BODY 2024-10-29 15:54:43 +00:00
genxml intel: Switch to COMPUTE_WALKER_BODY 2024-10-29 15:54:43 +00:00
isl intel/isl: Build for Xe3 2024-10-26 07:39:29 +00:00
nullhw-layer build: pass licensing information in SPDX form 2024-06-29 12:42:49 -07:00
perf intel/perf: Add INTEL_PERF_FEATURE_METRIC_SYNC and check if KMD supports it 2024-11-05 19:25:53 +00:00
shaders intel/shaders: Build for Xe3 2024-10-26 07:39:30 +00:00
tools intel/hang_replay: remove EXEC_OBJECT_WRITE 2024-10-04 21:37:41 +00:00
vulkan anv: fix incorrect aspect flag for depth/stencil formats 2024-11-18 09:40:12 -08:00
vulkan_hasvk intel/perf: Extend intel_perf_stream_set_metrics_id() to syncronize metrics id changes 2024-11-05 19:25:53 +00:00
meson.build intel: Add executor tool 2024-08-14 03:03:46 +00:00