mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-22 15:18:09 +02:00
8019a1b929
The condition !param->type->is_vector() || !param->type->is_scalar() alawys evaluates to true: * type is not scalar or vector -> true * type is vector, i.e. num_components > 1 -> num_components == 1 is false and !is_scalar() == true * type is scalar, i.e. num_components == 1 -> num_components > 1 is false and !is_vector() == true There is no comment explaining why such code has been written, therefore this seems to be a mistake. To maintain consistency with the surrounding code, glsl_type_is_scalar_or_vector has been used instead of replacing || with &&. Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24914> |
||
|---|---|---|
| .. | ||
| broadcom-rpi3-fails.txt | ||
| broadcom-rpi3-flakes.txt | ||
| broadcom-rpi3-skips.txt | ||
| broadcom-rpi4-fails.txt | ||
| broadcom-rpi4-flakes.txt | ||
| broadcom-rpi4-skips.txt | ||
| deqp-broadcom-rpi3.toml | ||
| deqp-broadcom-rpi4.toml | ||
| gitlab-ci.yml | ||
| traces-broadcom.yml | ||