mesa/src/broadcom
Iago Toral Quiroga 7e0616ecc5 v3dv: only flag 'shader writes point size' if the shader actually writes it
If the shader writes point size, then the compiler needs to ensure it
writes it in the appropriate vpm output slot and also clamp its value to
expected limits. This is why we have the per_vertex_point_size in the
shader key, so it doesn't really make sense to set this if the shader
doesn't write point size.

If the shader record flags that the shader writes point size then the
hardware will use the shader written value to override point size state
(set with the POINT_SIZE packet), so again, we really only want to set
this in the shader state record if the shader actually writes its value.

While we could also limit this to point primitives, since these are the
only primitives where point size has an effect, this is not really
required, and skipping this allows us to use the same shader with any
primitive type (otherwise we would have to compile 2 different shaders).

Finally, this change makes the vertex shader setup for point size match the
one we had been doing for geometry shaders, so it makes both stages behave
consistently regarding point size behavior.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29413>
2024-05-28 05:31:13 +00:00
..
ci v3dv/ci: Add more dEQP-VK subgroups that are currently skipped 2024-05-23 11:55:26 +02:00
cle broadcom/cle: fix up shader record for V3D 7.1.10 / 2712D0 2024-05-15 13:57:10 +00:00
clif broadcom: only support v42 and v71 2023-11-02 11:59:08 +01:00
common v3dv: V3D_CL_MAX_INSTR_SIZE bytes in last CL instruction not needed 2024-05-22 18:44:14 +00:00
compiler broadcom/compiler: check if vertex shader writes point size 2024-05-28 05:31:13 +00:00
drm-shim broadcom/compiler: remove include of gallium headers from meson.build 2023-12-12 10:03:11 +00:00
qpu broadcom/compiler: add new SFU instructions in V3D 7.x 2024-01-31 10:06:06 +00:00
simulator broadcom/simulator: Add DRM_IOCTL_V3D_GET_COUNTER to simulator 2024-05-22 05:37:48 +00:00
vulkan v3dv: only flag 'shader writes point size' if the shader actually writes it 2024-05-28 05:31:13 +00:00
.editorconfig
meson.build broadcom/common: Now "util/box.h" is under src, so remove the FIXME 2024-04-22 15:01:34 +00:00