mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-04-04 14:50:35 +02:00
6003a89b89
Otherwise we can have a case where binning VS uses more consts than full VS (when safe variant is used for full VS), that will result in a rendering issue because SP_VS_CONST_CONFIG.CONSTLEN is shared between full and binning VS in PROGRAM_CONFIG state and gets the value from the full VS. There are two alternative solutions that can allow binning VS to always use maximum constlen: - Move constlen emission to per-XS config. This interferes PROGRAM_CONFIG state which uploads consts and does SP_UPDATE_CNTL. Consts would need to be uploaded after constlen is defined, while SP_UPDATE_CNTL must be done before per-XS state is emitted. Also having SP_UPDATE_CNTL in a draw state that is always DIRTY isn't great. Something didn't work out on A6XX, so this idea was dropped. - Emit constlen again in VS_BINNING draw state. This seem to work but also likely an undefined behaviour since constlen is changed after some consts are uploaded. Cc: mesa-stable Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36203> |
||
|---|---|---|
| .. | ||
| amd | ||
| android_stub | ||
| asahi | ||
| broadcom | ||
| c11 | ||
| compiler | ||
| drm-shim | ||
| egl | ||
| etnaviv | ||
| freedreno | ||
| gallium | ||
| gbm | ||
| getopt | ||
| gfxstream | ||
| glx | ||
| gtest | ||
| imagination | ||
| imgui | ||
| intel | ||
| loader | ||
| mapi | ||
| mesa | ||
| microsoft | ||
| nouveau | ||
| panfrost | ||
| tool | ||
| util | ||
| virtio | ||
| vulkan | ||
| x11 | ||
| .clang-format | ||
| meson.build | ||