mesa/src
Ian Romanick 55d80bc20a intel/compiler: Don't predicate a WHILE if there is a CONT
Previously a predicated BREAK that appeared immediately before the WHILE
would get merged into the WHILE.  This doesn't work if other flow
control (e.g., a CONT) can transfer directly to the WHILE.

On Intel platforms, this fixes the CTS test
dEQP-VK.graphicsfuzz.stable-binarysearch-tree-nested-if-and-conditional.

No shader-db changes on any Intel platform.

When this commit was first created (over a month before it is going to
land), there were some regressions that were prevented by other commits
in MR !13095.  That does not appear to be the case now, so I don't know
what changed.  Basically, the treatment of discard as a combination of
demote and terminate causes additional continues in some loops, and
those continues trigger this bug.  The other commits from that MR
prevent those continues from being generated in the first place.

All Intel platforms had simlar fossil-db results. (Ice Lake shown)
Instructions in all programs: 144419989 -> 144419995 (+0.0%)
SENDs in all programs: 6947332 -> 6947332 (+0.0%)
Loops in all programs: 38277 -> 38277 (+0.0%)
Spills in all programs: 204075 -> 204075 (+0.0%)
Fills in all programs: 319480 -> 319480 (+0.0%)

A few shaders in Doom 2016 were hurt by one instruction each.  It seems
likely that these shaders would have experienced at least some
mis-rendering.

Closes: #4213
Fixes: d13bcdb3a9 ("i965/fs: Extend predicated break pass to predicate WHILE.")
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14128>
(cherry picked from commit 4563261ad1)
2021-12-17 22:30:49 +00:00
..
amd aco: don't create DPP instructions with SGPR operands 2021-12-01 18:55:48 +00:00
android_stub android_stub: update platform headers to include atrace 2021-10-09 00:42:32 +00:00
asahi nir: add indirect loop unrolling to compiler options 2021-08-03 10:54:50 +00:00
broadcom v3dv: Fix dEQP-VK.info#instance_extensions test 2021-12-17 22:30:49 +00:00
compiler nir/lower_io: include the variable access in the lowered intrinsic 2021-12-17 22:30:49 +00:00
drm-shim drm-shim: Support kernels with >4k pages 2021-08-13 23:33:52 +00:00
egl egl/wayland: Properly clear stale buffers on resize 2021-10-20 20:40:58 +01:00
etnaviv ci/deqp-runner: Rename the deqp-drivername-*.txt files to drivername-*.txt 2021-11-10 21:57:57 +00:00
freedreno ir3/lower_pcopy: Fix bug with "illegal" copies and swaps 2021-12-01 18:55:47 +00:00
gallium lima: disasm: use last argument as a filename 2021-12-01 18:55:48 +00:00
gbm gbm: Don't pass default usage flags on ABIs < 1 2021-12-17 22:30:49 +00:00
getopt
glx glx/dri3: fix glXQueryContext does not return GLX_RENDER_TYPE value 2021-12-01 18:55:46 +00:00
gtest
hgl
imgui
intel intel/compiler: Don't predicate a WHILE if there is a CONT 2021-12-17 22:30:49 +00:00
loader loader/dri3: fix swap out of order when changing swap interval 2021-09-30 03:27:14 +00:00
mapi mesa: GL_ARB_ES3_2_compatibility GL compat profile support 2021-09-23 11:10:23 +00:00
mesa mesa: fix buffer overrun in SavedObj texture obj array 2021-11-17 20:06:21 +00:00
microsoft microsoft/spirv_to_dxil: turn sysvals into input varyings 2021-10-27 19:58:10 +01:00
nouveau
panfrost panfrost: Don't shadow Mesa's fui() 2021-12-17 22:30:49 +00:00
tool pps: Panfrost pps driver 2021-07-13 11:03:55 +00:00
util util/u_trace: refcount payloads 2021-12-01 18:55:47 +00:00
virtio venus: Use the common WSI wrappers 2021-10-13 00:06:15 +00:00
vulkan vulkan-device-select: Don't leak drmDevicePtr 2021-12-17 22:30:49 +00:00
meson.build radv: Allow building when LLVM isn’t enabled 2021-10-01 10:40:18 +02:00