mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-17 22:38:06 +02:00
03d1de387e
Context: _mesa_add_parameter is sometimes[0] called with a NULL name as a mean of an unnamed parameter. Allowing NULL pointer as a name means that it must be NULL checked each access. So far it isn't always[1] true. Parameter name is only used for debug purpose (printf) and to lookup the index/location of the program by the application. Conclusion, there is no valid reason to use a NULL pointer instead of an empty string. So it was decided to use an empty string which avoid all issues related to NULL pointer [0]: texture gather offsets glsl opcode and st_init_atifs_prog [1]: at least shader cache, st_nir_lookup_parameter_index and some printfs Issue found by piglit 'texturegatheroffsets' tests on Nouveau v4: new patch based on Nicolai/Timothy/ilia discussion Signed-off-by: Gregory Hainaut <gregory.hainaut@gmail.com> Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> |
||
|---|---|---|
| .. | ||
| drivers | ||
| main | ||
| math | ||
| program | ||
| sparc | ||
| state_tracker | ||
| swrast | ||
| swrast_setup | ||
| tnl | ||
| tnl_dd | ||
| vbo | ||
| x86 | ||
| x86-64 | ||
| .gitignore | ||
| Android.gen.mk | ||
| Android.libmesa_dricore.mk | ||
| Android.libmesa_glsl_utils.mk | ||
| Android.libmesa_sse41.mk | ||
| Android.libmesa_st_mesa.mk | ||
| Android.mesa_gen_matypes.mk | ||
| Android.mk | ||
| gl.pc.in | ||
| Makefile.am | ||
| Makefile.sources | ||
| SConscript | ||