mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-17 13:58:05 +02:00
db371633e6
panfrost_invert_swizzle produces a (one-sided) inverse, that is a function g such that g(f(x)) = x. However, it is actually used in some cases where we want a two-sided inverse, where we also have f(g(x)) = x. An example is its use to pre-swizzle border color values so that a later pass will un-swizzle them. If the swizzle is not one-to-one this two sided inverse does not exist. However, we can do better than the original code, e.g. for an RRR1 swizzle inverse produced was originally B000, which when applied on the wrong side results in BBB1 as output, whereas R000 would produce the desired RRR1 output. Using the first valid component we see, rather than the last one, is thus usually better. The "correct" solution is to re-write all the code that uses an inverse to handle non-unique inverses. But frankly these uses only crop up in fairly niche cases like tests, and it's probably not worth spending a lot of effort to deal with these edge cases when this patch fixes most of them. Fixes some failing piglit ext_framebuffer_multisample tests. Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31060> |
||
|---|---|---|
| .. | ||
| deqp-panfrost-g52-vk.toml | ||
| deqp-panfrost-g52.toml | ||
| deqp-panfrost-g57.toml | ||
| deqp-panfrost-g72.toml | ||
| deqp-panfrost-g610.toml | ||
| deqp-panfrost-t720.toml | ||
| deqp-panfrost-t760.toml | ||
| deqp-panfrost-t860-egl.toml | ||
| deqp-panfrost-t860.toml | ||
| gitlab-ci.yml | ||
| panfrost-g52-fails.txt | ||
| panfrost-g52-flakes.txt | ||
| panfrost-g52-skips.txt | ||
| panfrost-g57-fails.txt | ||
| panfrost-g57-flakes.txt | ||
| panfrost-g57-skips.txt | ||
| panfrost-g72-fails.txt | ||
| panfrost-g72-flakes.txt | ||
| panfrost-t720-fails.txt | ||
| panfrost-t720-flakes.txt | ||
| panfrost-t720-skips.txt | ||
| panfrost-t760-fails.txt | ||
| panfrost-t760-flakes.txt | ||
| panfrost-t760-skips.txt | ||
| panfrost-t820-fails.txt | ||
| panfrost-t860-fails.txt | ||
| panfrost-t860-flakes.txt | ||
| panfrost-t860-skips.txt | ||
| traces-panfrost.yml | ||