Iago Toral Quiroga
d8a3473cf3
v3dv: add a v3dv_job_allocate_tile_state helper
...
If we enable double-buffer we are reducing the tile size, and thus,
we'll need more tiles and a larger tile state allocation, so we'll
need to call to this helper.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17854 >
2022-08-15 23:35:16 +00:00
Iago Toral Quiroga
3ab6eceac0
v3dv: fix tile state allocation
...
If we had decided that we only need one layer worth of tile state
we should actually only allocate one layer.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17854 >
2022-08-15 23:35:16 +00:00
Iago Toral Quiroga
5da4f5fe8d
v3dv: track if a job is compatible with double-buffer mode
...
MSAA is not compatible with double-buffer mode. Also, jobs that emit
tile loads or that don't have any stores can't take advantage
of double-buffer mode.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17854 >
2022-08-15 23:35:16 +00:00
Iago Toral Quiroga
9dcf0dd51f
v3dv: move check_needs_load/store helpers to unversioned code
...
These helpers don't depend on the V3D version and we are going
to need them outside v3dvx_cmd_buffer.c soon.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17854 >
2022-08-15 23:35:16 +00:00
Iago Toral Quiroga
87a9951073
broadcom/compiler: track number of TMU operations in prog data
...
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17854 >
2022-08-15 23:35:16 +00:00
Eric Engestrom
aa018415b3
docs/features: drop unsupported VK_KHR_display & VK_KHR_get_display_properties2 for lavapipe
...
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17796 >
2022-08-15 21:47:11 +00:00
Eric Engestrom
8f7d7d5fab
docs/features: start tracking extensions supported by powervr
...
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17796 >
2022-08-15 21:47:11 +00:00
Eric Engestrom
5e32ba0f7d
docs/features: start tracking extensions supported by panvk
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17796 >
2022-08-15 21:47:11 +00:00
Eric Engestrom
420aba38c5
docs/features: start tracking extensions supported by dozen
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6330
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17796 >
2022-08-15 21:47:11 +00:00
Eric Engestrom
11ecf94911
docs/features: add missing extensions supported by venus
...
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17796 >
2022-08-15 21:47:11 +00:00
Eric Engestrom
1fdbd98820
docs/features: add missing extensions supported by turnip
...
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17796 >
2022-08-15 21:47:11 +00:00
Eric Engestrom
53fd6434f6
docs/features: add missing extensions supported by radv
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17796 >
2022-08-15 21:47:11 +00:00
Eric Engestrom
9d7f4dd1e9
docs/features: add missing extensions supported by lavapipe
...
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17796 >
2022-08-15 21:47:11 +00:00
Eric Engestrom
da60522ed0
docs/features: add missing extensions supported by anv
...
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17796 >
2022-08-15 21:47:11 +00:00
Chia-I Wu
4f143a691a
turnip: handle fence wrapping in autotune
...
fence values can be 0 after wrapping. We should not treat 0 specially.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18040 >
2022-08-15 19:44:37 +00:00
Chia-I Wu
e40eae2ea9
turnip: remove unused member in tu_submission_data
...
buffers_count is set but unused.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18040 >
2022-08-15 19:44:37 +00:00
Chia-I Wu
b8a916fd0c
turnip: fix a use-after-free in autotune
...
When removing old histories, check against gpu fence. Otherwise,
pending_results could have dangling pointers to the removed histories.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7055
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18040 >
2022-08-15 19:44:37 +00:00
Mike Blumenkrantz
62b3e75e4c
zink: use a maybe more accurate wild guess for pcp-less gpl
...
this is only reachable with an env var, so being wrong is still okay,
but maybe be right slightly more often
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17955 >
2022-08-15 14:58:37 +00:00
Mike Blumenkrantz
85165a246c
zink: (correctly) require extendedDynamicState2PatchControlPoints for GPL
...
this is otherwise broken
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17955 >
2022-08-15 14:58:37 +00:00
Mike Blumenkrantz
c261179e14
zink: require EXT_non_seamless_cube_map for GPL support
...
it's impossible to precompile without this
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17955 >
2022-08-15 14:58:37 +00:00
Yonggang Luo
4579b702f6
c11: Remove mtx_try from mtx enums as it's not a part of c11 standard
...
And we support for four types of mtx init enum values that define by C11 standard:
0 mtx_plain - a simple, non-recursive mutex is created.
2 mtx_timed - a non-recursive mutex, that supports timeout, is created.
1 mtx_plain | mtx_recursive - a recursive mutex is created.
3 mtx_timed | mtx_recursive - a recursive mutex, that supports timeout, is created.
musl library also use these enum combination
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18036 >
2022-08-15 14:40:52 +00:00
Georg Lehmann
7b9d3ebe42
aco: Use v_cmpx pre GFX10.
...
Foz-DB Vega10:
Totals from 29508 (21.85% of 135041) affected shaders:
CodeSize: 184345656 -> 184345820 (+0.00%)
Instrs: 35906154 -> 35906195 (+0.00%)
Latency: 581696114 -> 581530021 (-0.03%); split: -0.03%, +0.00%
InvThroughput: 245625572 -> 245561351 (-0.03%); split: -0.03%, +0.00%
Copies: 3134925 -> 3278672 (+4.59%)
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18049 >
2022-08-15 13:25:38 +00:00
Georg Lehmann
393e577435
aco/assembler: Fix v_cmpx pre GFX10.
...
The second destination is implicit exec.
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18049 >
2022-08-15 13:25:38 +00:00
Georg Lehmann
410eff4d2f
aco: Fix optimizing branching sequence with s_and_saveexec.
...
This optimization was broken for two reasons:
- s_and_saveexec has two operands, the copy value and exec
- s_and_saveexec has an exec read, so exec_write_used will always be true
before we find branch_exec_val_idx
Foz-DB Navi21:
Totals from 31453 (23.31% of 134913) affected shaders:
CodeSize: 204831260 -> 204831156 (-0.00%)
Instrs: 38157117 -> 38157091 (-0.00%)
Latency: 533708882 -> 531211721 (-0.47%); split: -0.47%, +0.00%
InvThroughput: 107088408 -> 106719188 (-0.34%); split: -0.35%, +0.00%
Copies: 2326179 -> 2502490 (+7.58%)
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18049 >
2022-08-15 13:25:38 +00:00
Georg Lehmann
5ffc73896f
aco/assembler: Fix v_cmpx with SDWA.
...
We need to use the implicit destination.
Fixes: baab6f18c9 ("aco: Optimize branching sequence during SSA elimination.")
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18049 >
2022-08-15 13:25:38 +00:00
Georg Lehmann
9e5f311efe
aco: Check that we don't override exec_val operands during branching sequence optimization.
...
Fixes: baab6f18c9 ("aco: Optimize branching sequence during SSA elimination.")
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18049 >
2022-08-15 13:25:38 +00:00
Timur Kristóf
baf314e2c0
aco: Check for instructions that inhibit the branching sequence optimization.
...
Fixes: baab6f18c9 ("aco: Optimize branching sequence during SSA elimination.")
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18049 >
2022-08-15 13:25:38 +00:00
Timur Kristóf
d88b2e4ab5
aco: Fix invalidated reference in branching sequence optimization.
...
Inserting in the instructions vector may invalidate the exec_val reference,
so do that last.
Fixes: baab6f18c9 ("aco: Optimize branching sequence during SSA elimination.")
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18049 >
2022-08-15 13:25:38 +00:00
David Heidelberg
2e9044766e
ci: do not install i386 sub-architecture in VK images
...
Not required by apitrace.
debian/x86_test-vk image size:
previous: 1.8G
after: 1.0G
v2: added back winehq-stable (missing symlinks)
Acked-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17834 >
2022-08-15 12:18:41 +00:00
David Heidelberg
cdd508dddd
ci: use apt-get in x86_test-vk instead of apt
...
apt shouldn't be used in CI, see:
https://unix.stackexchange.com/questions/590699/should-i-use-apt-or-apt-get-in-shell-scripting
Acked-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17834 >
2022-08-15 12:18:41 +00:00
Tomeu Vizoso
ba518a31ac
ci: Report failures to GitLab for LAVA jobs
...
We were uploading the junit.xml to the artifacts, but weren't telling
GitLab about it.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18028 >
2022-08-15 11:40:19 +02:00
Tomeu Vizoso
477412f303
iris/ci: Set FDO_CI_CONCURRENT for all Chromebook jobs
...
For some reason we were missing these and that was causing some CPUs to
remain idle, and some boards to have too high load and some tests timing
out occasionally.
Set FDO_CI_CONCURRENT for the number of cores, plus one to account for
GPU and I/O waits.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18028 >
2022-08-15 11:40:16 +02:00
Tomeu Vizoso
1bdcf5c099
iris/ci: Test on Jasper Lake Chromebooks
...
8 such boards have been added to Collabora's lab, let's run all tests
from the selected set.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18028 >
2022-08-15 11:40:12 +02:00
Qiang Yu
84956286a8
nir/lower_gs_intrinsics: fix primitive count for points
...
When primitive is points, EndPrimitive can't be used to count
primitive. Need to use vertex count instead. And it's also not
needed to do vertex per primitive count and overwrite incomplete
primitive work for points.
Fixes: 2be99012e9 ("nir: Add ability to count emitted GS primitives.")
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17805 >
2022-08-15 01:39:28 +00:00
Mike Blumenkrantz
b88c3d5bd3
zink: fix program cache comparisons
...
I missed this when pipe shader types were merged with mesa types
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 20:11:48 -04:00
Mike Blumenkrantz
6ac64fcb6b
zink: delete zink_shader_stage()
...
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:05 -04:00
Mike Blumenkrantz
b988b8c84b
zink: remove all pipe_shader_type usage
...
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:05 -04:00
Mike Blumenkrantz
2792d2bd4a
zink: PIPE_SHADER_TYPES -> MESA_SHADER_STAGES
...
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:05 -04:00
Mike Blumenkrantz
fc657f8c07
zink: explicitly define ZINK_GFX_SHADER_COUNT
...
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00
Mike Blumenkrantz
7040745060
zink: ZINK_SHADER_COUNT -> ZINK_GFX_SHADER_COUNT
...
more descriptive
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00
Mike Blumenkrantz
89daf988bc
zink: use statically sized array for descriptor allocation
...
this will never be more than 100
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00
Mike Blumenkrantz
2ca46b66c3
zink: rename _lazy descriptor stuff
...
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00
Mike Blumenkrantz
48cb86d487
zink: reorder some descriptor structs
...
should yield slightly better packing
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00
Mike Blumenkrantz
e373f97804
zink: merge batch descriptor data onto batch state
...
also clean up some related descriptor code
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00
Mike Blumenkrantz
2c281b7ccd
zink: merge program descriptor data onto program struct
...
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00
Mike Blumenkrantz
f24c7bdef8
zink: merge context descriptor data onto context struct
...
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00
Mike Blumenkrantz
5512b15863
zink: merge batch descriptor data structs
...
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00
Mike Blumenkrantz
9938067287
zink: merge context descriptor data structs
...
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00
Mike Blumenkrantz
b25d8850f0
zink: remove descriptor dummy_set
...
while well-intentioned, this didn't actually do anything
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00
Mike Blumenkrantz
8c8fb47f6b
zink: delete some unused descriptor struct members
...
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051 >
2022-08-14 18:38:04 -04:00