fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-04 22:49:13 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2
207639 commits 66 branches 933 tags 962 MiB
Commit graph

207639 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ian Romanick
b83f618fb2 brw: Fully write temporary destinations
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details 
Consider an innocuous instruction like:

    and(1) v250:UD, g0.3<0,1,0>:UD, 4294967264u NoMask group0

If register allocation decides to spill v250, it will see this
instruction and say, "Oh no! The other components of v250 aren't set, so
I'd better add a fill before that instruction!"

But it gets even worse than that... if register coalesce decided to
merge two of these, the live range gets massively extended because the
writes don't fully initialize the value. This causes the need to spill
these registers in the first place.

Changing that instruction to SIMD16 on Xe2 or SIMD8 on other platforms
alleviates these issues.

shader-db:

Lunar Lake
total instructions in shared programs: 17118324 -> 17113191 (-0.03%)
instructions in affected programs: 93701 -> 88568 (-5.48%)
helped: 42 / HURT: 6

total cycles in shared programs: 895422566 -> 895079488 (-0.04%)
cycles in affected programs: 30111338 -> 29768260 (-1.14%)
helped: 35 / HURT: 40

total spills in shared programs: 3588 -> 3304 (-7.92%)
spills in affected programs: 285 -> 1 (-99.65%)
helped: 10 / HURT: 0

total fills in shared programs: 2218 -> 1663 (-25.02%)
fills in affected programs: 556 -> 1 (-99.82%)
helped: 10 / HURT: 0

Meteor Lake, DG2, Tiger Lake, and Ice Lake had similar results.  (Meteor Lake shown)
total instructions in shared programs: 20059218 -> 20053563 (-0.03%)
instructions in affected programs: 96938 -> 91283 (-5.83%)
helped: 43 / HURT: 6

total cycles in shared programs: 884174588 -> 883536475 (-0.07%)
cycles in affected programs: 22105268 -> 21467155 (-2.89%)
helped: 35 / HURT: 27

total spills in shared programs: 5032 -> 4679 (-7.02%)
spills in affected programs: 355 -> 2 (-99.44%)
helped: 12 / HURT: 0

total fills in shared programs: 4782 -> 4113 (-13.99%)
fills in affected programs: 671 -> 2 (-99.70%)
helped: 12 / HURT: 0

Skylake
total instructions in shared programs: 19097658 -> 19097665 (<.01%)
instructions in affected programs: 14202 -> 14209 (0.05%)
helped: 0 / HURT: 5

total cycles in shared programs: 862058109 -> 862058267 (<.01%)
cycles in affected programs: 3450244 -> 3450402 (<.01%)
helped: 7 / HURT: 11

fossil-db:

Lunar Lake
Totals:
Cycle count: 31439652246 -> 31439652272 (+0.00%)

Totals from 2 (0.00% of 707091) affected shaders:
Cycle count: 2602 -> 2628 (+1.00%)

No other Intel platforms had any fossil-db changes.

Reviewed-by: Matt Turner <mattst88@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35721>
 2025-06-26 17:59:47 +00:00
Gurchetan Singh
8a2f43c9bd util: rust: update to rustix 1.0.7 
Latest tagged release.  Fedora uses it, and for it to
work on Android we'll need to latest release so a pure
libc backend can be used.

Reviewed-by: Marcin Radomski <dextero@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35768>
 2025-06-26 17:11:41 +00:00
Serdar Kocdemir
5fbb3817ba gfxstream: Small optimization on transformDescriptorSetList 
Reduce number of possible allocations and remove unnecessary
memory initialization which will be overwritten immediately.

Test: dEQP-GLES31.functional.ssbo.layout.*

Reviewed-by: Marcin Radomski <dextero@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35768>
 2025-06-26 17:11:41 +00:00
Albert Liu
dce282e7d9 gfxstream: Add VK_EXT_memory_budget to allowlists. (mesa3d side) 
Codegen change.

Reviewed-by: Marcin Radomski <dextero@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35768>
 2025-06-26 17:11:41 +00:00
Alyssa Rosenzweig
194c717e04 agx: optimize sign fix ups 
Totals from 1787 (3.33% of 53701) affected shaders:
MaxWaves: 1620160 -> 1620096 (-0.00%); split: +0.01%, -0.01%
Instrs: 2036003 -> 2033382 (-0.13%); split: -0.16%, +0.04%
CodeSize: 13988944 -> 13971384 (-0.13%); split: -0.17%, +0.05%
Spills: 5505 -> 5504 (-0.02%)
ALU: 1514305 -> 1511676 (-0.17%); split: -0.22%, +0.05%
FSCIB: 1514305 -> 1511676 (-0.17%); split: -0.22%, +0.05%
GPRs: 200723 -> 200779 (+0.03%); split: -0.06%, +0.09%
Uniforms: 642921 -> 645743 (+0.44%); split: -0.00%, +0.44%

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35720>
 2025-06-26 16:41:55 +00:00
Alyssa Rosenzweig
6efe557718 nir/search_helpers: add has_multiple_uses helper 
heuristic for the next patch.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Mel Henning <mhenning@darkrefraction.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35720>
 2025-06-26 16:41:55 +00:00
Alyssa Rosenzweig
22272c71f2 hk: use new path for !soft fault UBO 
this is more efficient for !soft fault and lets us drop a code path. i've been
running fossils without soft fault since dev machine so that's what these stats
are based on.

Totals from 11799 (22.22% of 53090) affected shaders:
MaxWaves: 11472896 -> 11467200 (-0.05%); split: +0.09%, -0.14%
Instrs: 7032360 -> 6603558 (-6.10%); split: -6.11%, +0.02%
CodeSize: 49902322 -> 48693876 (-2.42%); split: -2.95%, +0.52%
Spills: 2817 -> 2846 (+1.03%); split: -5.75%, +6.78%
Fills: 2911 -> 3143 (+7.97%); split: -2.37%, +10.34%
Scratch: 10896 -> 11020 (+1.14%); split: -1.95%, +3.08%
ALU: 5092487 -> 5265337 (+3.39%); split: -0.58%, +3.97%
FSCIB: 5092487 -> 5265333 (+3.39%); split: -0.58%, +3.97%
IC: 1461194 -> 1387408 (-5.05%); split: -5.22%, +0.17%
GPRs: 803121 -> 805414 (+0.29%); split: -0.80%, +1.08%
Uniforms: 2942007 -> 2247619 (-23.60%); split: -24.35%, +0.75%

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35720>
 2025-06-26 16:41:55 +00:00
Alyssa Rosenzweig
63ce73a601 nir,hk: sink lowered UBOs 
this is better than doing it once we've lowered to hardware ops which makes it
more challenging to sink since then we'd have to sink the whole tree instead of
a single intrinsic.

Totals from 17617 (32.81% of 53701) affected shaders:
MaxWaves: 16863872 -> 16901504 (+0.22%); split: +0.24%, -0.02%
Instrs: 12406405 -> 12430375 (+0.19%); split: -0.15%, +0.35%
CodeSize: 87055248 -> 87180802 (+0.14%); split: -0.18%, +0.33%
Spills: 10350 -> 9301 (-10.14%); split: -11.57%, +1.43%
Fills: 5215 -> 3733 (-28.42%); split: -31.49%, +3.07%
Scratch: 113164 -> 110472 (-2.38%); split: -2.63%, +0.25%
ALU: 9552550 -> 9558513 (+0.06%); split: -0.22%, +0.28%
FSCIB: 9552545 -> 9558508 (+0.06%); split: -0.22%, +0.28%
IC: 2874032 -> 2876442 (+0.08%); split: -0.00%, +0.09%
GPRs: 1470040 -> 1459283 (-0.73%); split: -1.00%, +0.27%
Uniforms: 5113254 -> 5115158 (+0.04%); split: -0.82%, +0.85%

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Job Noorman <job@noorman.info> [NIR]
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35720>
 2025-06-26 16:41:55 +00:00
Alyssa Rosenzweig
d17dd8332e hk: sink SSBO loads 
Seems to hit instr count due to RA lottery but reduce reg pressure a LOT so,
probably worth it.

Totals from 5305 (9.88% of 53701) affected shaders:
MaxWaves: 4487168 -> 4551040 (+1.42%); split: +1.51%, -0.09%
Instrs: 6063323 -> 6178678 (+1.90%); split: -0.17%, +2.07%
CodeSize: 44356516 -> 44662024 (+0.69%); split: -0.21%, +0.90%
Spills: 7321 -> 4034 (-44.90%); split: -45.49%, +0.59%
Fills: 8522 -> 5069 (-40.52%); split: -40.87%, +0.35%
Scratch: 21940 -> 9856 (-55.08%); split: -55.17%, +0.09%
ALU: 4541440 -> 4554906 (+0.30%); split: -0.20%, +0.50%
FSCIB: 4541440 -> 4554906 (+0.30%); split: -0.20%, +0.50%
IC: 1180150 -> 1184856 (+0.40%); split: -0.01%, +0.41%
GPRs: 605023 -> 576336 (-4.74%); split: -5.00%, +0.26%
Uniforms: 1421832 -> 1425367 (+0.25%); split: -0.08%, +0.33%

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35720>
 2025-06-26 16:41:55 +00:00
Alyssa Rosenzweig
776f07517f hk: optimize load_global_bounded 
Totals from 5967 (11.24% of 53090) affected shaders:
MaxWaves: 5044864 -> 5126720 (+1.62%); split: +1.95%, -0.32%
Instrs: 6911845 -> 6227557 (-9.90%); split: -9.96%, +0.06%
CodeSize: 46353592 -> 45359410 (-2.14%); split: -4.41%, +2.27%
Spills: 18002 -> 7046 (-60.86%); split: -63.22%, +2.36%
Fills: 15833 -> 8074 (-49.01%); split: -54.59%, +5.58%
Scratch: 52160 -> 23324 (-55.28%); split: -58.32%, +3.04%
ALU: 4235569 -> 4602546 (+8.66%); split: -1.79%, +10.45%
FSCIB: 4235364 -> 4602341 (+8.66%); split: -1.79%, +10.45%
IC: 1261552 -> 1253110 (-0.67%); split: -4.33%, +3.66%
GPRs: 664060 -> 640627 (-3.53%); split: -4.69%, +1.16%
Uniforms: 1568288 -> 1505664 (-3.99%); split: -10.88%, +6.89%
Loops: 4669 -> 4670 (+0.02%)

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35720>
 2025-06-26 16:41:54 +00:00
Alyssa Rosenzweig
caa0854da8 nir: plumb load_global_bounded 
this lets the backend implement bounded loads (i.e. robust SSBOs) in a way
that's more clever than a full branch. similar idea to
load_global_constant_bound which should eventually be merged into this.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Job Noorman <job@noorman.info>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35720>
 2025-06-26 16:41:53 +00:00
Dave Airlie
37e71a5cb2 radv/video: add support for AV1 encoding
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details 
Co-authored-by: Charlie Turner <cturner@igalia.com>
Co-authored-by: Benjamin Cheng <benjamin.cheng@amd.com>
Co-authored-by: David Rosca <david.rosca@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32440>
 2025-06-26 15:41:01 +00:00
Dave Airlie
724655bfc6 vulkan/video: add support for AV1 encoding to runtime 
Co-authored-by: Charlie Turner <cturner@igalia.com>
Co-authored-by: Benjamin Cheng <benjamin.cheng@amd.com>
Co-authored-by: David Rosca <david.rosca@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32440>
 2025-06-26 15:41:01 +00:00
David Rosca
ac935c18b2 vulkan/video: Add bit depth to session and session params 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32440>
 2025-06-26 15:41:01 +00:00
Dave Airlie
ee9ec055d9 radv/video: move session defines to header as encode needs more. 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32440>
 2025-06-26 15:41:01 +00:00
Dylan Baker
dd45e25dc3 meson: update b_sanitize check for Meson >= 1.8 
In Meson 1.8 the b_sanitize option was changed from an enumerated set of
known sanitizers to an array of options to test with `-fsanitize`, this
means that the thread sanitizer could be used in conjunction with one
or more other sanitizers and we need to account for this. Use
`.contains()` to check if `thread` is in the sanitizer list

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35747>
 2025-06-26 14:59:27 +00:00
Mike Blumenkrantz
5cfaa6cd5f zink: use smaller keys for surface/bufferview caching and switch to sets 
this should be a bit more efficient

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
9ac256645e zink: use samplerview obj to check buffer rebinds in non-db path 
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
c88cc5d135 zink: unify bvci creation 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
3517ad1432 zink: remove redundant pipe_resource param from zink surface funcs 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
5cf6cb1c6d zink: enforce pipe_surface::texture matching the resource in zink_get_surface() 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
ef3f798957 zink: prune zink_surface down to the imageview and create/fetch on demand 
this eliminates all pipe_surface allocations

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
309710c260 zink: various trivial struct access changes 
ideally no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
b8108d0e7a zink: use temp struct for implicit feedback loop detection 
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
9197de066c zink: add layer info to bindless descriptor 
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
daa07aba98 zink: directly return import2d resource 
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
ed325d9309 zink: directly use imageview format for image descriptors for depth clamping 
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
21fbe0f893 zink: track whether fb has swapchain bound on context 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
defc3dfa79 zink: use a better check for current fb zsbuf in zink_clear_depth_stencil() 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
76e2b61a2f zink: delete/simplify some bindless descriptor resource accesss 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
8805afd291 zink: delete zink_surface::ivci 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
a9c928954e zink: allocate keys for surface cache to stop using zink_surface::ivci 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
b3c02d2bca zink: store/use fb attachment formats directly 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
b177136c56 zink: tweak zink_create_transient_surface to stop using zink_surface::ivci 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
35cd9f663b zink: break out fb ivci init 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
25441082d9 zink: big resource view rework 
* move/unify the cache onto zink_resource_object to streamline rebinds
* delete refcounts from surfaces and bufferviews
* only delete surfaces and bufferviews when owner object is destroyed
* cache swapchain surfaces onto the swapchain image

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
8eb5f272f2 zink: remove some usage of zink_surface::ivci 
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
b030b20d72 zink: unify some z24 sampler clamping code 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
74cf4f4efc zink: remove random format check in surface create 
not sure why this was here

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
efcd6c11d9 zink: delete some redundant flagging of ctx->rp_changed 
this already happens during unbind

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
635f0c5f4f zink: delete transient attachments instead of leaking them 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
07cc25d968 zink: always directly create surfaces 
no need to defer this anymore

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
a7bfa37c6a zink: unify zink_resource_object_init_mutable() calling 
this all goes through surface creation the same way

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
2ac0f97921 zink: delete surface handling of blockTexelViewCompatibleMultipleLayers 
this is a pipe cap now

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
e7a2268ca2 zink: simplify code surrounding prep_fb_attachment() 
there's no need to pass a surface here since no part
of the surface is actually used besides the resource

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
9a1f5e82ee zink: clean up null surface case in prep_fb_attachment() 
this is already checking for non-null surface in the caller,
and usage must be set after swapchain acquire to handle barriers

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
78cd7f17af zink: move zink_prep_fb_attachment up and make static 
no longer used externally

also move update_res_sampler_layouts() as a dependency

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
0f58227324 zink: remove pipe_resource ref from bufferviews 
this was only ever needed for shader images and bindless, which both
now take their own refs

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
3da0853867 zink: make pipe_resource refs for image views more consistent 
now they always get a ref on bind and lose the ref on unbind

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00
Mike Blumenkrantz
6658533ad5 zink: add a pipe_resource ref to bindless descriptors 
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35722>
 2025-06-26 10:10:28 -04:00