Rob Clark
6326ac4350
freedreno/a6xx: Drop legacy CP_EVENT_WRITE builders
...
Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39029 >
2025-12-20 00:23:06 +00:00
Rob Clark
32be52a457
freedreno/registers: Mark LOAD_IMMED as a5xx
...
This is replaced by CP_SET_LOAD_IMMEDIATE on later gens.
Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39029 >
2025-12-20 00:23:06 +00:00
Rob Clark
af38b71e5b
freedreno/a6xx: Set FD_BO_NO_HARDPIN from meson
...
Rather than setting it in each file, we can just set it globally for all
c++ files.
Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39029 >
2025-12-20 00:23:06 +00:00
Job Noorman
2ed37033a0
ir3/legalize: fix (eq) scheduling for sam.s2en
...
sam.s2en uses the first src for its samp/tex while the coordinates (for
which derivatives need to be calculated) are in the second src. We used
to unconditionally track needed helpers for the first src causing (eq)
to potentially get scheduled too early for sam.s2en. Fix this by using
the second src for sam.s2en.
Fixes frame instability in Metro Exodus.
Signed-off-by: Job Noorman <jnoorman@igalia.com>
Fixes: 29f8277952 ("ir3/legalize: schedule (eq) more accurately")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38992 >
2025-12-19 23:49:55 +00:00
Eric Engestrom
3584bac0b2
nil: cleanup derelict allow(dead_code) annotations
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:14:46 +01:00
Eric Engestrom
6b9524f864
nak: cleanup derelict allow(dead_code) annotations
...
As well as one `allow(non_camel_case_types)`.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:14:46 +01:00
Eric Engestrom
e2e36f352f
rusticl: cleanup derelict allow(non_upper_case_globals) annotation
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:14:46 +01:00
Eric Engestrom
96a48ee8db
rusticl: drop collapsible_else_if annotation now that it's allowed globally
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:14:46 +01:00
Eric Engestrom
2202c2d62a
util/rust: cleanup derelict allow(dead_code) annotations
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:14:46 +01:00
Eric Engestrom
eef174b56b
nak: use std::mem::size_of_val(data) instead of open-coding it
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:20 +01:00
Eric Engestrom
de7d3cdbda
nak: drop "unneeded return statement"
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
41ce1939f9
nak: replace .find(x).is_some() with .contains(x)
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
c52fa1ac14
nak: merge identical if branches for blackwell, ampere and ada
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
9cfb4b1fdb
nak: replace .get(0) with .first()
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
124fe82762
nak: drop "deref on an immutable reference"
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
4fbda98cf4
nak: drop "reference which is immediately dereferenced by the compiler"
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
daeed4a946
nak: allow LdCacheOp values to be named Cache*
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
9454006956
nak: drop cast of u8 to u8
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
ddc26666da
nak: drop clone of Copy-able types (RegOrigin & SSAValue)
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
340c355714
nak: use saturating_sub() instead of open-coding it
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
f4c832ac15
nak: drop "reference which is immediately dereferenced by the compiler"
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
5ebe62ebed
rusticl: silence incorrect clippy error about re-implementing memcpy
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
74aa12e5ab
compiler/rust: drop "borrow of a value the compiler would automatically borrow"
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
91e60e210a
compiler/rust: allow CFG & BitSetStreamTrait to have a len() without also having an is_empty()
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
e825eac272
compiler/rust: remove unnecessary lifetimes
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
cb57b77239
compiler/rust: rewrite match into a simpler if let
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
1def70585b
compiler/rust: replace !first.is_none() with first.is_some()
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
49b2597854
nak: replace !foo.is_{none,some}() with their positive counterpart
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
ca319ba707
nak: drop unnecessary mutable reference
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
97a7592557
nak: drop redundant closure
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
8a35fc9500
nak: remove unused lifetime
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
23ae567ae6
nak: add all identical values in one step
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
ce04b8a578
nak: use foo &= bar instead of foo = foo & bar
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
6d881284c3
nak: use assert_eq!(a, b) instead of assert!(a == b)
...
Tells you what's different when it fails.
Suggested-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Mel Henning
f48fcfe552
nak: impl fmt::Debug for SSAValue
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
9f830f622f
nak: drop unnecessary reference on both sides of ==
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
e0c5b40561
nak: rewrite repeat().take() into repeat_n()
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
f571428274
nak: remove "reference which is immediately dereferenced by the compiler"
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
10396d8db6
nak: remove conversion into the same type
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
f7a31b7d48
nak: drop empty string from eprintln!()
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
91496f6d68
nak: remove unnecessary use of format!()
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
0a529a908f
nak: silence clippy warning about x * 0
...
It is useful to keep here to show that there is an offset, even though
it's zero on these two first lines.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
85b7386158
nak: avoid errors when generated code is empty
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
dbd528ea3d
nak: use matches!() instead of open-coding it
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
28ff39fbb4
nak: use filter() instead of open-coding it
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
314144ba51
nak: set nir_shader_compiler_options one one step
...
Instead of setting it to default() and then overwriting, which clippy
doesn't like.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
f81d0cab83
nil: drop duplicate lib in "liblibnil.a"
...
It's a static lib so it doesn't matter much, but we might as well drop the dupe.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
236b8f081c
etnaviv: allow ISA struct to be spelled all uppercase
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Eric Engestrom
f70d1bcdbf
rusticl: rewrite blocks using if/else for clarity
...
Applying clippy's code suggestions.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00
Karol Herbst
5dbfa7f85d
rusticl/mesa: convert pointer to ref without transmute in PipeScreen::from_raw
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38807 >
2025-12-20 00:13:19 +01:00