Alyssa Rosenzweig
78445ce695
panfrost: XMLify exception access
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:17 +02:00
Alyssa Rosenzweig
99d17fb771
panfrost: XMLify MSAA writeout mode
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:17 +02:00
Alyssa Rosenzweig
c9bdba26b0
panfrost: XMLify Block Format
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:17 +02:00
Alyssa Rosenzweig
8c1ac96eb6
panfrost: Drop unused mali_channel_swizzle
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:16 +02:00
Alyssa Rosenzweig
ad0b32cdbd
panfrost: XMLify Bifrost textures
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:16 +02:00
Alyssa Rosenzweig
f008a6314c
panfrost: XMLify Midgard textures
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:16 +02:00
Alyssa Rosenzweig
b10c3c869d
panfrost: XMLify Bifrost samplers
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:16 +02:00
Alyssa Rosenzweig
f74186baa5
panfrost: XMLify Midgard samplers
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:16 +02:00
Alyssa Rosenzweig
c4c8c8e8fb
panfrost: Don't mask coverage mask to 4-bits
...
While it is correct for MSAA 4x, it will break for MSAA 8x and 16x, and
it is only dubiously correct for no-MSAA. Drop the mask.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:16 +02:00
Alyssa Rosenzweig
6afd4addef
panfrost: Simplify depth/stencil/alpha
...
The alpha test is lowered by the frontend so we can drop that unused
code path, and stencil state can be computed at CSO create time to
reduce draw-time complexity.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:16 +02:00
Alyssa Rosenzweig
1675d92d66
panfrost: Simplify zsa == NULL case
...
Stencil fields are only used if stenciling is enabled.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:16 +02:00
Alyssa Rosenzweig
931e7b4c7a
panfrost: XMLify stencil test
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:16 +02:00
Alyssa Rosenzweig
fa949678c1
panfrost: XMLify UBOs
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:16 +02:00
Alyssa Rosenzweig
7f487e087f
panfrost: XMLify viewport
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:15 +02:00
Alyssa Rosenzweig
ef20691e3d
panfrost: XMLify wrap modes
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:15 +02:00
Alyssa Rosenzweig
e9ca320461
panfrost: XMLify stencil op
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:15 +02:00
Alyssa Rosenzweig
d182a6057f
panfrost: XMLify mali_func
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:15 +02:00
Alyssa Rosenzweig
32dbc80979
panfrost: XMLify draw_mode
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:15 +02:00
Alyssa Rosenzweig
4b7056b8c8
panfrost: XMLify job_type
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:15 +02:00
Alyssa Rosenzweig
d2ddd4d565
pan/decode: Add helper to dump GPU structures
...
Based on generating unpack/print.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:15 +02:00
Alyssa Rosenzweig
88dc4c21e6
panfrost: Redirect cmdstream includes through GenXML
...
This will provide a way to incrementally upgrade.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:15 +02:00
Alyssa Rosenzweig
1ad921956d
panfrost: Build midgard_pack.h via meson
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:15 +02:00
Alyssa Rosenzweig
75cc5b8c29
panfrost: Adopt gen_pack_header.py via v3d
...
We fork gen_pack_header.py from v3d, which in turn forks GenXML from
Intel. Selected changes for Mali:
* Custom prefix/vendoring
* Cull supported types
* Drop <register> and <packet> support (no cmdstream)
* Pack 32-bit words instead of 8-bit bytes
* Inline packing helpers
* Introduce exact attribute
* Introduce general minus(..) and shr(..) modifiers
* Introduce word:bit syntax
* Introduce prettyprinters
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:15 +02:00
Alyssa Rosenzweig
9cb3a9e72e
panfrost: Add stub midgard.xml
...
This will be filled in incrementally.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6195 >
2020-08-13 08:55:14 +02:00
Eric Anholt
33e69203d2
util: Fix up indentation in the generated format tables code.
...
I did this as a separate commit to make the previous one more reviewable.
Acked-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5826 >
2020-08-12 14:22:24 -07:00
Eric Anholt
9fd0f455af
util: Change a codegenned switch statement to a nice little table.
...
This saves us 13 to 35kb on release drivers in my builds.
Acked-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5826 >
2020-08-12 14:22:24 -07:00
Eric Anholt
4064a6cd20
util: Split the pack/unpack functions out of the format desc.
...
This gives the compiler a chance to GC pack/unpack functions separate from
the format descriptions. For drivers that use everything, this is
+10-20kb, while for libvulkan_intel it's -1.3MB.
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1048434
Acked-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5826 >
2020-08-12 13:13:39 -07:00
Dylan Baker
6723addd8a
docs: update calendar for 20.2.0-rc2
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6292 >
2020-08-12 17:55:01 +00:00
Dylan Baker
6de5acdf4f
docs: update calendar for 20.2.0-rc1
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6292 >
2020-08-12 17:55:01 +00:00
Marek Olšák
4c84600afa
radeonsi: fix compute-based culling with VERTEX_COUNTER_GDS_MODE == 1
...
Discovered when testing Sienna Cichlid.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6282 >
2020-08-12 17:39:09 +00:00
Marek Olšák
2b78cb2e00
radeonsi: disable NGG culling on gfx10.3 because of hangs
...
Fixes: a23802bcb9 - ac,radeonsi: start adding support for gfx10.3
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6282 >
2020-08-12 17:39:09 +00:00
Mike Blumenkrantz
61042b1bdb
zink: handle more draw modes
...
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6269 >
2020-08-12 14:52:26 +00:00
Mike Blumenkrantz
ced9e6e3e5
zink: change pipeline hashes to index based on vk primitive type
...
this is a bit more convenient since we always support vk types but not
necessarily gallium types
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6269 >
2020-08-12 14:52:26 +00:00
Danylo Piliaiev
2701f887fc
anv/nir: Unify inputs_read/outputs_written between geometry stages
...
inputs_read/outputs_written are used for a shader stage to
determine the layout of input and output storage. Adjacent stages must
agree on the layout, so adjacent input/output bitfields must match.
Most of the time, cross-stage optimizations make that happen anyway,
but there are some cases (with special values like clip distances and
point size) where this doesn't happen.
Fixes crashes in dEQP-VK.subgroups.*.framebuffer.*_tess_eval
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3210
Cc: <mesa-stable@lists.freedesktop.org>
Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6102 >
2020-08-12 14:42:17 +00:00
Alyssa Rosenzweig
2a1217513e
panfrost: Implement panfrost_query_dmabuf_modifiers
...
v2: Only advertise AFBC if PAN_MESA_DEBUG=afbc is set. This is to avoid
sharing AFBC buffers as SCANOUT until corresponding kernel bugfixes are
landed. Technically a kernel issue but let's prevent a regression.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me> [v1]
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:21 -04:00
Alyssa Rosenzweig
24c921b1b5
panfrost: Ensure AFBC slices are aligned
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:21 -04:00
Alyssa Rosenzweig
4d0241dfed
panfrost: Allocate enough space for tiled formats
...
We need to align and possible reserve space for a header.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:20 -04:00
Alyssa Rosenzweig
8c0cb56fd9
panfrost: Enable YTR where allowed
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:20 -04:00
Alyssa Rosenzweig
d285ea6467
panfrost: Implement YTR availability check
...
Depends on format.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:20 -04:00
Alyssa Rosenzweig
acb8dcfebd
panfrost: Choose AFBC when available
...
There are lots of reasons we might fallback on u-interleaved tiling, but
when we can use AFBC, it's a big win.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:20 -04:00
Alyssa Rosenzweig
c54d45dd90
panfrost: Import staging routines from freedreno
...
For software access to AFBC textures.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:20 -04:00
Alyssa Rosenzweig
348d374d01
panfrost: Respect modifiers in resource management
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:20 -04:00
Alyssa Rosenzweig
56f9cc9948
panfrost: Account for modifiers when creating BO
...
If specified, use the modifier directly. If unspecified, pick our own
modifier.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:20 -04:00
Alyssa Rosenzweig
965537df2a
panfrost: Use modifier instead of layout throughout
...
Instead of converting back and forth we should stick with fourcc codes
as the canonical layout definition. Furthermore modifiers allow all the
variants of AFBC to be encoded canonically, whereas the previous enum
does not (info about YTR is encoded out of band, for instance).
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:20 -04:00
Alyssa Rosenzweig
6fed69cde2
panfrost: Introduce create_with_modifier helper
...
As a stepping stone to full modifier support.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:20 -04:00
Alyssa Rosenzweig
32bd588fed
panfrost: Remove hint-based AFBC heuristic
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:20 -04:00
Alyssa Rosenzweig
340017ec47
panfrost: Set initialized more conservatively
...
In case Gallium doesn't ask for direct but we give a direct mapping
anyway.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:19 -04:00
Alyssa Rosenzweig
22777025d4
gallium/dri2: Support Arm modifiers
...
This is needed to share both Utgard-style tiled and a subset of Arm
FrameBuffer Compression (AFBC) tiled framebuffers across processes in
Wayland.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
Tested-by: Icecream95 <ixn@keemail.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6159 >
2020-08-12 09:59:14 -04:00
Mike Blumenkrantz
37872edf6f
zink: print error when getprocaddr fails for extension functions
...
make this more visible on errors
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6271 >
2020-08-12 13:19:23 +00:00
Bas Nieuwenhuizen
371f6f42ad
radv: Update CI expectations for the recent descriptor indexing regressions.
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6285 >
2020-08-12 11:15:42 +00:00