Yiwei Zhang
64a4442090
v3dv: amend AHB buffer support
...
...via adopting vk_android_get_ahb_buffer_properties.
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36151 >
2025-07-17 20:12:23 +00:00
Yiwei Zhang
4ee67ba967
v3dv: adopt vk_android_get_ahb_image_properties
...
The runtime vk_android.h header has proper android detection inside, so
no need to wrap it with redundant android detection. Meanwhile, the enum
VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID is
defined in the vulkan_core.h, so no need Android wrap either.
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36151 >
2025-07-17 20:12:23 +00:00
Yiwei Zhang
7934c9ab78
vulkan/android: make vk_ahb_probe_format private to android runtime
...
...and drop duplicate docs.
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36151 >
2025-07-17 20:12:23 +00:00
Yiwei Zhang
e733ac9314
turnip: amend AHB buffer support
...
...via adopting vk_android_get_ahb_buffer_properties.
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36151 >
2025-07-17 20:12:23 +00:00
Yiwei Zhang
bdf9524e1c
turnip: adopt vk_android_get_ahb_image_properties
...
No behavior change.
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36151 >
2025-07-17 20:12:23 +00:00
Yiwei Zhang
cefda4eedb
venus: clean up post vk_android_get_ahb_image_properties adoption
...
Make this a separate commit to ease review of the prior adoption.
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36151 >
2025-07-17 20:12:23 +00:00
Yiwei Zhang
e4f9ce838a
venus: adopt vk_android_get_ahb_image_properties
...
Now we can fully resolve the AHB image query on the driver side without
roundtrips.
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36151 >
2025-07-17 20:12:23 +00:00
Yiwei Zhang
e33870d207
venus/wsi: move wsi image format info validation to vn_wsi
...
Added vn_wsi_validate_image_format_info helper to clean up query side
codes.
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36151 >
2025-07-17 20:12:23 +00:00
Yiwei Zhang
89f5938930
venus: adopt vk_android_get_ahb_buffer_properties
...
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36151 >
2025-07-17 20:12:23 +00:00
Yiwei Zhang
9fb91dfd93
vulkan/android: add vk_android_get_ahb_buffer_properties
...
This is to assist GetPhysicalDeviceExternalBufferProperties query.
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36151 >
2025-07-17 20:12:23 +00:00
Yiwei Zhang
850ede0970
vulkan/android: add vk_android_get_ahb_image_properties
...
This is to assist GetPhysicalDeviceImageFormatProperties2 query.
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36151 >
2025-07-17 20:12:23 +00:00
Mike Blumenkrantz
c768699a73
zink: fix valid contents check for adding new bind
...
the previous one didn't account for buffers
Fixes: b022cdc8a1 ("zink: only copy resource during add_bind if it is valid")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36201 >
2025-07-17 19:54:23 +00:00
Danylo Piliaiev
6003a89b89
tu: Use safe-const binning VS when safe-const full VS is used
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Otherwise we can have a case where binning VS uses more consts than
full VS (when safe variant is used for full VS), that will result in
a rendering issue because SP_VS_CONST_CONFIG.CONSTLEN is shared between
full and binning VS in PROGRAM_CONFIG state and gets the value from the
full VS.
There are two alternative solutions that can allow binning VS to always
use maximum constlen:
- Move constlen emission to per-XS config. This interferes
PROGRAM_CONFIG state which uploads consts and does SP_UPDATE_CNTL.
Consts would need to be uploaded after constlen is defined, while
SP_UPDATE_CNTL must be done before per-XS state is emitted.
Also having SP_UPDATE_CNTL in a draw state that is always DIRTY
isn't great.
Something didn't work out on A6XX, so this idea was dropped.
- Emit constlen again in VS_BINNING draw state. This seem to work
but also likely an undefined behaviour since constlen is changed
after some consts are uploaded.
Cc: mesa-stable
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36203 >
2025-07-17 19:33:42 +00:00
Karol Herbst
a0a9c12124
rusticl/mem: set swizzle for intensity images
...
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36199 >
2025-07-17 19:13:37 +00:00
Karol Herbst
e03d23ddc9
zink: disable shader images for intensity formats
...
Vulkan only allows identity remapping on storage images descriptors.
Fixes: 475c43cf8a ("zink: translate intensity formats")
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36199 >
2025-07-17 19:13:37 +00:00
Karol Herbst
146e843254
zink: disallow intensity buffer images
...
Fixes: 475c43cf8a ("zink: translate intensity formats")
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36199 >
2025-07-17 19:13:37 +00:00
Karol Herbst
3a2f38cd44
vtn/opencl: set exact on all ffmas and mads
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36175 >
2025-07-17 16:47:23 +00:00
Antonio Ospite
0f09c9436b
ci/android: update comment about ANDROID_CTS_MODULES
...
After commit 545727f97c (ci/android: Move ANDROID_CTS_MODULES to build
script, 2025-06-24) the comment about ANDROID_CTS_MODULES in
lvp-android-angle-android-cts-include.txt has become inaccurate.
Update the instructions to reflect the latest status.
Fixes: 545727f97c
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36187 >
2025-07-17 14:31:40 +00:00
Boyuan Zhang
9b158d0512
ci/fluster: remove 3 pass cases resulted by gaps_in_frame
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
These 3 failed tests are passing now by enabling the gaps_in_frame feature.
Therefore, remove all of them.
Signed-off-by: Boyuan Zhang <boyuan.zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36056 >
2025-07-17 12:44:51 +00:00
Boyuan Zhang
a63e5f015e
radeon/vcn: add gaps_in_frame flag to h264 sps
...
Implement gaps_in_frame_num_value_allowed_flag in h264 msg buffer.
Replace hardcoded flag values with defines.
Signed-off-by: Boyuan Zhang <boyuan.zhang@amd.com>
Reviewed-by: David Rosca <david.rosca@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36056 >
2025-07-17 12:44:51 +00:00
Boyuan Zhang
a7567ec6f4
frontends/va: get gaps_in_frame for h264 dec
...
Get gaps_in_frame_num_value_allowed_flag value from Va-api interface.
Signed-off-by: Boyuan Zhang <boyuan.zhang@amd.com>
Reviewed-by: David Rosca <david.rosca@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36056 >
2025-07-17 12:44:51 +00:00
Boyuan Zhang
587102196c
pipe: add gaps_in_frame for h264
...
Add gaps_in_frame_num_value_allowed_flag to h264 sps struct.
Signed-off-by: Boyuan Zhang <boyuan.zhang@amd.com>
Reviewed-by: David Rosca <david.rosca@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36056 >
2025-07-17 12:44:51 +00:00
Mike Blumenkrantz
ce09d80698
gallium/hud: set the framebuffer texture when drawing
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13545
Fixes: 2eb45daa9c ("gallium: de-pointerize pipe_surface")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36167 >
2025-07-17 11:48:51 +00:00
Valentine Burley
34c969f767
freedreno,zink+tu/ci: Document Piglit bug
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Document the Piglit bug exposed in 08b522d21e
("glsl: check against varying limits using NIR shader_info after nir_opt_varyings")
Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36027 >
2025-07-17 09:07:28 +00:00
Valentine Burley
bcc1a96a73
zink/ci: Run full zink-tu-a618 job pre-merge
...
We can use one more device to increase parallelism, which allows us to
run the full nightly job pre-merge.
Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36027 >
2025-07-17 09:07:28 +00:00
Valentine Burley
0b677027a8
freedreno/ci: Re-enable a618-gl job
...
Re-enables the previously disabled GL and EGL jobs on a618, combining
them into a single a618-gl job.
Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36027 >
2025-07-17 09:07:28 +00:00
Valentine Burley
2980a5913a
turnip/ci: Increase coverage of a618-vk, reduce parallelism
...
Thanks to the optimizations in the previous commits and further
increasing tests_per_group, we can now run more tests in a618-vk
while also reducing its parallelism.
Dropping `DEQP_FRACTION: 2` and only increasing the `fraction` of
the basic test set to 3 results in broader overall coverage.
Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36027 >
2025-07-17 09:07:26 +00:00
Valentine Burley
7ec9404971
freedreno/ci: Increase concurrency for a618 jobs
...
The a618 jobs run on two different 8 thread devices, which is the optimal
value for FDO_CI_CONCURRENT on most of their jobs.
Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36027 >
2025-07-17 09:07:25 +00:00
Yiwei Zhang
afdb2c64de
venus/ci: udpate expectations from venus-lavapipe-full runs
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36180 >
2025-07-16 22:56:43 +00:00
Yiwei Zhang
442f242a49
venus: requests whole blob mem size for non-dedicated import
...
For non-dedicated import, later import could have varied size against
the same bo, so we just request the whole blob mem size for those.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36128 >
2025-07-16 22:05:11 +00:00
Yiwei Zhang
b32a8d17a2
venus/virtgpu: use size zero to request mapping the entire blob mem
...
For import, requested size might be smaller than the whole blob mem
size. Currently, venus virtgpu backend tracks the initial import size
and sanity checks with later re-import size. So let's add a way to
request whole blob mem size
No need vtest backend changes since dma_buf import is not supported.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36128 >
2025-07-16 22:05:11 +00:00
Yiwei Zhang
768375fede
venus: refactor ahb import interface to take whole alloc info
...
Prepare for adopting common runtime so that we don't leave unused vars
after dropping codes from vn_AllocateMemory. It's trying to minimize
code changes in the venus adoption since that'd be huge.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36128 >
2025-07-16 22:05:11 +00:00
Yiwei Zhang
e27ad2a021
venus: drop force_unmappable hack
...
No longer needed since the vkMapMemory would fail properly instead of
failing the external memory import.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36128 >
2025-07-16 22:05:11 +00:00
Yiwei Zhang
6c8f075fb3
venus/virtgpu: drop mappable if blob size is smaller than requested
...
Instead of failing the import, drop the mappable bit if blob size is
smaller than the requested alloc size, which defers the error to the
intended vkMapMemory api call if the client app requests Vulkan mapping
from the imported external memory.
Normally this won't occur if the app obeys the spec with a properly
implemented blob mem allocator. However, legacy allocators like minigbm
virtgpu_virgl backend could allocate via virgl w/o knowing the real blob
size from the guest side. The unsatified cases are external gralloc
images, which won't be mapped in any meaningful way after being
imported. This is to prepare dropping the force_unmappable workaround,
and to further prepare adopting common Android runtime.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36128 >
2025-07-16 22:05:10 +00:00
Eric Engestrom
e39a41e104
gfxstream: move variables into the #ifdef that uses them
...
../src/gfxstream/guest/vulkan_enc/ResourceTracker.cpp:7585:14: warning: unused variable ‘actualFormat’ [-Wunused-variable]
7585 | VkFormat actualFormat = imageInfo.createInfo.format;
| ^~~~~~~~~~~~
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36171 >
2025-07-16 20:30:40 +00:00
Alyssa Rosenzweig
2308960bed
treewide: use nir_mov_scalar
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Via Coccinelle patch:
@@
expression builder, scalar;
@@
-nir_channel(builder, scalar.def, scalar.comp)
+nir_mov_scalar(builder, scalar)
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36142 >
2025-07-16 18:59:16 +00:00
Alyssa Rosenzweig
186db0ebfe
nir: add nir_mov_scalar helper
...
I keep reaching for this helper but it doesn't exist. So I fixed that.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36142 >
2025-07-16 18:59:16 +00:00
Alyssa Rosenzweig
a5e9669a78
hk: only pass sampler heap if needed
...
I'm guessing the hardware needs to prefetch the whole sampler heap, so if we're
not gonna use it, let's omit it. I don't know if this helps, but it can't hurt.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:22 +00:00
Alyssa Rosenzweig
74c32c2357
hk: optimize desc set addr push
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:22 +00:00
Alyssa Rosenzweig
642c6c6f62
hk,agx: promote bindless samplers
...
via the bindless_sampler_agx intrinsic.
Totals from 29771 (55.11% of 54019) affected shaders:
MaxWaves: 28934080 -> 28938304 (+0.01%); split: +0.02%, -0.00%
Instrs: 16623874 -> 16369120 (-1.53%); split: -1.54%, +0.01%
CodeSize: 117532138 -> 115994992 (-1.31%); split: -1.32%, +0.01%
Spills: 12721 -> 12652 (-0.54%); split: -0.72%, +0.17%
Fills: 6733 -> 6636 (-1.44%); split: -1.96%, +0.52%
Scratch: 132994 -> 132712 (-0.21%); split: -0.22%, +0.01%
ALU: 13054253 -> 12803059 (-1.92%); split: -1.93%, +0.01%
FSCIB: 13054138 -> 12802912 (-1.92%); split: -1.94%, +0.01%
IC: 3916012 -> 3915588 (-0.01%); split: -0.01%, +0.00%
GPRs: 2290907 -> 2289519 (-0.06%); split: -0.07%, +0.01%
Uniforms: 6794773 -> 6696943 (-1.44%); split: -1.44%, +0.00%
Preamble instrs: 6953594 -> 7024455 (+1.02%); split: -0.37%, +1.39%
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:21 +00:00
Alyssa Rosenzweig
49f042c5e8
hk: plumb sampler state counts
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:21 +00:00
Alyssa Rosenzweig
4a9ae295cd
agx: report sampler state count
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:20 +00:00
Alyssa Rosenzweig
2340541eca
asahi: drop image heap decode
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:20 +00:00
Alyssa Rosenzweig
5598d6aa10
hk: drop image heap
...
now everything is just inline in the set. saves 24MiB. fossil changes from start
of series to here:
Totals from 45270 (83.80% of 54019) affected shaders:
MaxWaves: 44151552 -> 44167808 (+0.04%); split: +0.05%, -0.01%
Instrs: 22630059 -> 22599471 (-0.14%); split: -0.31%, +0.17%
CodeSize: 160981702 -> 160987912 (+0.00%); split: -0.29%, +0.29%
Spills: 66105 -> 66276 (+0.26%); split: -1.09%, +1.35%
Fills: 43894 -> 43987 (+0.21%); split: -1.82%, +2.03%
Scratch: 375176 -> 374896 (-0.07%); split: -0.20%, +0.13%
ALU: 17656552 -> 17640750 (-0.09%); split: -0.29%, +0.20%
FSCIB: 17601880 -> 17586092 (-0.09%); split: -0.29%, +0.20%
IC: 4990178 -> 4995334 (+0.10%); split: -0.05%, +0.15%
GPRs: 3417893 -> 3413589 (-0.13%); split: -0.17%, +0.04%
Uniforms: 9260606 -> 9474203 (+2.31%); split: -0.22%, +2.52%
Preamble instrs: 9679627 -> 9282629 (-4.10%); split: -4.22%, +0.12%
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:20 +00:00
Alyssa Rosenzweig
1ea1b2d360
hk: stop reserving uniform for image heap
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:19 +00:00
Alyssa Rosenzweig
97ff0ada8b
hk: stop pushing image heap
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:19 +00:00
Alyssa Rosenzweig
5a6c5eed65
hk: embed texture desc in set
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:18 +00:00
Alyssa Rosenzweig
98aad84d73
hk: push descriptor set addresses
...
saves an indirection and sets us up for more goodness.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:18 +00:00
Alyssa Rosenzweig
899f001936
hk: dedupe hk_buffer_view_descriptor
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:17 +00:00
Alyssa Rosenzweig
24c708564f
nir: add bindless_sampler_agx intrinsic
...
to facilitate pushing on AGX.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36127 >
2025-07-16 18:27:17 +00:00