Alyssa Rosenzweig
3cc215b1cc
hk: fix null FS corner cases
...
this fixes null FS + cull distance/API sample mask, which require a prolog.
fixes upcoming CTS.
Backport-to: 25.1
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34585 >
(cherry picked from commit 3ab8ce8579 )
2025-04-22 01:24:49 +02:00
Alyssa Rosenzweig
5c048f7860
hk: fix tessellation + clipper queries
...
fixes upcoming cts
Backport-to: 25.1
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34585 >
(cherry picked from commit d959557669 )
2025-04-22 01:24:48 +02:00
Alyssa Rosenzweig
5c0cd81232
hk: fix underbinding scratch
...
need to round up to page size (minimally) or we assert out. hit in vulkaninfo
of all things.
Fixes: 678134add5 ("hk: implement sparse")
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34526 >
(cherry picked from commit 9b55451ea7 )
2025-04-17 02:28:16 +02:00
Alyssa Rosenzweig
618409a934
agx: switch to common LOD bias lowering
...
only functional change is a slight instr count regression for cube map txd
because of pass ordering but lol.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34507 >
2025-04-15 14:10:50 +00:00
Alyssa Rosenzweig
d53ad63c66
hk: handle lod/min_lod size mismatch
...
can be hit with the new lod bias lowering.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34507 >
2025-04-15 14:10:50 +00:00
Alyssa Rosenzweig
2e15b42eec
nir: unvendor lod_bias(_agx)
...
this will be useful for other backends.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34507 >
2025-04-15 14:10:49 +00:00
Konstantin Seurer
cb31b5a958
clc,libcl: Clean up CL includes
...
This patch does a couple of things to make CL integration with drivers
as seamless as possible:
- We pull in opencl-c.h and opencl-c-base.h to stop relying on system
headers.
- Parts of libcl.h are moved to new headers that are incomplete CL-safe
variants of libc headers.
- A couple of util headers are changed to remove now unnecessary
__OPENCL_VERSION__ guards and make more headers CL safe.
- Drivers now include src/compiler/libcl and use headers like
macros.h,u_math.h instead of libcl.h.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33576 >
2025-04-11 21:27:37 +00:00
Alyssa Rosenzweig
4a299bea27
hk: drop soft fault assumption in hk_buffer_addr_range
...
fixes test_index_buffer_edge_case_stream_output without soft fault.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34486 >
2025-04-11 20:16:01 +00:00
Alyssa Rosenzweig
0f9b396588
hk: advertise sparseResidencyBuffer
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34486 >
2025-04-11 20:16:01 +00:00
Alyssa Rosenzweig
4b119b36c8
hk: use ro maps
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34486 >
2025-04-11 20:16:01 +00:00
Alyssa Rosenzweig
f3272ebab8
hk: bind for sparse emulation
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34486 >
2025-04-11 20:16:01 +00:00
Alyssa Rosenzweig
fb71b8a4ee
asahi: fix zero bo leak
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34486 >
2025-04-11 20:16:01 +00:00
Alyssa Rosenzweig
546bc893f1
asahi: add sparse emu helpers
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34486 >
2025-04-11 20:16:01 +00:00
Alyssa Rosenzweig
c2d00c94b1
asahi: shrink VA space for sparse emulation
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34486 >
2025-04-11 20:16:01 +00:00
Alyssa Rosenzweig
1a76310fb7
asahi: remove unstable uapi header
...
now unused.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33984 >
2025-04-09 20:25:50 +00:00
Alyssa Rosenzweig
c64a2bbff5
asahi: port to stable uAPI
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33984 >
2025-04-09 20:25:49 +00:00
Alyssa Rosenzweig
3e110005a6
asahi: disable virtio gpu for upstream
...
until the wire protocol is stable.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33984 >
2025-04-09 20:25:49 +00:00
Alyssa Rosenzweig
1dc90e3f8b
hk: advertise maintenance8
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34426 >
2025-04-08 19:04:47 +00:00
Alyssa Rosenzweig
ab8adb8438
hk: advertise maintenance7
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34426 >
2025-04-08 19:04:47 +00:00
Alyssa Rosenzweig
af6646c3ce
hk: advertise VK_EXT_queue_family_foreign
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12904
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34426 >
2025-04-08 19:04:47 +00:00
Alyssa Rosenzweig
0da52e1fd8
hk: support colour <--> z/s copies
...
dEQP-VK.api.ds_color_copy.* for maint8, but there's more to maint8
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34426 >
2025-04-08 19:04:47 +00:00
Alyssa Rosenzweig
f0e6746ffa
hk: fix last VGT output component limits
...
per discussion.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34426 >
2025-04-08 19:04:47 +00:00
Alyssa Rosenzweig
56fc62c1ea
hk: drop dead todo
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34426 >
2025-04-08 19:04:47 +00:00
Alyssa Rosenzweig
4f1d08b234
agx: optimize nonuniform offset
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34426 >
2025-04-08 19:04:47 +00:00
Alyssa Rosenzweig
924075cd56
asahi,hk: disentangle logicop_enable
...
logicop_func=COPY is different from logicop_enable due to overriding blending.
maintain the info we need to implement properly. fixes
dEQP-VK.pipeline.shader_object_unlinked_binary.logic_op_na_formats.r32g32b32a32_sfloat.copy_blend
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34426 >
2025-04-08 19:04:47 +00:00
Aaron Ruby
8513bcbd2f
virtio: Remove virglrenderer_hw.h entirely
...
Capset definitions replaced by those in virtgpu_drm.h
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34300 >
2025-04-01 22:11:10 +00:00
Alyssa Rosenzweig
bfca178e27
asahi: clang-format
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34326 >
2025-04-01 17:42:51 +00:00
Alyssa Rosenzweig
1a36d0b5d7
libagx: use common heap allocs
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34326 >
2025-04-01 17:42:51 +00:00
Alyssa Rosenzweig
55046d0293
libagx: assert alignment for copies
...
would have exposed the bug fixed.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34326 >
2025-04-01 17:42:50 +00:00
Alyssa Rosenzweig
f0ee1b1967
libagx: clean up query copy; bug fix
...
oops.
- .partial = flags & VK_QUERY_RESULT_WITH_AVAILABILITY_BIT,
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34326 >
2025-04-01 17:42:50 +00:00
Alyssa Rosenzweig
b5367dd797
hk: fix unaligned copies
...
Fixes regression in Deus Ex: Human Revolution (DX11) via DXVK reported by James
Calligeros.
Pending CTS coverage: https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/5640
Only the alignment check here is load bearing but I clarified the logic while at
it.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34326 >
2025-04-01 17:42:50 +00:00
Alyssa Rosenzweig
f7e706e325
hk: advertise bufferDeviceAddressCaptureReplayEXT
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34326 >
2025-04-01 17:42:50 +00:00
Alyssa Rosenzweig
8f2dc51e7f
hk: advertise semaphore extensions
...
works on current kernels.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34326 >
2025-04-01 17:42:50 +00:00
Alyssa Rosenzweig
c068b34013
agx: fix tg4 offset residency
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34326 >
2025-04-01 17:42:50 +00:00
Konstantin Seurer
69cd2cb362
asahi: Only require IOKit for tooling
...
Reviewed-by: Rob Clark <robdclark@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33685 >
2025-03-26 18:35:36 +00:00
Alyssa Rosenzweig
c677ac13b9
agx: fix ctz of zero with address calcs
...
../src/asahi/compiler/agx_nir_lower_address.c:82:30: runtime error: passing zero to ctz(), which is not a valid argument
#0 0x56175dca5684 in pass ../src/asahi/compiler/agx_nir_lower_address.c:82
#1 0x56175dca2eda in nir_function_intrinsics_pass ../src/compiler/nir/nir_builder.h:164
#2 0x56175dca308c in nir_shader_intrinsics_pass ../src/compiler/nir/nir_builder.h:191
#3 0x56175dca68ae in agx_nir_lower_address ../src/asahi/compiler/agx_nir_lower_address.c:167
#4 0x56175dc885c0 in agx_optimize_nir ../src/asahi/compiler/agx_compile.c:3063
#5 0x56175dc9650d in agx_compile_shader_nir ../src/asahi/compiler/agx_compile.c:3827
#6 0x56175dc52148 in main ../src/asahi/clc/asahi_clc.c:359
#7 0x7fdf1c343249 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
#8 0x7fdf1c343304 in __libc_start_main_impl ../csu/libc-start.c:360
#9 0x56175dc44760 in _start (/builds/mesa/mesa/_build/src/asahi/clc/asahi_clc+0xbd0760)
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33685 >
2025-03-26 18:35:36 +00:00
Alyssa Rosenzweig
dfae262ca4
asahi: add assert for max variant count
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33685 >
2025-03-26 18:35:36 +00:00
Alyssa Rosenzweig
dfe995414f
libagx: reduce # of variants of unroll restart
...
33 variants of this stupid kernel is not worth it.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33685 >
2025-03-26 18:35:36 +00:00
Yiwei Zhang
488b2d4d25
virgl/venus/vtest: align capset and protocol with virglrenderer
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Virgl and venus capsets along with vtest protocol v3 are all stable now.
This change is to align with:
https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1311
Acked-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34135 >
2025-03-24 21:58:10 +00:00
Connor Abbott
7a55e13939
nir, compiler: Rename needs_quad_helper_invocations
...
This currently treats coarse and fine derivatives the same, but Qualcomm
needs to know whether just coarse derivatives are used or fine
derivatives/quad ops are also used. Rename this to
needs_coarse_quad_helper_invocations make clear the difference from the
new field, needs_full_quad_helper_invocations.
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Fixes: 264d8a6766 ("ir3: Set need_full_quad depending on info.fs.require_full_quads")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33862 >
2025-03-14 21:55:57 +00:00
Alyssa Rosenzweig
8b39b75308
ail: drop fake modifiers
...
this just existed so upstream could build.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34075 >
2025-03-14 20:51:36 +00:00
Alyssa Rosenzweig
67598775ad
libagx: clean up
...
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33901 >
2025-03-10 20:16:04 +00:00
Alyssa Rosenzweig
8d338292dc
libagx: use indirect draw struct
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33901 >
2025-03-10 20:16:04 +00:00
Alyssa Rosenzweig
9c057e57b1
hk: do not dispatch count/pre-GS unless needed
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33901 >
2025-03-10 20:16:04 +00:00
Alyssa Rosenzweig
927c95e118
asahi/gs: report whether xfb is needed
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33901 >
2025-03-10 20:16:04 +00:00
Alyssa Rosenzweig
70835ee0c5
asahi/gs: drop unused params
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33901 >
2025-03-10 20:16:04 +00:00
Alyssa Rosenzweig
dc96093494
libagx,asahi: hoist GS draw generation
...
for indirect GS, do it in the indirect kernel (not the pre-GS)
for direct, do it on the host (not the pre-GS)
we don't want pre-GS.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33901 >
2025-03-10 20:16:04 +00:00
Alyssa Rosenzweig
40aa260209
asahi/gs: only prefix sum with XFB
...
otherwise, an atomic suffices for the count shader.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33901 >
2025-03-10 20:16:04 +00:00
Alyssa Rosenzweig
184416a5e8
asahi/gs: avoid recalculating
...
we'd CSE but meh
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33901 >
2025-03-10 20:16:04 +00:00
Alyssa Rosenzweig
e70544d135
asahi/gs: factor out output info
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33901 >
2025-03-10 20:16:04 +00:00