fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-07 23:50:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panvk: Use RUN_COMPUTE over RUN_COMPUTE_INDIRECT

Browse source 
RUN_COMPUTE_INDIRECT has been found to cause intermittent hangs, so
this change replaces it with RUN_COMPUTE and a set TASK_AXIS_X.

While this task axis might be suboptimal, the performance cost is
somewhat offset by RUN_COMPUTE not being an emulated command.

Fixes: 2ffc05d8d2 ("panvk: Add support for CmdDispatchIndirect")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33841>
This commit is contained in:
Lars-Ivar Hesselberg Simonsen 2025-03-03 12:19:25 +01:00
parent 6bf9ad2610
commit fe31e7843d
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/panfrost/vulkan/csf/panvk_vX_cmd_dispatch.c
View file

@ -317,9 +317,17 @@ cmd_dispatch(struct panvk_cmd_buffer *cmdbuf, struct panvk_dispatch_info *info)
cs_req_res(b, CS_COMPUTE_RES);
if (indirect) {
cs_trace_run_compute_indirect(b, tracing_ctx,
cs_scratch_reg_tuple(b, 0, 4), wg_per_task,
false, cs_shader_res_sel(0, 0, 0, 0));
/* Use run_compute with a set task axis instead of run_compute_indirect as
* run_compute_indirect has been found to cause intermittent hangs. This
* is safe, as the task increment will be clamped by the job size along
* the specified axis.
* The chosen task axis is potentially suboptimal, as choosing good
* increment/axis parameters requires knowledge of job dimensions, but
* this is somewhat offset by run_compute being a native instruction. */
unsigned task_axis = MALI_TASK_AXIS_X;
cs_trace_run_compute(b, tracing_ctx, cs_scratch_reg_tuple(b, 0, 4),
wg_per_task, task_axis, false,
cs_shader_res_sel(0, 0, 0, 0));
} else {
unsigned task_axis = MALI_TASK_AXIS_X;
unsigned task_increment = 0;