fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-28 07:30:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

anv/genxml/intel/fs: fix binding shader record entry

Browse source 
Bit is flipped compared to all the other packets.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 705395344d ("intel/fs: Add support for compiling bindless shaders with resume shaders")
Fixes: c3ac9afca3 ("anv: Create and return ray-tracing pipeline SBT handles")
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15078>
(cherry picked from commit 2763a8af5a)
This commit is contained in:
Lionel Landwerlin 2022-01-31 12:43:04 +00:00 • committed by Dylan Baker
parent 5998d19a96
commit fdd351cc81
4 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1102,7 +1102,7 @@
"description": "anv/genxml/intel/fs: fix binding shader record entry",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "705395344d2541d038326a6f64fbff838b52a71e"
},

2
src/intel/compiler/brw_fs.cpp
View file

@ -10253,7 +10253,7 @@ brw_bsr(const struct intel_device_info *devinfo,
assert(local_arg_offset % 8 == 0);
return offset |
SET_BITS(simd_size > 8, 4, 4) |
SET_BITS(simd_size == 8, 4, 4) |
SET_BITS(local_arg_offset / 8, 2, 0);
}

4
src/intel/genxml/gen_rt.xml
View file

@ -3,8 +3,8 @@
<struct name="BINDLESS_SHADER_RECORD" length="2">
<field name="Offset To Local Arguments" start="0" end="2" type="uint"/>
<field name="Bindless Shader Dispatch Mode" start="4" end="4" type="uint">
<value name="SIMD8" value="0"/>
<value name="SIMD16" value="1"/>
<value name="RT_SIMD16" value="0"/>
<value name="RT_SIMD8" value="1"/>
</field>
<field name="Kernel Start Pointer" start="6" end="31" type="offset"/>
</struct>

3
src/intel/vulkan/anv_private.h
View file

@ -3430,7 +3430,8 @@ anv_shader_bin_unref(struct anv_device *device, struct anv_shader_bin *shader)
\
(struct GFX_BINDLESS_SHADER_RECORD) { \
.OffsetToLocalArguments = (local_arg_offset) / 8, \
.BindlessShaderDispatchMode = prog_data->simd_size / 16, \
.BindlessShaderDispatchMode = \
prog_data->simd_size == 16 ? RT_SIMD16 : RT_SIMD8, \
.KernelStartPointer = bin->kernel.offset, \
}; \
})