panvk: Make AFBC an opt-out

Use AFBC when we can.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Eric R. Smith <eric.smith@collabora.com>
Reviewed-by: Christoph Pillmayer <christoph.pillmayer@arm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37158>

src/panfrost/vulkan/panvk_image.c

@@ -75,7 +75,7 @@ panvk_image_can_use_afbc(
     * GetPhysicalDeviceImageFormatProperties2() and we don't have enough
     * information to conduct a full image property check in this context.
     */
-   return (instance->debug_flags & PANVK_DEBUG_AFBC) &&
+   return !(instance->debug_flags & PANVK_DEBUG_NO_AFBC) &&
           !(usage &
             (VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_HOST_TRANSFER_BIT)) &&
           pan_query_afbc(&phys_dev->kmod.props) &&

src/panfrost/vulkan/panvk_instance.c

@@ -34,7 +34,7 @@ static const struct debug_control panvk_debug_options[] = {
    {"nir", PANVK_DEBUG_NIR},
    {"trace", PANVK_DEBUG_TRACE},
    {"sync", PANVK_DEBUG_SYNC},
-   {"afbc", PANVK_DEBUG_AFBC},
+   {"noafbc", PANVK_DEBUG_NO_AFBC},
    {"linear", PANVK_DEBUG_LINEAR},
    {"dump", PANVK_DEBUG_DUMP},
    {"no_known_warn", PANVK_DEBUG_NO_KNOWN_WARN},

src/panfrost/vulkan/panvk_instance.h

@@ -18,7 +18,7 @@ enum panvk_debug_flags {
    PANVK_DEBUG_NIR = 1 << 1,
    PANVK_DEBUG_TRACE = 1 << 2,
    PANVK_DEBUG_SYNC = 1 << 3,
-   PANVK_DEBUG_AFBC = 1 << 4,
+   PANVK_DEBUG_NO_AFBC = 1 << 4,
    PANVK_DEBUG_LINEAR = 1 << 5,
    PANVK_DEBUG_DUMP = 1 << 6,
    PANVK_DEBUG_NO_KNOWN_WARN = 1 << 7,