From f67d26723734c4a0e5a55b81390a17029c8f6315 Mon Sep 17 00:00:00 2001 From: Boris Brezillon Date: Fri, 29 Aug 2025 17:05:03 +0200 Subject: [PATCH] panvk: Make AFBC an opt-out Use AFBC when we can. Signed-off-by: Boris Brezillon Reviewed-by: Eric R. Smith Reviewed-by: Christoph Pillmayer Part-of: --- src/panfrost/vulkan/panvk_image.c | 2 +- src/panfrost/vulkan/panvk_instance.c | 2 +- src/panfrost/vulkan/panvk_instance.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/panfrost/vulkan/panvk_image.c b/src/panfrost/vulkan/panvk_image.c index 58c431c7cdf..230cf60d905 100644 --- a/src/panfrost/vulkan/panvk_image.c +++ b/src/panfrost/vulkan/panvk_image.c @@ -75,7 +75,7 @@ panvk_image_can_use_afbc( * GetPhysicalDeviceImageFormatProperties2() and we don't have enough * information to conduct a full image property check in this context. */ - return (instance->debug_flags & PANVK_DEBUG_AFBC) && + return !(instance->debug_flags & PANVK_DEBUG_NO_AFBC) && !(usage & (VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_HOST_TRANSFER_BIT)) && pan_query_afbc(&phys_dev->kmod.props) && diff --git a/src/panfrost/vulkan/panvk_instance.c b/src/panfrost/vulkan/panvk_instance.c index b4ef524f9fd..02f0816bc5d 100644 --- a/src/panfrost/vulkan/panvk_instance.c +++ b/src/panfrost/vulkan/panvk_instance.c @@ -34,7 +34,7 @@ static const struct debug_control panvk_debug_options[] = { {"nir", PANVK_DEBUG_NIR}, {"trace", PANVK_DEBUG_TRACE}, {"sync", PANVK_DEBUG_SYNC}, - {"afbc", PANVK_DEBUG_AFBC}, + {"noafbc", PANVK_DEBUG_NO_AFBC}, {"linear", PANVK_DEBUG_LINEAR}, {"dump", PANVK_DEBUG_DUMP}, {"no_known_warn", PANVK_DEBUG_NO_KNOWN_WARN}, diff --git a/src/panfrost/vulkan/panvk_instance.h b/src/panfrost/vulkan/panvk_instance.h index 3ab77a5543b..1c93fea2106 100644 --- a/src/panfrost/vulkan/panvk_instance.h +++ b/src/panfrost/vulkan/panvk_instance.h @@ -18,7 +18,7 @@ enum panvk_debug_flags { PANVK_DEBUG_NIR = 1 << 1, PANVK_DEBUG_TRACE = 1 << 2, PANVK_DEBUG_SYNC = 1 << 3, - PANVK_DEBUG_AFBC = 1 << 4, + PANVK_DEBUG_NO_AFBC = 1 << 4, PANVK_DEBUG_LINEAR = 1 << 5, PANVK_DEBUG_DUMP = 1 << 6, PANVK_DEBUG_NO_KNOWN_WARN = 1 << 7,